Commit Graph

245 Commits

Author SHA1 Message Date
Dean Herbert 52cf1e1859 Fix hit type not being provided and hit time offset not being considered 2020-04-27 16:48:27 +09:00
Dean Herbert b9f28c8373 Combine hit types and remove old drumroll hits using a more efficient method 2020-04-27 16:13:28 +09:00
Dean Herbert 1cd4fd2ac4
Merge branch 'master' into taiko-drumroll-party 2020-04-27 13:27:10 +09:00
smoogipoo 20ae973e4a Use max result instead of GOOD 2020-04-27 12:29:11 +09:00
smoogipoo 7dc090cc24 Add support for hit explosions 2020-04-27 12:23:53 +09:00
smoogipoo dd36b839b9 Refactor 2020-04-27 12:01:31 +09:00
Dean Herbert 4ca7ce7715
Merge branch 'master' into taiko-barline-skinning 2020-04-25 18:58:44 +09:00
Tim Oliver 2a197db481 Merge branch 'master' into taiko-drumroll-party
# Conflicts:
#	osu.Game.Rulesets.Taiko/UI/TaikoPlayfield.cs
2020-04-25 13:31:50 +08:00
Tim Oliver 2be3a8184d Removed modifications to drum roll object 2020-04-25 00:15:37 +08:00
Dan Balasescu b3175f9dfa
Merge branch 'master' into taiko-playfield-background-skinning 2020-04-24 19:27:38 +09:00
Tim Oliver c059588a09 Removed un-needed unproxy method 2020-04-23 18:26:40 +08:00
Tim Oliver f1ae8af581 Removed un-needed using directives 2020-04-23 18:16:05 +08:00
Dean Herbert 12f156dcec Add taiko barline skinning support 2020-04-23 14:32:48 +09:00
Dean Herbert 58bf288595 Remove DrawableHit's custom sizing logic
Turns out this was unnecessary and never actually being used.
2020-04-23 12:17:52 +09:00
Tim Oliver 81c51f0661 Merge branch 'master' into taiko-drumroll-party
# Conflicts:
#	osu.Game.Rulesets.Taiko/Objects/Drawables/DrawableRimHit.cs
#	osu.Game.Rulesets.Taiko/UI/TaikoPlayfield.cs
2020-04-22 23:15:48 +08:00
Tim Oliver 26779a57b4 Exposed public ability to unproxy content 2020-04-22 22:49:30 +08:00
Tim Oliver 44405d4771 Moved result to load complete for flying hits 2020-04-22 15:50:23 +08:00
smoogipoo ba12e23d9e Fix inspection 2020-04-22 09:06:04 +09:00
smoogipoo d8fdd73e17 Implement IHasCurve on DrumRoll 2020-04-22 09:06:04 +09:00
Tim Oliver 5b4f69bb8c Moved flying hit objects to separate files 2020-04-20 13:32:51 +08:00
Dean Herbert 58a1c6e171 Reapply taiko visibility hack at a higher level 2020-04-17 19:52:58 +09:00
Dean Herbert f36477e39d Add back "filled" property setting 2020-04-16 10:04:09 +09:00
Dean Herbert 07632cd1e5 Remove unnecessary container logic 2020-04-15 18:44:12 +09:00
Dean Herbert eb165840cb Add remaining taiko hitobject skinnables and expose as SkinnableDrawable for safety 2020-04-15 18:03:23 +09:00
Andrei Zavatski f4b5a17b65 Fix typo in DrawableTaikoHitObject 2020-04-15 07:00:38 +03:00
Dean Herbert c3f0475748 Make CirclePiece abstract 2020-04-12 17:40:22 +09:00
Tim Oliver 162a85042a Removed un-needed using 2020-04-12 10:38:22 +08:00
Tim Oliver 3ad36c7b84 Moved flying objects to use ignore hit judgements 2020-04-11 17:20:52 +08:00
Tim Oliver 1c0ad13d82 Added ignore hit object 2020-04-11 17:20:37 +08:00
Dean Herbert 009b138364 Prepare for skinnable versions 2020-04-11 14:19:59 +09:00
Dean Herbert 78db83fd0e Remove TaikoPiece class and localise kiai for now 2020-04-11 14:19:59 +09:00
Dean Herbert 7fba291134 Change inheritance of taiko hit pieces to better allow for skinning 2020-04-11 13:33:49 +09:00
Tim Oliver b883586add Added logic to allow strong notes 2020-04-08 12:46:02 +08:00
Tim Oliver 9d5a977501 Added judgement forwarder to drumroll tick object 2020-04-08 12:46:02 +08:00
Tim Oliver 1057981c79 Added arbitrary hit handler to drum roll object 2020-04-08 12:46:02 +08:00
Tim Oliver 6e12f1b69b Added “instant fly” variant of hit notes 2020-04-08 12:46:02 +08:00
smoogipoo 5106d275ca Remove CentreHit/RimHit hitobject abstraction 2020-03-23 12:08:15 +09:00
Dean Herbert 0e29d3c4a2 Correctly expire bar lines in osu!taiko and osu!mania 2020-02-23 13:50:05 +09:00
Dean Herbert ffc7eaa3f2 Fix hitobjects with unknown lifetimes by enforcing non-null judgement
We've seen multiple cases where DrawableHitObject are stuck in the lifetime management container
due to not implementing a judgement (meaning they are never "hit" or "missed"). To avoid this going forward
CreateJudgement() must be implemented and return a non-null judgement.

This fixes BananaShower and JuiceStreams in osu!catch.

This also makes HitObject abstract and cleans up convert HitObject implementations.
2020-02-23 13:49:06 +09:00
Dean Herbert cd6902a312 Make EndTime and RepeatCount settable 2020-02-05 17:52:51 +09:00
smoogipoo 7b2f58eb30 Apply OnRelease method signature refactorings 2020-01-22 13:22:34 +09:00
smoogipoo 91735ff367 Update MathUtils namespace usages 2020-01-09 13:43:44 +09:00
smoogipoo 0f8a76afde Remove manual hitobject sample namespacing 2020-01-02 14:27:27 +09:00
Huo Yaoyuan 40b43b85f1 CA1715: use prefix for generic parameters. 2019-12-17 13:00:25 +08:00
Huo Yaoyuan ddb2cfc46d Use GetEndTime in Taiko and Mania 2019-12-14 18:16:13 +08:00
Huo Yaoyuan 818553027b Merge branch 'master' into sharpen 2019-11-21 23:42:46 +08:00
Berkan Diler 6cab517b2d .NET Standard 2.1 implements Math.Clamp , use it instead of MathHelper.Clamp from osuTK. 2019-11-20 13:37:47 +01:00
Huo Yaoyuan bbeab6fa76 Use auto property. 2019-11-12 19:53:25 +08:00
smoogipoo f429a8f7c2 Add back/obsolete old AddNested() method 2019-10-17 14:02:08 +09:00
smoogipoo d8f3678c3c Rename parameter 2019-10-17 12:53:54 +09:00