mirror of https://github.com/mpv-player/mpv
fc8c1fcfb2
This commit fixes a bug where handle for a framebuffer gets double freed. It seems to happen that the same prime fd gets two framebuffers. As the prime fd is the same the resulting prime handle is also the same. This means one handle but 2 framebuffers and can lead to the following chain: 1. The first framebuffer gets deleted the handle gets also freed via the ioctl. 2. In startup phase not all 4 dumb buffers for overlay drawing are set up. It can happen that the last dumb buffer gets the handle we freed above. 3. The second framebuffer gets freed and the handle will be freed again resulting that the 4's dumb buffer handle is not backed by a buffer. 4. Drm prime continues to assign handles to its prime fds an will lead to have this handle which was just freed to reassign again but to an prime buffer. 5.Now the overlay should be drawn into dumb buffer 4 which still has the same handle but is backed by the wrong buffer. This leads to two different behaviors: - MPV crashes as the drm prime buffers size als calculated by the decoder output format. The overlay output format differs and it takes more space. SO the size check in kernel fails. - MPV is continuing play. This happens when the decoders allocates a bigger buffer than needed for the overlay. For example overlay is Full HD and decoder output is 4k. This leads to the behavior das the overlay wil be drawn into the wrong buffer as its a drm prime buffer and results in a flicker every fourth step. |
||
|---|---|---|
| .. | ||
| angle_dynamic.c | ||
| angle_dynamic.h | ||
| common.c | ||
| common.h | ||
| context.c | ||
| context.h | ||
| context_android.c | ||
| context_angle.c | ||
| context_cocoa.c | ||
| context_drm_egl.c | ||
| context_dxinterop.c | ||
| context_glx.c | ||
| context_rpi.c | ||
| context_wayland.c | ||
| context_win.c | ||
| context_x11egl.c | ||
| egl_helpers.c | ||
| egl_helpers.h | ||
| formats.c | ||
| formats.h | ||
| gl_headers.h | ||
| hwdec_d3d11egl.c | ||
| hwdec_drmprime_drm.c | ||
| hwdec_dxva2egl.c | ||
| hwdec_dxva2gldx.c | ||
| hwdec_ios.m | ||
| hwdec_osx.c | ||
| hwdec_rpi.c | ||
| hwdec_vdpau.c | ||
| libmpv_gl.c | ||
| oml_sync.c | ||
| oml_sync.h | ||
| ra_gl.c | ||
| ra_gl.h | ||
| utils.c | ||
| utils.h | ||