mirror of
https://github.com/mpv-player/mpv
synced 2024-12-22 06:42:03 +00:00
a9cb2dc1b8
Decoding H264 using Video Decode Acceleration used the custom 'vda_h264_dec'
decoder in FFmpeg.
The Good: This new implementation has some advantages over the previous one:
- It works with Libav: vda_h264_dec never got into Libav since they prefer
client applications to use the hwaccel API.
- It is way more efficient: in my tests this implementation yields a
reduction of CPU usage of roughly ~50% compared to using `vda_h264_dec` and
~65-75% compared to h264 software decoding. This is mainly because
`vo_corevideo` was adapted to perform direct rendering of the
`CVPixelBufferRefs` created by the Video Decode Acceleration API Framework.
The Bad:
- `vo_corevideo` is required to use VDA decoding acceleration.
- only works with versions of ffmpeg/libav new enough (needs reference
refcounting). That is FFmpeg 2.0+ and Libav's git master currently.
The Ugly: VDA was hardcoded to use UYVY (2vuy) for the uploaded video texture.
One one end this makes the code simple since Apple's OpenGL implementation
actually supports this out of the box. It would be nice to support other
output image formats and choose the best format depending on the input, or at
least making it configurable. My tests indicate that CPU usage actually
increases with a 420p IMGFMT output which is not what I would have expected.
NOTE: There is a small memory leak with old versions of FFmpeg and with Libav
since the CVPixelBufferRef is not automatically released when the AVFrame is
deallocated. This can cause leaks inside libavcodec for decoded frames that
are discarded before mpv wraps them inside a refcounted mp_image (this only
happens on seeks).
For frames that enter mpv's refcounting facilities, this is not a problem
since we rewrap the CVPixelBufferRef in our mp_image that properly forwards
CVPixelBufferRetain/CvPixelBufferRelease calls to the underying
CVPixelBufferRef.
So, for FFmpeg use something more recent than `b3d63995` for Libav the patch
was posted to the dev ML in July and in review since, apparently, the proposed
fix is rather hacky.
|
||
|---|---|---|
| .. | ||
| aspect.c | ||
| aspect.h | ||
| bitmap_packer.c | ||
| bitmap_packer.h | ||
| cocoa_common.h | ||
| cocoa_common.m | ||
| d3d_shader_yuv.h | ||
| d3d_shader_yuv.hlsl | ||
| dither.c | ||
| dither.h | ||
| filter_kernels.c | ||
| filter_kernels.h | ||
| gl_cocoa.c | ||
| gl_common.c | ||
| gl_common.h | ||
| gl_header_fixes.h | ||
| gl_lcms.c | ||
| gl_lcms.h | ||
| gl_osd.c | ||
| gl_osd.h | ||
| gl_video_shaders.glsl | ||
| gl_video.c | ||
| gl_video.h | ||
| gl_w32.c | ||
| gl_wayland.c | ||
| gl_x11.c | ||
| pnm_loader.c | ||
| pnm_loader.h | ||
| vo_caca.c | ||
| vo_corevideo.c | ||
| vo_direct3d.c | ||
| vo_image.c | ||
| vo_lavc.c | ||
| vo_null.c | ||
| vo_opengl_old.c | ||
| vo_opengl.c | ||
| vo_sdl.c | ||
| vo_vaapi.c | ||
| vo_vdpau.c | ||
| vo_x11.c | ||
| vo_xv.c | ||
| vo.c | ||
| vo.h | ||
| w32_common.c | ||
| w32_common.h | ||
| wayland_common.c | ||
| wayland_common.h | ||
| x11_common.c | ||
| x11_common.h | ||