Commit Graph

119105 Commits

Author SHA1 Message Date
Kefu Chai
e9e4ae8378 pybind/mgr/snap-schedule: use use_fs if fs is not specified
the "vol_name" parameter of "fs subvolume getpath" command is not
optional, so we have to pass an fs name to it.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-01-29 19:42:32 +08:00
Kefu Chai
52d17e5852 pybind/mgr/snap-schedule: close a string with single quote
if it starts with single quote, we should close it with a single quote
also.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-01-29 19:42:32 +08:00
Kefu Chai
80cbf407c2 pybind/mgr/snap-schedule: add typing annotations
please note, the behavior of `updates_schedule_db()` is changed so that
it now returns the return value of the decorated function. this change
makes it a real decorator which keeps the signature of the decorated
function unchanged. the reason why we need this change is that mypy does
not allow us to match the parameter pack of a Callable at the time of
writing.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-01-29 19:42:32 +08:00
Kefu Chai
9d888ee42c pybind/mgr/status: flake8 cleanup
* remove unused import
* wrap long lines
* remove comments which do not start with "# "

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-01-29 19:42:32 +08:00
Kefu Chai
60bef081f8 pybind/mgr/status: add typing annotations
Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-01-29 19:42:32 +08:00
Kefu Chai
6f68dea55c pybind/mgr/status: always map 'mds_version' to a list of dict
more consistent this way, as json format is supposed to be consumed by a
parser not human being.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-01-29 19:42:32 +08:00
Kefu Chai
5ac2901f54 pybind/mgr/status: construct defaultdict without key
it's simply wrong to construct defaultdict with the key which does not
have the mapped value, what we should do is to specify the
"default_factory" which construct the default value whose key does not
exist in the dict when being accessed.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-01-29 19:42:32 +08:00
Kefu Chai
f1ebf6b34d pybind/mgr/status: cast return value to int
the return value of get_rate() is fed to mgr_util.format_dimless(),
which always cast the formatted value to int.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-01-29 19:42:32 +08:00
Kefu Chai
3649ecf64c pybind/mgr: correct a MgrModule annotation
Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-01-29 19:42:32 +08:00
Kefu Chai
2966e1f46c pybind/mgr/status: use CLIReadCommand for defining commands
simpler this way. and will be more consistent with other mgr modules

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-01-29 19:42:32 +08:00
Kefu Chai
7ee1301a02 pybind/mgr/iostat: add typing annotations
Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-01-29 19:42:32 +08:00
Kefu Chai
367f264100 pybind/mgr: silence flake8 warnings
silence following warnings from flake8

* line too long (107 > 100 characters) [E501]

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-01-29 19:42:32 +08:00
Kefu Chai
5a7f2827ee
Merge pull request #39157 from xxhdx1985126/wip-crimson-bug-fix
crimson/osd: capture "intervals_included" by value in ReplicatedRecoveryBackend::submit_push_data

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-01-29 16:24:19 +08:00
Kefu Chai
d58481a6c4
Merge pull request #39057 from aclamk/wip-mempool-shards-check-random
common/mempool: Improve mempool shard selection

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2021-01-29 15:21:51 +08:00
Xuehan Xu
e1f8b585bd crimson/osd: capture "intervals_included" by value in ReplicatedRecoveryBackend::submit_push_data
ReplicatedRecoveryBackend::submit_push_data()'s parameter "intervals_included" might be an
local varaiable in the outer method, so we should capture it by value to avoid a dangling
reference in the inner lambda

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2021-01-29 14:44:36 +08:00
pcuzner
9fea82cacc
Merge pull request #39112 from pcuzner/fix-gather-facts
cephadm:add missing kernel_security property
2021-01-29 10:35:33 +13:00
Sebastian Wagner
39fd806cd4
Merge pull request #39113 from liewegas/fix-datetime-test
python-common: fix test_datetime_to_str_2 on non-UTC hosts

Reviewed-by: Willem Jan Withagen <wjw@digiware.nl>
2021-01-28 13:04:07 +01:00
Kefu Chai
5a6623c80e
Merge pull request #39100 from xxhdx1985126/wip-crimson-bug-fix-2
crimson/osd: fix recovery related bugs

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-01-28 19:20:42 +08:00
Xuehan Xu
50bf0bdce0 crimson/osd: use do_with to capture MOSDPGPull::take_pulls()'s return
MOSDPGPull::take_pulls() returns a temporary object, so we need to use seastar::do_with
to create an object whose lives until seastar::do_with's inner continuation chain ends

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2021-01-28 16:17:37 +08:00
Xuehan Xu
ee8a068f45 crimson/osd: objects without omap header may not necessarily be a error
There are circumstances in which objects don't have omap headers, so this should
not be treated as an error

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2021-01-28 10:46:21 +08:00
Xuehan Xu
b80a5c6cc9 crimson/osd: should capture seastar::do_with params by reference
The lambda within seastar::do_with need to use lvalue reference as its parameter,
otherwise it would be referencing a variable whose lifecycle ends when lambda finishes
runing

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2021-01-28 10:44:00 +08:00
Jason Dillaman
c4917eef53
Merge pull request #39115 from wjwithagen/wjw-fix-QCOWFormat.cc
librbd: Fix variable declaration in capture list in lambda

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2021-01-27 20:51:36 -05:00
Neha Ojha
a3d74ad052
Merge pull request #39108 from zdover23/wip-doc-leads-update-epuertat-28-Jan-2021
doc/dev: add Ernesto Puerta as dashboard lead

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2021-01-27 17:10:59 -08:00
Josh Durgin
b912bb7947
Merge pull request #39114 from liewegas/drop-rhel-8.0
qa/suites/rados/cephadm: drop rhel_8.0 tests

Reviewed-by: David Galloway <dgallowa@redhat.com>
2021-01-27 16:58:36 -08:00
Neha Ojha
36bf44e150
Merge pull request #37949 from ideepika/wip-docs-update
doc/dev/developer_guide:  teuthology update developer guide

Reviewed-by: Neha Ojha <nojha@redhat.com>
2021-01-27 16:35:23 -08:00
Willem Jan Withagen
461412352d librbd: Fix variable declaration in capture list in lambda
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
2021-01-28 01:00:45 +01:00
Sage Weil
ebee47e06f qa/suites/rados/cephadm/*/distro: drop rhel_8.0 targets
We still have centos 8.0.  We're missing an 8.0 image for the gibba.

Signed-off-by: Sage Weil <sage@newdream.net>
2021-01-27 16:04:58 -06:00
Sage Weil
78aca4db24 python-common: fix test_datetime_to_str_2 on non-UTC hosts
The old test parsed to a datetime without a tz, which was interpreted as
the local time zone when rendering back to a string.  Specify that it's a
UTC datetime so that behavior is consistent regardless of the test host
timezone.

Signed-off-by: Sage Weil <sage@newdream.net>
2021-01-27 15:44:21 -06:00
Paul Cuzner
1bc953cfbf cephadm:add missing kernel_security property
The propery decorator had gone missing which meant
the dump of host facts was missing the kernel security
(LSM) settings. This patch just adds the @property
decorator back

Signed-off-by: Paul Cuzner <pcuzner@redhat.com>
2021-01-28 09:40:58 +13:00
Casey Bodley
3558fd7291
Merge pull request #38861 from alimaredia/wip-rgw-create-bucket-dpp
rgw: Thread dpp through Create Bucket logging

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2021-01-27 13:51:09 -05:00
Jason Dillaman
59119d7a96
Merge pull request #39105 from dillaman/wip-48989
librbd: tweaks to support Boost 1.75.0

Reviewed-by: Mykola Golub <mgolub@suse.com>
2021-01-27 13:16:56 -05:00
Ali Maredia
df236920b8 rgw: Add DoutPrefixProvider to create_bucket logging
This commit hits all log messages for a create bucket
request and ensures each has a DoutPrefixProvider.

This commit gets dpp's all the way down to rgw/services
up way though to rgw_op.cc, rgw_rest.cc files,
rgw_admin.cc, etc.

This commit also removes store as dpp in rgw_sal.h

Signed-off-by: Ali Maredia <amaredia@redhat.com>
2021-01-27 12:04:24 -05:00
Mykola Golub
f41a587a59
Merge pull request #39068 from dillaman/wip-librbd-migration-qcow-2
librbd/migration: tweaks and unit tests for QCOW handler

Reviewed-by: Mykola Golub <mgolub@suse.com>
2021-01-27 18:58:28 +02:00
Josh Durgin
88832fbb47
Merge pull request #39107 from yuriw/wip-yuriw-crontab-master
qa/tests: reduced octopus, nautilus, master frequency

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2021-01-27 08:48:22 -08:00
Sebastian Wagner
0d37d7e6d6
Merge pull request #39043 from tchaikov/wip-cephadm-call
cephadm: refactor call() using asyncio.asyncio.StreamReader

Reviewed-by: Paul Cuzner <pcuzner@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>
2021-01-27 17:46:52 +01:00
Yuri Weinstein
5795442fd5 qa/tests: changed priority - master 100, pacific 80
Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
2021-01-27 08:45:19 -08:00
Yuri Weinstein
300c7312de qa/tests: reduced octopus, nautilus, master frequency
Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
2021-01-27 08:31:19 -08:00
Jason Dillaman
4141049ca8
Merge pull request #39015 from lixiaoy1/fix_lib
librbd/cmake: add library dependency for pwl_cache

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2021-01-27 11:31:10 -05:00
Zac Dover
d318b60cc1 doc/dev: add Ernesto Puerta as dashboard lead
This commit removes Lenz Grimmer's name and github
handle from the list of component leads and replaces
it with Ernesto Puerta's name and github handle.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2021-01-28 02:26:23 +10:00
Sebastian Wagner
1c921304ff
Merge pull request #39101 from sebastian-philipp/cephadm-fix-ok-to-stop-return-value
mgr/cephadm: Fix wrong argument type to HandleCommandResult

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-01-27 16:54:56 +01:00
Kefu Chai
2d923a7099
Merge pull request #39098 from tchaikov/wip-zabbix-ann
mgr: add annotations to zabbix and devicehealth

Reviewed-by: Sebastian Wagner <swagner@suse.com>
2021-01-27 23:11:25 +08:00
Kefu Chai
d0c3a5134f
Merge pull request #39065 from cbodley/wip-48988
cmake: boost>=1.74 adds BOOST_ASIO_USE_TS_EXECUTOR_AS_DEFAULT to radosgw

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-01-27 22:24:06 +08:00
Ramana Raja
23f0c5b2dd
Merge pull request #38786 from kotreshhr/evict-clients-of-deauthorized-authids
mgr/volumes: Evict clients based on auth-IDs and subvolume path

Reviewed-by: Victoria Martinez de la Cruz <victoria@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
2021-01-27 19:44:17 +05:30
Jason Dillaman
4d80c798a7 librbd: tweaks to support Boost 1.75.0
Fixes: https://tracker.ceph.com/issues/48989
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2021-01-27 09:12:58 -05:00
Jason Dillaman
6cd7e84293 librbd/migration: minor cleanup to QCOWFormat code
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2021-01-27 08:32:45 -05:00
Casey Bodley
b48adde207
Merge pull request #37259 from soumyakoduri/head_req
rgw: Set CURLOPT_NOBODY for HEAD request

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2021-01-27 08:27:15 -05:00
Sebastian Wagner
647e2da469
Merge pull request #38982 from jmolmo/fix_iscsi_client_caps
cephadm: Fix iscsi client caps

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
2021-01-27 14:15:50 +01:00
Kefu Chai
3b4a7af3ce
Merge pull request #39099 from ZhenLiu94/liuz
doc: Correct spelling mistakes.

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-01-27 21:00:59 +08:00
Sebastian Wagner
677b3d1b0f mgr/cephadm: Fix wrong argument type to HandleCommandResult
the argument must be a string

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2021-01-27 13:15:47 +01:00
Sebastian Wagner
84b78520ea
Merge pull request #38854 from adk3798/ots-monitoring
mgr/cephadm: force flag for ok-to-stop and ok-to-stop for monitoring stack

Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
2021-01-27 12:57:07 +01:00