Commit Graph

119105 Commits

Author SHA1 Message Date
Lucian Petrut
057660aec9 compat: add win32 endianness helpers
The new QCOW migration helpers are using functions such as "be64toh",
which aren't provided by MINGW, breaking the "rbd" tool on Windows.

We'll define those endianness related helpers in compat.h

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
2021-01-22 11:49:53 +00:00
Kefu Chai
71711b56db
Merge pull request #39016 from sebastian-philipp/cephadm-mypy-status-none
mgr/cephadm: mypy says: dd.status can be None

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-01-22 19:46:42 +08:00
Kefu Chai
eab2a7cf07
Merge pull request #38999 from tchaikov/wip-crimson-bootstrap
crimson/osd: fetch_config() before mkfs

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2021-01-22 19:45:30 +08:00
Sage Weil
ce4743f72e cephadm: fix 2> syntax in unit.run
We need a space between the command (which ends with a container name)
and the 2> or else the 2 is considered part of the command.  E.g.,

! /usr/bin/podman rm -f ceph-a9a8c7ee-5b72-11eb-8f93-001a4aab830c-mon.a2> /dev/null

Fixes: 1bed46e4b0
Signed-off-by: Sage Weil <sage@newdream.net>
2021-01-22 19:11:39 +08:00
Kefu Chai
2d63bc0fbd vstart.sh: print out osd mkfs command
for better understanding the progress of vstart, and also allows
developer to repeat the command.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-01-22 18:54:29 +08:00
Kefu Chai
37dc3ea9c2 mon/MonClient: do not include unused header
MGetConfig.h is not used anywhere in this source file, so no need to
include it.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-01-22 18:54:28 +08:00
Kefu Chai
237cbc9ba5 crimson/os: do not use __func__ in lambda
Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-01-22 18:54:28 +08:00
Kefu Chai
71229d557d crimson/mon: use switch case for checking return code
also, since seastar supports returning plain value instead a ready
future, let's return plain value. simpler this way.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-01-22 18:54:28 +08:00
Jan Fajerski
1f9cabf8a8 Merge PR #32027 into master
* refs/pull/32027/head:
	librados: avoid symbol versioning on Windows

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2021-01-22 11:35:18 +01:00
Sebastian Wagner
2df47b88ab mgr/cephadm: Minor pep8 fix
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2021-01-22 11:32:40 +01:00
Sebastian Wagner
fb19769503 mgr/cephadm: mypy says: dd.status can be None
`DaemonDescription.status` is annotated
as `Optional[int]` and thus can be `None`

This is a conflict between c95ba878c6
and 01f60cf4e0

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2021-01-22 11:32:31 +01:00
Juan Miguel Olmo Martínez
9b9934f75b
cephadm: Fix iscsi client caps (allow mgr <service status> calls)
iSCSI daemons need to execute <ceph service status> command

Fixes: https://tracker.ceph.com/issues/48925

Signed-off-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
2021-01-22 11:09:15 +01:00
Sebastian Wagner
e27cc8183e
Merge pull request #38978 from liewegas/cephadm-daemon-health
mgr/cephadm: raise HEALTH_WARN when cephadm daemon in 'error' state

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
2021-01-22 10:40:00 +01:00
Sebastian Wagner
b8e49ea914
Merge pull request #38967 from liewegas/wip-cephadm-pacific
cephadm: latest stable release is now pacific

Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
2021-01-22 10:36:25 +01:00
Sebastian Wagner
6200f4c42e
Merge pull request #38739 from jecluis/wip-cephadm-splits
cephadm: splits bootstrap function, add context, drop global variables

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
2021-01-22 10:35:19 +01:00
Sebastian Wagner
4ca11ae50d mgr/cephadm: minor pep8 fixes
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2021-01-22 10:19:50 +01:00
Sebastian Wagner
eb1a40c3ea mgr/cephadm: Properly handle JSON Decode error
Fixes 6d759fb5de

I.e. don't use `out`, until it is acutally defined

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2021-01-22 10:19:41 +01:00
Aashish Sharma
06cc0d8743 mgr/dashboard: trigger alert if some nodes have a MTU different than the median value
This PR intends to alert a user if a specific network is configured with a custom MTU

Fixes: https://tracker.ceph.com/issues/48748
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
2021-01-22 11:20:13 +05:30
Mahati Chamarthy
23327ce374 doc: update rwl doc to include ssd config
... options.

Signed-off-by: Mahati Chamarthy <mahati.chamarthy@intel.com>
2021-01-22 10:59:18 +05:30
Kefu Chai
84b2e06794 crimson/osd: fetch_config() before mkfs
* fetch_config() before mkfs and starting osd
  for populating settings related to booting and transport layer
  before it starts.
* set fsid read from monitor before mkfs
  it's crucial to mkfs if osd is supposed to retrieve the fsid
  from monitor.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-01-22 13:07:48 +08:00
Kefu Chai
c54bcf660f crimson/net: move implementation of dtor into .cc file
ceph_assert() is expanded into 5 lines of code. it'd help to speed up
the compiling a little bit.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-01-22 13:07:48 +08:00
Kefu Chai
9a248da3fe crimson/mon: add mon::Client::wait_for_config()
just for waiting for monmap and config from mon. crimson-osd needs this
for populating settings related to booting and transport layer before it
starts.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-01-22 13:07:48 +08:00
Kefu Chai
264e710a37 crimson/mon: fallback to msgr v2 for unbound msgr
so, for instance, if we want to connect to monitor without bind to any
address, we can try to use the v2 addresses advertised in monmap or
local settings, instead of being unable to connect to mon because we are
using an `entity_addr_t::TYPE_NONE` address which is returned by
`entity_addrvec_t::front()` if the addrvec is empty.

see also AsyncMessenger::should_use_msgr2().

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-01-22 13:07:48 +08:00
Kefu Chai
51c8ffff6d crimson/mon: print out entity addr type when non peer address matches
Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-01-22 13:07:48 +08:00
Casey Bodley
3cdd3d18a1
Merge pull request #39010 from mdw-at-linuxbox/wip-master-barbicany2021
qa/tasks/barbican.py: fix year2021 problem

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2021-01-21 17:42:38 -05:00
Casey Bodley
e36b72f4f0
Merge pull request #39008 from mdw-at-linuxbox/wip-master-vaultunzip
qa/tasks/vault.py: unzip: try harder to find a working unzip.

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2021-01-21 17:42:09 -05:00
Adam C. Emerson
78ece45796 rgw: Since we aren't using these anyway
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2021-01-21 17:17:39 -05:00
Jason Dillaman
8d86249a8e
Merge pull request #38988 from orozery/librbd-crypto-empty-copyup
librbd: don't restart empty copyups in crypto layer

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2021-01-21 15:07:01 -05:00
Jason Dillaman
21bc198918
Merge pull request #38985 from orozery/rbd-nbd-luks2-blksize
tools/rbd-nbd: change block size to 4K for LUKS2 images

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2021-01-21 15:06:20 -05:00
Jason Dillaman
410c40ee53
Merge pull request #38983 from orozery/qa-qemu-rbd-encryption
qa/tasks/rbd: increase image size of encrypted disks

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2021-01-21 15:05:30 -05:00
Nizamudeen A
3c2e8e4f9a mgr/dashboard: Fix for incorrect validation in rgw user form
The rgw users create form doesnt validate the username correctly if the username is a tenated one. For eg. Consider there is a user called tenate$sample. Now I am trying to create another user and I entered tenate$sample as username. But it doesn't async validate the username as existing. Instead it just shows the green tick and once the submit button is clicked it'll show the user as existing.

Fixes: https://tracker.ceph.com/issues/48907
Signed-off-by: Nizamudeen A <nia@redhat.com>
2021-01-22 00:38:41 +05:30
Marcus Watts
b1fac2224b qa/tasks/barbican.py: fix year2021 problem
The expiration timestamp was hard-coded as
2020-12-31T19:14:44.180394
which is now in the past.  Instead, use a timestamp
90 minutes in the future.

Fixes: https://tracker.ceph.com/issues/48919
Signed-off-by: Marcus Watts <mwatts@redhat.com>
2021-01-21 13:31:27 -05:00
Marcus Watts
5258b20bf0 qa/tasks/keystone.py: centos-8 bindep fix
The upstream git repository for keystone contains a dependency
for "python34-devel" which only exists in centos 7.
For centos 8, the correct package is "python36-devel".
So, patch bindep.txt before running bindep.

Fixes: https://tracker.ceph.com/issues/48920
Signed-off-by: Marcus Watts <mwatts@redhat.com>
2021-01-21 13:30:55 -05:00
Marcus Watts
ed664a4d0b qa/tasks/vault.py: unzip: try harder to find a working unzip.
The existing logic uses "python -m zipfile" to unzip files.
This will (most likely) fail on CentOS 8-Stream , where python
defaults to 'unset' (see man unversioned-python).

So: try harder: try unzip, python3, and python in that order,
to find something that can unzip files.

Fixes: https://tracker.ceph.com/issues/48921
Signed-off-by: Marcus Watts <mwatts@redhat.com>
2021-01-21 12:35:01 -05:00
Harish Munjulur
b32153a4ed
Merge pull request #38691 from soumyakoduri/lc_fixes
rgw/lc: Fix use-after-free in RGWLC::process
2021-01-21 09:25:06 -08:00
Harish Munjulur
dee214ea11
Merge pull request #38465 from IlsooByun/fix_lc_infinite_loop
rgw: lc: fix infinite loop in bucket_lc_prepare
2021-01-21 09:24:51 -08:00
Or Ozeri
b11d6285a7 librbd: use 512 sector size for crypto IV
This commit aligns with the LUKS2 format which requires plain-64 mode IV
to be derived from the 512 bytes sector number

Signed-off-by: Or Ozeri <oro@il.ibm.com>
2021-01-21 18:21:32 +02:00
Venky Shankar
beb00bd2a8
Merge pull request #36698 from vshankar/wip-cephfs-mirror-tests
cephfs-mirror: teuthology task and tests
2021-01-21 09:46:51 +05:30
Venky Shankar
a7d1fd6ae8
Merge pull request #35993 from vshankar/wip-fs-mirror-interface
pybind/mgr/mirroring: directory snapshot mirror support
2021-01-21 09:45:41 +05:30
Brad Hubbard
4f07cffb8b osd/OSDMap: An empty bucket or OSD is not an error
Fixes: https://tracker.ceph.com/issues/48884

Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
2021-01-21 13:15:23 +10:00
Brad Hubbard
3dc72a0be0 test/osd: Verify print_osd_utilization output
Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
2021-01-21 13:15:20 +10:00
Sage Weil
9eef1bcced qa/suites/rados/cephadm/upgrade: avoid allow_ptrace with old cephadm
Older cephadm is not smart enough to not combine --cap-add=SYS_PTRACE
and --privileged, which some version of podman cannot handle.

For upgrades, leave off the allow_ptrace behavior since we may be starting
on one of those old versions.

See also https://tracker.ceph.com/issues/46429

Fixes: https://tracker.ceph.com/issues/48142
Signed-off-by: Sage Weil <sage@newdream.net>
2021-01-20 16:40:17 -06:00
Casey Bodley
d42db5f434
Merge pull request #38991 from cbodley/wip-rgw-perm-state-valgrind
rgw: fix reference to temporary in perm_state ctor

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2021-01-20 17:05:30 -05:00
Sage Weil
59576d17f7
Merge pull request #38817 from ideepika/fix-interactive-error
qa/tasks/ceph: do not update info.yaml if ctx.archive is not set
2021-01-20 15:21:15 -06:00
Neha Ojha
173ba0a239
Merge pull request #38941 from sseshasa/wip-48906-async-rec-min-cost-fix
osd: Remove override for osd_async_recovery_min_cost for mclock profiles

Reviewed-by: Sunny Kumar <sunkumar@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2021-01-20 12:37:44 -08:00
Igor Fedotov
6159a692d9 os/bluestore: be more protective in _deferred_queue
Signed-off-by: Igor Fedotov <ifedotov@suse.com>
2021-01-20 22:57:15 +03:00
Matt Benjamin
9773f0a538 rgw: avoid (rgw_file) illegal access to stack memory
Fixes: https://tracker.ceph.com/issues/48941

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2021-01-20 13:46:58 -05:00
Sage Weil
0ee2b2b807 mgr/devicehealth: fix 'device monitoring on|off' return value
Signed-off-by: Sage Weil <sage@newdream.net>
2021-01-20 12:35:23 -06:00
Casey Bodley
b421128951
Merge pull request #38987 from cbodley/wip-qa-rgw-valgrind-supp-tls
valgrind: update suppression for _dl_allocate_tls

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2021-01-20 13:22:56 -05:00
Or Ozeri
cd6f3ccd33 librbd: don't restart empty copyups in crypto layer
This commit fixes a bug where an empty parent copyup is restarted indefinitely.

Signed-off-by: Or Ozeri <oro@il.ibm.com>
2021-01-20 18:43:47 +02:00