Commit Graph

115495 Commits

Author SHA1 Message Date
Ilya Dryomov
d2884adb15 qa: add test for mapping and unmapping from a network namespace
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2020-09-21 13:54:08 +02:00
Guillaume Abrioux
888998f886
Merge pull request #37234 from guits/guits-quick-fix
ceph-volume: fix wrong type passed in terminal.warning()
2020-09-21 13:41:41 +02:00
Mykola Golub
9548fb02a9
Merge pull request #37222 from dillaman/wip-librbd-image-dispatch
librbd: bug fixes and cleanup for IO dispatch path

Reviewed-by: Mykola Golub <mgolub@suse.com>
2020-09-21 14:05:21 +03:00
Kefu Chai
0ef2a830b5
Merge pull request #37215 from uweigand/fix-librados-test-endian
test/librados: fix endian bugs in checksum test cases

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2020-09-21 17:49:08 +08:00
Lenz Grimmer
73803fed07
Merge pull request #36900 from wjwithagen/wjw-enhance-mgr_module.py
mgr/dashboard: Report the missing path in error message

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2020-09-21 11:48:28 +02:00
Lenz Grimmer
0c9e31cf6d
Merge pull request #37087 from tspmelo/wip-iscsi-logged-in
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Ricardo Marques <rimarques@suse.com>
2020-09-21 11:45:19 +02:00
Kefu Chai
983e28b46b
Merge pull request #37261 from tchaikov/wip-47552
common/BackTrace: do not use len for length of demangled symbol

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2020-09-21 17:43:17 +08:00
Kefu Chai
c2af45b659
Merge pull request #37185 from david-z/wip-fix-osdmaptool
tools/osdmaptool.cc: fix inaccurate pg map result when simulating osd out

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2020-09-21 17:38:56 +08:00
Kefu Chai
c2a94678a0
Merge pull request #37210 from changchengx/no_tune_message
messenger: remove unused variable

Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-09-21 17:37:21 +08:00
Lenz Grimmer
f0fb21ada0
Merge pull request #37183 from rhcs-dashboard/fix-47434-master
mgr/dashboard: table detail rows overflow

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2020-09-21 10:42:19 +02:00
Guillaume Abrioux
a1f42c8d7b ceph-volume: fix wrong type passed in terminal.warning()
`terminal.warning()` excepts a `str`.
Passing `e` means we pass a type `exceptions.RuntimeError`

Changing to `terminal.warning(e.message)` fixes the issue.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1877672
Resolves: rhbz#1877672

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
2020-09-21 09:36:27 +02:00
Kefu Chai
35613d091a
Merge pull request #37268 from anthonyeleven/anthonyeleven/doc-fixes
doc/man: Add optional reweight-by-utilization args

Reviewed-by: Zac Dover <zac.dover@gmail.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-09-21 14:41:35 +08:00
Anthony D'Atri
815263b583 doc/man: Add optional reweight-by-utilization args
doc/mgr: Grammar and wording for Prometheus labels
doc/rados: Spelling and clarity

Signed-off-by: Anthony D'Atri <anthony.datri@gmail.com>
2020-09-20 22:47:01 -07:00
Yingxin Cheng
9f7b7fdced crimson/seastore: fix potential non-repeatable-read from RootBlock
Load root block into the transaction when read it.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2020-09-21 10:18:55 +08:00
songweibin
7bc663dbe3 librbd: async version of metadata_set/remove
In iSCSI scenario (via tcmu-runner), after a client has acquired exclusive
lock on an image, users will no longer be able to set metadata on the image.
This commit try to fix it by forward the request to the lock owner.

Steps to reproduce:

1. Client A:
```
>>> import rbd, rados;client=rados.Rados(conffile='');client.connect();ioctx=client.open_ioctx('rbd');rbd_inst=rbd.RBD();image=rbd.Image(ioctx, 'img1')
>>> from rbd import RBD_LOCK_MODE_EXCLUSIVE
>>> image.lock_acquire(RBD_LOCK_MODE_EXCLUSIVE)
>>>
```

2. Client B:
```
$ rbd image-meta set img1 conf_rbd_qos_iops_limit 10000
2020-09-12T15:19:58.325+0800 7f161affd700 -1 librbd::ManagedLock: 0x7f15f4001d48 handle_acquire_lock: failed to acquire exclusive lock:(30) Read-only file system
failed to set metadata conf_rbd_qos_iops_limit of image : (30) Read-only file system
rbd: setting metadata failed: (30) Read-only file system
$
```

Signed-off-by: songweibin <song.weibin@zte.com.cn>
2020-09-21 09:42:55 +08:00
Brad Hubbard
0a288f6690
Merge pull request #37176 from badone/wip-enable-mgr-client-debug
qa: Enable debug_client for mgr tests

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2020-09-21 11:34:58 +10:00
Changcheng Liu
4d6b678736 messenger: remove unused variable
Signed-off-by: Changcheng Liu <changcheng.liu@aliyun.com>
2020-09-21 09:22:07 +08:00
Or Ozeri
2f4c769e67 librbd: add data encryptor/decryptor using openssl
This commit adds the first CryptoInterface implementation
which translates bufferlist encryption to the standard api of crypto libraries,
i.e. using block ciphers operating on C-style arrays.

It defines an abstract DataCryptor interface to allow different crypto libraries implementations.
With this commit, we add an OpenSSL based implementation.
Lastly, we implement a context-pool wrapper implementation to optimize performance.

Signed-off-by: Or Ozeri <oro@il.ibm.com>
2020-09-20 21:23:45 +03:00
Yin Congmin
f18aca8746 qa: check immutable object cache content
fix check immutable cache does not work

Signed-off-by: Yin Congmin <congmin.yin@intel.com>
2020-09-21 01:36:56 +08:00
Mykola Golub
d3fa8d01dc rbd-nbd: fix typo in mini help
Signed-off-by: Mykola Golub <mgolub@suse.com>
2020-09-20 08:19:30 +01:00
Kefu Chai
14b6d35b17 common/BackTrace: do not use len for length of demangled symbol
it turns out `len` is longer than the length of demangled symbol,
let's rely on the `\0` sentry in the returned char* string instead.

in this change, use `status` to tell if the demangle is successful or
not.

Fixes: https://tracker.ceph.com/issues/47552
Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-09-20 11:34:53 +08:00
Ilya Dryomov
240c46a75a
Merge pull request #37072 from idryomov/wip-kcephfs-blacklisted-string
mds: add " (blacklisted)" to session reject error string

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2020-09-19 11:36:43 +02:00
Kefu Chai
fbfc53c708 crimson/osd: extract PG::load_head_obc() out
so it can be reused in later refactory

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-09-19 13:30:51 +08:00
Kefu Chai
da32890cf5 crimson/osd: split PG::get_oid_and_lock() into two methods
for better readability

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-09-19 13:30:51 +08:00
Kefu Chai
f7e9664fd4 crimson/osd/object_context: add helper for acquiring locks
Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-09-19 13:30:51 +08:00
Kefu Chai
c90bbc0630 crimson/common/tri_mutex: add helpers for seastar::with_lock()
so we don't need to worry about unlocking the object context.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-09-19 13:30:51 +08:00
Kefu Chai
5fb318fd25 crimson/common: discard failure of finally() block
instead of assuming that the function passed to finally() returns an
erroratorized future, in this change:

* s/safe_then/then_wrapped/ to handle the exception thrown by
  the finally function.
* specialize for the case where the finally function does not return
  a future, and just call it. note, in seastar's implementation of
  finally, `finally_body` is used for specializing these two cases.
* rename "future" to "result", for better readability.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-09-19 12:40:50 +08:00
Kefu Chai
47e7cd0f65
Merge pull request #37207 from tchaikov/wip-doc-dev-osx
doc/dev/macos.rst: disable features not supported on osx

Reviewed-by: Kamoltat Sirivadhna <ksirivad@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2020-09-19 12:08:35 +08:00
Kefu Chai
266aa66aa9
Merge pull request #37252 from pponnuvel/spellcheck-docs
doc: Fixed a number of typos in documentation

Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-09-19 11:07:52 +08:00
Kefu Chai
7e15a95bab
Merge pull request #37216 from tchaikov/wip-doc-cephadmin-codeblock
doc/cephadm: use appropriate directive for formatting codeblocks

Reviewed-by: Zac Dover <zac.dover@gmail.com>
2020-09-19 10:57:58 +08:00
Patrick Donnelly
7eceaf45de
Merge PR #37202 into master
* refs/pull/37202/head:
	mon: allow overriding the initial mon_host

Reviewed-by: Neha Ojha <nojha@redhat.com>
2020-09-18 18:54:57 -07:00
Kefu Chai
a251ea097d
Merge pull request #37224 from tchaikov/wip-cmake-boost-MPL-list-size
cmake: introduce Boost::MPL interface library for increasing BOOST_MPL_LIMIT_LIST_SIZE

Reviewed-by: David Zafman <dzafman@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2020-09-19 09:33:31 +08:00
Patrick Donnelly
0275e1c7af
Merge PR #37214 into master
* refs/pull/37214/head:
	mgr/volumes/nfs: Check if orchestrator spec service_id is valid

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2020-09-18 17:29:27 -07:00
Patrick Donnelly
22b3d48fa0
Merge PR #37190 into master
* refs/pull/37190/head:
	mon/MonCap: check profile_grants too while checking caps

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2020-09-18 17:27:09 -07:00
Patrick Donnelly
d1a0a6eecc
Merge PR #37148 into master
* refs/pull/37148/head:
	mds/FSMap: do not set legacy_client_fscid after filtering

Reviewed-by: Rishabh Dave <ridave@redhat.com>
2020-09-18 17:24:38 -07:00
Patrick Donnelly
b64c3784f0
Merge PR #37037 into master
* refs/pull/37037/head:
	mds: fix purge_queue's _calculate_ops is inaccurate

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2020-09-18 17:23:32 -07:00
Patrick Donnelly
269667b3a2
Merge PR #37218 into master
* refs/pull/37218/head:
	qa: spawn MDS daemons before creating fs

Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-09-18 16:25:59 -07:00
Neha Ojha
8ba0a61a51
Merge pull request #35906 from gregsfortytwo/wip-stretch-mode
Add a new stretch mode for 2-site Ceph clusters

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2020-09-18 14:31:45 -07:00
Patrick Donnelly
2aae719653
Merge PR #36957 into master
* refs/pull/36957/head:
	mds: convert stringstream to CachedStackStringStream

Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>
2020-09-18 11:04:11 -07:00
Michael Fritch
a6c06a9ca7
Merge pull request #37245 from mgfritch/cephadm-extra-ceph-conf-test
mgr/cephadm: fixup expected extra ceph conf test result

Reviewed-by: Adam King <adking@redhat.com>
2020-09-18 11:50:35 -06:00
Ponnuvel Palaniyappan
d99d520493 doc: Fixed a number of typos in documentation
Signed-off-by: Ponnuvel Palaniyappan <pponnuvel@gmail.com>
2020-09-18 18:17:15 +01:00
Alfonso Martínez
924368e1d0 mgr/dashboard: fix performance issue when listing large amounts of buckets
Fixes: https://tracker.ceph.com/issues/47543
Signed-off-by: Alfonso Martínez <almartin@redhat.com>
2020-09-18 17:16:34 +02:00
Michael Fritch
b3205210a1
mgr/cephadm: fixup expected extra ceph conf test result
fix test failure introduced by:
ff7e76348e

```
E           AssertionError: expected call not found.
E           Expected: _run_cephadm('test', 'mon.test', 'deploy', ['--name', 'mon.test', '--reconfig', '--config-json', '-'], stdin='{"config": "\\n\\n[mon]\\nk=v\\n", "keyring": ""}')
E           Actual: _run_cephadm('test', 'mon.test', 'deploy',
['--name', 'mon.test', '--reconfig', '--config-json', '-'],
stdin='{"config": "\\n\\n[mon]\\nk=v\\n", "keyring": ""}', image='')
```

Signed-off-by: Michael Fritch <mfritch@suse.com>
2020-09-18 08:54:57 -06:00
Daniel Gryniewicz
7d2e36845b Fix missing req_state for librgw
One of the zipper commits broke the declaration of req_state.

Fixes issue #47520

Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
2020-09-18 10:52:02 -04:00
Lenz Grimmer
de3c66c568 doc: Updated HACKING.rst and README.rst
Replaced the content of `HACKING.rst` in the dashboard source code
directory with a pointer to the new location in the developer guide.

Updated references in `README.rst` to also point to the online versions
of these files.

Fixes: tracker.ceph.com/issues/47396

Signed-off-by: Lenz Grimmer <lgrimmer@suse.com>
2020-09-18 15:15:34 +02:00
Rishabh Dave
f07ccd64d4 qa/mgr: revert a patch from commit 04ed58f
mds_cluster.mds_fail() runs command "mds fail" not "fs fail". The reason
for failure was PR #32581 which accidentally changed the return code
from 0 to EINVAL. Since this was reversed in PR #37159, the change
introduced by 04ed58f is not only incorrect but also redundant.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2020-09-18 16:33:41 +05:30
Lenz Grimmer
ec05d87432
Merge pull request #34545 from rhcs-dashboard/read_only
mgr/dashboard: Disabling the form inputs for the read_only modals

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
2020-09-18 12:59:30 +02:00
Aashish Sharma
1c812e0d61 mgr/dashboard/api: move/create OSD histogram in separate endpoint
Added a separate endpoint for osd/histogram - api/osd/{svc_id}/histogram

Fixes:https://tracker.ceph.com/issues/46898
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
2020-09-18 16:11:04 +05:30
Lenz Grimmer
0625509c7f
Merge pull request #37023 from p-se/grafana-many-to-many
mgr/dashboard: Fix many-to-many issue in host-details Grafana dashboard

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
2020-09-18 11:58:47 +02:00
Joshua Schmid
4057f30187
Merge pull request #37059 from guits/guits-cephadm-shell-multiple-mounts
cephadm: support multiple mounts when running interactive shell
2020-09-18 10:57:52 +02:00