to silence the warning like
follow the suggestion from pip
ERROR: After October 2020 you may experience errors when installing or updating packages. This is because pip will change the way that it resolves dependency conflicts.
We recommend you use --use-feature=2020-resolver to test your packages with the new resolver before it becomes the default.
Fixes: https://tracker.ceph.com/issues/47636
Signed-off-by: Kefu Chai <kchai@redhat.com>
mgr/dashboard: fix perf. issue when listing large amounts of buckets
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
The --key option was removed in commit 1b5f37bbcd
("backport-create-issue: read redmine key from file").
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
crimson: do not set_value() twice and fix Message leak
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
crimson::mon::Connection::handle_auth_done() is shared by both v1 and v2
authentication implementation, so move it to "v1 and v2" section
Signed-off-by: Kefu Chai <kchai@redhat.com>
in 7736bddc53, we assumed that the object
to be recovered did not exist in `recovering` before
`recover_object(oid)` was called. but this turns out not true. so, in
this change, `add_object(oid)` is called before `recover_object(oid)`
gets called.
Fixes: https://tracker.ceph.com/issues/47593
Signed-off-by: Kefu Chai <kchai@redhat.com>
this helps to avoid the confusion of "where the recovery is added" and
"are we adding a new instance of recovery here".
should call add_recovery() explicitly when we need to add a new recovery
instance.
Signed-off-by: Kefu Chai <kchai@redhat.com>
before this change, get_recovery() can also be used for adding a
recovery instance to `recovering`. this behavior is error-prone and
confusing.
after this change, add_recovery() is used in the place where we
want to add a new instance of recovery instance.
Signed-off-by: Kefu Chai <kchai@redhat.com>
mgr/dashboard: log in non-admin users successfully if the telemetry notification is shown
Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
crimson::osd::PG::send_cluster_message() accepts a `Message*`
pointer, and then hand it over to `shard_services.send_to_osd()`,
which expects a `Ref<Message>`. so the raw pointer is used to
construct an `intrusive_ptr<Message>`, which increment the
refcount of that Message instance by one. but that Message
was owned by nobody before that, so we end up with an
`intrusive_ptr<Message>` of 2 refcount, and only a single
owner. hence the memory leak.
in this change, instructs the constructor to not add the refcount.
Signed-off-by: Kefu Chai <kchai@redhat.com>
once the continuation consuming the stored value of the associated
future, we cannot set_value() again. otherwise, ASan complains that we
are accessing the memory on heap after it is freed.
in this change, std::optional<> is used for holding
promise<auth_result_t>, once the promise is fulfilled, `auth_done` is
reset to prevent another call of `set_value()` or `set_exception()`.
Signed-off-by: Kefu Chai <kchai@redhat.com>
This gets past things like tzconfig stopping for user input.
Remove redundant install of python-virtualenv.
Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
* refs/pull/36776/head:
systemd: Support Graceful Reboot for AIO Node
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: David Disseldorp <ddiss@suse.de>
crimson/seastore: fix potential non-repeatable-read from RootBlock
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
