Commit Graph

140786 Commits

Author SHA1 Message Date
Venky Shankar
8400e77a96 Merge PR #53280 into main
* refs/pull/53280/head:
	mds: fix issuing redundant reintegrate/migrate_stray requests
	mds: record the internal client request and receive client reply

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
2023-10-20 10:41:08 +05:30
zdover23
9b8b61115e
Merge pull request #54084 from zdover23/wip-doc-2023-10-19-rados-troubleshooting-troubleshooting-pg-2-of-x
doc/rados: edit troubleshooting-pg (2 of x)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-10-20 14:05:16 +10:00
zdover23
8deaa9597a
Merge pull request #54099 from jmolmo/monitoring_doc
doc: Documentation about main Ceph metrics

Reviewed-by: Zac Dover <zac.dover@gmail.com>
2023-10-20 07:56:17 +10:00
Juan Miguel Olmo Martínez
9bb63bdc89 doc: Documentation about main Ceph metrics
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Co-authored-by: Zac Dover <zac.dover@proton.me>
Signed-off-by: Juan Miguel Olmo Martínez <jolmomar@ibm.com>
2023-10-20 07:21:52 +10:00
Zac Dover
d0cdfc1d72 doc/rados: edit troubleshooting-pg (2 of x)
Edit doc/rados/troubleshooting/troubleshooting-pg.rst (1 of x).

Follows https://github.com/ceph/ceph/pull/54052.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-10-20 05:42:31 +10:00
J. Eric Ivancich
5ac998474c
Merge pull request #53929 from ivancich/wip-indexless-test
rgw: only buckets with reshardable layouts need to be considered for resharing

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2023-10-19 13:16:54 -04:00
J. Eric Ivancich
d7e88292db
Merge pull request #53813 from cfsnyder/wip-63092
rgw: add versioning info to radosgw-admin bucket stats output

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2023-10-19 13:15:55 -04:00
J. Eric Ivancich
c959100fba
Merge pull request #53801 from BBoozmen/oozmen_sts_keygen
RGW/STS: when generating keys, take the trailing null character into account

Reviewed-by: Pritha Srivastava <prsrivas@redhat.com>
2023-10-19 13:14:46 -04:00
J. Eric Ivancich
5b9fc05a20
Merge pull request #53750 from Inode1/rgw-user-policy-check-subuser
rgw: fix user.rgw.user-policy attr remove by modify user

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2023-10-19 13:13:27 -04:00
Nizamudeen A
1afba5cde5
Merge pull request #53653 from rhcs-dashboard/fix-alert-generation
mgr/dashboard: fix broken alert generator

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Anthony D Atri <anthony.datri@gmail.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Guillaume Abrioux <gabrioux@redhat.com>
2023-10-19 09:57:06 +05:30
Zack Cerza
9ee47b0328
Merge pull request #53327 from zmc/cv-disk-unbound-var
ceph-volume: Fix unbound var in disk.get_devices()
2023-10-18 15:02:20 -06:00
zdover23
d1422109fe
Merge pull request #54051 from NUABO/tanchangzhi
doc: Update mClock QOS documentation to discard osd_mclock_cost_per_*

Reviewed-by: Zac Dover <zac.dover@proton.me>
2023-10-19 05:41:28 +10:00
Nizamudeen A
72ea37aed3
Merge pull request #52897 from cloudbehl/navigation-improvements
mgr/dashboard: Left navigation improvements

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: ivoalmeida <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2023-10-18 22:13:07 +05:30
J. Eric Ivancich
ee4f5d7de2 rgw: check if bucket index layout can be resharded before progressing
Adds a test for a reshardable index layout when a bucket is considered
for immediate, scheduled, or dynamic resharding.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
2023-10-18 12:20:23 -04:00
Adam King
0787262864
Merge pull request #53910 from rkachach/fix_issue_63123
mgr/rook: fixing rook-ceph-exporter daemon type handling

Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@ibm.com>
Reviewed-by: travisn <tnielsen@redhat.com>
2023-10-18 08:47:32 -04:00
zdover23
38a6007ddf
Merge pull request #54052 from zdover23/wip-doc-2023-10-17-rados-troubleshooting-troubleshooting-pg-1-of-x
doc/rados: edit troubleshooting-pg.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-10-18 19:58:30 +10:00
zdover23
2028691b92
Merge pull request #54028 from anthonyeleven/anthonyeleven/hw-recs
doc/start: Modernize and clarify hardware-recommendations.rst

Reviewed-by: Zac Dover <zac.dover@proton.me>
2023-10-18 19:27:14 +10:00
Zac Dover
fbde0a441e doc/rados: edit troubleshooting-pg.rst (1 of x)
Edit doc/rados/troubleshooting/troubleshooting-pg.rst (1 of x).

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-10-18 19:20:17 +10:00
Nizamudeen A
f5c7649c24
Merge pull request #53991 from rhcs-dashboard/fix-cephfs-edit-form-placement
mgr/dashboard: disable hosts field while editing the filesystem 

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
2023-10-18 12:19:57 +05:30
Ilya Dryomov
c31f506768
Merge pull request #54002 from idryomov/wip-63028
pybind/rbd: don't produce info on errors in aio_mirror_image_get_info()

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
2023-10-17 13:20:59 +02:00
Ilya Dryomov
a567f55bb6
Merge pull request #53800 from batrick/cmake-debug-wrn
CMakeLists: warn if CMAKE_BUILD_TYPE is set/unset

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2023-10-17 13:14:25 +02:00
cloudbehl
7a54ba3cc1 mgr/dashboard: Left navigation improvements
Fixes: https://tracker.ceph.com/issues/62366

Signed-off-by: cloudbehl <cloudbehl@gmail.com>
2023-10-17 16:22:27 +05:30
tanchangzhi
a7502cb512 doc: Update mClock QOS documentation to discard osd_mclock_cost_per_*
The cost parameters (osd_mclock_cost_per_*) have been removed.
The cost of an operation is now determined using the random IOPS
and maximum sequential bandwidth capability of the OSD's underlying device.

Fixes: https://tracker.ceph.com/issues/58529
Signed-off-by: tanchangzhi <544463199@qq.com>
2023-10-17 17:00:31 +08:00
Anthony D'Atri
83bd3a8dfb doc/start: Modernize and clarify hardware-recommendations.rst
Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
2023-10-16 23:43:23 -04:00
Adam King
28cb4d10b1
Merge pull request #53802 from phlogistonjohn/jjm-cephadm-dtypes-2
cephadm: convert more types to be based on ContainerDaemonForm

Reviewed-by: Adam King <adking@redhat.com>
2023-10-16 15:33:53 -04:00
Casey Bodley
b2d0278750
Merge pull request #53351 from ceph/QE_defect_fixes
rgw/s3select: fix per QE defect.
2023-10-16 17:02:52 +01:00
Patrick Donnelly
b8c6ba01b2
CMakeLists: warn if CMAKE_BUILD_TYPE is set/unset
At some point the debug builds for wip branches no longer had the .git
directory available so the Debug build type was unset. This meant we are
no longer doing numerous checks (like mutex ownership checks) that we
would normally be doing in the qa suite.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2023-10-16 12:01:06 -04:00
zdover23
4a426ea801
Merge pull request #54022 from zdover23/wip-doc-2023-10-15-rados-troubleshooting-troubleshooting-osd-3-of-x
doc/rados: Edit troubleshooting-osd (3 of x)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-10-16 09:39:20 +10:00
Zac Dover
01b5aa5d27 doc/rados: Edit troubleshooting-osd (3 of x)
Edit doc/rados/troubleshooting/troubleshooting-osd.rst (3 of x).

Follows https://github.com/ceph/ceph/pull/53986.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-10-16 09:25:37 +10:00
Yuval Lifshitz
9b943423e5
Merge pull request #53547 from yuvalif/wip-yuval-req-context
rgw: adding request context structure

reviewed-by: dang, cbodley
2023-10-15 09:51:25 +03:00
Anthony D'Atri
984ba140e1
Merge pull request #54006 from zdover23/wip-doc-2023-10-14-filestore-deprecation
doc/rados: remove FileStore material (in Reef)
2023-10-13 14:50:21 -04:00
Zac Dover
eab0be5ca5 doc/rados: remove FileStore material (in Reef)
Remove FileStore-related material because FileStore is not supported in
Reef.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-10-14 04:40:26 +10:00
Anthony D'Atri
66e596a8cd
Merge pull request #54005 from zdover23/wip-doc-2023-10-14-dev-cache-pool-removal
doc/dev: remove cache-pool
2023-10-13 14:25:59 -04:00
Zac Dover
073b0919ed doc/dev: remove cache-pool
Remove cache-pool, which is deprecated in Reef.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-10-14 04:17:44 +10:00
Kamoltat (Junior) Sirivadhna
cdf5c2d5fc
Merge pull request #53979 from kamoltat/wip-ksirivad-fix-63183
src/mon/Monitor: Fix set_elector_disallowed_leaders
Reviewed-by: Greg Farnum <gfarnum@redhat.com>
2023-10-13 11:44:36 -04:00
Ilya Dryomov
01fff6a72a mgr/rbd_support: make type hits on aio_mirror_image_*() callbacks better
Make it clear that mirror mode, mirror info and snap ID can be None if
the respective operation fails.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2023-10-13 17:39:26 +02:00
Ilya Dryomov
a81bd2db3a pybind/rbd: don't produce info on errors in aio_mirror_image_get_info()
Check completion return value before attemting to decode c_info.
Otherwise we are guaranteed to access invalid memory in decode_cstr()
while trying to compute global_id string length when the client is
blocklisted for example.

Fixes: https://tracker.ceph.com/issues/63028
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2023-10-13 17:39:26 +02:00
Adam Kupczyk
9b8e8d93b6
Merge pull request #53732 from pereman2/bluefs-expand-bug
os/bluestore: fix bluefs _extend_log seq update
2023-10-13 16:07:57 +02:00
zdover23
26f89fc8bc
Merge pull request #53986 from zdover23/wip-doc-2023-10-12-rados-troubleshooting-troubleshooting-osd-2-of-x
doc/rados: Edit troubleshooting-osd (2 of x)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-10-13 23:40:38 +10:00
Zac Dover
37e7099267 doc/rados: Edit troubleshooting-osd (2 of x)
Edit doc/rados/troubleshooting/troubleshooting.rst (2 of x).

Follows https://github.com/ceph/ceph/pull/53936.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-10-13 23:03:33 +10:00
ivan
e66e0b17f5 rgw: fix user.rgw.user-policy attr remove by modify user
Signed-off-by: ivan <i.makarychev@tinkoff.ru>
2023-10-13 13:36:22 +03:00
Yingxin
833bf7ec7e
Merge pull request #53234 from xxhdx1985126/wip-seastore-onode-manager-replay
crimson/os/seastore/onode_manager: populate delta recorders for each onode modification

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2023-10-13 16:28:34 +08:00
Nizamudeen A
b18a1441be mgr/dashboard: disable hosts field while editing the filesystem
Even though the Placement field was disabled, the Host field was still
showing up in UI while Editing. That option is not possible in fs form.

Fixes: https://tracker.ceph.com/issues/63193
Signed-off-by: Nizamudeen A <nia@redhat.com>
2023-10-13 13:17:05 +05:30
Nizamudeen A
a5027e37ec mgr/dashboard: fix broken alert generator
Currently the alert generator is broken if you try to run `tox
-ealerts-fix`. I fixed it and ran the command and it built a new json
file as well.

Signed-off-by: Nizamudeen A <nia@redhat.com>
2023-10-13 12:42:50 +05:30
galsalomon66
99d12712c5 fix per QE defect.
s3select submodule

s3select engine changes

s3select submodule
aggregation functions upon no data

Signed-off-by: galsalomon66 <gal.salomon@gmail.com>
2023-10-12 23:31:15 +03:00
Kamoltat
5d1b5da215 src/mon/Monitor: Fix set_elector_disallowed_leaders
Problem:

In the monitors we hold 2 copies of disallowed_leader ...
1. MonMap class 2. Elector class.
When computing the ConnectivityScore for the monitors during
the election, we use the `disallowed_leader` from Elector
class to determine which monitors we shouldn't allow to lead.

Now, we rely on the function `set_elector_disallowed_leaders`
to set the `disallowed_leader` of the Elector class, MonMap
class copy of the `disallowed_leader` contains the
`tiebreaker_monitor` so we inherit that plus we also add the
monitors that are dead due to a zone failure.

Hence, the `adding dead monitors` phase is only allowed if we can
enter stretch_mode. However, there is a problem when failing over a stretch cluster
zone and reviving the entire zone back up, the revived monitors
couldn't enter stretch_mode when they are at the state of "probing"
since PaxosServices like osdmon becomes unreadable (this is expected)

Solution:

We unconditionally add monitors that are in
`monmap->stretch_marked_down_mons` to the
`disallowed_leaders` list in
`Monitor::set_elector_disallowed_leaders` since
if the monitors are in `monmap->stretch_marked_down_mons`
we know that they probably belong in a marked down
zone and is not fit for lead.

This will fix the problem of newly revived monitors
having different disallowed_leaders set
and getting stuck in election.

Fixes: https://tracker.ceph.com/issues/63183

Signed-off-by: Kamoltat <ksirivad@redhat.com>
2023-10-12 20:07:12 +00:00
Ilya Dryomov
4e051e66a3
Merge pull request #53914 from idryomov/wip-63149
qa/suites/rbd: drop cache tiering workload tests

Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Mykola Golub <mgolub@suse.com>
2023-10-12 21:29:05 +02:00
Adam King
b15daa4888
Merge pull request #51416 from adk3798/jaeger-agent-dep
mgr/cephadm: make jaeger-collector a dep for jaeger-agent

Reviewed-by: John Mulligan <jmulligan@redhat.com>
2023-10-12 15:24:26 -04:00
Yuri Weinstein
869c1cf7af
Merge pull request #53980 from ceph/wip-yuri-crontab-main
qa/tests: fixed typo and added `--force-priority` in missing places

Reviewed-by: Laura Flores <lflores@redhat.com>
2023-10-12 07:56:01 -07:00
Yingxin
b044a965af
Merge pull request #53062 from xxhdx1985126/wip-seastore-list-objects
crimson/os/seastore: return ghobject_t::max as the end when list_objects reaches the end of the listing

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
2023-10-12 14:44:11 +08:00