Commit Graph

140786 Commits

Author SHA1 Message Date
Adam King
ab07057e18
Merge pull request #53621 from phlogistonjohn/jjm-cephadm-dtypes-common
cephadm: introduce Daemon Forms

Reviewed-by: Adam King <adking@redhat.com>
2023-10-05 11:41:47 -04:00
Venky Shankar
3844ff224e Merge PR #53836 into main
* refs/pull/53836/head:
	PendingReleaseNotes: add a note about disallowing delegating inodes
	qa: start testing mds_client_delegate_inos_pct config
	mds: disable delegating inode ranges to clients

Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
2023-10-05 20:58:33 +05:30
Dhairya Parmar
1f78a32a18 doc: remove egg fragment from dev/developer_guide/running-tests-locally
DEPRECATION: git+https://github.com/ceph/teuthology#egg=teuthology
[test] contains an egg fragment with a non-PEP 508 name pip 25.0 will enforce
this behaviour change. A possible replacement is to use the req @ url syntax,
and remove the egg fragment. Discussion can be found at
https://github.com/pypa/pip/issues/11617

Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
2023-10-05 20:17:14 +05:30
Rishabh Dave
84f1280991 src/MDSMonitor: make use of imported namespace symbols
Symbols imported into current namespace should be used directly; there
is no need to mention their parent namespace while using them. IOW, to use
"std::string" after it has been imported, just write "string" instead of
"std::string".

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2023-10-05 19:56:32 +05:30
Rishabh Dave
7c864711e5 mon/MDSMonitor: remove unused namespace imports
Remove symbols imported into the current namespace since they are not being
used.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2023-10-05 19:54:30 +05:30
Rishabh Dave
3cbe4e2321 mon/FSCommands: import std::ostream into current namespace
Signed-off-by: Rishabh Dave <ridave@redhat.com>
2023-10-05 19:54:03 +05:30
Yuval Lifshitz
c217fba493 rgw/lua: install lua packages in temp directory
and switch to it only once installation is done.
this is needed for cases where installation can happen
while RGW is running

Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
2023-10-05 17:21:32 +03:00
Yuval Lifshitz
84944ab680 rgw/lua/doc: fix luajson example
Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
2023-10-05 17:21:32 +03:00
Rishabh Dave
c3a2e678c9 mon/FSCommands: make use of imported namespace symbols
There's no need to mention the "home" namespace of a symbol while using
it after it has been imported into the current namespace. IOW, no need to
write, for example, "std::string" after it has been imported from its
namespace; instead simply writing "string" will suffice.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2023-10-05 19:50:11 +05:30
Rishabh Dave
ee940855be mon/FSCommands: remove unused namespace imports
When symbols imported into the current namespace won't be used, don't
import them.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2023-10-05 19:48:21 +05:30
Rishabh Dave
8545784a98 mon/AuthMonitor: make use of imported namespace symbols
Once a symbol has been imported into the current namespace, no need to
mention the original namespace while using it. IOW, no need to write
"std::string" after it has been imported from the namespace "std" into the
current namespace.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2023-10-05 19:47:09 +05:30
Rishabh Dave
3126533d26 mon/AuthMonitor: remove unused namespace imports
Don't import items into current namespace when they'll be never used.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2023-10-05 19:43:39 +05:30
Nizamudeen A
7f32bce6c5
Merge pull request #53700 from cloudbehl/cephfs-snapshot
mgr/dashboard: Fixed cephfs snapshot listing in directories

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2023-10-05 19:40:32 +05:30
Adam King
a44dd1fd70
Merge pull request #53782 from sachinpunadikar/vstart-fix
vstart: exclude default route during cluster setup

Reviewed-by: Adam King <adking@redhat.com>
2023-10-05 08:37:56 -04:00
cloudbehl
a40fd8ca92 mgr/dashboard: Filter active alerts
- List alerts which are not suppressed

fixes: https://tracker.ceph.com/issues/62990

Signed-off-by: cloudbehl <cloudbehl@gmail.com>
2023-10-05 17:33:35 +05:30
zdover23
ce1bf5ae25
Merge pull request #53819 from zdover23/wip-doc-2023-10-04-rados-troubleshooting-index
doc/rados: edit troubleshooting.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-10-05 22:43:02 +11:00
Venky Shankar
689b3d5ae1 PendingReleaseNotes: add a note about disallowing delegating inodes
Signed-off-by: Venky Shankar <vshankar@redhat.com>
2023-10-05 16:54:32 +05:30
Venky Shankar
4c6660842f qa: start testing mds_client_delegate_inos_pct config
Signed-off-by: Venky Shankar <vshankar@redhat.com>
2023-10-05 15:09:15 +05:30
Venky Shankar
8d57584ff8 mds: disable delegating inode ranges to clients
Fixes: http://tracker.ceph.com/issues/63103
Signed-off-by: Venky Shankar <vshankar@redhat.com>
2023-10-05 15:09:15 +05:30
Yuval Lifshitz
5fede37615
Merge pull request #52735 from vedanshbhartia/coverity_minlong
rgw: Add coverity annotation for warning about tautological comparison

reviewed-by: thotz, yuvalif
2023-10-05 10:50:21 +03:00
Ali Masarwa
8cf2e2d089
Merge pull request #53788 from AliMasarweh/wip-alimasa-topic-stats-help
RGW: add the missing help print for command 'topic stats'

Reviewed-by: thotz <thottanjiffin@gmail.com>, Daniel Gryniewicz <dang@redhat.com>
2023-10-05 10:46:37 +03:00
Nizamudeen A
296044d181
Merge pull request #53789 from rhcs-dashboard/rgw-overview-fix
mgr/dashboard: fix rgw inventory card and broken shadows

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
2023-10-05 12:25:11 +05:30
Sachin Punadikar
8b328dd979 vstart: exclude default route during cluster setup
"ip route list" may list default route, and that needs to be excluded
while doing cluster setup
Typical o/p of ip route list:
$ ip route list
default via 10.8.159.254 dev eno1 proto dhcp src 10.8.152.13 metric 100
10.8.152.0/21 dev eno1 proto kernel scope link src 10.8.152.13 metric 100

Signed-off-by: Sachin Punadikar <sachin.punadikar@ibm.com>
2023-10-05 02:22:08 -04:00
Nizamudeen A
54afd7b36e
Merge pull request #52313 from linuxbox2/wip-fix-disable-dashboard
dashboard: regression, make install fails w/dashboard disabled

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2023-10-05 09:12:25 +05:30
John Mulligan
ed1bdff776 cephadm: convert cephadm agent to a daemon form
The cephadm agent is a bit special in that it will not be converted
to a ContainerDaemonForm (it is not containerized) but we still want
to have it registered as a DeamonForm so that the deamon_type can be
passed to create and have it resolve correctly.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-04 15:17:57 -04:00
John Mulligan
e82baf51be cephadm: convert SNMPGateway to a ContainerDaemonForm
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-04 15:17:57 -04:00
John Mulligan
be3e552717 cephadm: convert CustomContainer to a ContainerDaemonForm
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-04 15:17:57 -04:00
John Mulligan
0c702d530e cephadm: convert NFSGanesha to a ContainerDaemonForm
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-04 15:17:57 -04:00
John Mulligan
3d75f99119 cephadm: add func to deploy any generic ContainerDaemonForm
While there are no ContainerDaemonForms implemented yet, add a function
that uses the ContainerDaemonForm methods to construct a deployment
for the container based daemons.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-04 15:17:57 -04:00
John Mulligan
81566c3a3f cephadm: add ContainerDaemonForm
Add a supplemental DaemonForm subclass that helps deploy container
based daemons in a standard fashion. Most of these methods are
optional and should have sensible defaults.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-04 15:17:57 -04:00
John Mulligan
0e58e0a170 cephadm: move DeploymentType to deploy.py
The DeploymentType is used by a number of other classes and functions
and has no dependencies beyond enum and is safe to move.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-04 15:17:57 -04:00
John Mulligan
33f2606935 cephadm: move firewalld related items to firewalld.py
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-04 15:17:57 -04:00
John Mulligan
d3b59b80da cephadm: remove direct daemon-class deps from firewall
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-04 15:17:57 -04:00
John Mulligan
4a00814f82 cephadm: move sysctl specific functions to sysctl.py
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-04 15:17:57 -04:00
John Mulligan
14f3cf1738 cephadm: remove direct daemon-type deps from sysctl
Using the appropriate daemon form we can break the direct dependency
that the sysctl setup function has on particular classes and use
a generic interface.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-04 15:17:57 -04:00
John Mulligan
8f459ad3db cephadm: add test_daemon_form.py
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-04 15:17:57 -04:00
John Mulligan
1a70e6a72e cephadm: introduce daemon forms to cephadm.py
Introduce the DeamonForm base class to cephadm.py and make various
daemon-type classes into fully fleged deamon form classes.

Some classes already had a semi-standard `init` classmethod for
instantiation. In these cases the new `create` classmethod is a thin
wrapper over the existing method. In cases where the class was not
already being instantiated a minimal set of methods are added.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-04 15:17:57 -04:00
John Mulligan
910a2e01f4 cephadm: add daemon_form.py: bases and funcs for daemon forms
Create daemon_form.py containing the DaemonForm class and a few
subclasses and utility functions for working with DaemonForms.
In a future commit, DaemonForm will become the base class for
the current assortment of classes named after the daemon or
family of daemon they help manage.

A daemon form, think "form" as in "template" or "mold", assists
in setting up, creating, and managing daemons controlled with
cephadm. Because cephadm supports a variety of services the
DaemonForm is an abstract base class and the module also supports
additional ABCs that may be used by DaemonForms to implement
optional features.

The daemon forms that are expected to be used directly must be
registered using the provided decorator. This is an explicit extra
step so that common bases that inherit from DaemonForm can be
implemented. Plus explicit is better than implicit. :-)
All DeamonForm subclasses are expected to provide a small set
of standard methods so that the types can be chosen, instantiated,
and used a common manner.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-04 15:17:57 -04:00
John Mulligan
f80c976f8d cephadm: add some unit test coverage for deploying nfs, snmp
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-04 15:17:57 -04:00
Zac Dover
9d9d92837e doc/rados: edit troubleshooting.rst
Edit doc/rads/troubleshooting.rst to remove some language that sounds
quite close to marketing language.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-10-05 00:43:04 +10:00
Cory Snyder
7752b9019d rgw: add versioning info to radosgw-admin bucket stats output
This allows admins to more easily identify whether a bucket
has versioning / object lock/ mfa enabled.

Fixes: https://tracker.ceph.com/issues/63092
Signed-off-by: Cory Snyder <csnyder@1111systems.com>
2023-10-04 10:24:19 -04:00
Matt Benjamin
0225f2685d dashboard: regression, make install fails w/dashboard disabled
https://tracker.ceph.com/issues/63100

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2023-10-04 10:15:55 -04:00
Nizamudeen A
db8fb4d047
Merge pull request #53436 from rhcs-dashboard/fix-bootstrap-script
mgr/dashboard: fix bootstrap script for cephadm installation

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
2023-10-04 18:43:09 +05:30
Igor Fedotov
739416b087
Merge pull request #45069 from ifed01/wip-ifed-alloc-stuff
os/bluestore: fixing some non-critical bugs for HybridAllocator

Reviewed-by: Adam Kupczyk <akupzyk@ibm.com>
2023-10-04 16:03:42 +03:00
Pedro Gonzalez Gomez
5f532a8dd9
Merge pull request #53642 from rhcs-dashboard/fix-62964-main
mgr/dashboard: Fix user/bucket count in rgw overview dashboard


Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
2023-10-04 13:03:52 +02:00
zdover23
7f5d9018c5
Merge pull request #53792 from zdover23/wip-doc-2023-10-03-rados-operations-control-2-of-x
doc/rados: edit ops/control.rst (2 of x)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-10-04 21:51:51 +11:00
Ali Masarwa
4cc9841041 RGW: add the missing help print for command 'topic stats'
Signed-off-by: Ali Masarwa <ali.saed.masarwa@gmail.com>
2023-10-04 13:22:48 +03:00
Rishabh Dave
6cfc4e73e9 mon/AuthMonitor: revise a comment
Signed-off-by: Rishabh Dave <ridave@redhat.com>
2023-10-04 15:42:02 +05:30
avanthakkar
7d4ae2331f mgr/dashboard: fix bootstrap script for cephadm installation
Fixes: https://tracker.ceph.com/issues/62827
Signed-off-by: avanthakkar <avanjohn@gmail.com>
2023-10-04 15:17:06 +05:30
zdover23
73b046f44e
Merge branch 'main' into wip-doc-2023-10-03-rados-operations-control-2-of-x
Signed-off-by: zdover23 <zac.dover@proton.me>
2023-10-04 20:33:03 +11:00