Commit Graph

129891 Commits

Author SHA1 Message Date
Casey Bodley
7eaed47aa6
Merge pull request #44488 from cfsnyder/wip-53788-reopen-ops-log-sighup
rgw: reopen ops log file on sighup

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2022-03-08 10:30:36 -05:00
Casey Bodley
e11e62e5e5
Merge pull request #45212 from cbodley/wip-54435
rgw: prevent spurious/lost notifications in the index completion thread

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
2022-03-08 10:29:48 -05:00
Casey Bodley
e98697fdcb
Merge pull request #44859 from cfsnyder/wip-54112-rgw-segfault-init-fetch
rgw: fix segfault in UserAsyncRefreshHandler::init_fetch

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2022-03-08 08:31:54 -05:00
Casey Bodley
eb25bf2557
Merge pull request #44946 from adamemerson/wip-54208
rgw: Fix data race in ChangeStatus

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2022-03-08 08:31:15 -05:00
Casey Bodley
112c260875 rgw: initialize RGWIndexCompletionManager thread after related members
resolves valgrind issues about RGWIndexCompletionManager::process()
using uninitialized memory

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2022-03-08 08:28:35 -05:00
Samuel Just
78af510044
Merge pull request #45274 from Matan-B/wip-matanb-c-ops-debug
crimson/osd: do_pgnls_common debug message format

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2022-03-07 19:15:36 -08:00
Adam C. Emerson
ec81f225e3
Merge pull request #44831 from adamemerson/wip-prepend
build: PREPEND -Og, not APPEND

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Matt Benjamin <mbenjami@redhat.com>
2022-03-07 15:51:24 -05:00
Ilya Dryomov
25cf302049
Merge pull request #43858 from rzarzynski/wip-msgr-no-cpp_error-on-read
msg/async: remove the misleading error description on read failures

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2022-03-07 18:30:03 +01:00
Kefu Chai
f6b9693b43
Merge pull request #45277 from rzarzynski/wip-crimson-fix-bo-in-pgbackend
crimson/osd: fix buffer overflow due to missed debug's param

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2022-03-08 00:28:22 +08:00
Radoslaw Zarzynski
0e212b2d7f crimson/osd: fix buffer overflow due to missed debug's param
The problem is:

```
DEBUG 2022-03-07 13:50:40,027 [shard 0] osd - calling method rbd.create, num_read=0, num_write=0
DEBUG 2022-03-07 13:50:40,027 [shard 0] objclass - <cls> ../src/cls/rbd/cls_rbd.cc:787: create object_prefix=parent_id size=2097152 order=0 features=1
DEBUG 2022-03-07 13:50:40,027 [shard 0] osd - handling op omap-get-vals-by-keys on object 1:144d5af5:::parent_id:head
=================================================================
==2109764==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7f6de5176e70 at pc 0x7f6dfd2a7157 bp 0x7f6de5176e30 sp 0x7f6de51765d8
WRITE of size 24 at 0x7f6de5176e70 thread T0
    #0 0x7f6dfd2a7156 in __interceptor_sigaltstack.part.0 (/lib64/libasan.so.6+0x54156)
    #1 0x7f6dfd30d5b3 in __asan::PlatformUnpoisonStacks() (/lib64/libasan.so.6+0xba5b3)
    #2 0x7f6dfd31314c in __asan_handle_no_return (/lib64/libasan.so.6+0xc014c)
Reactor stalled for 275 ms on shard 0. Backtrace: 0x45d9d 0xda72bd3 0xd801f73 0xd81f6f9 0xd81fb9c 0xd81fe2c 0xd8200f7 0x12b2f 0x7f6dfd3383c1 0x7f6dfd339b18 0x7f6dfd339bd4 0x7f6dfd339bd4 0x7f6dfd339bd4 0x7f6dfd339bd4 0x7f6dfd33b089 0x7f6dfd33bb36 0x7f6dfd32e0b5 0x7f6dfd32ff3a 0xd61d0 0x32412 0xbd8a7 0xbd134 0x54178 0xba5b3 0xc014c 0x1881f22 0x188344a 0xe8b439d 0xe8b58f2 0x2521d5a 0x2a2ee12 0x2c76349 0x2e04ce9 0x3c70c55 0x3cb8aa8 0x7f6de558de39
    #3 0x1881f22 in fmt::v6::internal::arg_map<fmt::v6::basic_format_context<seastar::internal::log_buf::inserter_iterator, char> >::~arg_map() /usr/include/fmt/core.h:1170
    #4 0x1881f22 in fmt::v6::basic_format_context<seastar::internal::log_buf::inserter_iterator, char>::~basic_format_context() /usr/include/fmt/core.h:1265
    #5 0x1881f22 in fmt::v6::format_handler<fmt::v6::arg_formatter<fmt::v6::internal::output_range<seastar::internal::log_buf::inserter_iterator, char> >, char, fmt::v6::basic_format_context<seastar::internal::log_buf::inserter_iterator, char> >::~format_handler() /usr/include/fmt/format.h:3143
    #6 0x1881f22 in fmt::v6::basic_format_context<seastar::internal::log_buf::inserter_iterator, char>::iterator fmt::v6::vformat_to<fmt::v6::arg_formatter<fmt::v6::internal::output_range<seastar::internal::log_buf::inserter_iterator, char> >, char, fmt::v6::basic_format_context<seastar::internal::log_buf::inserter_iterator, char> >(fmt::v6::arg_formatter<fmt::v6::internal::output_range<seastar::internal::log_buf::inserter_iterator, char> >::range, fmt::v6::basic_string_view<char>, fmt::v6::basic_format_args<fmt::v6::basic_format_context<seastar::internal::log_buf::inserter_iterator, char> >, fmt::v6::internal::locale_ref) /usr/include/fmt/format.h:3206
    #7 0x188344a in seastar::internal::log_buf::inserter_iterator fmt::v6::vformat_to<fmt::v6::basic_string_view<char>, seastar::internal::log_buf::inserter_iterator, , 0>(seastar::internal::log_buf::inserter_iterator, fmt::v6::basic_string_view<char> const&, fmt::v6::basic_format_args<fmt::v6::basic_format_context<fmt::v6::type_identity<seastar::internal::log_buf::inserter_iterator>::type, fmt::v6::internal::char_t_impl<fmt::v6::basic_string_view<char>, void>::type> >) /usr/include/fmt/format.h:3395
    #8 0x188344a in seastar::internal::log_buf::inserter_iterator fmt::v6::format_to<seastar::internal::log_buf::inserter_iterator, std::basic_string_view<char, std::char_traits<char> >, hobject_t const&, 0>(seastar::internal::log_buf::inserter_iterator, std::basic_string_view<char, std::char_traits<char> > const&, hobject_t const&) /usr/include/fmt/format.h:3418
    #9 0x188344a in seastar::logger::log<hobject_t const&>(seastar::log_level, seastar::logger::format_info, hobject_t const&)::{lambda(seastar::internal::log_buf::inserter_iterator)#1}::operator()(seastar::internal::log_buf::inserter_iterator) const ../src/seastar/include/seastar/util/log.hh:227
    #10 0x188344a in seastar::logger::lambda_log_writer<seastar::logger::log<hobject_t const&>(seastar::log_level, seastar::logger::format_info, hobject_t const&)::{lambda(seastar::internal::log_buf::inserter_iterator)#1}>::operator()(seastar::internal::log_buf::inserter_iterator) ../src/seastar/include/seastar/util/log.hh:106
    #11 0xe8b439d in operator() ../src/seastar/src/util/log.cc:268
    #12 0xe8b58f2 in seastar::logger::do_log(seastar::log_level, seastar::logger::log_writer&) ../src/seastar/src/util/log.cc:280
    #13 0x2521d5a in void seastar::logger::log<hobject_t const&>(seastar::log_level, seastar::logger::format_info, hobject_t const&) ../src/seastar/include/seastar/util/log.hh:230
    #14 0x2a2ee12 in void seastar::logger::debug<hobject_t const&>(seastar::logger::format_info, hobject_t const&) ../src/seastar/include/seastar/util/log.hh:373
    #15 0x2a2ee12 in PGBackend::omap_get_vals_by_keys(ObjectState const&, OSDOp&, object_stat_sum_t&) const ../src/crimson/osd/pg_backend.cc:1220
    #16 0x2c76349 in operator()<PGBackend, ObjectState> ../src/crimson/osd/ops_executer.cc:577
    #17 0x2c76349 in do_const_op<crimson::osd::OpsExecuter::execute_op(OSDOp&)::<lambda(auto:167&, const auto:168&)> > ../src/crimson/osd/ops_executer.cc:449
    #18 0x2e04ce9 in do_read_op<crimson::osd::OpsExecuter::execute_op(OSDOp&)::<lambda(auto:167&, const auto:168&)> > ../src/crimson/osd/ops_executer.h:216
    #19 0x2e04ce9 in crimson::osd::OpsExecuter::execute_op(OSDOp&) ../src/crimson/osd/ops_executer.cc:576
Reactor stalled for 762 ms on shard 0. Backtrace: 0x45d9d 0xda72bd3 0xd801f73 0xd81f6f9 0xd81fb9c 0xd81fe2c 0xd8200f7 0x12b2f 0x7f6dfd33ae85 0x7f6dfd33bb36 0x7f6dfd32e0b5 0x7f6dfd32ff3a 0xd61d0 0x32412 0xbd8a7 0xbd134 0x54178 0xba5b3 0xc014c 0x1881f22 0x188344a 0xe8b439d 0xe8b58f2 0x2521d5a 0x2a2ee12 0x2c76349 0x2e04ce9 0x3c70c55 0x3cb8aa8 0x7f6de558de39
    #20 0x3c70c55 in execute_osd_op ../src/crimson/osd/objclass.cc:35
    #21 0x3cb8aa8 in cls_cxx_map_get_val(void*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, ceph::buffer::v15_2_0::list*) ../src/crimson/osd/objclass.cc:372
    #22 0x7f6de558de39  (/home/rzarzynski/ceph1/build/lib/libcls_rbd.so.1.0.0+0x28e39)

0x7f6de5176e70 is located 249456 bytes inside of 262144-byte region [0x7f6de513a000,0x7f6de517a000)
allocated by thread T0 here:
    #0 0x7f6dfd3084a7 in aligned_alloc (/lib64/libasan.so.6+0xb54a7)
    #1 0xdd414fc in seastar::thread_context::make_stack(unsigned long) ../src/seastar/src/core/thread.cc:196
    #2 0x7fff3214bc4f  ([stack]+0xa5c4f)
```

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2022-03-07 14:26:07 +00:00
Daniel Gryniewicz
d9ac8f20cd
Merge pull request #45225 from dang/wip-dang-fix-inverted
RGW - Fix inverted return check

Reviewed-by: Eric Ivancich <eivancic@redhat.com>
2022-03-07 09:10:11 -05:00
Matan Breizman
ea5273e390 crimson/osd: do_pgnls_common debug message format
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2022-03-07 12:47:11 +00:00
Ilya Dryomov
4ba375ea2b
Merge pull request #45149 from sunnyku/wip-fix-schedule-status
mgr/rbd_support: cast pool_id from int to str when collecting LevelSpec

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2022-03-07 12:14:36 +01:00
Venky Shankar
c0c05efaf3
Merge pull request #42098 from joscollin/wip-B50033-rank0-stale-perf-stats
mgr/stats: be resilient to offline rank0 MDS

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2022-03-07 10:37:23 +05:30
Venky Shankar
84835e6b71
Merge pull request #41397 from vshankar/wip-48619
cephfs-top: display average read/write/metadata latency

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2022-03-07 10:34:15 +05:30
Venky Shankar
e0e2049e5b
Merge pull request #42001 from mchangir/mds-implement-new-getvxattr-rpc
mds,client: add new getvxattr op

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2022-03-07 10:32:57 +05:30
Venky Shankar
dc953902db
Merge pull request #44863 from nmshelke/ceph-fuse-54049
ceph-fuse: perform cleanup if test_dentry_handling failed

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2022-03-07 10:30:51 +05:30
Adam King
9bfb499d64
Merge pull request #45174 from adk3798/no-drain-admin
mgr/cephadm: block draining last _admin host

Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2022-03-06 12:19:17 -05:00
Adam King
140b410b39
Merge pull request #45202 from adk3798/no-label-rm-admin
mgr/cephadm: block removing last instance of _admin label

Reviewed-by: Michael Fritch <mfritch@suse.com>
2022-03-06 12:17:08 -05:00
Kefu Chai
b8fc4097cb
Merge pull request #45253 from tchaikov/wip-crimson-is-future
crimson/common: specialize seastar::is_future<> for interruptible_fut…

Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2022-03-06 13:21:14 +08:00
Kefu Chai
6fe8e680a3
Merge pull request #45258 from tchaikov/wip-cmake-disable-dpdk-warnings
cmake: pass RTE_DEVEL_BUILD=n when building dpdk

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
2022-03-05 20:36:06 +08:00
Ilya Dryomov
361dca26ca
Merge pull request #45255 from kamoltat/wip-ksirivad-add-jenkins-window
.github/pull_request_template.md: added test windows command

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2022-03-05 13:02:07 +01:00
Ilya Dryomov
beffb7f9c6 rbd: fix a typo in "rbd trash purge schedule ls" formatted output
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2022-03-05 11:20:49 +01:00
Ilya Dryomov
08df6e0fd0 qa/workunits/rbd: expand LevelSpec parsing coverage
Invoke "rbd mirror snapshot schedule ls -R" and "rbd mirror snapshot
schedule status" commands on all levels, consistently.  In particular,
make sure that an image level schedule is listed for a recursive query
at the pool level both before and after the schedule kicks in:

  $ rbd create --size 1G --mirror-image-mode snapshot -p foo bar
  $ rbd mirror snapshot schedule add -p foo --image bar 1m
  $ rbd mirror snapshot schedule ls -p foo -R
  POOL  NAMESPACE  IMAGE  SCHEDULE
  foo              bar    every 1m
  <wait for schedule to become visible in status>
  $ rbd mirror snapshot schedule ls -p foo -R
  POOL  NAMESPACE  IMAGE  SCHEDULE
  foo              bar    every 1m

Also, make sure that pool and image level status queries work:

  $ rbd mirror snapshot schedule status -p foo
  SCHEDULE TIME        IMAGE
  2022-03-04 07:14:00  foo/bar
  $ rbd mirror snapshot schedule status -p foo --image bar
  SCHEDULE TIME        IMAGE
  2022-03-04 07:14:00  foo/bar

Both of these issues are fixed by the previous commit.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2022-03-05 11:20:33 +01:00
Kefu Chai
91a616b26e cmake: pass RTE_DEVEL_BUILD=n when building dpdk
ceph is still using the Makefile based building system for building
DPDK. and DPDK enables -Werror if RTE_DEVEL_BUILD is 'y' which is
enabled by default when the dpdk is built from a git repo.

but newer GCC is more picky than the older versions, to prevent
the possible FTBFS when we switch to newer GCC for building old
branches whose dpdk submodule might be include the changes addressing
those warnings. let's just disable this option.

the only effect of this option is to add -Werror to CFLAGS. but
the building warnings from DPDK is not our focus when developing
Ceph in the most cases. so it should be fine.

see also
eac901ce29/doc/build-sdk-quick.txt (L18)

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-03-05 12:57:24 +08:00
Kamoltat
7c464a0eeb .github/pull_request_template.md: added test windows command
Added `jenkins test windows` to the

Show available Jenkins Commands section

Signed-off-by: Kamoltat <ksirivad@redhat.com>
2022-03-04 19:01:21 +00:00
Kefu Chai
fa64368a43 test/crimson: use std::for_each() for applying plain function
let's just use std::for_each() for applying function not returning future
to a range, otherwise we'd have

../src/test/crimson/seastore/test_transaction_manager.cc:950:5: error: no matching function for call to 'parallel_for_each'
    seastar::parallel_for_each(
    ^~~~~~~~~~~~~~~~~~~~~~~~~~
../src/seastar/include/seastar/core/loop.hh:559:1: note: candidate template ignored: constraints not satisfied [with Iterator = boost::iterators::counting_iterator<unsigned int, boost::use_default, boost::use_default>, Sentinel = boost::iterators::counting_iterator<unsigned int, boost::use_default, boost::use_default>, Func = (lambda at ../src/test/crimson/seastore/test_transaction_manager.cc:953:7)]
parallel_for_each(Iterator begin, Sentinel end, Func&& func) noexcept {
^
../src/seastar/include/seastar/core/loop.hh:553:78: note: because type constraint 'std::same_as<void, future<> >' was not satisfied:

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-03-05 02:47:38 +08:00
Kefu Chai
d97ea8e55d crimson/common: specialize seastar::is_future<> for interruptible_future<>
this ensures that seastar helper functions are able to accept
interruptible_future<> in place of vanilla seastar::future<>.

for instance, if concepts is enabled, seastar::when_all_succeed()
has a set of constraits which include:

is_future<std::remove_reference_t<decltype(*i)>>::value

where i is the iterator passed to this function. so, to ensure
seastar::when_all_succeed() works with interruptible_future,
we need to teach the is_future<> to accept interruptible_future
as well.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-03-05 01:42:16 +08:00
Daniel Gryniewicz
988c09d5ad RGW - Fix inverted return check
get_obj_head_ioctx() returns the standard int but the call was casting
it to a bool, inverting it's meaning.  Fix it to act correctly.

Fixes: https://tracker.ceph.com/issues/54452
Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
2022-03-04 10:10:57 -05:00
Laura Flores
f735432033
Merge pull request #45140 from dvanders/snaptrim_fix
osd: require osd_pg_max_concurrent_snap_trims > 0
2022-03-03 11:48:23 -06:00
Ronen Friedman
24303836a1
Merge pull request #45239 from ronen-fr/wip-rf-54458-snaps
test: osd-scrub-snaps.sh: fix expected 'missing snaps' log string

Reviewed-by: Neha Ojha <nojha@redhat.com>
2022-03-03 19:14:39 +02:00
Yuri Weinstein
ec371278ee
Merge pull request #45042 from dvanders/report_leader
Monitor: forward report command to leader

Reviewed-by: Neha Ojha <nojha@redhat.com>
2022-03-03 07:47:46 -08:00
Yuri Weinstein
1f703bcc68
Merge pull request #45035 from ssdohammer-sl/bug-fix-TierFlushDuringFlush
test: fix TierFlushDuringFlush to wait until dedup_tier is set on base pool
2022-03-03 07:47:25 -08:00
Yuri Weinstein
742a60ec04
Merge pull request #44439 from myoungwon/fix-reference-leak-dedup-tier
osd: fix ObjectContextRef reference leak

Reviewed-by: Samuel Just <sjust@redhat.com>
2022-03-03 07:47:06 -08:00
Kefu Chai
1ea8a7fd00
Merge pull request #45222 from tchaikov/wip-cmake-cleanup
cmake: use string(JOIN ..) to compose URL for boost download

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2022-03-03 23:17:55 +08:00
Ilya Dryomov
54fe2d8b33
Merge pull request #45219 from idryomov/wip-ceph-config-get-doc
doc: document "ceph config get <who> <option>"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2022-03-03 11:41:32 +01:00
Ronen Friedman
d654839222 test: osd-scrub-snaps.sh: fix expected 'missing snaps' log string
Fix the expected log message to match the scrub code, by removing
the redundant part.

Fixes: https://tracker.ceph.com/issues/54458

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2022-03-03 08:03:00 +00:00
Liu-Chunmei
8433578825
Merge pull request #45090 from liu-chunmei/seastore-fix-sparse-read
crimson/seastore: fix object not exists when do fiemap

Reviewed-by: Samuel Just <sam.just@inktank.com>
2022-03-02 18:28:36 -08:00
zdover23
7f092bb347
Merge pull request #45209 from zdover23/wip-doc-2022-03-01-hardware-recs-alpha-links
doc/start: alphabetize hardware-recs links

Reviewed-by: Anthony D Atri <anthony.datri@gmail.com>
2022-03-03 10:51:04 +10:00
chunmei-liu
50bd0c7641 crimson: fix object not exist when do fiemap
Signed-off-by: chunmei-liu <chunmei.liu@intel.com>
2022-03-02 14:39:55 -08:00
chunmei-liu
2bc57d3fc3 crimson/seastore: make fiemap return errorator future
Signed-off-by: chunmei-liu <chunmei.liu@intel.com>
2022-03-02 14:39:49 -08:00
Guillaume Abrioux
f57e3c1667
Merge pull request #45216 from guits/fix-54441
ceph-volume: fix generic activate
2022-03-02 22:49:10 +01:00
Casey Bodley
068c0807f3
Merge pull request #45207 from pritha-srivastava/wip-rgw-data-sync-run
rgw: adding OPT_DATA_SYNC_RUN to gc_ops_list so that gc gets

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Matt Benjamin <mbenjami@redhat.com>
2022-03-02 15:35:22 -05:00
Yuri Weinstein
1a684be89d
Merge pull request #44656 from NitzanMordhai/fix_44092_config_get
mon/ConfigMonitor: fix config get key with whitespace

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2022-03-02 08:02:05 -08:00
Yuri Weinstein
d4e218a93b
Merge pull request #44479 from leeq2016/leeq2016_0106
common: Use thread-local pointer variables to save the *shard

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
2022-03-02 08:01:40 -08:00
Yuri Weinstein
7e7e0b31f7
Merge pull request #44425 from sqiu110/fix-ENABLE_COVERAGE
cmake: link ceph-common against gcov if coverage is enabled

Reviewed-by: Neha Ojha <nojha@redhat.com>
2022-03-02 08:00:08 -08:00
Yuri Weinstein
5b5c93be99
Merge pull request #43058 from k0ste/feature_52512
mgr/prometheus: Added `avail_raw` field for Pools DF Prometheus mgr module

Reviewed-by: Neha Ojha <nojha@redhat.com>
2022-03-02 07:59:38 -08:00
Kefu Chai
f356cc8869 cmake: use string(JOIN ..) to compose URL for boost download
* since the minimum required cmake version is now 3.16, there is no
  need to check for cmake version for using multiple URLs for
  downloading external project.
* use string(JOIN ..) to compose URL option for downloading boost

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-03-02 23:49:52 +08:00
Ilya Dryomov
33b16fd04d doc: document "ceph config get <who> <option>"
... and note the confusing asymmetry with "ceph config set <who>
<option> <value>".

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2022-03-02 14:17:31 +01:00
Ernesto Puerta
c1a4d9ce49
Merge pull request #44923 from rhcs-dashboard/box-host-add
cephadm/box: default add hosts

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2022-03-02 13:17:45 +01:00