Ceph is a distributed object, block, and file storage platform
Go to file
Radoslaw Zarzynski 0e212b2d7f crimson/osd: fix buffer overflow due to missed debug's param
The problem is:

```
DEBUG 2022-03-07 13:50:40,027 [shard 0] osd - calling method rbd.create, num_read=0, num_write=0
DEBUG 2022-03-07 13:50:40,027 [shard 0] objclass - <cls> ../src/cls/rbd/cls_rbd.cc:787: create object_prefix=parent_id size=2097152 order=0 features=1
DEBUG 2022-03-07 13:50:40,027 [shard 0] osd - handling op omap-get-vals-by-keys on object 1:144d5af5:::parent_id:head
=================================================================
==2109764==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7f6de5176e70 at pc 0x7f6dfd2a7157 bp 0x7f6de5176e30 sp 0x7f6de51765d8
WRITE of size 24 at 0x7f6de5176e70 thread T0
    #0 0x7f6dfd2a7156 in __interceptor_sigaltstack.part.0 (/lib64/libasan.so.6+0x54156)
    #1 0x7f6dfd30d5b3 in __asan::PlatformUnpoisonStacks() (/lib64/libasan.so.6+0xba5b3)
    #2 0x7f6dfd31314c in __asan_handle_no_return (/lib64/libasan.so.6+0xc014c)
Reactor stalled for 275 ms on shard 0. Backtrace: 0x45d9d 0xda72bd3 0xd801f73 0xd81f6f9 0xd81fb9c 0xd81fe2c 0xd8200f7 0x12b2f 0x7f6dfd3383c1 0x7f6dfd339b18 0x7f6dfd339bd4 0x7f6dfd339bd4 0x7f6dfd339bd4 0x7f6dfd339bd4 0x7f6dfd33b089 0x7f6dfd33bb36 0x7f6dfd32e0b5 0x7f6dfd32ff3a 0xd61d0 0x32412 0xbd8a7 0xbd134 0x54178 0xba5b3 0xc014c 0x1881f22 0x188344a 0xe8b439d 0xe8b58f2 0x2521d5a 0x2a2ee12 0x2c76349 0x2e04ce9 0x3c70c55 0x3cb8aa8 0x7f6de558de39
    #3 0x1881f22 in fmt::v6::internal::arg_map<fmt::v6::basic_format_context<seastar::internal::log_buf::inserter_iterator, char> >::~arg_map() /usr/include/fmt/core.h:1170
    #4 0x1881f22 in fmt::v6::basic_format_context<seastar::internal::log_buf::inserter_iterator, char>::~basic_format_context() /usr/include/fmt/core.h:1265
    #5 0x1881f22 in fmt::v6::format_handler<fmt::v6::arg_formatter<fmt::v6::internal::output_range<seastar::internal::log_buf::inserter_iterator, char> >, char, fmt::v6::basic_format_context<seastar::internal::log_buf::inserter_iterator, char> >::~format_handler() /usr/include/fmt/format.h:3143
    #6 0x1881f22 in fmt::v6::basic_format_context<seastar::internal::log_buf::inserter_iterator, char>::iterator fmt::v6::vformat_to<fmt::v6::arg_formatter<fmt::v6::internal::output_range<seastar::internal::log_buf::inserter_iterator, char> >, char, fmt::v6::basic_format_context<seastar::internal::log_buf::inserter_iterator, char> >(fmt::v6::arg_formatter<fmt::v6::internal::output_range<seastar::internal::log_buf::inserter_iterator, char> >::range, fmt::v6::basic_string_view<char>, fmt::v6::basic_format_args<fmt::v6::basic_format_context<seastar::internal::log_buf::inserter_iterator, char> >, fmt::v6::internal::locale_ref) /usr/include/fmt/format.h:3206
    #7 0x188344a in seastar::internal::log_buf::inserter_iterator fmt::v6::vformat_to<fmt::v6::basic_string_view<char>, seastar::internal::log_buf::inserter_iterator, , 0>(seastar::internal::log_buf::inserter_iterator, fmt::v6::basic_string_view<char> const&, fmt::v6::basic_format_args<fmt::v6::basic_format_context<fmt::v6::type_identity<seastar::internal::log_buf::inserter_iterator>::type, fmt::v6::internal::char_t_impl<fmt::v6::basic_string_view<char>, void>::type> >) /usr/include/fmt/format.h:3395
    #8 0x188344a in seastar::internal::log_buf::inserter_iterator fmt::v6::format_to<seastar::internal::log_buf::inserter_iterator, std::basic_string_view<char, std::char_traits<char> >, hobject_t const&, 0>(seastar::internal::log_buf::inserter_iterator, std::basic_string_view<char, std::char_traits<char> > const&, hobject_t const&) /usr/include/fmt/format.h:3418
    #9 0x188344a in seastar::logger::log<hobject_t const&>(seastar::log_level, seastar::logger::format_info, hobject_t const&)::{lambda(seastar::internal::log_buf::inserter_iterator)#1}::operator()(seastar::internal::log_buf::inserter_iterator) const ../src/seastar/include/seastar/util/log.hh:227
    #10 0x188344a in seastar::logger::lambda_log_writer<seastar::logger::log<hobject_t const&>(seastar::log_level, seastar::logger::format_info, hobject_t const&)::{lambda(seastar::internal::log_buf::inserter_iterator)#1}>::operator()(seastar::internal::log_buf::inserter_iterator) ../src/seastar/include/seastar/util/log.hh:106
    #11 0xe8b439d in operator() ../src/seastar/src/util/log.cc:268
    #12 0xe8b58f2 in seastar::logger::do_log(seastar::log_level, seastar::logger::log_writer&) ../src/seastar/src/util/log.cc:280
    #13 0x2521d5a in void seastar::logger::log<hobject_t const&>(seastar::log_level, seastar::logger::format_info, hobject_t const&) ../src/seastar/include/seastar/util/log.hh:230
    #14 0x2a2ee12 in void seastar::logger::debug<hobject_t const&>(seastar::logger::format_info, hobject_t const&) ../src/seastar/include/seastar/util/log.hh:373
    #15 0x2a2ee12 in PGBackend::omap_get_vals_by_keys(ObjectState const&, OSDOp&, object_stat_sum_t&) const ../src/crimson/osd/pg_backend.cc:1220
    #16 0x2c76349 in operator()<PGBackend, ObjectState> ../src/crimson/osd/ops_executer.cc:577
    #17 0x2c76349 in do_const_op<crimson::osd::OpsExecuter::execute_op(OSDOp&)::<lambda(auto:167&, const auto:168&)> > ../src/crimson/osd/ops_executer.cc:449
    #18 0x2e04ce9 in do_read_op<crimson::osd::OpsExecuter::execute_op(OSDOp&)::<lambda(auto:167&, const auto:168&)> > ../src/crimson/osd/ops_executer.h:216
    #19 0x2e04ce9 in crimson::osd::OpsExecuter::execute_op(OSDOp&) ../src/crimson/osd/ops_executer.cc:576
Reactor stalled for 762 ms on shard 0. Backtrace: 0x45d9d 0xda72bd3 0xd801f73 0xd81f6f9 0xd81fb9c 0xd81fe2c 0xd8200f7 0x12b2f 0x7f6dfd33ae85 0x7f6dfd33bb36 0x7f6dfd32e0b5 0x7f6dfd32ff3a 0xd61d0 0x32412 0xbd8a7 0xbd134 0x54178 0xba5b3 0xc014c 0x1881f22 0x188344a 0xe8b439d 0xe8b58f2 0x2521d5a 0x2a2ee12 0x2c76349 0x2e04ce9 0x3c70c55 0x3cb8aa8 0x7f6de558de39
    #20 0x3c70c55 in execute_osd_op ../src/crimson/osd/objclass.cc:35
    #21 0x3cb8aa8 in cls_cxx_map_get_val(void*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, ceph::buffer::v15_2_0::list*) ../src/crimson/osd/objclass.cc:372
    #22 0x7f6de558de39  (/home/rzarzynski/ceph1/build/lib/libcls_rbd.so.1.0.0+0x28e39)

0x7f6de5176e70 is located 249456 bytes inside of 262144-byte region [0x7f6de513a000,0x7f6de517a000)
allocated by thread T0 here:
    #0 0x7f6dfd3084a7 in aligned_alloc (/lib64/libasan.so.6+0xb54a7)
    #1 0xdd414fc in seastar::thread_context::make_stack(unsigned long) ../src/seastar/src/core/thread.cc:196
    #2 0x7fff3214bc4f  ([stack]+0xa5c4f)
```

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2022-03-07 14:26:07 +00:00
.github mgr/dashboard: configure dependabot 2021-12-02 14:17:06 +01:00
admin mgr/cephadm: Adding python natsort module 2022-02-23 11:39:40 +01:00
bin scripts: fix bash path in shebangs (part 2) 2017-09-25 17:20:40 -06:00
ceph-erasure-code-corpus@2d7d78b9cc tests: erasure-code: add k=2, m=2 for isa & jerasure 2016-12-08 12:44:21 +01:00
ceph-menv ceph-menv: mrun shell environment 2018-05-21 13:51:16 -07:00
ceph-object-corpus@038c72b5ac ceph-object-corpus: pick up 16.2.0-90-g50f1821b4c 2021-04-12 21:49:28 +08:00
cmake/modules compressor: fix compilation issues about QATzip 2022-02-18 17:45:30 +08:00
debian mgr/cephadm: Adding python natsort module 2022-02-23 11:39:40 +01:00
doc doc/mgr/nfs: document that nfs exports related mgr call requirements 2022-02-23 16:33:48 -05:00
etc packaging: remove SuSEfirewall2 support 2019-07-12 09:55:35 +02:00
examples examples: typos found by codespell 2021-12-22 00:08:42 +01:00
fusetrace fuse: update to newer FUSE_USE_VERSION 2020-06-03 14:03:31 -04:00
keys
man doc,man: typos found by codespell 2021-12-15 12:04:36 +01:00
mirroring MIRRORS: Add ca.ceph.com 2021-06-16 13:25:15 -04:00
monitoring monitoring: mention PyYAML only once in requirements 2022-02-08 11:19:15 +05:30
qa Merge pull request #44873 from kotreshhr/clone-inherit-quota-files 2022-02-21 14:37:44 +05:30
selinux selinux: add amqp and soundd types to ceph.te 2020-07-10 01:38:00 -04:00
share
src crimson/osd: fix buffer overflow due to missed debug's param 2022-03-07 14:26:07 +00:00
sudoers.d rpm, debian: move smartmontools and nvme-cli to ceph-base 2021-08-25 13:20:23 +00:00
systemd Merge pull request #44221 from BenoitKnecht/ceph-mon-device-metrics 2022-01-10 07:56:29 -08:00
udev rbd: include RADOS namespace in krbd symlinks 2020-09-08 19:36:02 +02:00
.gitattributes doc: use union merge strategy for resolving conflicts in PendingReleaseNotes 2020-08-28 18:59:30 -07:00
.githubmap github: fix id and mail 2022-02-03 15:43:41 +01:00
.gitignore osd/scrub: scrubbing schedule - minor related cleanups 2021-11-05 17:07:57 +02:00
.gitmodule_mirrors
.gitmodules .gitmodules: remove submodule jaeger-cpp-client 2021-11-24 19:59:18 +05:30
.mailmap github: fix id and mail 2022-02-03 15:43:41 +01:00
.organizationmap mailmap: Add Nitzan Mordechai 2022-01-30 15:35:05 +02:00
.peoplemap .githubmap: update mail address 2021-08-17 09:57:25 +05:30
.readthedocs.yml .readthedocs.yml: use ditaa instead of plantweb 2021-08-02 01:00:35 +08:00
AUTHORS AUTHORS: Update Component Technical Leads and maintainers to canonical location of ceph.com. 2017-10-18 18:48:37 +08:00
ceph.spec.in mgr/cephadm: Adding python natsort module 2022-02-23 11:39:40 +01:00
CMakeLists.txt compressor: fix compilation issues about QATzip 2022-02-18 17:45:30 +08:00
CodingStyle coding-style: update a link and fix typos. 2020-02-07 15:55:08 +00:00
CONTRIBUTING.rst doc/rados/configuration/common.rst: expand the running multiple clusters section 2020-11-14 01:36:07 -08:00
COPYING COPYING: add entries for backport scripts 2021-01-14 17:42:56 +01:00
COPYING-GPL2
COPYING-LGPL2.1
COPYING-LGPL3 relicense LGPL-2.1 code as LGPL-2.1 or LGPL-3.0 2019-04-22 11:22:55 -05:00
do_cmake.sh do_cmake:sh: do not set BOOST_J 2021-08-11 17:34:23 +08:00
do_freebsd.sh do_freebsd.sh: disable WITH_SYSTEMD 2021-04-08 16:59:39 +08:00
doc_deps.deb.txt admin/build-doc: s/virtualenv/python3 -m venv/ 2021-07-31 22:34:05 +08:00
install-deps.sh Merge pull request #44805 from Matan-B/wip-matanb-deps-unicode 2022-01-31 20:38:02 +02:00
make-debs.sh make-debs.sh: remove lsb_release 2021-08-18 13:08:24 -04:00
make-dist cmake: Replace boost download url 2021-05-07 10:12:43 +02:00
make-srpm.sh Pass first parameter to make-dist for building SRPM 2017-02-17 12:23:10 +01:00
mingw_conf.sh win32*.sh: move debug symbols to separate files 2021-02-03 12:07:41 +00:00
PendingReleaseNotes Merge pull request #44588 from kamoltat/wip-ksirivad-disable-progress-by-default 2022-02-11 14:49:17 -08:00
pom.xml
README.aix ceph.spec.in: drop gdbm from build deps 2021-08-18 01:04:42 +08:00
README.FreeBSD doc: fix typos 2018-09-21 12:41:42 +08:00
README.md README.md: Update README.md to add link to tracker.ceph.com 2022-01-05 14:48:12 -07:00
README.solaris
README.windows.rst doc: reorganize Windows docs 2021-03-15 15:15:32 +00:00
run-make-check.sh rgw: add CORTX Motr SAL implementation 2022-01-27 10:45:25 +00:00
SECURITY.md SECURITY.md: update security policy 2021-05-14 19:11:02 +05:30
SubmittingPatches-backports.rst SubmittingPatches-backports.rst: clarify where to explain 2020-09-24 20:04:47 +02:00
SubmittingPatches-kernel.rst doc: split up SubmittingPatches.rst 2019-10-17 19:32:03 +02:00
SubmittingPatches.rst Merge pull request #37587 from anthonyeleven/yet-more-doc-polishing 2020-10-15 02:48:25 +10:00
win32_build.sh win*.sh,cmake: Fix Windows linking errors 2021-05-07 09:23:30 +00:00
win32_deps_build.sh win32_deps_build.sh: only clone the tip of required tag 2021-07-29 12:13:26 +08:00

Ceph - a scalable distributed storage system

Please see http://ceph.com/ for current info.

Contributing Code

Most of Ceph is dual licensed under the LGPL version 2.1 or 3.0. Some miscellaneous code is under a BSD-style license or is public domain. The documentation is licensed under Creative Commons Attribution Share Alike 3.0 (CC-BY-SA-3.0). There are a handful of headers included here that are licensed under the GPL. Please see the file COPYING for a full inventory of licenses by file.

Code contributions must include a valid "Signed-off-by" acknowledging the license for the modified or contributed file. Please see the file SubmittingPatches.rst for details on what that means and on how to generate and submit patches.

We do not require assignment of copyright to contribute code; code is contributed under the terms of the applicable license.

Checking out the source

You can clone from github with

git clone git@github.com:ceph/ceph

or, if you are not a github user,

git clone git://github.com/ceph/ceph

Ceph contains many git submodules that need to be checked out with

git submodule update --init --recursive

Build Prerequisites

The list of Debian or RPM packages dependencies can be installed with:

./install-deps.sh

Building Ceph

Note that these instructions are meant for developers who are compiling the code for development and testing. To build binaries suitable for installation we recommend you build deb or rpm packages or refer to the ceph.spec.in or debian/rules to see which configuration options are specified for production builds.

Build instructions:

./do_cmake.sh
cd build
ninja

(do_cmake.sh now defaults to creating a debug build of ceph that can be up to 5x slower with some workloads. Please pass "-DCMAKE_BUILD_TYPE=RelWithDebInfo" to do_cmake.sh to create a non-debug release.

The number of jobs used by ninja is derived from the number of CPU cores of the building host if unspecified. Use the -j option to limit the job number if the build jobs are running out of memory. On average, each job takes around 2.5GiB memory.)

This assumes you make your build dir a subdirectory of the ceph.git checkout. If you put it elsewhere, just point CEPH_GIT_DIR to the correct path to the checkout. Any additional CMake args can be specified by setting ARGS before invoking do_cmake. See cmake options for more details. Eg.

ARGS="-DCMAKE_C_COMPILER=gcc-7" ./do_cmake.sh

To build only certain targets use:

ninja [target name]

To install:

ninja install

CMake Options

If you run the cmake command by hand, there are many options you can set with "-D". For example, the option to build the RADOS Gateway is defaulted to ON. To build without the RADOS Gateway:

cmake -DWITH_RADOSGW=OFF [path to top-level ceph directory]

Another example below is building with debugging and alternate locations for a couple of external dependencies:

cmake -DLEVELDB_PREFIX="/opt/hyperleveldb" \
-DCMAKE_INSTALL_PREFIX=/opt/ceph -DCMAKE_C_FLAGS="-Og -g3 -gdwarf-4" \
..

To view an exhaustive list of -D options, you can invoke cmake with:

cmake -LH

If you often pipe ninja to less and would like to maintain the diagnostic colors for errors and warnings (and if your compiler supports it), you can invoke cmake with:

cmake -DDIAGNOSTICS_COLOR=always ...

Then you'll get the diagnostic colors when you execute:

ninja | less -R

Other available values for 'DIAGNOSTICS_COLOR' are 'auto' (default) and 'never'.

Building a source tarball

To build a complete source tarball with everything needed to build from source and/or build a (deb or rpm) package, run

./make-dist

This will create a tarball like ceph-$version.tar.bz2 from git. (Ensure that any changes you want to include in your working directory are committed to git.)

Running a test cluster

To run a functional test cluster,

cd build
ninja vstart        # builds just enough to run vstart
../src/vstart.sh --debug --new -x --localhost --bluestore
./bin/ceph -s

Almost all of the usual commands are available in the bin/ directory. For example,

./bin/rados -p rbd bench 30 write
./bin/rbd create foo --size 1000

To shut down the test cluster,

../src/stop.sh

To start or stop individual daemons, the sysvinit script can be used:

./bin/init-ceph restart osd.0
./bin/init-ceph stop

Running unit tests

To build and run all tests (in parallel using all processors), use ctest:

cd build
ninja
ctest -j$(nproc)

(Note: Many targets built from src/test are not run using ctest. Targets starting with "unittest" are run in ninja check and thus can be run with ctest. Targets starting with "ceph_test" can not, and should be run by hand.)

When failures occur, look in build/Testing/Temporary for logs.

To build and run all tests and their dependencies without other unnecessary targets in Ceph:

cd build
ninja check -j$(nproc)

To run an individual test manually, run ctest with -R (regex matching):

ctest -R [regex matching test name(s)]

(Note: ctest does not build the test it's running or the dependencies needed to run it)

To run an individual test manually and see all the tests output, run ctest with the -V (verbose) flag:

ctest -V -R [regex matching test name(s)]

To run tests manually and run the jobs in parallel, run ctest with the -j flag:

ctest -j [number of jobs]

There are many other flags you can give ctest for better control over manual test execution. To view these options run:

man ctest

Building the Documentation

Prerequisites

The list of package dependencies for building the documentation can be found in doc_deps.deb.txt:

sudo apt-get install `cat doc_deps.deb.txt`

Building the Documentation

To build the documentation, ensure that you are in the top-level /ceph directory, and execute the build script. For example:

admin/build-doc

Reporting Issues

To report an issue and view existing issues, please visit https://tracker.ceph.com/projects/ceph.