This PR alters "ssh" to "SSH" in the text (that is, not in
commands) every location in the doc/cephadm/ directory where
"ssh" should be "SSH".
Signed-off-by: Zac Dover <zac.dover@gmail.com>
- I fixed a sentence that was missing a verb.
- I linked to the Ceph-specific Rook instructions.
- I removed the word "GitHub", because after adding the
Rook instructions it made the sentence false.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
Two lines in host-management.rst ended with both colons and
full stops (periods), causing a kind of punctuational turf
war. This commit removes the full stops.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
This commit addresses https://github.com/ceph/ceph/pull/43250,
which has remained unmerged for thirteen months. The issues
raised in that PR are addressed here.
This commit contributes to the simplification of the procedure
that explains how to install cephadm. More remains to be done
on this page, but the old PR had to be dealt with first.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
there are chances that there is no cluster running at that moment,
so we could have failure messages like
[errno 2] RADOS object not found (error connecting to the cluster)
usage: cephadm rm-cluster [-h] --fsid FSID [--force] [--keep-logs]
[--zap-osds]
cephadm rm-cluster: error: argument --fsid: expected one argument
in that case, better off not failing this bash function, as this
is not a fatal failure.
See-also: https://tracker.ceph.com/issues/57834
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
mgr/cephadm: consolidate test_alertmanager_config_* tests into one
Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@redhat.com>
This commit refines the English in the "Notifications"
and "Events" sections of the notifications.rst page
(the "Bucket Notifications" page).
Signed-off-by: Zac Dover <zac.dover@gmail.com>
crimson/osd: add the delete-head special case of CEPH_OSD_OP_ROLLBACK
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
This commit refines the English in the "OS Tuning Profiles" section of
the "Host Management" page of the cephadm documentation. This commit is
made separately from but in anticipation of a forthcoming commit that
corrects technical (non-grammatical) errors.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
This allows to pass `TestLibRBD.TestIOToSnapshot`:
```
[rzarzynski@o06 build]$ CRIMSON_COMPAT=true RBD_FEATURES=1 bin/ceph_test_librbd --gtest_filter=TestLibRBD.TestIOToSnapshot
seed 3954016
Note: Google Test filter = TestLibRBD.TestIOToSnapshot
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from TestLibRBD
[ RUN ] TestLibRBD.TestIOToSnapshot
using new format!
...
opening testimg@orig
read: 80
write to snapshot returned -30
Read-only file system
num snaps is: 2
expected: 2
snap: orig
snap: written
found orig with size 2097152
found written with size 2097152
num snaps is: 1
expected: 1
snap: orig
found orig with size 2097152
num snaps is: 0
expected: 0
[ OK ] TestLibRBD.TestIOToSnapshot (7510 ms)
[----------] 1 test from TestLibRBD (7510 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (8504 ms total)
[ PASSED ] 1 test.
```
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
crimson/osd: fix use after free error in FuturizedStoreLogReader::read
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
