Commit Graph

116331 Commits

Author SHA1 Message Date
Kefu Chai
4cc179ff08
Merge pull request #37890 from tchaikov/wip-crimson-os-cleanup
crimson/os: fix couple issues reported by clang

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
2020-10-29 19:59:08 +08:00
Matt Benjamin
64f15c838b
Merge pull request #36739 from pritha-srivastava/wip-rgw-sts-expire-session-token
rgw/sts: adding code for "aws:TokenIssueTime" to be used
2020-10-29 07:58:10 -04:00
Matt Benjamin
133f26325d
Merge pull request #35612 from pritha-srivastava/wip-sts-role-min-duration
rgw/sts: Adding a configurable rgw_sts_min_session_duration
2020-10-29 07:57:50 -04:00
Kefu Chai
7736aaf32f crimson/os: capture local bindings using capture variable list
structured binding does not define variables, and the implicit
capture-by-copy `=` does not help in this case, we have to define a
capture with an initializer to create a *variable* enclosed by
the closure explicitly.

this address the error like:

src/crimson/os/seastore/segment_cleaner.cc:315:5: error: reference to local binding 'addr' declared in enclosing lambda expression
                  addr);
                  ^

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-10-29 16:32:26 +08:00
Kefu Chai
e29f6e84d7 crimson/os: do not move temporay variable
copy ellision ensures that copy ctor is not called in this case

silences warning like:

mson/os/seastore/lba_manager/btree/lba_btree_node_impl.cc:262:5: warning: moving a temporary object prevents copy elision [-Wpessimizing-move]
    std::move(begin()),
    ^

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-10-29 16:32:26 +08:00
Kefu Chai
6498d97a0e crimson/os: do not capture unused variable
silences warning like:

btree/extentmap_btree_node.h💯8: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
      [this, ec, len] (auto &extents) {
       ^

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-10-29 16:32:25 +08:00
Kefu Chai
f3f688c48f
Merge pull request #37887 from tchaikov/wip-seastar
seastar: pick up changes to colocate libc allocator and seastar alloc…

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2020-10-29 15:21:41 +08:00
Kefu Chai
4cd2b00d2a seastar: pick up changes to colocate libc allocator and seastar allocator
this allows us to use seastar's builtin allocator along with the libc
allocator used by alien threads.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-10-29 13:59:41 +08:00
Yan, Zheng
a80cb18726
Merge pull request #37777 from chenerqi/fix-modified-dentries-count
mds: fix count error of modified dentries
2020-10-29 11:08:10 +08:00
Jason Dillaman
79fb76cecd
Merge pull request #37636 from MahatiC/wip-init-ssd
librbd/cache: init functionality for SSD Cache

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2020-10-28 19:03:05 -04:00
Jason Dillaman
c457985dfa
Merge pull request #37680 from orozery/object-dispatch-aligned-crypto
librbd: crypto alignment support

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2020-10-28 19:02:47 -04:00
Samuel Just
10b0a5ed3a
Merge pull request #37871 from cyx1231st/wip-seastore-misc-fixes
crimson/seastore: misc fixes in transaction manager

crimson/seastore: misc fixes in transaction manager
2020-10-28 13:16:55 -07:00
Daniel Gryniewicz
35bbc13258
Merge pull request #37877 from dang/wip-dang-cond-writeback
rgw: Fix broken merge in #37774
2020-10-28 14:27:06 -04:00
Daniel Gryniewicz
e47b71955d RGW - Fix broken merge in #37774
I messed up the merge in #37774 and somehow forgot to push a change.
This resulted it the flag being set on the wrong branch.  This fixes
that.

RHBZ#1845501

Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
2020-10-28 11:49:58 -04:00
Kefu Chai
651f77cf99
Merge pull request #37865 from neha-ojha/wip-mon-fixes
qa: miscellaneous mon test fixes

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-10-28 23:45:38 +08:00
Lenz Grimmer
0b9a4e053a
Merge pull request #36764 from ishanrai05/guide
mgr/dashboard: Style guide to give a the UI an overall look and feel

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Sebastian Krah <skrah@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2020-10-28 15:47:32 +01:00
Jan Fajerski
f4cd2a1784 Merge PR #37808 into master
* refs/pull/37808/head:
	ceph-volume: consume mount opt in simple activate

Reviewed-by: Jan Fajerski <jfajerski@suse.com>
Reviewed-by: Guillaume Abrioux <gabrioux@redhat.com>
2020-10-28 09:21:06 +01:00
Yingxin Cheng
354346572e crimson/os/seastore/transaction_manager: add missing final keyword
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2020-10-28 15:51:24 +08:00
Yingxin Cheng
4f2f4f4ab0 crimson/os/seastore/transaction_manager: use weak transaction when initialize cached extents
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2020-10-28 15:45:20 +08:00
Kefu Chai
b28174f13f
Merge pull request #37761 from tchaikov/wip-ceph.spec-with-seastar
ceph.spec.in: install gcc-toolset on RHEL only

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2020-10-28 14:43:49 +08:00
Mahati Chamarthy
01400fedc3 librbd/cache: init functionality for SSD Cache
Adds build option and implements init functionality for SSD cache

Signed-off-by: Lisa Li <xiaoyan.li@intel.com>
Signed-off-by: Mahati Chamarthy <mahati.chamarthy@intel.com>
Signed-off-by: Changcheng Liu <changcheng.liu@intel.com>
2020-10-28 11:16:41 +05:30
Erqi Chen
e76073ef19 mds: fix count error of modified dentries
CDir::_omap_commit counts modified dentries, for fragmenting
new dir modified dentries include head and snap items.

Fixes: https://tracker.ceph.com/issues/47981
Signed-off-by: Erqi Chen <chenerqi@gmail.com>
2020-10-28 11:11:19 +08:00
Brad Hubbard
677d939b39
Merge pull request #37826 from badone/wip-make-dist-ng-cli-noprompt
make-dist: Don't prompt while running 'npm ci'

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by:  Tiago Melo <tmelo@suse.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2020-10-28 07:32:41 +10:00
Neha Ojha
df7adbf387 qa/tasks/ceph_manager.py: remove redundant quorum status logging
2020-10-21T03:42:45.985 INFO:teuthology.orchestra.run.smithi114:> sudo adjust-ulimits ceph-coverage /home/ubuntu/cephtest/archive/coverage timeout 120 ceph --cluster ceph quorum_status
2020-10-21T03:42:58.574 INFO:teuthology.orchestra.run.smithi114.stdout:{"election_epoch":1650,"quorum":[0,2],"quorum_names":["a","c"],"quorum_leader_name":"a","quorum_age":0,"features":{"quorum_con":"4540138297136906239","quorum_mon":["kraken","luminous","mimic","osdmap-prune","nautilus","octopus","pacific","elector-pinging"]},"monmap":{"epoch":1,"fsid":"807c36f1-9e85-4fa3-81fc-95915ab50584","modified":"2020-10-21T00:34:48.421341Z","created":"2020-10-21T00:34:48.421341Z","min_mon_release":16,"min_mon_release_name":"pacific","election_strategy":3,"disallowed_leaders":"","features":{"persistent":["kraken","luminous","mimic","osdmap-prune","nautilus","octopus","pacific","elector-pinging"],"optional":[]},"mons":[{"rank":0,"name":"a","public_addrs":{"addrvec":[{"type":"v1","addr":"172.21.15.114:6789","nonce":0}]},"addr":"172.21.15.114:6789/0","public_addr":"172.21.15.114:6789/0","priority":0,"weight":0},{"rank":1,"name":"b","public_addrs":{"addrvec":[{"type":"v1","addr":"172.21.15.133:6789","nonce":0}]},"addr":"172.21.15.133:6789/0","public_addr":"172.21.15.133:6789/0","priority":0,"weight":0},{"rank":2,"name":"c","public_addrs":{"addrvec":[{"type":"v1","addr":"172.21.15.114:6790","nonce":0}]},"addr":"172.21.15.114:6790/0","public_addr":"172.21.15.114:6790/0","priority":0,"weight":0}]}}
2020-10-21T03:42:58.589 INFO:tasks.mon_thrash.ceph_manager:quorum_status is {"election_epoch":1650,"quorum":[0,2],"quorum_names":["a","c"],"quorum_leader_name":"a","quorum_age":0,"features":{"quorum_con":"4540138297136906239","quorum_mon":["kraken","luminous","mimic","osdmap-prune","nautilus","octopus","pacific","elector-pinging"]},"monmap":{"epoch":1,"fsid":"807c36f1-9e85-4fa3-81fc-95915ab50584","modified":"2020-10-21T00:34:48.421341Z","created":"2020-10-21T00:34:48.421341Z","min_mon_release":16,"min_mon_release_name":"pacific","election_strategy":3,"disallowed_leaders":"","features":{"persistent":["kraken","luminous","mimic","osdmap-prune","nautilus","octopus","pacific","elector-pinging"],"optional":[]},"mons":[{"rank":0,"name":"a","public_addrs":{"addrvec":[{"type":"v1","addr":"172.21.15.114:6789","nonce":0}]},"addr":"172.21.15.114:6789/0","public_addr":"172.21.15.114:6789/0","priority":0,"weight":0},{"rank":1,"name":"b","public_addrs":{"addrvec":[{"type":"v1","addr":"172.21.15.133:6789","nonce":0}]},"addr":"172.21.15.133:6789/0","public_addr":"172.21.15.133:6789/0","priority":0,"weight":0},{"rank":2,"name":"c","public_addrs":{"addrvec":[{"type":"v1","addr":"172.21.15.114:6790","nonce":0}]},"addr":"172.21.15.114:6790/0","public_addr":"172.21.15.114:6790/0","priority":0,"weight":0}]}}

Signed-off-by: Neha Ojha <nojha@redhat.com>
2020-10-27 21:14:54 +00:00
Neha Ojha
1fa25e0780 qa/suites/rados/dashboard: ignore MON_DOWN
This warning is expected during:

2020-10-27T16:29:40.549+0000 7fa1f0927700 10 mon.c@2(peon) e1 handle_auth_request haven't formed initial quorum, EBUSY

and is cleared after:

2020-10-27T16:29:42.597+0000 7fe7b3ada700  7 mon.a@1(peon).log v7 update_from_paxos applying incremental log 7 2020-10-27T16:29:42.319274+0000 mon.b (mon.0) 76 : cluster [INF] mon.b is new leader, mons b,a,c in quorum (ranks 0,1,2)
2020-10-27T16:29:42.597+0000 7fe7b3ada700  7 mon.a@1(peon).log v7 update_from_paxos applying incremental log 7 2020-10-27T16:29:42.326711+0000 mon.b (mon.0) 82 : cluster [INF] Health check cleared: MON_DOWN (was: 1/3 mons down, quorum b,a)

Signed-off-by: Neha Ojha <nojha@redhat.com>
2020-10-27 21:14:54 +00:00
Dimitri Savineau
1f4301a15d ceph-volume: consume mount opt in simple activate
When running ceph-volume simple activate command on a Filestore OSD
then the data device is mounted without any specific options so the
one from the ceph configuration file are ignored.
When deploying Filestore with the lvm subcommand then everything is
fine because the filestore_activate method uses mount_osd which relies
on the mount options defined in the ceph configuration file (if any).

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1891557
Fixes: https://tracker.ceph.com/issues/48018

Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
2020-10-27 11:53:28 -04:00
Ishan Rai
590ce3c4f6 doc: style guide to give a the UI an overall look and feel
fixes: https://tracker.ceph.com/issues/27218

Signed-off-by: Ishan Rai <ishanrai05@gmail.com>
2020-10-27 13:50:15 +00:00
Daniel Gryniewicz
c0cf69e067
Merge pull request #37774 from dang/wip-dang-cond-writeback
Don't writeback when inside a readdir callback
2020-10-27 07:22:50 -04:00
Yan, Zheng
ef9c29d77a
Merge pull request #37828 from chenerqi/inode_commit_ops
mds: optimize batch backtrace store
2020-10-27 15:34:44 +08:00
Erqi Chen
04904b9a5d mds: optimize batch backtrace store
Call backtrace stored callback in batch. This avoids taking mds_lock
for each inode.

Signed-off-by: Erqi Chen <chenerqi@gmail.com>
2020-10-27 10:14:35 +08:00
Brad Hubbard
f4f53ece4d make-dist: Don't prompt while running 'npm ci'
Prompting for input while in the background results in SIGTTOU being
sent and npm hanging forever.

Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
2020-10-27 10:37:15 +10:00
Jason Dillaman
2eec592372
Merge pull request #37750 from lixiaoy1/fix_partial_1022
librbd/deep_copy: fix issues in deep_copy

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2020-10-26 20:14:53 -04:00
lixiaoy1
b1f11939d6 librbd/deep_copy: skip reading data from image cache
Signed-off-by: Li, Xiaoyan <xiaoyan.li@intel.com>
2020-10-26 16:10:37 -04:00
Mykola Golub
ec64935861
Merge pull request #37714 from dillaman/wip-librbd-migration-1
librbd: initial set of changes to migration API for instant-restore

Reviewed-by: Mykola Golub <mgolub@suse.com>
2020-10-26 21:26:17 +02:00
Jason Dillaman
32767bbfb5 librbd/io: ensure ImageDispatchSpec cannot re-use AioCompletion
Prevent re-using the same AioCompletion between multiple
ImageDispatchSpec objects to prevent the possibility of a memory
leak.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2020-10-26 12:01:12 -04:00
Jason Dillaman
65a05a0aa6 librbd/migration: native format should not issue a new read request
Tweak the format interface's 'read' call to just let the existing
read request continue passed the migration layer if the native
format is in use. Otherwise, the provided AioCompletion would need to
be wrapped with another AioCompletion to prevent the original
image dispatch spec from getting lost.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2020-10-26 12:01:11 -04:00
Adam C. Emerson
2041788435
Merge pull request #37683 from adamemerson/wip-fifo-lessnoisy
rgw: Be less noisy when probing FIFO existence

Reviewed-By: Casey Bodley cbodley@redhat.com
Reviewed-By: J. Eric Ivancich ivancich@redhat.com
2020-10-26 11:58:41 -04:00
Jason Dillaman
0db501b2e3
Merge pull request #37273 from trociny/wip-rbd-nbd-persist
rbd-nbd: allow to restart daemon without destroying device

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2020-10-26 07:57:47 -04:00
Lenz Grimmer
f99d15ab0d
Merge pull request #37769 from rhcs-dashboard/black-border-text
mgr/dashboard: Removing the black border on the text/input field when its clicked

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
2020-10-26 12:57:32 +01:00
Jason Dillaman
43525ae5f5
Merge pull request #37743 from lixiaoy1/fix_1022
librbd/image: remove implicit features when cloning

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2020-10-26 07:55:42 -04:00
Lenz Grimmer
a363e69336
Merge pull request #37753 from bk201/wip-47947
mgr/dashboard: fix disable action for MGR modules

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
2020-10-26 11:33:24 +01:00
Lenz Grimmer
b0e963a2c9
Merge pull request #37006 from clwluvw/monitoring-osd-latency
monitoring: Use null yaxes min for OSD read latency

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Patrick Seidensal <pnawracay@suse.com>
2020-10-26 11:31:45 +01:00
Lenz Grimmer
10cb89241f
Merge pull request #37568 from s0nea/wip-dashboard-qa-linting
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2020-10-26 11:27:23 +01:00
Abhishek L
27916d18c0
Merge pull request #37754 from smithfarm/wip-nautilus-rn-typo
doc/releases/nautilus: fix typo

Reviewed-By: Neha Ojha <nojha@redhat.com>
Reviewed-By: Kefu Chai <kchai@redhat.com>
Reviewed-By: Abhishek Lekshmanan <abhishek@suse.com>
2020-10-26 10:36:17 +01:00
Jan Fajerski
562ee2a0a9 Merge PR #37415 into master
* refs/pull/37415/head:
	pybind/mgr/snap-schedule: fix deactivate

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2020-10-26 09:10:05 +01:00
Kefu Chai
07019beead
Merge pull request #37758 from batrick/i47951
mon/MonMap: fix unconditional failure for init_with_hosts

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Reviewed-by: Wido den Hollander <wido@42on.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2020-10-26 14:59:39 +08:00
Kefu Chai
9809db9099
Merge pull request #37759 from adamemerson/wip-context4all
cmake, rgw: always enable Boost.context

Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-10-26 14:41:55 +08:00
Jason Dillaman
81ee1cdb88 librbd: migration raw format source
The raw format maps an abstract, fully allocated, raw block device image
to the migration source IO API.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2020-10-25 19:37:56 -04:00
Jason Dillaman
951571879b librbd: migration file stream source
The file stream helper will translate byte-extent IO read requests
to ASIO file read requests on the specified backing file. This can be
layered with file format helpers to translate image IO extents down
to the backing file.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2020-10-25 19:37:55 -04:00
Jason Dillaman
41a32b1205 librbd: increase debug logging in ImageCtx
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2020-10-25 19:37:55 -04:00