Commit Graph

116331 Commits

Author SHA1 Message Date
Jason Dillaman
65531c38b6 librbd: migration should attempt to open destination image first
With the exception of the 'prepare' command, always attempt to open
the destination image first. This will better align with the
ability for read-only, non-native images to be used as a source
image.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2020-10-25 19:37:55 -04:00
Patrick Donnelly
d6097c4971
Merge PR #37776 into master
* refs/pull/37776/head:
	cephfs: Fix variable declartion in capture list in lambda

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2020-10-25 16:29:13 -07:00
Patrick Donnelly
0078579530
Merge PR #37735 into master
* refs/pull/37735/head:
	client: fix inode ll_ref reference count leak

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2020-10-25 16:27:48 -07:00
Patrick Donnelly
c569036c5d
Merge PR #37629 into master
* refs/pull/37629/head:
	qa/cephfs: add session_timeout option support
	qa/cephfs: move the cephfs's opertions setting to create()
	qa/cephfs: add 'cephfs:' section support

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2020-10-25 16:26:36 -07:00
Patrick Donnelly
e059e9666c
Merge PR #37652 into master
* refs/pull/37652/head:
	qa/tasks: tear down the background process before unmounting
	qa/tasks: switch to _kill_background() helper to terminate the daemons

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
2020-10-25 16:25:24 -07:00
Or Ozeri
11fb90757d librbd: crypto alignment support
This commit extents the recently added CryptoObjectDispatch layer to support block ciphers (as opposed to stream ciphers).
In other words, the crypto layer now handles the necessary data alignments before data is passed on to the crypto engine.

Signed-off-by: Or Ozeri <oro@il.ibm.com>
2020-10-25 10:13:09 +02:00
Nathan Cutler
e3c0edf616
Merge pull request #37718 from smithfarm/wip-rn-nautilus
doc/releases: add Nautilus 14.2.12 release notes

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2020-10-24 22:27:00 +02:00
Jason Dillaman
bf0198ad08 librbd: pass source ImageCtx to migration API helper methods
This will help ensure that the source ImageCtx can be made optional
when migrating from a read-only, non-native image source.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2020-10-24 13:51:07 -04:00
Jason Dillaman
d9005b053c librbd: new helper API method to retrieving the migration source spec
When using advanced, non-legacy migration sources like a remote Ceph
cluster or a flat file, this API will return the JSON-encoded description
of the migration source.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2020-10-24 13:51:07 -04:00
Jason Dillaman
9331600edd librbd: helper method for constructing source-spec for legacy migration
The legacy migration source format has explicit pool, namespace, and image
parameters. This helper method will convert it into the JSON format that
will be used for the new-style migration source-spec.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2020-10-24 13:51:06 -04:00
Lenz Grimmer
77bb88be28
Merge pull request #37755 from rhcs-dashboard/notification-style
mgr/dashboard: Adding more style to the notification sidebar

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2020-10-24 19:02:58 +02:00
Kefu Chai
5a59e16b97
Merge pull request #37738 from ifed01/wip-ifed-fix-death-tests
test/store_test: use 'threadsafe' style for death tests.

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2020-10-25 00:17:33 +08:00
Kefu Chai
6678c7c6c2
Merge pull request #37765 from tchaikov/wip-mgr-common-cleanup
mgr,common: use make_unique<> and fmt::format()

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2020-10-25 00:15:29 +08:00
Sridhar Seshasayee
5c987403eb
Merge pull request #37431 from sseshasa/wip-handle-future-sched-ops
osd: Handle possible future work items returned from mclock scheduler.

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2020-10-24 13:22:01 +05:30
Willem Jan Withagen
77f2f88dcb cephfs: Fix variable declartion in capture list in lambda
/home/jenkins/workspace/ceph-master-compile/src/tools/cephfs_mirror/Mirror.cc:529:33: error: 'mirror_action' in capture list does not name a variable
    m_cond.wait(locker, [this, &mirror_action] {return !mirror_action.action_in_progress;});
                                ^
/home/jenkins/workspace/ceph-master-compile/src/tools/cephfs_mirror/Mirror.cc:529:57: error: reference to local binding 'mirror_action' declared in enclosing function 'cephfs:🪞:Mirror::run'
    m_cond.wait(locker, [this, &mirror_action] {return !mirror_action.action_in_progress;});
                                                        ^
/home/jenkins/workspace/ceph-master-compile/src/tools/cephfs_mirror/Mirror.cc:526:27: note: 'mirror_action' declared here
  for (auto &[filesystem, mirror_action] : m_mirror_actions) {
                          ^
/home/jenkins/workspace/ceph-master-compile/src/tools/cephfs_mirror/Mirror.cc:529:26: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
    m_cond.wait(locker, [this, &mirror_action] {return !mirror_action.action_in_progress;});
                         ^~~~
1 warning and 2 errors generated.

Tracker: https://tracker.ceph.com/issues/47973
Fixes: https://github.com/ceph/ceph/pull/37313
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
2020-10-24 01:53:14 +02:00
Patrick Donnelly
21d9f8333b
mon/MonMap: fix unconditional failure for init_with_hosts
This bug prevents setting mon_host to a DNS name.

Fixes: https://tracker.ceph.com/issues/47951
Fixes: 7a1f02acfe
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2020-10-23 16:33:44 -07:00
Patrick Donnelly
4022c1f1fb
test/mon: add tests for mon_host build by hostname
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2020-10-23 16:33:44 -07:00
Patrick Donnelly
06f44cbf12
test/mon: fix compiler errors in MonMap unittest
The code atrophied. Clean this up.

The tests are disabled because they SIGSEGV during SetUp.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2020-10-23 16:29:30 -07:00
Patrick Donnelly
8408b63e90
test/mon: build MonMap unittest
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2020-10-23 16:29:30 -07:00
Daniel Gryniewicz
96ed166570 Don't writeback when inside a readdir callback
The code updates some attributes that may have changed between versions
when doing a lookup.  However, a lookup can be done from within a
readdir callback, which causes a deadlock during the writeback.  Extend
the flag indicating we're in a callback all the way down, so we can
conditionally avoid the write.

Fixes RHBZ#1845501

Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
2020-10-23 12:43:03 -04:00
Neha Ojha
27871caa7f
Merge pull request #37678 from ideepika/wip-drop-hammer-from-qa
qa: drop hammer branch qa tests

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2020-10-23 08:35:02 -07:00
Adam C. Emerson
5429f10c47 dpkg: Remove use of no-longer-existing WITH_BOOST_CONTEXT option
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2020-10-23 11:21:53 -04:00
Adam C. Emerson
c9d20eb1a0 rpm: Remove use of no-longer-existing WITH_BOOST_CONTEXT option
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2020-10-23 11:21:53 -04:00
Adam C. Emerson
b132d68930 {rgw, cmake}: Remove WITH_BOOST_CONTEXT
As Boost.Context now supports s390, there is no longer any need for
the conditional compilation.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2020-10-23 11:21:53 -04:00
Lenz Grimmer
6434564e71
Merge pull request #37193 from rhcs-dashboard/log_download
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2020-10-23 16:47:20 +02:00
Lenz Grimmer
1e131d5a99
Merge pull request #36449 from s0nea/wip-dashboard-osd-flags-indiv
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
2020-10-23 16:45:28 +02:00
Lenz Grimmer
2564dd4b09
Merge pull request #37440 from Devp00l/wip-44433
mgr/dashboard: Add clay plugin support

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
2020-10-23 13:57:51 +02:00
Lenz Grimmer
a38d766881
Merge pull request #37512 from tspmelo/wip-ng-validation
mgr/dashboard: Extract ng-bootstrap-form-validation

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2020-10-23 13:29:32 +02:00
Kefu Chai
8ecce5cfa2
Merge pull request #37748 from Rethan/msg_remove_dispatch_strategy
msg: move DispatchStrategy into test/

Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-10-23 18:09:20 +08:00
Nizamudeen A
e6b7b9d3e4 mgr/dashboard: Removing the black border on the text/input field when its clicked
Resolves: https://tracker.ceph.com/issues/47967
Signed-off-by: Nizamudeen A <nia@redhat.com>
2020-10-23 14:46:24 +05:30
Kefu Chai
cdf596c8ca
Merge pull request #37404 from badone/wip-docker-test-allow-persistent-containers
test/docker-test: Allow persistent containers

Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-10-23 16:15:35 +08:00
Kefu Chai
85acc8bf12 mgr/DaemonHealthMetricCollector: replace boost::format with fmt::format
the latter is easier to use, and future proof in the sense that {fmt}
was included as a part of C++20 standard

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-10-23 16:02:16 +08:00
Kefu Chai
990f742b38 common/Formatter: replace boost::format with fmt::format
the latter is easier to use, and future proof in the sense that {fmt}
was included as a part of C++20 standard

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-10-23 16:02:16 +08:00
Kefu Chai
fb725f7cc3 mgr: use make_unique<> when appropriate
Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-10-23 16:02:16 +08:00
Xiubo Li
0422673b61 qa/cephfs: add session_timeout option support
When the mds revoking the Fwbl caps, the clients need to flush
the dirty data back to the OSDs, but the flush may make the OSDs
to be overloaded and slow, which may take more than 60 seconds to
finish. Then the MDS daemons will report the WRN messages.

For the teuthology test cases, let's just increase the timeout
value to make it work.

Fixes: https://tracker.ceph.com/issues/47565
Signed-off-by: Xiubo Li <xiubli@redhat.com>
2020-10-23 14:27:37 +08:00
Xiubo Li
cb8081ce7f qa/cephfs: move the cephfs's opertions setting to create()
Fixes: https://tracker.ceph.com/issues/47565
Signed-off-by: Xiubo Li <xiubli@redhat.com>
2020-10-23 14:27:37 +08:00
Xiubo Li
3b5303482f qa/cephfs: add 'cephfs:' section support
Fixes: https://tracker.ceph.com/issues/47565
Signed-off-by: Xiubo Li <xiubli@redhat.com>
2020-10-23 14:27:30 +08:00
Kefu Chai
179f6a1c7a
Merge pull request #36754 from rzarzynski/wip-bs-filewriter-appender
common/bl, os/bluestore: eradicate bufferlist rebuilds caused by FileWriter of BlueFS

Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-10-23 14:19:32 +08:00
Brad Hubbard
76eb858e40 test/docker-test: Allow persistent containers
It can be useful to allow the container to persist for debugging
purposes. Also show the command used to create the container.

Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
2020-10-23 16:07:07 +10:00
haoyixing
65c66f2fda msg: move DispatchStrategy into test/
Since commit cc9a914, xio related code were all removed, which made
direct_messenger become the only user of DispatchStraegy. So move
these code there.

Signed-off-by: haoyixing <haoyixing@kuaishou.com>
2020-10-23 11:27:02 +08:00
Kefu Chai
36759b5363 ceph.spec.in: install gcc-toolset on RHEL only
there is no need to use GTS for compiling crimson, as the GCC-10 shipped by
fedora32 is good enough.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-10-23 10:49:08 +08:00
sepia-liu
019ba52c8f client: fix inode ll_ref reference count leak
Fixes: https://tracker.ceph.com/issues/47918

Signed-off-by: sepia-liu <liuwei_coder@163.com>
2020-10-23 09:50:35 +08:00
Adam C. Emerson
713efb66e8 cmake: Bump boost version to 1.72
This gives us s390 support for Boost.Context.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2020-10-22 21:39:50 -04:00
Kefu Chai
43710ed030
Merge pull request #37760 from athanatos/sjust/wip-fix-lba-leaf
crimson/seastore: remove invalid mutate_mapping assert

Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-10-23 08:33:48 +08:00
Patrick Donnelly
f946e783ee
Merge PR #36204 into master
* refs/pull/36204/head:
	client: add command_lock support
	client: defer swapping the newmap to mdsmap
	client: try to grab the client_lock when needed
	client: clean up the client code

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2020-10-22 17:17:37 -07:00
Samuel Just
2c3bed268c crimson/os/seastore/.../lba_btree_node_impl: remove invalid mutate_mapping assert
A leaf node can have fewer than min_capacity items when it is the root.

Signed-off-by: Samuel Just <sjust@redhat.com>
2020-10-22 16:12:25 -07:00
Samuel Just
8bf261016f test/crimson/seastore/test_btree_lba_manager: test mutate_mapping on more split/merge states
incref_mapping has a slightly different relationship with merge than
decref_mapping, update split/merge test to ensure that we call into
mutate_mapping at each step as the nodes fill, split, empty, and merge.

Signed-off-by: Samuel Just <sjust@redhat.com>
2020-10-22 16:07:06 -07:00
zdover23
a5b6270464
Merge pull request #37715 from anthonyeleven/rados-doc-improvements
doc/rados: operations.rst: clarity, detail, modernization

Reviewed-by: Zac Dover <zac.dover@gmail.com>
2020-10-23 09:00:51 +10:00
Patrick Donnelly
ad61410b7e
Merge PR #37702 into master
* refs/pull/37702/head:
	mon/MDSMonitor: do not ignore mds's down:dne request

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2020-10-22 12:58:15 -07:00
Patrick Donnelly
f16b3fc114
Merge PR #37663 into master
* refs/pull/37663/head:
	msg/MFSMap: remove unused variable

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2020-10-22 12:57:46 -07:00