Commit Graph

107005 Commits

Author SHA1 Message Date
Jan Fajerski
dd89f467a0 util/disk: extend Size class
The Size class can now parse strings and has support for arithmetic
operations and comparisons with numbers.

Signed-off-by: Jan Fajerski <jfajerski@suse.com>
2020-01-22 14:55:50 +01:00
Laura Paduano
c4f555fda1
Merge pull request #32699 from tspmelo/wip-npm-audit-fix
mgr/dashboard: Fix npm vulnerabilities

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
2020-01-22 14:44:25 +01:00
Laura Paduano
c60b9cf27d
Merge pull request #32653 from votdev/issue_43603_clone_role
mgr/dashboard: Clone an existing user role

Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
2020-01-22 14:28:09 +01:00
Laura Paduano
9cadc5b875
Merge pull request #32648 from p-se/wip-pse-cd-api-err-msg
mgr/dashboard: monitoring: improve generic "Could not reach external API" message

Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
2020-01-22 14:24:26 +01:00
Sage Weil
8960d41013 Merge PR #32765 into master
* refs/pull/32765/head:
	unittest_lockdep: avoid any threads for death test

Reviewed-by: Neha Ojha <nojha@redhat.com>
2020-01-22 07:15:24 -06:00
Kefu Chai
e59966abd4
Merge pull request #32728 from rishabh-d-dave/doc-teuth-broken-links
doc: fix links in developer_guide

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-01-22 15:56:44 +08:00
Laura Paduano
80fa7deaca
Merge pull request #32703 from s0nea/wip-dashboard-pwd-expiration-field
mgr/dashboard: fix visibility of pwdExpirationDate field

Reviewed-by: Volker Theile <vtheile@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
2020-01-22 08:25:45 +01:00
Kefu Chai
a01f8d12d4
Merge pull request #32683 from liewegas/wip-variable-pg-log
osd: trim pg logs based on a per-osd budget

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2020-01-22 13:04:57 +08:00
Kefu Chai
29cf178db5
Merge pull request #32770 from tchaikov/wip-gtest-skip
test/librados: use GTEST_SKIP() to skip test

Reviewed-by: Neha Ojha <nojha@redhat.com>
2020-01-22 12:57:49 +08:00
Patrick Donnelly
8b73d63983
Merge PR #31719 into master
* refs/pull/31719/head:
	mds: Reorganize class members in Server header

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2020-01-21 20:01:37 -08:00
Patrick Donnelly
6637200cac
Merge PR #31232 into master
* refs/pull/31232/head:
	test: test case for openfiletable MAX_ITEMS_PER_OBJ value verification
	mds/OpenFileTable: match MAX_ITEMS_PER_OBJ to osd_deep_scrub_large_omap_object_key_threshold

Reviewed-by: Zheng Yan <zyan@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2020-01-21 20:00:43 -08:00
Patrick Donnelly
42cb8c39be
Merge PR #31817 into master
* refs/pull/31817/head:
	mds: send delegated_inos in openc response
	mds: make take_ino just return 0 if it can't find one
	mds: add infrastructure for delegating inos from the prealloc set
	mds: fix dump of prealloc and used inos
	mds: don't warn when inodes are not allocated out sequentially
	mds: fix decoding version for EMetaBlob
	mds: remove MDRequestImpl::did_ino_allocation()
	mds: add a comment explaining what session_info_t is
	doc: fix awkward phrasing in caching.txt

Reviewed-by: Zheng Yan <zyan@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2020-01-21 19:57:26 -08:00
Patrick Donnelly
9e55bf69f9
Merge PR #32326 into master
* refs/pull/32326/head:
	mds: Reorganize class members in SnapClient header

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2020-01-21 19:55:39 -08:00
Patrick Donnelly
ee8ac2122b
Merge PR #32706 into master
* refs/pull/32706/head:
	mount.ceph: remove arbitrary limit on size of name= option

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
2020-01-21 19:54:54 -08:00
Kefu Chai
a135bf81b1 test/librados: use GTEST_SKIP() to skip test
the output would look like

```
[  SKIPPED ] SkipTest.DoesSkip (0 ms)
```

easier for tester/developer to review the test result.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-01-22 10:52:47 +08:00
Sage Weil
d0eba9b9c2 osd/PeeringState: maximize log entries sent during backfill
Send as much log as we can during backfill so that dup op detection works
as well as it can.

Signed-off-by: Sage Weil <sage@redhat.com>
2020-01-22 09:13:00 +08:00
Sage Weil
bd20c24011 osd/PeeringState: always use target pg log length
Previously, the min and max log length was the same, so we didn't adjust
our log length based on whether we were degraded.  Preserve that behavior
by removing the degraded check entirely.  This keeps memory usage
consistent when recovery happens.

Signed-off-by: Sage Weil <sage@redhat.com>
2020-01-22 09:13:00 +08:00
Sage Weil
0db140c15c osd: trim pg logs based on a per-osd budget
Set the default budget based on the current defaults: 3000 per osd, and a
rule of thumb target of 100 PGs per OSD.  Set the per-PG trim target
by dividing the overall value by the number of PGs on the OSD.

Increase the max pg log length alone, so if the OSD has <100 PGs,
those PGs will get more entries.  Reduce the minimum to be smaller than
the max.  Use the min/max config options to bracket what is allocated to
a single PG.

Signed-off-by: Sage Weil <sage@redhat.com>
2020-01-22 09:13:00 +08:00
Kefu Chai
8aa8b41fa5 crimson/osd: drop unused member variable
Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-01-22 09:13:00 +08:00
Kefu Chai
582f369608 crimson/osd: track number of pgs in shard_services
pg will be using it for evaluating the number pg log entries to keep for
each PG

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-01-22 09:13:00 +08:00
Patrick Donnelly
c74a261e5b
Merge PR #32522 into master
* refs/pull/32522/head:
	doc/cephfs: improve wording in mount-prerequisites.rst
	doc: migrate best practices recommendations to relevant docs
	doc/cephfs: rename doc/cephfs/kernel.rst & doc/cephfs/fuse.rst

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2020-01-21 15:15:12 -08:00
Patrick Donnelly
b8fb667120
Merge PR #32763 into master
* refs/pull/32763/head:
	qa: build v5.4 kernel

Reviewed-by: Jeff Layton <jlayton@redhat.com>
2020-01-21 15:08:49 -08:00
Patrick Donnelly
4811a62e14
Merge PR #32762 into master
* refs/pull/32762/head:
	doc/cephfs/client-auth: description and example are inconsistent

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2020-01-21 13:32:38 -08:00
Patrick Donnelly
1dcfa5e29b
Merge PR #32739 into master
* refs/pull/32739/head:
	qa: log warning on scrub error

Reviewed-by: Neha Ojha <nojha@redhat.com>
2020-01-21 13:28:34 -08:00
Sage Weil
791faefc7e unittest_lockdep: avoid any threads for death test
Heed the warning:

[WARNING] /home/sage/src/ceph/src/googletest/googletest/src/gtest-death-test.cc:1122:: Death tests use fork(), which is unsafe particularly in a threaded context. For this test, Google Test detected 4 threads. See https://github.com/google/googletest/blob/master/googletest/docs/advanced.md#death-tests-and-threads for more explanation and suggested solutions, especially if this is the last message you see before your test times out.

Fixes: https://tracker.ceph.com/issues/43403
Signed-off-by: Sage Weil <sage@redhat.com>
2020-01-21 15:17:19 -06:00
Sage Weil
d6f0642b82 mon/Session: only index osd ids >= 0
This ensures that get_random_osd_session behaves when it does

    int n = by_osd.rbegin()->first + 1;
    int r = rand() % n;

Fixes: https://tracker.ceph.com/issues/43552
Signed-off-by: Sage Weil <sage@redhat.com>
2020-01-21 15:09:01 -06:00
Patrick Donnelly
bc63a6581c
qa: build v5.4 kernel
CentOS8 userspace cannot build v4.17 kernel anymore. See also [1].

[1] https://lkml.org/lkml/2019/4/23/517

Fixes: https://tracker.ceph.com/issues/43719
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2020-01-21 13:03:03 -08:00
Ali Maredia
54d54c8dff
Merge pull request #32761 from alimaredia/wip-rgw-verify-os-version-8.0
qa: pin rgw/verify to 8.0
2020-01-21 15:19:58 -05:00
Mykola Golub
e6bea300cb librbd: fix typo in mirror:snapshot::UnlinkPeerRequest
Signed-off-by: Mykola Golub <mgolub@suse.com>
2020-01-21 19:12:53 +00:00
Mykola Golub
92be6fb093 librbd: ignore ENOENT for mirror::snapshot::RemoveImageStateRequest
It may happen (the state object already removed) when handling
replayed RPC message.

Fixes: https://tracker.ceph.com/issues/43666
Signed-off-by: Mykola Golub <mgolub@suse.com>
2020-01-21 19:12:40 +00:00
Ilya Dryomov
267c00012a doc/cephfs/client-auth: description and example are inconsistent
According to the path restriction example, the filesystem name
should be cephfs_a, not cephfs.  Converge on cephfs_a to avoid it
being confused with with the pool tag, which is always cephfs.

This was introduced in 160c4bfeb8 ("mon/AuthMonitor: Use new osd
auth caps for ceph fs authorize").

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2020-01-21 19:57:09 +01:00
Radoslaw Zarzynski
5b54e836a8 crimson, common: introduce ceph::atomic and apply it on bufferlist.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2020-01-21 19:53:38 +01:00
Ali Maredia
2552974fe7 qa: pin rgw/verify to 8.0
Signed-off-by: Ali Maredia <amaredia@redhat.com>
2020-01-21 13:02:42 -05:00
Tiago Melo
145e9f8901 mgr/dashboard: Update nodejs to v10.18.1
This will fix some problems that showed up after updating some npm packages.

Signed-off-by: Tiago Melo <tmelo@suse.com>
2020-01-21 16:46:33 -01:00
Tiago Melo
cfee7accc1 mgr/dashboard: Fix npm vulnerabilities
Add npm-force-resolutions to help fix npm vulnerabilities.

When you need to force a package to be updated,
add it to the resolutions lists in package.json and run "npm run fix:audit".

This will update package-lock.json and all next "npm ci" will contain the
specified version of the package.

Signed-off-by: Tiago Melo <tmelo@suse.com>
2020-01-21 16:25:25 -01:00
Igor Fedotov
db9e6ce17a os/bluestore: do per-pool omap repair in shallow fsck mode
Signed-off-by: Igor Fedotov <ifedotov@suse.com>
2020-01-21 20:15:36 +03:00
Patrick Donnelly
057391854c
Merge PR #32748 into master
* refs/pull/32748/head:
	doc: minor fix in mount.ceph

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2020-01-21 08:54:58 -08:00
Sage Weil
5ace82e65c pybind/mgr/*: fix config_notify handling of default values
The default values are handled by mgr_module.py's _get_module_option();
the or here means that we break any non-true (0, false, none) value and
override it with the default.

https://tracker.ceph.com/issues/43746
Signed-off-by: Sage Weil <sage@redhat.com>
2020-01-21 10:44:45 -06:00
Michael Fritch
af662553d0
cephadm: fix tox DeprecationWarning
cephadm:842
  cephadm:842: DeprecationWarning: invalid escape sequence \
    '--default-log-stderr-prefix=debug\ '

Signed-off-by: Michael Fritch <mfritch@suse.com>
2020-01-21 09:24:34 -07:00
Kefu Chai
c7c9cbe176
Merge pull request #32751 from tchaikov/wip-readme-cmake
README.md: remove stale cmake prerequisite

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-By: Casey Bodley <cbodley@redhat.com>
2020-01-22 00:17:47 +08:00
Kefu Chai
9d32ca8c36 README.md: remove stale cmake prerequisite
it's stale. as we now require 3.10 after dropping the support of xenial.

and it's incomplete, we have a ton of build dependencies apart from
cmake.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-01-22 00:00:01 +08:00
Jan Fajerski
b2ed73b183
Merge pull request #32655 from jan--f/c-v-mock-has_bluestore_label
ceph-volume: fix device unittest, mock has_bluestore_label
2020-01-21 16:34:42 +01:00
Sage Weil
ff41594ade Merge PR #32738 into master
* refs/pull/32738/head:
	qa/standalone/misc/ok-to-stop: improve test
	qa/standalone/ceph-helpers: add wait_for_peered

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2020-01-21 09:18:49 -06:00
Casey Bodley
7b8fae8c07
Merge pull request #32740 from cbodley/wip-rgw-doc-s3-extension-url
doc/rgw: fix broken link to boto s3 extensions document

Reviewed-by: Yuval Lifshitz <yuvalif@yahoo.com>
2020-01-21 09:38:56 -05:00
Kefu Chai
951dd14e60
Merge pull request #32742 from tchaikov/wip-crimson-thread-pool
crimson/thread: generalize Task so it works w/ func returns void

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2020-01-21 22:32:12 +08:00
Jan Fajerski
91c7f5189d ceph-volume: fix device unittest, mock has_bluestore_label, lint
This also adds a test case for has_bluestore_label.

Fixes: https://tracker.ceph.com/issues/43611

Signed-off-by: Jan Fajerski <jfajerski@suse.com>
2020-01-21 15:13:27 +01:00
Rishabh Dave
34c6f2f11a doc: minor fix in mount.ceph
Also, fix the indentation since we are already here.

Fixes: https://tracker.ceph.com/issues/43743
Signed-off-by: Rishabh Dave <ridave@redhat.com>
2020-01-21 19:43:25 +05:30
Volker Theile
944490f34f mgr/dashboard: Clone an existing user role
Fixes: https://tracker.ceph.com/issues/43603

Signed-off-by: Volker Theile <vtheile@suse.com>
2020-01-21 14:51:56 +01:00
Kefu Chai
d7d19ad65c crimson/thread: generalize Task so it works w/ func returns void
Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-01-21 21:39:42 +08:00
Tatjana Dehler
a581ab0f1a mgr/dashboard: fix visibility of pwdExpirationDate field
Show the 'pwdExpirationDate' form field only if SSO is not enabled.
Also show a helper message if 'pwdExpirationSpan' is '0' to let
the admin know that the password will only expire once.

Fixes: https://tracker.ceph.com/issues/43523
Signed-off-by: Tatjana Dehler <tdehler@suse.com>
2020-01-21 14:21:03 +01:00