* refs/pull/32616/head:
cephadm: annotate call()
cephadm: podman inspect: image field was called `ImageID`:
Reviewed-by: Patrick Seidensal <pseidensal@suse.com>
Reviewed-by: Sage Weil <sage@redhat.com>
* refs/pull/32795/head:
cephadm: require fsid if name contains a daemon id
cephadm: infer the fsid by name
Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Sage Weil <sage@redhat.com>
* refs/pull/32787/head:
qa/tasks/cephadm: work around .git suffix on ceph_repo
qa/tasks/cephadm: learn to pull cephadm from github
Reviewed-by: Jan Fajerski <jfajerski@suse.com>
Until we understand the performance regression and allocator behavior,
go back to 64k. This will continue to have a high space overhead for
small objects and EC, but will preserve the current performance levels
for all workloads.
This partially reverts 0ec75c99dd
Signed-off-by: Sage Weil <sage@redhat.com>
To be inline with per-pool omaps let's repair legacy statfs no matter
what's the value (true or false) is set to 'bluestore_fsck_error_on_no_per_pool_omap'
parameter. I.e. repair will bring per-pool statfs even when legacy statfs are considered as warning.
Signed-off-by: Igor Fedotov <ifedotov@suse.com>
Some 'expected' fsck falures (e.g. legacy omap records from previous
releases in Octopus) might produce tons of corresponding error/warning log lines.
This is a simple and rough workaround which limits number of printed lines by a
predefined value of 100.
Curretly applied to omap-related errors only.
Known flaw is that limit is applied on per-task basis hence multi-threaded quick-fix will
prooduce up to 100 * <number of fix task> lines instead of 100 which is a bit confusing.
Signed-off-by: Igor Fedotov <ifedotov@suse.com>
$ cephadm shell --name mon.123
INFO:cephadm:Found fsids []
Traceback (most recent call last):
File "./cephadm", line 2805, in <module>
r = args.func()
File "./cephadm", line 646, in _infer_fsid
return func()
File "./cephadm", line 1992, in command_shell
no_config=True if args.config else False)
File "./cephadm", line 1009, in get_container_mounts
data_dir = get_data_dir(fsid, daemon_type, daemon_id)
File "./cephadm", line 670, in get_data_dir
return os.path.join(args.data_dir, fsid, '%s.%s' % (t, n))
File "/usr/lib64/python3.7/posixpath.py", line 94, in join
genericpath._check_arg_types('join', a, *p)
File "/usr/lib64/python3.7/genericpath.py", line 149, in _check_arg_types
(funcname, s.__class__.__name__)) from None
TypeError: join() argument must be str or bytes, not 'NoneType'
Signed-off-by: Michael Fritch <mfritch@suse.com>
* refs/pull/32794/head:
cephadm: normalize image_id in 'pull' output too
cephadm: fix image_id normalization
cephadm: pull: remove newline from ceph_version
mgr/cephadm: base upgrade check on return code, not stderr
mgr/cephadm: fix ok-to-stop
mgr/cephadm: some upgrade debug output
mgr/cephadm: remove dup check
mgr/cephadm: only need_upgrade_self if image_id doesn't match
mgr/cephadm: safe to restart mgr and other non-mon/osd/mds daemons
Reviewed-by: Michael Fritch <mfritch@suse.com>
this also silences the warning of
src/mgr/BaseMgrModule.cc:402:9: warning: unused variable 'r' [-Wunused-variable]
int r = g_conf().get_val(string(what), &value);
^
Signed-off-by: Kefu Chai <kchai@redhat.com>
Commit d1b9d14324 added a check for
16-byte atomics without library support on IBM Z. Unfortunately
it turns out this test only works correctly when the test case
is built without optimization. (This is normally true, but it
may not be the case when passing explicit CXXFLAGS to cmake.)
The underlying reason is that GCC may choose to use either an
inline implementation of the 16-byte atomics or library calls,
depending on whether or not it is able to prove the atomic
variable is properly aligned. At -O0 it is never able to prove
that, but at higher optimization levels it depends on the complexity
of the expression (in particular, whether GCC can track down the
definition of the underlying object).
As the test case uses a very simple expression, it may happen that
this test can be built without requiring library support, but some
of the "real" uses of atomics in Ceph code cannot. This defeats
the whole purpose of the test at configure time.
Fixed by making the access pattern in the test more complex, so
that the test fails even at high optimization levels.
Fixes: https://tracker.ceph.com/issues/43747
Signed-off-by: Ulrich Weigand <ulrich.weigand@de.ibm.com>
This prevents the symbol from breaking from the last word of the label,
if the width gets too small.
This will also remove the need to add an extra span just to show the symbol.
Fixes: https://tracker.ceph.com/issues/40751
Signed-off-by: Tiago Melo <tmelo@suse.com>
With this change we are able to configura the col sizes of labels and inputs in
one single place.
Also increased the col size in smaller screens to be able to display longer
labels.
This was not applied in some situations where the col size was different than
usual.
Fixes: https://tracker.ceph.com/issues/40751
Signed-off-by: Tiago Melo <tmelo@suse.com>
When running 'FOR_MAKE_CHECK=1 ./install-deps.sh' in CentOS 8
these dependencies were not being installed.
Missing dependencies are provided by
https://copr.fedorainfracloud.org/coprs/ktdreyer/ceph-el8/
Signed-off-by: Alfonso Martínez <almartin@redhat.com>
The unit test AccessControlTest::test_load_v2() is testing a v1 database instead of a v2.
Fixes: https://tracker.ceph.com/issues/43760
Signed-off-by: Volker Theile <vtheile@suse.com>
The function calculates the difference between the values
in a time series list.
The previous location of it was in the dashboard, that's why the
function has doc tests. In order to be able to test them as part of the
manager utilities a bit of tox magic was added.
Fixes: https://tracker.ceph.com/issues/40365
Signed-off-by: Stephan Müller <smueller@suse.com>
this change is made to adapt
89e801b373
* always use the helpers from `futurize` instead of using
`::seastar::make_exception_future()` directly. as
`make_exception_future(future_state_base&& state)` is located in
`seastar::internal` namespace
* add `noexcept` specifier in both constructors. to match with the
helpers of `make_exception_future2()` which dispatch the call to
different constructor variants.
Signed-off-by: Kefu Chai <kchai@redhat.com>
