Commit Graph

107005 Commits

Author SHA1 Message Date
Kefu Chai
6857348f64 seastar: pickup change to pin socket to fixed core
and clang / GCC-10 related fixes

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-01-23 15:52:27 +08:00
Neha Ojha
f205d38c2c
Merge pull request #32373 from zdover23/wip-doc-pg-formats-update-dec-2019
doc: update list of formats for --format flag for "ceph pg dump"

Reviewed-by: Neha Ojha <nojha@redhat.com>
2020-01-22 19:10:00 -08:00
Neha Ojha
9f96f9bdc5
Merge pull request #32790 from neha-ojha/wip-pglog-defaults
doc/rados: update osd_min_pg_log_entries and add osd_max_pg_log_entries

Reviewed-by: Sage Weil <sage@redhat.com>
2020-01-22 19:03:48 -08:00
Samuel Just
181d991e53 rgw_kms: fix concat_url for empty url case
Can't call back() on an empty string.  Causes unittest_rgw_kms
to fail when compiled with _GLIBCXX_ASSERTIONS.

Signed-off-by: Samuel Just <sjust@redhat.com>
2020-01-22 16:03:14 -08:00
Samuel Just
9c89b16a8c fastbmap_allocator_impl: avoid std::vector[] for oob index
This was relatively harmless as the pointer won't actually be
dereferenced, but it runs afoul of std::vector's bounds checks with
_GLIBCXX_ASSERTIONS enabled.

Signed-off-by: Samuel Just <sjust@redhat.com>
2020-01-22 16:03:14 -08:00
Samuel Just
d2b4cd2820 unittest_random: min > max triggers a glibc assert
Signed-off-by: Samuel Just <sjust@redhat.com>
2020-01-22 16:03:14 -08:00
Samuel Just
385215f284 src/CMakeLists.txt: enable _GLIBCXX_ASSERTIONS in debug builds
We already enable this by default in our rpm builds.  Adding it here as
well increases the odds we'll catch things with make check and local
testing.

Signed-off-by: Samuel Just <sjust@redhat.com>
2020-01-22 16:03:06 -08:00
Sage Weil
f0049916a1 cephadm: normalize image_id in 'pull' output too
Signed-off-by: Sage Weil <sage@redhat.com>
2020-01-22 16:46:17 -06:00
Sage Weil
3806c5e7f2 cephadm: fix image_id normalization
Remove sha256: prefix from id (hash), not name.

Signed-off-by: Sage Weil <sage@redhat.com>
2020-01-22 16:46:05 -06:00
Patrick Donnelly
5d8e1d0949
Merge PR #32741 into master
* refs/pull/32741/head:
	qa/cephfs: make filelock_interrupt.py work with python3

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2020-01-22 14:41:40 -08:00
Sage Weil
04d1f378e5 cephadm: pull: remove newline from ceph_version
Signed-off-by: Sage Weil <sage@redhat.com>
2020-01-22 16:39:57 -06:00
Sage Weil
7244b7cef1 mgr/cephadm: base upgrade check on return code, not stderr
Signed-off-by: Sage Weil <sage@redhat.com>
2020-01-22 16:37:51 -06:00
Sage Weil
702e0c2e4d mgr/cephadm: fix ok-to-stop
Signed-off-by: Sage Weil <sage@redhat.com>
2020-01-22 16:33:03 -06:00
Sage Weil
1412177f8f mgr/cephadm: some upgrade debug output
Signed-off-by: Sage Weil <sage@redhat.com>
2020-01-22 16:31:01 -06:00
Sage Weil
1deae2492f mgr/cephadm: remove dup check
Signed-off-by: Sage Weil <sage@redhat.com>
2020-01-22 16:27:42 -06:00
Sage Weil
c360205961 mgr/cephadm: only need_upgrade_self if image_id doesn't match
Signed-off-by: Sage Weil <sage@redhat.com>
2020-01-22 16:25:09 -06:00
Sage Weil
a0180d75a6 mgr/cephadm: safe to restart mgr and other non-mon/osd/mds daemons
We don't have "ok-to-stop" checks for these.  And the mgr check for
self/active is already in the caller.

Signed-off-by: Sage Weil <sage@redhat.com>
2020-01-22 16:14:21 -06:00
Sage Weil
acd0e31177 qa/suites/rgw/website: run test on ubuntu
The dnsmasq package on centos 8.0 is broken, see
https://tracker.ceph.com/issues/43744

For now, run this test on ubuntu.

Signed-off-by: Sage Weil <sage@redhat.com>
2020-01-22 15:17:57 -06:00
Casey Bodley
cbcf45c189
Merge pull request #30152 from theanalyst/rgw/iam-policy-bitset-fn
rgw: iam: use a function to calculate the Action Bit string

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
2020-01-22 15:53:29 -05:00
Casey Bodley
d2fc41cc65
Merge pull request #29851 from linuxbox2/wip-rgw-linkvtrack
rgw: fix version tracking across bucket link steps

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2020-01-22 15:52:30 -05:00
Casey Bodley
0b49fdced8
Merge pull request #30540 from mikulely/uri-beast-cleanup
rgw: fix REQUEST_URI setting in the rgw_asio_client.cc

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2020-01-22 15:51:53 -05:00
Casey Bodley
3b955a012d
Merge pull request #30539 from mikulely/fix-operation2
rgw: fix opslog operation field as per Amazon s3

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2020-01-22 15:51:36 -05:00
Casey Bodley
f5f2bf660f
Merge pull request #30471 from liuchang0812/delete-bucket-with-system-user
rgw: the http response code of delete bucket should not be 204-no-content

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2020-01-22 15:51:19 -05:00
Neha
2451b93d10 doc/rados/configuration: document osd_max_pg_log_entries
Signed-off-by: Neha Ojha <nojha@redhat.com>
2020-01-22 19:21:59 +00:00
Neha
75b4707ca9 doc/rados: update osd_min_pg_log_entries
update docs to match 0db140c15c

Signed-off-by: Neha Ojha <nojha@redhat.com>
2020-01-22 19:15:11 +00:00
Neha
d6e720b29e qa/tasks/mgr/dashboard: set pg_num to 32
Signed-off-by: Neha Ojha <nojha@redhat.com>
2020-01-22 16:38:38 +00:00
Patrick Donnelly
1a0258ed3c
Merge PR #32644 into master
* refs/pull/32644/head:
	qa: ignore trimmed cache items for dead cache drop
	qa: use unit test comparisons

Reviewed-by: Zheng Yan <zyan@redhat.com>
2020-01-22 08:21:04 -08:00
Kefu Chai
bc1e874e47
Merge pull request #32772 from tchaikov/wip-43403
test/unittest_lockdep: do not start extra threads

Reviewed-by: Sage Weil <sage@redhat.com>
2020-01-22 23:42:05 +08:00
Radoslaw Zarzynski
6548dbcf30 msg/async: reset the V1's session_security in proper EventCenter.
Fixes: https://tracker.ceph.com/issues/43070
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2020-01-22 16:40:34 +01:00
Casey Bodley
3d00484c4e
Merge pull request #31356 from xxcs/xxcs06
rgw: Incorrectly calling ceph::buffer::list::decode_base64 in bucket policy

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
2020-01-22 10:28:13 -05:00
Casey Bodley
47f9991cd1
Merge pull request #31355 from zhangsw/fix-rgw-reshard-max-entries
rgw: reshard list may return more than specified max_entries.

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2020-01-22 10:27:43 -05:00
Casey Bodley
87e104a961
Merge pull request #31344 from zhangsw/fix-rgw-reshard-lock-failed
rgw: return error if lock log shard fails

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2020-01-22 10:27:18 -05:00
Casey Bodley
ad579a7a2b
Merge pull request #31239 from joke-lee/rgw-modify-zone-placement
rgw: radosgw-admin zone placement rm and radosgw-admin zonegroup placement rm support --storage-class

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2020-01-22 10:26:51 -05:00
Casey Bodley
35e25f2015
Merge pull request #31591 from liuchang0812/current-version-in-rgw-user-info
rgw: fix RGWUserInfo decode current version

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2020-01-22 10:26:26 -05:00
Neha
0c7991c0e8 mgr/pg_autoscaler: default to pg_num[_min] = 32
78bf924480 increased the default to 16.
Increasing it further to 32 will provide enough parallelism to improve
out of the box performance for new users.

Fixes: https://tracker.ceph.com/issues/43757
Signed-off-by: Neha Ojha <nojha@redhat.com>
2020-01-22 15:21:21 +00:00
Alfonso Martínez
4ef0e2c1ba mgr/dashboard: disable 'Add Capability' button when all the capabilities are added
Fixes: https://tracker.ceph.com/issues/43564
Signed-off-by: Alfonso Martínez <almartin@redhat.com>
2020-01-22 16:05:12 +01:00
Sage Weil
317c78cf46 qa/tasks/cephadm: learn to pull cephadm from github
Fixes: https://tracker.ceph.com/issues/43755
Signed-off-by: Sage Weil <sage@redhat.com>
2020-01-22 08:47:03 -06:00
Radoslaw Zarzynski
e084688622 common: encode for std::list<T> doesn't use bl::copy_in() anymore.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2020-01-22 15:41:51 +01:00
Sage Weil
498fa22ce9 Merge PR #30636 into master
* refs/pull/30636/head:
	common: Fix multiple logical errors in get_device_id.

Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-01-22 08:30:20 -06:00
Sage Weil
480ce84882 Merge PR #32732 into master
* refs/pull/32732/head:
	msg/async: use dedicated method for clearing conn's priv up.
	msg/async: mark down local_connection before draining the stack.

Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-01-22 08:30:02 -06:00
Sage Weil
4d30f8aead mon/ConfigMonitor: transition old keys to have global/ prefix
Convert keys that were missing the global prefix before to now have them.

Signed-off-by: Sage Weil <sage@redhat.com>
2020-01-22 08:27:09 -06:00
Sage Weil
9da5cb75c6 mon/ConfigMonitor: always prefix global config keys with global/
This avoids some ambiguity.  For instance, we cannot trivially tell if

 config/mgr/module/option

is an option called module/option that we don't understand that's in
the mgr section, or a mgr/module/option option in global.  In any case,
it's simpler to have a universal prefix.

Also, this aligns the storage schema with what assimilate-conf does (it
adds global/ for the global section).

Fixes: https://tracker.ceph.com/issues/43296
Signed-off-by: Sage Weil <sage@redhat.com>
2020-01-22 08:27:09 -06:00
Sage Weil
f27c6e0405 mon/ConfigMonitor: switch to use pending_cleanup boost::optional
This is more flexible.

Signed-off-by: Sage Weil <sage@redhat.com>
2020-01-22 08:26:48 -06:00
Kefu Chai
803dc981b8 googletest: pick up change to print GTEST_SKIP messages
to include the fix for
https://github.com/google/googletest/pull/2517

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-01-22 22:25:04 +08:00
Kefu Chai
2dc50b5f91 test/unittest_lockdep: do not start extra threads
also, stop linking against libglobal

Fixes: https://tracker.ceph.com/issues/43403
Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-01-22 22:25:04 +08:00
Sage Weil
e81054c640 Merge PR #32726 into master
* refs/pull/32726/head:
	mon/ConfigMonitor: clean out bad config records
	mon/ConfigMonitor: make 'config get' on fsid work
	common/options: remove NO_MON_UPDATE from mon_dns_srv_name
	mon/ConfigMonitor: do not 'config get' on NO_MON_UPDATE options
	mon/ConfigMonitor: do not set NO_MON_UPDATE values

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2020-01-22 08:23:36 -06:00
Jan Fajerski
6f107f7de9 ceph-volume: remove redefinition of [LV,PV,VG]_FIELDS
This was introduced in https://github.com/ceph/ceph/pull/32242
erroneously.

Signed-off-by: Jan Fajerski <jfajerski@suse.com>
2020-01-22 14:55:50 +01:00
Jan Fajerski
405112970e tests: fix tests after batch sizing was fixed
Signed-off-by: Jan Fajerski <jfajerski@suse.com>
2020-01-22 14:55:50 +01:00
Jan Fajerski
9e61b80d2c lvm/batch: adjust devices for byte based size calculation
Signed-off-by: Jan Fajerski <jfajerski@suse.com>
2020-01-22 14:55:50 +01:00
Jan Fajerski
8b8913ad3c lvm: add sizing arguments to prepare and create.
This adds options to size to-be-created LVs in the prepare and create
subcommands. Sizing can be done explicitly by passing a sizes or
implicitly by specifying the number of slots per [data|journal|wal|db]
device. The former will try to create a LV of the specified size and use
that to create OSDs if it succeeds. The latter will carve up the device
size into $n slots and use one of those slots for the to-be-created OSD.
If partitions or LVs are passed these options are ignored.
This also creates the foundation to move to byte-based sizing, by moving
VolumeGroup lvm querying and size calculation to bytes as the base unit.

Fixes: https://tracker.ceph.com/issues/43299

Signed-off-by: Jan Fajerski <jfajerski@suse.com>
2020-01-22 14:55:50 +01:00