Upstart configurations and sysv init scripts should be started and stopped
using invoke-rc.d in maintainer scripts.
This ensures the correct behaviour across both Debian (sysv) and Ubuntu (upstart)
and in restricted environments such as schroot where start/stop of services from
maintainer scripts is normally disabled.
Signed-off-by: James Page <james.page@ubuntu.com>
Convert an int pool id to a pool name. Useful for making sense of the
output from ceph_get_*_layout()'s poolid output argument.
Signed-off-by: Sage Weil <sage@inktank.com>
Call release() on librados::AioCompletion to free storage before
leave the loop or call new again.
CID 1021213 (#1 of 1): Resource leak (RESOURCE_LEAK)
leaked_storage: Variable "rados_completion" going out of scope leaks
the storage it points to.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
- prepend $local to the $allconf list at the top
- remove $local special case for all case
- fix the type prefix checks to explicitly check for prefixes
Fugly bash, but works!
Backport: cuttlefish, bobtail
Signed-off-by: Sage Weil <sage@inktank.com>
Reviewed-by: Dan Mick <dan.mick@inktank.com>
Wheezy's udev (175-7.2) has broken rules for the /dev/disk/by-partuuid/
symlinks that ceph-disk relies on. Install parallel rules that work. On
new udev, this is harmless; old older udev, this will make life better.
Fixes: #4865
Backport: cuttlefish
Signed-off-by: Sage Weil <sage@inktank.com>
If we have not pg_map updates, the delta doesn't update, and can get stuck
with the velocity right before activity stopped. This is confusing, and
can cause incorrect health warnings about in-progress recovery.
To fix this, zero the delta if there is no activity for
'mon delta reset interval' seconds.
Fixes: #5077
Signed-off-by: Sage Weil <sage@inktank.com>
FileStoreDiff umounts the stores in its destructor.
Also, DeterministicOpSequence handles deletes its passed
object store.
Fixes: #5076
Signed-off-by: Samuel Just <sam.just@inktank.com>
Reviewed-by: David Zafman <david.zafman@inktank.com>
The finish() method for Contexts calls delete this.
This reverts commit 36028916c4.
Fixes: #5075
Signed-off-by: Samuel Just <sam.just@inktank.com>
Reviewed-by: David Zafman <david.zafman@inktank.com>
...indirectly via ceph-common. We get bad behavior when they diverge, I
think because of libcommon.la being linked both statically and dynamically.
Fixes: #4997
Backport: cuttlefish, bobtail
Signed-off-by: Sage Weil <sage@inktank.com>
Reviewed-by: Gary Lowell <gary.lowell@inktank.com>
client/Client.cc: fix/silence "logically dead code" CID-Error
Even money that this satisfies the coverity gods...
Reviewed-by: Sage Weil <sage@inktank.com>
In committed_thru, we use write_pos to reset the header.start value in cases
where seq is past the end of our journalq. It is therefore important that the
journalq be updated atomically with write_pos (that is, under the write_lock).
The call to align_bl() is moved into do_write in order to ensure that write_pos
is adjusted correctly prior to write_bl().
Also, we adjust pos at the end of write_bl() such that pos \in [get_top(),
header.max_size) after write_bl().
Fixes: #5020
Signed-off-by: Samuel Just <sam.just@inktank.com>
Reviewed-by: Sage Weil <sage@inktank.com>
Fix handling of 'safe' and the conditions after calling file_flush().
CID 1019548 (#1 of 1): Logically dead code (DEADCODE)
dead_error_begin: Execution cannot reach this statement "flock.Unlock();"
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
