Commit Graph

140613 Commits

Author SHA1 Message Date
Venky Shankar
1568321c17 Merge PR #53873 into main
* refs/pull/53873/head:
	qa: typo fix when checking for perf counter - s/md_thresh_evicted/mdthresh_evicted
	qa: lower mds_session_metadata_threshold for tests

Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Leonid Usov <leonid.usov@ibm.com>
2023-10-09 17:49:30 +05:30
Venky Shankar
5856a1e6b7 qa: typo fix when checking for perf counter - s/md_thresh_evicted/mdthresh_evicted
Signed-off-by: Venky Shankar <vshankar@redhat.com>
2023-10-09 14:59:18 +05:30
Venky Shankar
92200d9d10 qa: lower mds_session_metadata_threshold for tests
... and increase the number of files that are created so as to
hit the threshold with a high probability.

Fixes: http://tracker.ceph.com/issues/62873
Signed-off-by: Venky Shankar <vshankar@redhat.com>
2023-10-09 14:59:18 +05:30
Nizamudeen A
6ed5a2884f
Merge pull request #53817 from cloudbehl/active-alert-filter
mgr/dashboard: Filter active alerts

Reviewed-by: Nizamudeen A <nia@redhat.com>
2023-10-09 10:41:21 +05:30
zdover23
03e43c5bb0
Merge pull request #53874 from zdover23/wip-doc-2023-10-07-rados-troubleshooting-community
doc/rados: edit troubleshooting/community.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-10-08 16:10:20 +11:00
zdover23
9c383d15ad
Merge pull request #53875 from zdover23/wip-doc-2023-10-07-troubleshooting-troubleshooting-mon-3-of-x
doc/rados: edit troubleshooting-mon.rst (3 of x)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-10-08 15:50:45 +11:00
Zac Dover
fabfec2734 doc/rados: edit troubleshooting/community.rst
Edit doc/rados/troubleshooting/community.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-10-08 14:43:58 +10:00
Zac Dover
fc45a0c4dd doc/rados: edit troubleshooting-mon.rst (3 of x)
Edit doc/rados/troubleshooting/troubleshooting-mon.rst.

Follows https://github.com/ceph/ceph/pull/52827

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-10-08 14:35:33 +10:00
Anthony D'Atri
25775d5442
Merge pull request #53876 from zdover23/wip-doc-2023-10-08-architecture-rbd-sentence-repair
doc/architecture: repair RBD sentence
2023-10-07 20:45:38 -04:00
Zac Dover
5abd530460 doc/architecture: repair RBD sentence
Improve an ambiguous sentence in doc/architecture.rst.

The problem presented by the original sentence is that the phrasal verb
"to provide with" is implicated in one of its possible readings.
Interpreted in that way, the sentence seems to express the incorrect
idea that RBD furnishes block devices with snapshotting and cloning, as
though snapshotting and cloning are being delivered to the block
devices. In fact, snapshotting and cloning are just features of RBD, and
are features that are described on this page:
https://docs.ceph.com/en/quincy/rbd/rbd-snapshot/.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-10-08 07:47:00 +10:00
zdover23
b05d167b48
Merge pull request #53790 from zdover23/wip-doc-2023-10-03-architecture-17-of-x
doc/architecture: edit "Peering and Sets"
2023-10-07 15:51:27 +11:00
Zac Dover
c69b111966 doc/architecture: edit "Peering and Sets"
Edit the English in the section "Peering and Sets" in the file
doc/architecture.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-10-07 14:24:30 +10:00
Patrick Donnelly
617f7153d7
Merge PR #53855 into main
* refs/pull/53855/head:
	script: add option for debug build

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
2023-10-06 20:15:23 -04:00
Patrick Donnelly
ec720e94e9
script: add option for debug build
See: https://github.com/ceph/ceph-build/pull/2167

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2023-10-06 12:06:01 -04:00
Yuri Weinstein
080768f77c
Merge pull request #53417 from jrchyang/fix_mclock_scheduling_slow_main
osd: fix: slow scheduling when item_cost is large

Reviewed-by: Sridhar Seshasayee <sseshasa@redhat.com>
2023-10-06 06:58:11 -07:00
Yuval Lifshitz
9a0a855fb0
Merge pull request #52430 from vedanshbhartia/coverity_datarace
rgw: Add coverity annotations for missing mutex locks

reviewed-by: yuvalif, mkogan1
2023-10-06 13:07:31 +03:00
zdover23
be8824907d
Merge pull request #53834 from dparmar18/remove-egg-fragment-from-doc
doc: remove egg fragment from dev/developer_guide/running-tests-locally

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Zac Dover <zac.dover@proton.me>
2023-10-06 10:21:14 +11:00
Adam King
6c4ed58ab1
Merge pull request #52296 from asm0deuz/bz2153448_ipv6
mgr/cephadm: ceph orch add fails when ipv6 address is surrounded by square brackets.

Reviewed-by: Adam King <adking@redhat.com>
2023-10-05 11:43:53 -04:00
Adam King
ab07057e18
Merge pull request #53621 from phlogistonjohn/jjm-cephadm-dtypes-common
cephadm: introduce Daemon Forms

Reviewed-by: Adam King <adking@redhat.com>
2023-10-05 11:41:47 -04:00
Venky Shankar
3844ff224e Merge PR #53836 into main
* refs/pull/53836/head:
	PendingReleaseNotes: add a note about disallowing delegating inodes
	qa: start testing mds_client_delegate_inos_pct config
	mds: disable delegating inode ranges to clients

Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
2023-10-05 20:58:33 +05:30
Dhairya Parmar
1f78a32a18 doc: remove egg fragment from dev/developer_guide/running-tests-locally
DEPRECATION: git+https://github.com/ceph/teuthology#egg=teuthology
[test] contains an egg fragment with a non-PEP 508 name pip 25.0 will enforce
this behaviour change. A possible replacement is to use the req @ url syntax,
and remove the egg fragment. Discussion can be found at
https://github.com/pypa/pip/issues/11617

Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
2023-10-05 20:17:14 +05:30
Nizamudeen A
7f32bce6c5
Merge pull request #53700 from cloudbehl/cephfs-snapshot
mgr/dashboard: Fixed cephfs snapshot listing in directories

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2023-10-05 19:40:32 +05:30
Adam King
a44dd1fd70
Merge pull request #53782 from sachinpunadikar/vstart-fix
vstart: exclude default route during cluster setup

Reviewed-by: Adam King <adking@redhat.com>
2023-10-05 08:37:56 -04:00
cloudbehl
a40fd8ca92 mgr/dashboard: Filter active alerts
- List alerts which are not suppressed

fixes: https://tracker.ceph.com/issues/62990

Signed-off-by: cloudbehl <cloudbehl@gmail.com>
2023-10-05 17:33:35 +05:30
zdover23
ce1bf5ae25
Merge pull request #53819 from zdover23/wip-doc-2023-10-04-rados-troubleshooting-index
doc/rados: edit troubleshooting.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-10-05 22:43:02 +11:00
Venky Shankar
689b3d5ae1 PendingReleaseNotes: add a note about disallowing delegating inodes
Signed-off-by: Venky Shankar <vshankar@redhat.com>
2023-10-05 16:54:32 +05:30
Venky Shankar
4c6660842f qa: start testing mds_client_delegate_inos_pct config
Signed-off-by: Venky Shankar <vshankar@redhat.com>
2023-10-05 15:09:15 +05:30
Venky Shankar
8d57584ff8 mds: disable delegating inode ranges to clients
Fixes: http://tracker.ceph.com/issues/63103
Signed-off-by: Venky Shankar <vshankar@redhat.com>
2023-10-05 15:09:15 +05:30
Yuval Lifshitz
5fede37615
Merge pull request #52735 from vedanshbhartia/coverity_minlong
rgw: Add coverity annotation for warning about tautological comparison

reviewed-by: thotz, yuvalif
2023-10-05 10:50:21 +03:00
Ali Masarwa
8cf2e2d089
Merge pull request #53788 from AliMasarweh/wip-alimasa-topic-stats-help
RGW: add the missing help print for command 'topic stats'

Reviewed-by: thotz <thottanjiffin@gmail.com>, Daniel Gryniewicz <dang@redhat.com>
2023-10-05 10:46:37 +03:00
Nizamudeen A
296044d181
Merge pull request #53789 from rhcs-dashboard/rgw-overview-fix
mgr/dashboard: fix rgw inventory card and broken shadows

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
2023-10-05 12:25:11 +05:30
Sachin Punadikar
8b328dd979 vstart: exclude default route during cluster setup
"ip route list" may list default route, and that needs to be excluded
while doing cluster setup
Typical o/p of ip route list:
$ ip route list
default via 10.8.159.254 dev eno1 proto dhcp src 10.8.152.13 metric 100
10.8.152.0/21 dev eno1 proto kernel scope link src 10.8.152.13 metric 100

Signed-off-by: Sachin Punadikar <sachin.punadikar@ibm.com>
2023-10-05 02:22:08 -04:00
Nizamudeen A
54afd7b36e
Merge pull request #52313 from linuxbox2/wip-fix-disable-dashboard
dashboard: regression, make install fails w/dashboard disabled

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2023-10-05 09:12:25 +05:30
John Mulligan
ed1bdff776 cephadm: convert cephadm agent to a daemon form
The cephadm agent is a bit special in that it will not be converted
to a ContainerDaemonForm (it is not containerized) but we still want
to have it registered as a DeamonForm so that the deamon_type can be
passed to create and have it resolve correctly.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-04 15:17:57 -04:00
John Mulligan
e82baf51be cephadm: convert SNMPGateway to a ContainerDaemonForm
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-04 15:17:57 -04:00
John Mulligan
be3e552717 cephadm: convert CustomContainer to a ContainerDaemonForm
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-04 15:17:57 -04:00
John Mulligan
0c702d530e cephadm: convert NFSGanesha to a ContainerDaemonForm
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-04 15:17:57 -04:00
John Mulligan
3d75f99119 cephadm: add func to deploy any generic ContainerDaemonForm
While there are no ContainerDaemonForms implemented yet, add a function
that uses the ContainerDaemonForm methods to construct a deployment
for the container based daemons.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-04 15:17:57 -04:00
John Mulligan
81566c3a3f cephadm: add ContainerDaemonForm
Add a supplemental DaemonForm subclass that helps deploy container
based daemons in a standard fashion. Most of these methods are
optional and should have sensible defaults.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-04 15:17:57 -04:00
John Mulligan
0e58e0a170 cephadm: move DeploymentType to deploy.py
The DeploymentType is used by a number of other classes and functions
and has no dependencies beyond enum and is safe to move.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-04 15:17:57 -04:00
John Mulligan
33f2606935 cephadm: move firewalld related items to firewalld.py
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-04 15:17:57 -04:00
John Mulligan
d3b59b80da cephadm: remove direct daemon-class deps from firewall
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-04 15:17:57 -04:00
John Mulligan
4a00814f82 cephadm: move sysctl specific functions to sysctl.py
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-04 15:17:57 -04:00
John Mulligan
14f3cf1738 cephadm: remove direct daemon-type deps from sysctl
Using the appropriate daemon form we can break the direct dependency
that the sysctl setup function has on particular classes and use
a generic interface.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-04 15:17:57 -04:00
John Mulligan
8f459ad3db cephadm: add test_daemon_form.py
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-04 15:17:57 -04:00
John Mulligan
1a70e6a72e cephadm: introduce daemon forms to cephadm.py
Introduce the DeamonForm base class to cephadm.py and make various
daemon-type classes into fully fleged deamon form classes.

Some classes already had a semi-standard `init` classmethod for
instantiation. In these cases the new `create` classmethod is a thin
wrapper over the existing method. In cases where the class was not
already being instantiated a minimal set of methods are added.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-04 15:17:57 -04:00
John Mulligan
910a2e01f4 cephadm: add daemon_form.py: bases and funcs for daemon forms
Create daemon_form.py containing the DaemonForm class and a few
subclasses and utility functions for working with DaemonForms.
In a future commit, DaemonForm will become the base class for
the current assortment of classes named after the daemon or
family of daemon they help manage.

A daemon form, think "form" as in "template" or "mold", assists
in setting up, creating, and managing daemons controlled with
cephadm. Because cephadm supports a variety of services the
DaemonForm is an abstract base class and the module also supports
additional ABCs that may be used by DaemonForms to implement
optional features.

The daemon forms that are expected to be used directly must be
registered using the provided decorator. This is an explicit extra
step so that common bases that inherit from DaemonForm can be
implemented. Plus explicit is better than implicit. :-)
All DeamonForm subclasses are expected to provide a small set
of standard methods so that the types can be chosen, instantiated,
and used a common manner.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-04 15:17:57 -04:00
John Mulligan
f80c976f8d cephadm: add some unit test coverage for deploying nfs, snmp
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-04 15:17:57 -04:00
Zac Dover
9d9d92837e doc/rados: edit troubleshooting.rst
Edit doc/rads/troubleshooting.rst to remove some language that sounds
quite close to marketing language.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-10-05 00:43:04 +10:00
Matt Benjamin
0225f2685d dashboard: regression, make install fails w/dashboard disabled
https://tracker.ceph.com/issues/63100

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2023-10-04 10:15:55 -04:00