RepoMirrors/ceph
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2025-01-12 14:10:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #52430 from vedanshbhartia/coverity_datarace

Browse Source 
rgw: Add coverity annotations for missing mutex locks

reviewed-by: yuvalif, mkogan1
This commit is contained in:
Yuval Lifshitz 2023-10-06 13:07:31 +03:00 committed by GitHub
commit 9a0a855fb0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/rgw/driver/rados/rgw_d3n_datacache.cc
View File

@ -65,6 +65,7 @@ D3nDataCache::D3nDataCache()
void D3nDataCache::init(CephContext *_cct) {
cct = _cct;
// coverity[missing_lock:SUPPRESS]
free_data_cache_size = cct->_conf->rgw_d3n_l1_datacache_size;
head = nullptr;
tail = nullptr;

2
src/rgw/driver/rados/rgw_rados.cc
View File

@ -1038,6 +1038,8 @@ void RGWRados::finalize()
}
}
if (run_sync_thread) {
// https://github.com/ceph/ceph/commit/9106e8ad3121a503bf49a7334367849756bd1291
// coverity[missing_lock:SUPPRESS]
delete meta_sync_processor_thread;
meta_sync_processor_thread = NULL;
std::lock_guard dl{data_sync_thread_lock};

1
src/rgw/rgw_file_int.h
View File

@ -226,6 +226,7 @@ namespace rgw {
~file();
};
// coverity[missing_lock:SUPPRESS]
struct directory {
static constexpr uint32_t FLAG_NONE = 0x0000;

3
src/rgw/rgw_http_client.cc
View File

@ -1017,7 +1017,10 @@ int RGWHTTPManager::set_request_state(RGWHTTPClient *client, RGWHTTPRequestSetSt
return 0;
}
// mutex already locked
// coverity[missing_lock:SUPPRESS]
req_data->write_paused = suggested_wr_paused;
// coverity[missing_lock:SUPPRESS]
req_data->read_paused = suggested_rd_paused;
int bitmask = CURLPAUSE_CONT;