Commit Graph

121918 Commits

Author SHA1 Message Date
Willem Jan Withagen
130dbc7725 test: Undo the FreeBSD specific retval test
Changes to the socket code now result in returning EINVAL
In the past ENOENT was returned which is the FreeBSD error code
if DNS lookup does not work.

And that change is probably because somewhere in the code that
errorcode is not passed verbatim from the systemcall, but is
rewritten in extra evaluation.

Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
2021-04-12 10:36:28 +02:00
Sage Weil
d9497684f7 Merge PR #40577 into master
* refs/pull/40577/head:
	cephadm: normalize unqualified repo digests to docker.io
	mgr/cephadm/upgrade: normalize unqualified target image

Reviewed-by: Juan Miguel Olmo <jolmomar@redhat.com>
2021-04-10 09:01:58 -04:00
Sage Weil
542b81b8f1 Merge PR #40537 into master
* refs/pull/40537/head:
	cephadm:persist the grafana.db file

Reviewed-by: Sage Weil <sage@redhat.com>
2021-04-10 09:01:27 -04:00
Patrick Donnelly
4803e9f5d5
Merge PR #40653 into master
* refs/pull/40653/head:
	mon: check mdsmap is resizeable before promoting standby-replay

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2021-04-09 20:08:51 -07:00
Patrick Donnelly
3e849e7349
Merge PR #40642 into master
* refs/pull/40642/head:
	client: don't allow access to MDS-private inodes

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
2021-04-09 20:06:21 -07:00
Patrick Donnelly
4d29e591dd
Merge PR #40481 into master
* refs/pull/40481/head:
	qa: test standby-replay with fs:workloads

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2021-04-09 20:04:32 -07:00
Patrick Donnelly
76ac006875
Merge PR #40431 into master
* refs/pull/40431/head:
	qa/cephfs: remove create_keyring_file from cephfs_test_case.py
	qa/cephfs: don't use sudo to write files in /tmp

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
2021-04-09 20:02:27 -07:00
Patrick Donnelly
d302b72691
Merge PR #40389 into master
* refs/pull/40389/head:
	mds: reject lookup ino requests for mds dirs
	test: add test for invalid lookup of mdsdir

Reviewed-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
2021-04-09 19:58:40 -07:00
Neha Ojha
b4f291a6b4
Merge pull request #40723 from zdover23/wip-doc-second-attempt-mclock-rewrite-second-half-2021-Apr-09
doc/rados: rewrite mclock docs (2 of 2)

Reviewed-by: Sridhar Seshasayee <sseshasa@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2021-04-09 17:24:41 -07:00
Josh Durgin
91104375cd
Merge pull request #40738 from jdurgin/wip-librados-docs
include/librados: fix doxygen syntax for docs build

Reviewed-by: Neha Ojha <nojha@redhat.com>
2021-04-09 16:48:13 -07:00
Josh Durgin
70b8f16a2c include/librados: fix doxygen syntax for docs build
The docs build is now warning about these like:

WARNING: Unparseable C cross-reference: '[in]'
Invalid C declaration: Expected identifier in nested name.

Signed-off-by: Josh Durgin <jdurgin@redhat.com>
2021-04-09 18:01:35 -04:00
Sage Weil
e07a738304 cephadm: normalize unqualified repo digests to docker.io
A RepoDigests returned by docker|podman image inspect can either include
the docker.io/ prefix or not.  For reasons that aren't entirely clear,
this may vary between hosts in a cluster.  However, ceph/ceph@sha256:abc...
is the same thing as docker.io/ceph/ceph@sha256:abc..., and should be
treated as such.  Otherwise, upgrade can get into a loop where it pulls
the image on a new host, finds the other variant of the repodigests,
sees no overlap, updates target_digests, and restarts.  (It will then
find the first variant again on the first host and loop.)

Avoid this by normalizing any docker.io digests by always including the
docker.io/ prefix.

Note that it is technically possible that this assumption is wrong: it
may be that the image that already exists on the local host is from a
different registry in registries.conf's unqualified-search-registries.
However, we don't know which, since this is a search list.  In practice,
it should be exceeding rare that an image that *we* are installing using
a fully-qualified image name will end up having an unqualified repodigest
in the local registry.  Hopefully!

Fixes: https://tracker.ceph.com/issues/50114
Signed-off-by: Sage Weil <sage@newdream.net>
2021-04-09 16:53:37 -04:00
Sage Weil
38f84520ee mgr/cephadm/upgrade: normalize unqualified target image
If we get an unqualified target image, assume it's docker.io.  This
ensures that we're passing a fully-qualified target to docker|podman on
the various hosts and don't end up with something different based on the
per-host search path for unqualified image names.

Signed-off-by: Sage Weil <sage@newdream.net>
2021-04-09 16:53:37 -04:00
Zac Dover
f3180ad722 doc/rados: rewrite mclock docs (2 of 2)
This is my second attempt to rewrite the
second half of the mclock docs. The first attempt
is enshrined in https://github.com/ceph/ceph/pull/40571,
in which I got cute with git and got burned.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2021-04-10 06:49:43 +10:00
Samuel Just
055ebe381d
Merge pull request #39216 from myoungwon/wip-manifest-dedup-test
osd, test: reworks for manifest dedup test cases

Reviewed-by: Samuel Just <sjust@redhat.com>
2021-04-09 12:42:18 -07:00
Yuri Weinstein
5f2f793af2
Merge pull request #40623 from ronen-fr/wip-ronenf-revert-40077
osd: Revert "osd: Try other PGs when reservation failures occur"

Reviewed-by: Neha Ojha <nojha@redhat.com>
2021-04-09 07:45:55 -07:00
Yuri Weinstein
63a3452248
Merge pull request #40606 from myoungwon/wip-49427-2
osd: recover unreadable snapshot before reading refcount info

Reviewed-by: Samuel Just <sjust@redhat.com>
2021-04-09 07:44:42 -07:00
Josh Durgin
e734c2d123
Merge pull request #40510 from aclamk/wip-bluestore-sharding-rst
doc: Add BlueStore sharding documentation

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2021-04-08 15:36:27 -07:00
Patrick Donnelly
682a55e8a2
mds: reject lookup ino requests for mds dirs
Fixes: https://tracker.ceph.com/issues/49922
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2021-04-08 12:21:42 -07:00
Patrick Donnelly
4702be4f47
qa: test standby-replay with fs:workloads
Fixes: https://tracker.ceph.com/issues/50045
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2021-04-08 11:37:56 -07:00
Patrick Donnelly
9d7a42e709
Merge PR #40486 into master
* refs/pull/40486/head:
	mds: trim cache regularly for standby-replay
	mds: remove extra heap release

Reviewed-by: Sidharth Anupkrishnan <sanupkri@redhat.com>
2021-04-08 11:35:05 -07:00
Patrick Donnelly
1cfc753e9a
Merge PR #40520 into master
* refs/pull/40520/head:
	mds/scrub: background scrub error fixes

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2021-04-08 11:34:21 -07:00
Patrick Donnelly
2f1d3aa629
Merge PR #40633 into master
* refs/pull/40633/head:
	mds: ensure export_pin rank < max_mds

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2021-04-08 11:33:41 -07:00
Patrick Donnelly
b02fa8b9de
Merge PR #40638 into master
* refs/pull/40638/head:
	mds: do not show the default auth if it's unambiguous
	mds: switch to rank number instead

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2021-04-08 11:33:08 -07:00
Patrick Donnelly
e1748e7a83
mon: check mdsmap is resizeable before promoting standby-replay
If any MDS is up:creating, some rank data structures may not exist yet.

Fixes: https://tracker.ceph.com/issues/50215
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2021-04-08 11:24:49 -07:00
Kefu Chai
8e7e4420d0
Merge pull request #40617 from tchaikov/wip-system-pmem
install-deps.sh: install libpmem libraries if WITH_PMEM is set

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2021-04-08 22:57:23 +08:00
Patrick Donnelly
1b8ee16c13
Merge PR #40467 into master
* refs/pull/40467/head:
	doc: detail `fs snapshot mirror daemon status` mgr command
	doc: s/<fs>/<fs_name>/g

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Sébastien Han <seb@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
2021-04-08 07:28:10 -07:00
Kefu Chai
8202aa3ddf
Merge pull request #40654 from rzarzynski/wip-crimson-notify-lifetime
crimson/osd: fix the lifetime of Notify during timeouts

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-04-08 20:37:41 +08:00
Ilya Dryomov
99f3a452ef
Merge pull request #40641 from idryomov/wip-require-ceph-common-for-ioc
packaging: require ceph-common for immutable object cache daemon

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-04-08 13:07:44 +02:00
Radoslaw Zarzynski
03d35060d6 crimson/osd: improve debugs around Watch / Notify.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2021-04-08 09:49:51 +00:00
Radoslaw Zarzynski
aa4c90254e crimson/osd: fix the lifetime of Notify during timeouts.
This fixes a segfault during `LibRadosWatchNotify.WatchNotify2Timeout`.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2021-04-08 09:49:27 +00:00
Venky Shankar
bfaf5e9929 doc: detail fs snapshot mirror daemon status mgr command
@leseb noticed that this interface did not have any documentation. Thanks!

Fixes: http://tracker.ceph.com/issues/50229
Signed-off-by: Venky Shankar <vshankar@redhat.com>
2021-04-08 15:13:58 +05:30
Venky Shankar
9d60ec8ceb doc: s/<fs>/<fs_name>/g
Signed-off-by: Venky Shankar <vshankar@redhat.com>
2021-04-08 15:13:58 +05:30
Kefu Chai
69a7ed4eab run-make-check: enable WITH_RBD_RWL when WITH_PMEM is true
so we can at least build-test the rwl cache plugin in "make check" run.

this is an opt-in option which is only enabled if WITH_PMEM is "true",
we will set it in the corresponding ceph-build job.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-04-08 17:16:46 +08:00
Kefu Chai
17d2bc3707 install-deps.sh: install libpmem libraries if WITH_PMEM is set
Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-04-08 17:15:15 +08:00
myoungwon oh
efd89f9beb osd: do not assert() in the case of no obc
Upon rollback, we should handle ENOENT case,
so what we should do here is to return NOOP.

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2021-04-08 17:38:14 +09:00
myoungwon oh
779e60e5bc osd: remove unnecessary ref handling in _delete_oid
Let's consider the following case when handling a delete op.
1. Delete --> whiteouted
2. Make clone

In this case, current code clears chunk_map and calls dec_all_manifest_refcount()
in _delete_oid() even if the clone still has the references.

To fix this, This commit remove unnecessary ref handling in _delete_oid, and
makes finish_ctx() to handle ref handling, which can aware of whether the
clone is created or not.

Also, remove oi.size == 0 condition in finish_ctx() to handle ref. counting
upon a delete op with whitedouted clone.

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2021-04-08 17:35:59 +09:00
Adam Kupczyk
a2067a02d7 doc: Add BlueStore sharding documentation
Provide sharding explanation, configuration parameters explanation.
Provide resharding tool example into Pacific format.

Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
Co-authored-by: Josh Durgin <jdurgin@redhat.com>
2021-04-08 09:27:58 +02:00
Kefu Chai
e42c93c785
Merge pull request #40596 from tchaikov/wip-cmake-clean
cmake: remove created directory when "clean" target is run

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2021-04-08 15:26:07 +08:00
Rishabh Dave
511434ac5a qa/cephfs: remove create_keyring_file from cephfs_test_case.py
Since teuthology.orchestra.remote.mktemp() can write a temporary file
and not just create it, create_keyring_file() is now redundant.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2021-04-08 12:11:00 +05:30
Rishabh Dave
e213849581 qa/cephfs: don't use sudo to write files in /tmp
Files in /tmp cannot be written by any user( including the root user)
other than the file owner even if the permission mode on the file is
777.

Fixes: https://tracker.ceph.com/issues/49466
Signed-off-by: Rishabh Dave <ridave@redhat.com>
2021-04-08 11:56:00 +05:30
Venky Shankar
714d51301b
Merge pull request #40342 from batrick/snap_schedule-qa-fixes
qa: snap_schedule test debugging

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2021-04-08 11:51:05 +05:30
Yuval Lifshitz
c43878d0bd
Merge pull request #40625 from TRYTOBE8TME/wip-rgw-notifications
rgw/test: Changing force-branch to master
2021-04-08 08:32:45 +03:00
Kefu Chai
dfca3f8cb1
Merge pull request #40622 from batrick/dev-make
doc: update some docs still referring to make

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-04-08 12:55:37 +08:00
Kefu Chai
50287ee333
Merge pull request #40647 from rzarzynski/wip-crimson-notify-send_comp-broken-debug
crimson/osd: fix broken debug in Notify::send_completion().

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
2021-04-08 11:58:56 +08:00
Patrick Donnelly
dd2e31a336
Merge PR #40204 into master
* refs/pull/40204/head:
	client: cleanup _preadv_pwritev_locked()

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
2021-04-07 19:37:40 -07:00
Patrick Donnelly
c20ee8eedf
Merge PR #40427 into master
* refs/pull/40427/head:
	mds: skip the buffer in UnknownPayload::decode()

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2021-04-07 19:37:00 -07:00
Patrick Donnelly
d06d66d88d
Merge PR #40611 into master
* refs/pull/40611/head:
	qa: retry cloning the ceph.git

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2021-04-07 19:35:58 -07:00
Kefu Chai
a9fe167c1a
Merge pull request #40636 from tchaikov/wip-50196
qa/tasks/mgr: skip test_diskprediction_local on python>=3.8

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
2021-04-08 10:15:33 +08:00
Yanhu Cao
3017b78225 mds: ensure export_pin rank < max_mds
Signed-off-by: Yanhu Cao <gmayyyha@gmail.com>
2021-04-08 09:51:29 +08:00