Commit Graph

121918 Commits

Author SHA1 Message Date
Patrick Donnelly
42d7da5f12
Merge PR #40469 into master
* refs/pull/40469/head:
	qa: check mounts attribute in ctx

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2021-04-06 10:41:55 -07:00
Patrick Donnelly
40dfede339
Merge PR #40501 into master
* refs/pull/40501/head:
	client: fix the opened inodes counter increasing

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2021-04-06 10:41:07 -07:00
Zac Dover
e262e85606 doc/rados: rewrite mclock-config-ref
This PR rewrites the material provided in
PR#40531, improving its elegance and
readability.

This PR rewrites the first 48 percent of the
material provided in PR#40531.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2021-04-07 03:17:51 +10:00
Yuval Lifshitz
36e03d79cd
Merge pull request #40113 from yuvalif/wip-yuval-fix-49799
rgw/notification: set correct type to "post" and "copy" notifications
2021-04-06 19:45:57 +03:00
Nizamudeen A
fb607f1561 mgr/dashboard: Revoke read-only user's access to Manager modules
This will disable read only user to read/open Manager Modules page in
Ceph Dashboard where some of the security related informations are
shown.

Fixes: https://tracker.ceph.com/issues/50174
Signed-off-by: Nizamudeen A <nia@redhat.com>
2021-04-06 21:24:51 +05:30
Patrick Donnelly
c94f0a50a5
Merge PR #40620 into master
* refs/pull/40620/head:
	cephfs-top: fix typo in help

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2021-04-06 08:25:49 -07:00
Patrick Donnelly
9f68564bda
Merge PR #40613 into master
* refs/pull/40613/head:
	doc/cephfs/nfs: add user id, fs name and key to FSAL block

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2021-04-06 08:24:59 -07:00
Patrick Donnelly
551134a935
doc: update some docs still referring to make
We use ninja now.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2021-04-06 08:11:36 -07:00
Ernesto Puerta
c448dfad84
Merge pull request #40616 from rhcs-dashboard/fix-50044-master
mgr/dashboard: debug nodeenv hangs

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: David Galloway <dgallowa@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-04-06 16:33:24 +02:00
Patrick Donnelly
19293d9b9d
mds: trim cache regularly for standby-replay
This change is slightly awkward because standby-replay MDS do not do all
the kinds of upkeep a normal active MDS does. In particular, it is not
going to recall client state from clients.

This diff also merges the extra recall_client_state in
MDCache::check_memory_usage into its only caller (the upkeep thread)
where it was also doing a recall. That's just a matter of merging the
recall flags. This has the added benefit of making
MDCache::check_memory_usage callable for all MDS daemons regardless of
state.

Fixes: https://tracker.ceph.com/issues/50048
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2021-04-06 07:10:55 -07:00
Patrick Donnelly
5a9d6c080d
mds: remove extra heap release
We now regularly do this unconditionally in the MDS, see the upkeep
thread.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2021-04-06 07:10:55 -07:00
Kefu Chai
39a23d9cd5
Merge pull request #40615 from tchaikov/wip-doc-header-css
doc/_themes: fix the styling of section header

Reviewed-by: Sebastian Wagner <swagner@suse.com>
2021-04-06 22:04:54 +08:00
Kefu Chai
bd6f810a81 doc/_themes: fix the styling of section header and list items
in the latest document generated from RtD, the section headers are now
in <section> tags instead of <div class="section">, so update the css
accordingly.

also tweak the style of the list items in unordered list to be the same
as it was.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-04-06 21:38:01 +08:00
Kefu Chai
90a79647fb
Merge pull request #40587 from tchaikov/wip-addr-parse-cleanup
src: use entity_addr_t::parse(string_view) when possible

Reviewed-by: Sage Weil <sage@redhat.com>
2021-04-06 20:47:17 +08:00
Ernesto Puerta
2c2a397f84
mgr/dashboard: debug nodeenv hangs
Increase verbosity in nodeenv command for debugging purposes.

Fixes: https://tracker.ceph.com/issues/50044
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
2021-04-06 13:45:15 +02:00
Varsha Rao
08f1d906c2 doc/cephfs/nfs: add user id, fs name and key to FSAL block
Fixes: https://tracker.ceph.com/issues/50161
Signed-off-by: Varsha Rao <varao@redhat.com>
2021-04-06 15:52:04 +05:30
Kefu Chai
c0f7225687 common/buffer.cc: use shift_round_up() when appropriate
Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-04-06 16:08:25 +08:00
Xiubo Li
c160e972ab qa: retry cloning the ceph.git
The cloning may take a very long time, 2.5 hours for example, usally
it should be done in server minutes. If it really very slow, there
maybe something wrong with the current socket connections, retry it
maybe fixed.

This fixing will timeout the clone command after 30m, and retry it
by doubling the timeout value.

Fixes: https://tracker.ceph.com/issues/50021
Signed-off-by: Xiubo Li <xiubli@redhat.com>
2021-04-06 16:02:45 +08:00
Yuval Lifshitz
21b4f5aaf8 rgw/notification: set correct type to "post" and "copy" notifications
Fixes: https://tracker.ceph.com/issues/49799

Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
2021-04-06 11:01:18 +03:00
Kefu Chai
80c4a1cd37 common: disable journald logging backend if struct msghdr is not found
* cmake/modules/CephChecks.cmake: detect the existence of struct msghdr,
  define HAVE_MSGHDR if it is found
* src/common/CMakeLists.txt: do not compile journald.cc if HAVE_MSGHDR
  is FALSE. as in that case, we cannot use sendmsg() to write to
  journald unix domain socket
* src/test/CMakeLists.txt, src/test/common/CMakeLists.txt: disable test
  exercising journald logging backend if HAVE_MSGHDR is not defined
* src/common/Journald.h: define a dummy JournaldLogger and a dummy
  JournaldClusterLogger when HAVE_MSGHDR is not defined, in order to
  minimize the change in Log.h and Log.cc, otherwise the source code of
  Log.h and Log.cc would be segmented into smaller chunks by
  `ifdef HAVE_MSGHDR` macros.
* src/include/config-h.in.cmake: define a new macro named
  HAVE_MSGHDR.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-04-06 14:46:33 +08:00
Jos Collin
96c7e07799
cephfs-top: fix typo in help
Signed-off-by: Jos Collin <jcollin@redhat.com>
2021-04-06 12:08:25 +05:30
Kefu Chai
9f94d27752
Merge pull request #40582 from a16bitsysop/32bit
src/common/buffer.cc: change cast to static_cast

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-04-06 14:35:18 +08:00
Kefu Chai
8c37039c95
Merge pull request #40578 from tchaikov/wip-cmake-pmem
cmake: require libpmem 1.7 and cleanups

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2021-04-06 14:31:51 +08:00
Kefu Chai
4ae1ab90fe
Merge pull request #40572 from athanatos/sjust/wip-48613
osd/PeeringState: fix acting_set_writeable min_size check

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2021-04-06 14:30:20 +08:00
Kefu Chai
57ab82be38
Merge pull request #40475 from tchaikov/wip-qa-focal
qa/tests: replaced ubuntu_latest.yaml with ubuntu 20.04

Reviewed-by: Yuri Weinstein <yweins@redhat.com>
2021-04-06 14:28:42 +08:00
Kefu Chai
38946dab0d
Merge pull request #40591 from tchaikov/wip-dencoder
tools/ceph-dencoder: link against libtcmalloc

Reviewed-by: Willem Jan Withagen <wjw@digiware.nl>
Reviewed-by: Sage Weil <sage@redhat.com>
2021-04-06 10:31:07 +08:00
Samuel Just
642a1c1654 osd/PeeringState: fix acting_set_writeable min_size check
acting.size() >= pool.info.min_size is meant to check min_size against
acting set participants, but acting is a vector with placeholders.
actingset is the representation with placeholders removed.

The upshot of this bug is that the activation process will basically
ignore min_size for an ec pool allowing writes in cases where it
shouldn't.  PastIntervals::check_new_interval, however, performs
the check correctly, and will therefore discount intervals in which
we really did serve writes as not writeable.  This can trigger many
different problem conditions including but not limited to:
  - Unfound objects due to accepting a last_update with insufficient
    osds
  - Lost writes
  - Crashes due to peering rules being violated

This bug was originally introduced with recovery below min_size in
e5a96fd, and then preserved through refactors in 749a13d and 95bec9.

7cb818a exposed it with with expansion of recovery below min_size
to include ec pools (acting.size() is sufficient for replicated
pools).

Fixes: https://tracker.ceph.com/issues/48613
Fixes: https://tracker.ceph.com/issues/48417
Signed-off-by: Samuel Just <sjust@redhat.com>
2021-04-05 17:43:18 -07:00
Sage Weil
0f1aa79a4a Merge PR #40599 into master
* refs/pull/40599/head:
	rpm: add missing % in %dir directive

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-04-05 16:50:23 -04:00
Sage Weil
917a9c49e5 qa/distros/podman: preserve registries.conf
Otherwise we'll lose the mirror configuration.

Signed-off-by: Sage Weil <sage@newdream.net>
2021-04-05 13:49:18 -05:00
Yuval Lifshitz
bede749630
Merge pull request #40598 from TRYTOBE8TME/wip-rgw-kafka-tests-fix
src/rgw: Issue #50138 fix
2021-04-05 21:30:40 +03:00
Sage Weil
94df762447 qa/tasks/ceph.conf: shorten cephx TTL for testing
Rotate tickets frequently to exercise those code paths during testing.

Signed-off-by: Sage Weil <sage@newdream.net>
2021-04-05 13:19:57 -05:00
Sage Weil
ee2e6e715e Merge PR #40025 into master
* refs/pull/40025/head:
	cephadm: use split cgroup strategy for podman
	cephadm: use class to represent container engine

Reviewed-by: Adam King <adking@redhat.com>
2021-04-05 14:14:31 -04:00
Sage Weil
6200ba4139 Merge PR #40459 into master
* refs/pull/40459/head:
	mgr/cephadm: don't cleanup the daemon keyring on failed redeploy

Reviewed-by: Adam King <adking@redhat.com>
2021-04-05 14:14:22 -04:00
Sage Weil
91eb165167 Merge PR #40508 into master
* refs/pull/40508/head:
	mgr/cephadm: fix orch host add with multiple labels and no addr

Reviewed-by: Sage Weil <sage@redhat.com>
2021-04-05 14:14:12 -04:00
Casey Bodley
b1830e43d2 qa/rgw: move ignore-pg-availability.yaml out of suites/rgw
this was added in https://github.com/ceph/ceph/pull/39820 to
avoid repeating the override in rgw subsuites, but teuthology
was picking up suites/rgw/ignore-pg-availability.yaml as a job
of its own, and led to 'list index out of range' failures

Fixes: https://tracker.ceph.com/issues/50147

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2021-04-05 13:09:52 -04:00
Sage Weil
05b3ce2585 qa/tasks/cephadm: add apply() method/task
Signed-off-by: Sage Weil <sage@newdream.net>
2021-04-05 11:44:22 -05:00
root
903b941742 rgw/test: stop kafka consumer if tests fails
This PR fixes https://tracker.ceph.com/issues/50138 by stopping the kafka consumer if the test fails.

Signed-off-by: Kalpesh Pandya <kapandya@redhat.com>
2021-04-05 21:14:17 +05:30
Nathan Cutler
404f8b2ce2 rpm: add missing % in %dir directive
de6c8250a6 added an explicit %dir directive for
a new directory added to the ceph-common package, but -- due to a typo --
neglected to include the "%". As a result, RPM builds started to fail with:

Processing files: ceph-common-17.0.0-2787.gde6c8250.el8.x86_64
error: File must begin with "/": {_libdir}/ceph/denc/

RPM build errors:
    File must begin with "/": {_libdir}/ceph/denc/

Fixes: de6c8250a6
Signed-off-by: Nathan Cutler <ncutler@suse.com>
2021-04-05 17:30:04 +02:00
Kefu Chai
b9e0d4b8b3
Merge pull request #40584 from smithfarm/wip-denc-fix
rpm: make ceph-common own the new denc directory

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-04-05 23:09:14 +08:00
Yuval Lifshitz
d9b3fd3b01
Merge pull request #40585 from yuvalif/wip-yuval-fix-50135
rgw/multisite: handle case when empty marker is provided
2021-04-05 18:04:00 +03:00
Kefu Chai
9ef8055175
Merge pull request #39738 from SMIL-Infra/journald
common: enable log to journald

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2021-04-05 23:01:27 +08:00
Sage Weil
8091bfda76 cephadm: pass '-i' to docker|podman run for shell|enter
This allows us to pipe things to stdin.

Signed-off-by: Sage Weil <sage@newdream.net>
2021-04-05 09:48:24 -05:00
Kefu Chai
b27230551b cmake: remove created directory when "clean" target is run
Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-04-05 22:34:56 +08:00
Kefu Chai
d2c0f56b92
Merge pull request #40579 from tchaikov/wip-mgr-typing
pybind/mgr/mgr_util: fix typing annotation

Reviewed-by: Sage Weil <sage@redhat.com>
2021-04-05 21:29:13 +08:00
Sage Weil
d49bc22a10 Merge PR #40500 into master
* refs/pull/40500/head:
	doc/cephadm: remove keepalived_user from haproxy docs

Reviewed-by: Juan Miguel Olmo <jolmomar@redhat.com>
Reviewed-by: Adam King <adking@redhat.com>
2021-04-05 09:16:34 -04:00
Kefu Chai
37a015a9ed cmake: dedup components when finding pmem
otherwise we always find libpmem twice if libpmem is explicitly
specified when find_package()

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-04-05 17:33:10 +08:00
Kefu Chai
6978584e99 cmake: find pmem once instead twice
less noise in cmake output

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-04-05 17:33:09 +08:00
Kefu Chai
195d1e8c8e tools/ceph-dencoder: print human-readable error message
if $CEPH_LIB is not specified.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-04-05 16:30:05 +08:00
Kefu Chai
2365f265b1 tools/ceph-dencoder: link against libtcmalloc
to address the failure like

src/tcmalloc.cc:332] Attempt to free invalid pointer 0x5627da496130
Aborted

we need to link and load libtcmalloc before it is loaded by a shared
library, otherwise the memory chunk allocated by libc will be freed
by tcmalloc after it is loaded.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-04-05 16:30:04 +08:00
Kefu Chai
89121189ac cmake,install-deps,make-dist: use boost 1.75
so we can use the latest boost

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-04-05 15:09:29 +08:00