mirror of
https://github.com/prometheus/prometheus
synced 2024-12-29 10:12:26 +00:00
aa82fe198f
So far, `ValidateHistogram` would not detect if the count did not include the count in the zero bucket. This commit fixes the problem and updates all the tests that have been undetected offenders so far. Note that this problem would only ever create false negatives, so we never falsely rejected to store a histogram because of it. On the other hand, `ValidateFloatHistogram` has been to strict with the count being at least as large as the sum of the counts in all the buckets. Float precision issues could create false positives here, see products of PromQL evaluations, it's actually quite hard to put an upper limit no the floating point imprecision. Users could produce the weirdest expressions, maxing out float precision problems. Therefore, this commit simply removes that particular check from `ValidateFloatHistogram`. Signed-off-by: beorn7 <beorn@grafana.com> |
||
|---|---|---|
| .. | ||
| fuzz-data | ||
| parser | ||
| testdata | ||
| bench_test.go | ||
| engine_test.go | ||
| engine.go | ||
| functions_test.go | ||
| functions.go | ||
| fuzz_test.go | ||
| fuzz.go | ||
| promql_test.go | ||
| quantile.go | ||
| query_logger_test.go | ||
| query_logger.go | ||
| test_test.go | ||
| test.go | ||
| value_test.go | ||
| value.go | ||