李国忠
40dd13b074
Storage concurrently ( #6770 )
...
* Storage concurrently
Signed-off-by: fuling <fuling.lgz@alibaba-inc.com>
2020-02-11 17:19:34 +00:00
Boyko
1c321ed047
React-UI: flex-wrap the content ( #6796 )
...
* flex-wrap the content
Signed-off-by: blalov <boiskila@gmail.com>
* wrap formatted series in a div
Signed-off-by: blalov <boiskila@gmail.com>
2020-02-11 15:25:39 +01:00
Nguyen Hai Truong
26574eb04d
docs: Fix typo in docs/storage.md ( #6799 )
...
`availiablity` -> `availability`
Signed-off-by: Nguyen Hai Truong <truongnh@vn.fujitsu.com>
2020-02-10 18:32:58 +00:00
Bartlomiej Plotka
916e66edf2
Merge pull request #6773 from codesome/head-test
...
Refactor TestGCChunkAccess and TestGCSeriesAccess to create chunks by appending samples
2020-02-10 10:53:02 +00:00
helenxu1221
7df4fe3faa
reset counter after collecting metric ( #6798 )
...
Signed-off-by: HelenXu <helenxu@Helens-MacBook-Pro.local>
2020-02-09 20:51:21 -07:00
Julien Pivotto
ff0003e072
Make lookbackDelta a option of QueryEngine ( #6746 )
...
* Make lookbackDelta a option of QueryEngine
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
* julius' suggestion
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
* remove trivial getter
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
* Assume lookback delta is always > 0
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
* add debug log
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
* don't expose loopback delta
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
* Specify that lookack delta is also used in federation
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
* Fix federation test
While we have added some logic to the promql engine to keep it backwards
compatible and have a 5 minute loopback by default, the web/ package is
likely to really be internal to Prometheus and we should not add the
same kind of heuritstics here.
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
* loopback delta: Fix debug log
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
2020-02-10 00:58:23 +01:00
Drumil Patel
b00023344e
Formatting short tables for readability ( #6762 )
...
* Formatting short tables for readability
Signed-off-by: Drumil Patel <drumilpatel720@gmail.com>
* Solving linting issues in DataTable.tsx
Signed-off-by: Drumil Patel <drumilpatel720@gmail.com>
* Increasing maxFormattable Size to 1000 and changing value of toFormatStyle
Signed-off-by: Drumil Patel <drumilpatel720@gmail.com>
* Solve tests failure for multiple alerts on size gretaer than 10000
Signed-off-by: Drumil Patel <drumilpatel720@gmail.com>
* Solve linting errors
Signed-off-by: Drumil Patel <drumilpatel720@gmail.com>
* Add tests for alert of not formatting
Signed-off-by: Drumil Patel <drumilpatel720@gmail.com>
2020-02-10 00:11:57 +01:00
Julius Volz
0a8acb654e
React UI: Use null value for determining consoles link display ( #6790 )
...
Signed-off-by: Julius Volz <julius.volz@gmail.com>
2020-02-09 13:39:44 +01:00
Drumil Patel
687a962bd1
Add conditional rendering of Navlink for Consoles ( #6761 )
...
* Add conditional rendering of Navlink for Consoles
Signed-off-by: Drumil Patel <drumilpatel720@gmail.com>
* Replacing if else with only if conditional rendering
Signed-off-by: Drumil Patel <drumilpatel720@gmail.com>
* Add tests and removing global declaration in Navbar
Signed-off-by: Drumil Patel <drumilpatel720@gmail.com>
* Correct Navbar Testcases and add types for ConsolesLink
Signed-off-by: Drumil Patel <drumilpatel720@gmail.com>
* Change names for Console link as per-naming convention
Signed-off-by: Drumil Patel <drumilpatel720@gmail.com>
* Change prop names to AppProps and NavbarProps respectively
Signed-off-by: Drumil Patel <drumilpatel720@gmail.com>
2020-02-08 11:00:47 +01:00
Andrew Hayworth
a336908678
Adds link to valid metric names ( #6774 )
...
One of our users today asked us if dashes were allowed in recording rule names.
We asserted that they were not, but also that we could not remember for certain.
After determining empirically that they are _not_ allowed, I realized that the
documentation could be slightly clearer about valid rule names.
This PR simply adds a note to the documentation re-iterating that the rules must
be valid metric names - and more importantly, adds a link to where a user can
read what those *are*, in case they were not aware (or did not know where to find it).
Signed-off-by: Andrew Hayworth <ahayworth@gmail.com>
2020-02-07 07:32:15 +00:00
Ben Ye
1a18594176
keep kubernetes metrics in global vars ( #6765 )
...
Signed-off-by: yeya24 <yb532204897@gmail.com>
2020-02-06 15:52:57 +00:00
Ganesh Vernekar
bc6fd96979
Refactor TestGCChunkAccess and TestGCSeriesAccess to create chunks by appending samples
...
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
2020-02-06 18:26:18 +05:30
Bartlomiej Plotka
641676b397
Merge pull request #6687 from pracucci/reduce-tsdb-head-inuse-memory
...
Trim TSDB head chunks after being cut, to reduce inuse memory
2020-02-06 10:55:33 +00:00
Ben Ye
60527de355
keep consul service metrics in global variables ( #6764 )
...
Signed-off-by: yeya24 <yb532204897@gmail.com>
2020-02-06 05:48:58 +00:00
Ganesh Vernekar
0a27df92f0
Refactor tsdb/chunks/chunks.go for future PRs ( #6754 )
...
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
2020-02-05 19:09:40 +05:30
Ganesh Vernekar
56bf0ee4dc
Add OpenMmapFileWithSize method ( #6753 )
...
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
2020-02-05 19:08:30 +05:30
Bartlomiej Plotka
49f8850a3c
Merge pull request #6756 from simonpasquier/revert-6605
...
Revert "Add armv6 docker image (#6605 )"
2020-02-05 13:16:30 +00:00
Simon Pasquier
3297ae2169
Revert "Add armv6 docker image ( #6605 )"
...
This reverts commit 6ba8565619c7d97478a6012ad2410126ab5ce377.
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
2020-02-05 14:13:14 +01:00
Marco Pracucci
699f3e8f4d
Added comments to the Chunk interface
...
Signed-off-by: Marco Pracucci <marco@pracucci.com>
2020-02-05 13:07:41 +01:00
Marco Pracucci
0703dae7cc
Compact TSDB head chunks after being cut, to reduce inuse memory
...
Signed-off-by: Marco Pracucci <marco@pracucci.com>
2020-02-05 13:00:39 +01:00
Ben Ye
492414542e
fix matcher for regex ( #6540 )
...
Signed-off-by: yeya24 <yb532204897@gmail.com>
2020-02-05 10:53:12 +00:00
Mark Hansen
6ba8565619
Add armv6 docker image ( #6605 )
...
This follows the approach used to generate armv7 images.
It was all so nicely factored already that I just had to update two
parts of the code.
Signed-off-by: Mark Hansen <mark@markhansen.co.nz>
2020-02-05 09:16:52 +01:00
Robert Fratto
a53e00f9fd
pass registerer from storage to queue manager for its metrics ( #6728 )
...
* pass registerer from storage to queue manager for its metrics
Signed-off-by: Robert Fratto <robert.fratto@grafana.com>
2020-02-03 13:47:03 -08:00
Boyko
8c2bc2f57a
Unify react fetcher components ( #6629 )
...
* set useFetch loading flag to be true initially
Signed-off-by: blalov <boiskila@gmail.com>
* make extended props optional
Signed-off-by: blalov <boiskila@gmail.com>
* add status indicator to targets page
Signed-off-by: blalov <boiskila@gmail.com>
* add status indicator to tsdb status page
Signed-off-by: blalov <boiskila@gmail.com>
* spread response in Alerts
Signed-off-by: blalov <boiskila@gmail.com>
* disable eslint func retun type rule
Signed-off-by: blalov <boiskila@gmail.com>
* add status indicator to Service Discovery page
Signed-off-by: blalov <boiskila@gmail.com>
* refactor PanelList
Signed-off-by: blalov <boiskila@gmail.com>
* test fix
Signed-off-by: blalov <boiskila@gmail.com>
* use local storage hook in PanelList
Signed-off-by: blalov <boiskila@gmail.com>
* use 'useFetch' for fetching metrics
Signed-off-by: blalov <boiskila@gmail.com>
* left-overs
Signed-off-by: blalov <boiskila@gmail.com>
* remove targets page custom error message
Signed-off-by: Boyko Lalov <boiskila@gmail.com>
* adding components displayName
Signed-off-by: Boyko Lalov <boiskila@gmail.com>
* display more user friendly error messages
Signed-off-by: Boyko Lalov <boiskila@gmail.com>
* update status page snapshot
Signed-off-by: Boyko Lalov <boiskila@gmail.com>
* pr review changes
Signed-off-by: Boyko Lalov <boiskila@gmail.com>
* fix broken tests
Signed-off-by: Boyko Lalov <boiskila@gmail.com>
* fix typos
Signed-off-by: Boyko Lalov <boiskila@gmail.com>
2020-02-03 15:14:25 +01:00
Dustin Hooten
820d7775eb
Escape invalid css selector characters in tooltip ID ( #6737 )
...
* Escape invalid css selector characters in tooltip ID
Signed-off-by: Dustin Hooten <dhooten@splunk.com>
* Use CSS.escape polyfill to escape characters
Signed-off-by: Dustin Hooten <dhooten@splunk.com>
2020-02-02 10:51:33 +01:00
Julien Pivotto
0e912faf4f
rules: Cleanup unused function alert.Duration ( #6734 )
...
The function HoldDuration and Duration did the exact same thing.
Let's only keep HoldDuration() as Duration() is more confusing.
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
2020-02-01 07:31:37 +00:00
Callum Styan
bdcfebdf74
Revert "cut v2.16.0 rc.0 pre-release ( #6729 )" ( #6735 )
...
This reverts commit 15a7753d6e
2020-01-31 14:36:59 -08:00
Callum Styan
15a7753d6e
cut v2.16.0 rc.0 pre-release ( #6729 )
...
* Cut 2.16.0-rc.0 release
Signed-off-by: Callum Styan <callumstyan@gmail.com>
2020-01-31 14:35:00 -08:00
LongKB
1ebcf3d5e4
Fix some typo in comments ( #6730 )
...
Signed-off-by: Kim Bao Long <longkb@vn.fujitsu.com>
2020-01-31 12:11:52 +05:30
Julien Pivotto
3c4c01eae2
Fix race in Query Log Test ( #6727 )
...
A data race can happen if we run t.Log after the test t is done -- which
in this case is highly possible because of the use of subtests and the
fact that we call t.Log in a goroutine.
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
2020-01-30 13:51:18 -08:00
Callum Styan
83601202d9
Add missing param to NewHead call in test. ( #6725 )
...
Signed-off-by: Callum Styan <callumstyan@gmail.com>
2020-01-30 11:45:14 -08:00
Peter Štibraný
08c5549055
Document that NewMergeSeriesSet expects individual sets to be sorted. ( #6718 )
...
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
2020-01-30 19:30:32 +05:30
Thor
17d8c49919
made stripe size configurable ( #6644 )
...
Signed-off-by: Thor <thansen@digitalocean.com>
2020-01-30 12:42:43 +05:30
Julien Pivotto
9c67fce6e0
Scrape: test samples_post_metric_relabeling when metrics are dropped ( #6720 )
...
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
2020-01-29 17:47:36 +00:00
Bartlomiej Plotka
ad1518c629
Merge pull request #6683 from roidelapluie/issue
...
Update issue templates
2020-01-29 13:35:46 +00:00
Hrishikesh Barman
03b4f58f33
Updated contexts for GitHub actions Status updates. ( #6709 )
...
Signed-off-by: Hrishikesh Barman <plain.hrishikeshbman@gmail.com>
2020-01-29 14:51:35 +02:00
Julien Pivotto
f82d55e79f
Refactor and simplify rule_group_interval_seconds ( #6711 )
...
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
2020-01-29 11:26:08 +00:00
gotjosh
8b49c9285d
scrape: Add metrics to track bytes and entries in the metadata cache ( #6675 )
...
Signed-off-by: gotjosh <josue@grafana.com>
2020-01-29 11:13:18 +00:00
Julien Pivotto
9adad8ad30
Remove MaxConcurrent from the PromQL engine opts ( #6712 )
...
Since we use ActiveQueryTracker to check for concurrency in
d992c36b3a
2020-01-28 20:38:49 +00:00
Brian Brazil
540dc7dfb0
Merge pull request #6651 from prometheus/sort-block
...
Don't sort postings if we only have one block.
2020-01-28 14:52:07 +00:00
Brian Brazil
61262159c4
Simplify benchmark given the new API
...
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
2020-01-28 14:38:09 +00:00
Boyko
41071278b6
Change old UI link to React App to point to graph page ( #6697 )
...
* change the link to React App to point to graph page
Signed-off-by: blalov <boiskila@gmail.com>
* add search params to classic UI link
Signed-off-by: blalov <boiskila@gmail.com>
* lint fix
Signed-off-by: blalov <boiskila@gmail.com>
* remove navLink onclick
Signed-off-by: blalov <boiskila@gmail.com>
* remove left-over
Signed-off-by: blalov <boiskila@gmail.com>
* remove pkg files
Signed-off-by: blalov <boiskila@gmail.com>
* delete .vscode
Signed-off-by: Boyko Lalov <boiskila@gmail.com>
2020-01-28 14:04:56 +01:00
Brian Brazil
38d32e0686
Don't sort postings if we only have one block.
...
Sorting the heads postings can be quite slow.
We only need sorted series when merging with another
querier, so only sort then.
This will make big queries that only touch the head faster,
though queries that touch both the head and a block will still
be the same speed. This probably won't help much with graphing
unless the range is under an hour, however it should make most
recording rules faster.
Add gaurantee that remote read streaming produces sorted series.
PromQL benchmarks for histograms show only 2-3% improvement, but
they're only over 1k series.
benchmark old ns/op new ns/op delta
BenchmarkQuerierSelect/Head/1of1000000-4 1375486282 507657736 -63.09%
BenchmarkQuerierSelect/Head/10of1000000-4 1387859004 507769850 -63.41%
BenchmarkQuerierSelect/Head/100of1000000-4 1387087935 506029110 -63.52%
BenchmarkQuerierSelect/Head/1000of1000000-4 1386869064 504521986 -63.62%
BenchmarkQuerierSelect/Head/10000of1000000-4 1386213685 505210422 -63.55%
BenchmarkQuerierSelect/Head/100000of1000000-4 1392754988 529842406 -61.96%
BenchmarkQuerierSelect/Head/1000000of1000000-4 1569414722 725059506 -53.80%
BenchmarkQuerierSelect/SortedHead/1of1000000-4 1381019902 1370495863 -0.76%
BenchmarkQuerierSelect/SortedHead/10of1000000-4 1375696209 1366789468 -0.65%
BenchmarkQuerierSelect/SortedHead/100of1000000-4 1386009422 1364519297 -1.55%
BenchmarkQuerierSelect/SortedHead/1000of1000000-4 1377700532 1364486191 -0.96%
BenchmarkQuerierSelect/SortedHead/10000of1000000-4 1383539536 1369545314 -1.01%
BenchmarkQuerierSelect/SortedHead/100000of1000000-4 1410089163 1394731339 -1.09%
BenchmarkQuerierSelect/SortedHead/1000000of1000000-4 1634744148 1581554956 -3.25%
BenchmarkQuerierSelect/Block/1of1000000-4 881741242 879839470 -0.22%
BenchmarkQuerierSelect/Block/10of1000000-4 880381562 882846038 +0.28%
BenchmarkQuerierSelect/Block/100of1000000-4 887519357 881016916 -0.73%
BenchmarkQuerierSelect/Block/1000of1000000-4 902194205 883433524 -2.08%
BenchmarkQuerierSelect/Block/10000of1000000-4 892321964 885130170 -0.81%
BenchmarkQuerierSelect/Block/100000of1000000-4 938604466 933527150 -0.54%
BenchmarkQuerierSelect/Block/1000000of1000000-4 1313510845 1295881124 -1.34%
benchmark old allocs new allocs delta
BenchmarkQuerierSelect/Head/1of1000000-4 4000056 4000018 -0.00%
BenchmarkQuerierSelect/Head/10of1000000-4 4000074 4000036 -0.00%
BenchmarkQuerierSelect/Head/100of1000000-4 4000254 4000216 -0.00%
BenchmarkQuerierSelect/Head/1000of1000000-4 4002054 4002016 -0.00%
BenchmarkQuerierSelect/Head/10000of1000000-4 4020054 4020016 -0.00%
BenchmarkQuerierSelect/Head/100000of1000000-4 4200054 4200016 -0.00%
BenchmarkQuerierSelect/Head/1000000of1000000-4 6000054 6000016 -0.00%
BenchmarkQuerierSelect/SortedHead/1of1000000-4 4000071 4000071 +0.00%
BenchmarkQuerierSelect/SortedHead/10of1000000-4 4000089 4000089 +0.00%
BenchmarkQuerierSelect/SortedHead/100of1000000-4 4000269 4000269 +0.00%
BenchmarkQuerierSelect/SortedHead/1000of1000000-4 4002069 4002069 +0.00%
BenchmarkQuerierSelect/SortedHead/10000of1000000-4 4020069 4020069 +0.00%
BenchmarkQuerierSelect/SortedHead/100000of1000000-4 4200069 4200069 +0.00%
BenchmarkQuerierSelect/SortedHead/1000000of1000000-4 6000069 6000069 +0.00%
BenchmarkQuerierSelect/Block/1of1000000-4 6000023 6000022 -0.00%
BenchmarkQuerierSelect/Block/10of1000000-4 6000059 6000058 -0.00%
BenchmarkQuerierSelect/Block/100of1000000-4 6000419 6000418 -0.00%
BenchmarkQuerierSelect/Block/1000of1000000-4 6004019 6004018 -0.00%
BenchmarkQuerierSelect/Block/10000of1000000-4 6040019 6040018 -0.00%
BenchmarkQuerierSelect/Block/100000of1000000-4 6400019 6400018 -0.00%
BenchmarkQuerierSelect/Block/1000000of1000000-4 10000020 10000019 -0.00%
benchmark old bytes new bytes delta
BenchmarkQuerierSelect/Head/1of1000000-4 229192200 176001176 -23.21%
BenchmarkQuerierSelect/Head/10of1000000-4 229193352 176002328 -23.21%
BenchmarkQuerierSelect/Head/100of1000000-4 229204872 176013848 -23.21%
BenchmarkQuerierSelect/Head/1000of1000000-4 229320072 176129048 -23.20%
BenchmarkQuerierSelect/Head/10000of1000000-4 230472072 177281048 -23.08%
BenchmarkQuerierSelect/Head/100000of1000000-4 241992072 188801048 -21.98%
BenchmarkQuerierSelect/Head/1000000of1000000-4 357192072 304001048 -14.89%
BenchmarkQuerierSelect/SortedHead/1of1000000-4 229193928 229193928 +0.00%
BenchmarkQuerierSelect/SortedHead/10of1000000-4 229195080 229195080 +0.00%
BenchmarkQuerierSelect/SortedHead/100of1000000-4 229206600 229206600 +0.00%
BenchmarkQuerierSelect/SortedHead/1000of1000000-4 229321800 229321800 +0.00%
BenchmarkQuerierSelect/SortedHead/10000of1000000-4 230473800 230473800 +0.00%
BenchmarkQuerierSelect/SortedHead/100000of1000000-4 241993800 241993800 +0.00%
BenchmarkQuerierSelect/SortedHead/1000000of1000000-4 357193800 357193800 +0.00%
BenchmarkQuerierSelect/Block/1of1000000-4 227201516 227201500 -0.00%
BenchmarkQuerierSelect/Block/10of1000000-4 227202924 227202908 -0.00%
BenchmarkQuerierSelect/Block/100of1000000-4 227217036 227217020 -0.00%
BenchmarkQuerierSelect/Block/1000of1000000-4 227358156 227358140 -0.00%
BenchmarkQuerierSelect/Block/10000of1000000-4 228769356 228769340 -0.00%
BenchmarkQuerierSelect/Block/100000of1000000-4 242881356 242881340 -0.00%
BenchmarkQuerierSelect/Block/1000000of1000000-4 384001616 384001600 -0.00%
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
2020-01-28 09:14:56 +00:00
Brian Brazil
d682731efc
Extend BenchmarkQuerierSelect to use multiple blocks.
...
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
2020-01-28 09:14:56 +00:00
Julien Pivotto
d992c36b3a
promql: make active query tracker context-aware ( #6701 )
...
* promql: make query logger context-aware
* Remove gate
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
2020-01-27 22:29:44 +00:00
Krasimir Georgiev
ddd49b743c
Update README.md
2020-01-27 18:10:08 +02:00
Krasimir Georgiev
cf6144a98f
Update README.md
2020-01-27 18:09:00 +02:00
Hrishikesh Barman
3476555d31
Add Github Actions workflow to run Prombench ( #6703 )
...
* Adding prombench github actions workflow.
Signed-off-by: Hrishikesh Barman <plain.hrishikeshbman@gmail.com>
2020-01-27 18:06:28 +02:00
Anand Singh Kunwar
aa61e392b2
Make remote client Store use passed context ( #6673 )
...
* Remote store client's `Store` API currently doesn't use passed
context, but instead just constructs a new `context.Background()`
Signed-off-by: Anand Singh Kunwar <anandkunwar95@gmail.com>
2020-01-27 07:43:20 -07:00
Julien Pivotto
56ebd5afde
Delete prometheus_rule_group metrics when groups are removed ( #6693 )
...
* Delete prometheus_rule_group metrics when groups are removed
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
2020-01-27 12:41:32 +00:00
