RepoMirrors
/
prometheus
mirror of https://github.com/prometheus/prometheus
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Clarify notify metric descriptions (#2551) 

The implementation of `sendAll` means that we observe latencies even for
notifications that would be considered dropped due to errors when
sending them.

Similarly, we count alerts as 'sent' even if an error occurred when
trying to send them (meaning they are potentially not sent at all).

336c7870ea/notifier/notifier.go (L340-L347)
This commit is contained in:
Matt Bostock 2018-02-19 14:40:49 +00:00 committed by Brian Brazil
parent 2124a436ff
commit f0fd701309
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
notifier/notifier.go
View File

@ -145,7 +145,7 @@ func newAlertMetrics(r prometheus.Registerer, queueCap int, queueLen, alertmanag
Namespace: namespace, Namespace: namespace,
Subsystem: subsystem, Subsystem: subsystem,
Name: "latency_seconds", Name: "latency_seconds",
Help: "Latency quantiles for sending alert notifications (not including dropped notifications).", Help: "Latency quantiles for sending alert notifications.",
}, },
[]string{alertmanagerLabel}, []string{alertmanagerLabel},
), ),
@ -161,7 +161,7 @@ func newAlertMetrics(r prometheus.Registerer, queueCap int, queueLen, alertmanag
Namespace: namespace, Namespace: namespace,
Subsystem: subsystem, Subsystem: subsystem,
Name: "sent_total", Name: "sent_total",
Help: "Total number of alerts successfully sent.", Help: "Total number of alerts sent.",
}, },
[]string{alertmanagerLabel}, []string{alertmanagerLabel},
), ),