From f0fd70130932bf6bcce2a7877524924170f1e9b0 Mon Sep 17 00:00:00 2001 From: Matt Bostock Date: Mon, 19 Feb 2018 14:40:49 +0000 Subject: [PATCH] Clarify notify metric descriptions (#2551) The implementation of `sendAll` means that we observe latencies even for notifications that would be considered dropped due to errors when sending them. Similarly, we count alerts as 'sent' even if an error occurred when trying to send them (meaning they are potentially not sent at all). https://github.com/prometheus/prometheus/blob/336c7870eae2448a9b3509685767e74a1a256bcf/notifier/notifier.go#L340-L347 --- notifier/notifier.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/notifier/notifier.go b/notifier/notifier.go index 94e4c5e7e..1f1dd7cfe 100644 --- a/notifier/notifier.go +++ b/notifier/notifier.go @@ -145,7 +145,7 @@ func newAlertMetrics(r prometheus.Registerer, queueCap int, queueLen, alertmanag Namespace: namespace, Subsystem: subsystem, Name: "latency_seconds", - Help: "Latency quantiles for sending alert notifications (not including dropped notifications).", + Help: "Latency quantiles for sending alert notifications.", }, []string{alertmanagerLabel}, ), @@ -161,7 +161,7 @@ func newAlertMetrics(r prometheus.Registerer, queueCap int, queueLen, alertmanag Namespace: namespace, Subsystem: subsystem, Name: "sent_total", - Help: "Total number of alerts successfully sent.", + Help: "Total number of alerts sent.", }, []string{alertmanagerLabel}, ),