RepoMirrors
/
prometheus
mirror of https://github.com/prometheus/prometheus
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Correct notifications_dropped description 

The current description does not accurately describe when the metric is incremented.

Aside from Alertmanger missing from the configuration, `prometheus_notifications_dropped_total` is incremented when errors occur while sending alert notifications to Alertmanager, or because the notifications queue is full, or because the number of notifications to be sent exceeds the queue capacity.

I think calling these cases 'errors' in a generic sense is more useful than the current description.
This commit is contained in:
Matt Bostock 2017-01-13 23:36:00 +00:00 committed by GitHub
parent f64c231dad
commit 4160892109
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
notifier/notifier.go
View File

@ -118,7 +118,7 @@ func New(o *Options) *Notifier {
Namespace: namespace, Namespace: namespace,
Subsystem: subsystem, Subsystem: subsystem,
Name: "dropped_total", Name: "dropped_total",
Help: "Total number of alerts dropped due to alert manager missing in configuration.", Help: "Total number of alerts dropped due to errors when sending to Alertmanager.",
}), }),
queueLength: prometheus.NewGauge(prometheus.GaugeOpts{ queueLength: prometheus.NewGauge(prometheus.GaugeOpts{
Namespace: namespace, Namespace: namespace,