From 4160892109c12913083da0895cb21aa97fe097cb Mon Sep 17 00:00:00 2001 From: Matt Bostock Date: Fri, 13 Jan 2017 23:36:00 +0000 Subject: [PATCH] Correct notifications_dropped description The current description does not accurately describe when the metric is incremented. Aside from Alertmanger missing from the configuration, `prometheus_notifications_dropped_total` is incremented when errors occur while sending alert notifications to Alertmanager, or because the notifications queue is full, or because the number of notifications to be sent exceeds the queue capacity. I think calling these cases 'errors' in a generic sense is more useful than the current description. --- notifier/notifier.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/notifier/notifier.go b/notifier/notifier.go index 5cee01eac..b896d53a4 100644 --- a/notifier/notifier.go +++ b/notifier/notifier.go @@ -118,7 +118,7 @@ func New(o *Options) *Notifier { Namespace: namespace, Subsystem: subsystem, Name: "dropped_total", - Help: "Total number of alerts dropped due to alert manager missing in configuration.", + Help: "Total number of alerts dropped due to errors when sending to Alertmanager.", }), queueLength: prometheus.NewGauge(prometheus.GaugeOpts{ Namespace: namespace,