osu/osu.Game.Rulesets.Catch
Bartłomiej Dach a3b8493751
Remove rounding of slider velocity multiplier on juice streams
Compare: https://github.com/ppy/osu/pull/26616

This came up elsewhere, namely in
https://github.com/ppy/osu/pull/28277#issuecomment-2133505958.

As it turns out, at least one beatmap among those whose scores had
unexpected changes in total score, namely
https://osu.ppy.sh/beatmapsets/971028#fruits/2062131, was using slider
velocity multipliers that were not a multiple of 0.01 (the specific
value used was 0.225x). This meant that due to the rounding applied to
`SliderVelocityMultiplierBindable` via `Precision`, the raw value was
being incorrectly rounded, resulting in incorrect conversion.

The "direct" change that revealed this is most likely
https://github.com/ppy/osu-framework/pull/6249, by the virtue of
shuffling the `BindableNumber` rounding code around and accidentally
changing midpoint rounding semantics in the process. But it was not
at fault here, as rounding was just as wrong before that change
as after in this specific context.
2024-05-28 13:14:44 +02:00
..
Beatmaps Fix catch hit object position getting randomised when last object has pos=0 2024-03-02 03:18:59 +03:00
Difficulty Fix catch pp calculator not matching live with respect to miss handling 2024-03-04 11:53:59 +01:00
Edit Merge pull request #27723 from 64ArthurAraujo/editor-fix-reverse-selection 2024-03-28 11:25:17 +01:00
Judgements
Mods Adjust "Floating Fruits" in line with layout changes 2024-02-14 01:34:55 +03:00
Objects Remove rounding of slider velocity multiplier on juice streams 2024-05-28 13:14:44 +02:00
Properties
Replays
Scoring Fix banana showers causing fails when hp is at 0 2024-03-20 17:31:33 +09:00
Skinning Remove behaviour of flipping catcher plate on direction change 2024-02-14 07:17:05 +03:00
UI Merge branch 'master' into tcm-resume 2024-03-14 12:22:46 +09:00
CatchInputManager.cs
CatchRuleset.cs Extract preempt durations to shared constants 2023-12-14 20:41:12 +01:00
CatchSkinComponentLookup.cs Remove unused members from GameplaySkinComponentLookup 2024-04-19 18:03:13 +09:00
CatchSkinComponents.cs
osu.Game.Rulesets.Catch.csproj Upgrade to .NET 8 SDK 2024-02-02 21:28:51 +09:00