RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
29,780 Commits 3 Branches 651 Tags 354 MiB
Commit Graph

81 Commits

Author SHA1 Message Date
smoogipoo 10e849d196 Separate into separate class 2020-04-10 02:02:09 +09:00
smoogipoo a2f5a469cf Merge branch 'master' into add-notelock 2020-04-10 01:18:54 +09:00
Dean Herbert fb4b334ce2 Add support for legacy skin sliderstartcircle / sliderstartcircleoverlay 2020-03-28 14:10:26 +09:00
smoogipoo 742698acab Add notelock implementation 2020-03-10 15:30:24 +09:00
Bartłomiej Dach 77fd748035 Fix incorrect circle piece hitbox 
Hitboxes of circle pieces in osu! have regressed with commit 8592335.
The reason for the regression was that hit detection was moved from
DrawableHitCircle itself to a newly-introduced private HitArea class
(now named HitReceptor).

As HitArea inherited from Drawable, it would return IsHovered == true
over its entire bounding box. This meant that the hit area could wrongly
pick up actions that are not within circle radius and make them into
hits.

To resolve, make HitReceptor a CompositeDrawable and set its corner
radius to match the circle piece. This fixes the invalid hitbox, as
IsHovered takes radius into account.
 2020-03-06 21:21:20 +01:00
Bartłomiej Dach 434c0d92e4 Use Bindable{Float,Double}s everywhere 
To avoid further floating-point comparison bugs, remove all usages of
Bindable<{float,double}>, replacing them with their
Bindable<Float,Double> counterparts.
 2020-02-01 22:50:29 +01:00
smoogipoo 7b2f58eb30 Apply OnRelease method signature refactorings 2020-01-22 13:22:34 +09:00
smoogipoo c34d3362df Fix hit circles selection area being too large 2019-10-21 17:14:08 +09:00
smoogipoo 3155a90501 Use bindables for displayed circle piece numbers 2019-09-26 16:58:20 +09:00
Dean Herbert cfdac956c2 Fix issues with colour and skin application 2019-09-18 20:04:49 +09:00
smoogipoo 5c2c055614 Set lifetime on initial state update 2019-09-13 18:49:21 +09:00
Dean Herbert f21e47d6d2 Move expire to DrawableHitObject 2019-09-12 19:29:08 +09:00
Dean Herbert f925e781a9 Refactor HitWindows for legibility 2019-09-06 15:24:14 +09:00
Dean Herbert 05ed9d3802 Merge remote-tracking branch 'upstream/master' into non-timeoffset-judgements 2019-09-03 13:07:58 +09:00
smoogipoo 8302658186 Fix other potential nullref cases that rider missed 2019-09-02 18:31:33 +09:00
Dean Herbert a15828ab25 Introduce the concept of SkinComponents 
Removes reliance on string lookups and better defines elements for introduction into database
 2019-08-30 14:55:52 +09:00
Dean Herbert 9752dbf950 Fix osu! approach circles fading in too late 2019-08-28 18:10:58 +09:00
Dean Herbert e6bd02d276 Simplify namespace definition 2019-07-30 22:41:20 +09:00
Dean Herbert 766cf9295d Merge remote-tracking branch 'upstream/master' into add-legacy-hit-animations 2019-07-29 19:03:36 +09:00
Dean Herbert 53a91b46e0
Fix approach circles not scaling to circle correctly when a ski… (#5455) 
Fix approach circles not scaling to circle correctly when a skin is applied
 2019-07-29 18:47:36 +09:00
Dean Herbert 859233526d Move circle visual implementation to new class 
Allows for more precise skin control over state animations.
 2019-07-25 16:09:20 +09:00
Dean Herbert c989185774 Fix incorrect approach circle scaling 2019-07-25 11:27:24 +09:00
Dean Herbert c16af88299 Start exploding animation earlier (don't wait for flash) 2019-07-25 11:11:26 +09:00
Dean Herbert be170b4124 Naming and documentation improvements 2019-07-22 15:50:02 +09:00
Dean Herbert 8327452fe1 Make AccentColour a bindable 2019-07-22 14:48:59 +09:00
Dean Herbert 612db31c38 Apply newline additions 2019-04-01 12:16:32 +09:00
Dean Herbert 42be7857d1 Use expression body for property get/set where possible 2019-02-28 13:58:19 +09:00
smoogipoo a07d797d75 Merge remote-tracking branch 'Joehuu/master' into use-lifetime-optimization 2019-02-27 12:08:43 +09:00
Dean Herbert 7566fcf536 Slider press fix 2019-02-23 14:14:34 +09:00
Dean Herbert 367bc53a06 Revert some more instances of 'e' variable names 2019-02-22 20:15:25 +09:00
smoogipoo d8c55bc729 Adjust namespaces 2019-02-21 19:05:52 +09:00
smoogipoo bca347427f Update with framework bindable changes 2019-02-21 18:56:34 +09:00
Dean Herbert 810175235d Fix incorrect application of scaling in some cases 
Isolates different usages of hitcircle scale so they can't ever cause regressions.
 2019-02-14 18:47:05 +09:00
ekrctb 504e79b968 Merge branch 'master' into use-lifetime-optimization 2019-01-29 12:15:02 +09:00
Dean Herbert 8617aaa2a7 Update licence header (and remove year) 2019-01-24 17:43:03 +09:00
ekrctb 6f8a2e6ff2 Use LifetimeManagementContainer 
This is a significant performance boost for gameplay,
especially for long or stroyboard-heavy maps.
 2018-12-13 15:23:06 +09:00
smoogipoo f27bd3ef3e OpenTK -> osuTK 2018-11-20 17:14:59 +09:00
smoogipoo cc8531790a Use bindables for hitobject events 2018-11-09 13:58:46 +09:00
smoogipoo 22c545ea8c Make circle piece respond to hitobject scale 2018-10-26 15:26:19 +09:00
smoogipoo 1cd11a6e5b Fix StackHeight changes not causing position updates 2018-10-03 17:06:18 +09:00
Dean Herbert ffcad6e0f1 Merge remote-tracking branch 'upstream/master' into tgi74-hit-shake 
# Conflicts:
#	osu.Game.Rulesets.Osu.Tests/TestCaseHitCircle.cs
#	osu.Game.Rulesets.Osu/Objects/Drawables/DrawableOsuHitObject.cs
#	osu.Game.Rulesets.Osu/Objects/Drawables/Pieces/SliderBall.cs
 2018-08-24 15:26:36 +09:00
smoogipoo 741ec0021e Rename more judgement-related methods to "result" 2018-08-06 11:31:46 +09:00
smoogipoo 2a4994e5ce Make hitobjects only have one judgement + result 2018-08-03 15:38:48 +09:00
smoogipoo 4548d2c87f Make Rulesets.Osu use the new judgement result structure 2018-08-02 20:36:38 +09:00
smoogipoo 462f1033c0 Migrate Rulesets.Osu to the new judgement system 2018-08-02 15:21:23 +09:00
Dean Herbert 79af5cb0a0 Limit shake duration to ensure it doesn't overlap miss window 2018-07-06 17:24:30 +09:00
Dean Herbert aa96d91762 Merge remote-tracking branch 'upstream/master' into tgi74-hit-shake 2018-07-06 11:57:32 +09:00
Dean Herbert 1d6609d9f3 Add common custom words to dotsettings dictionary 
Also fixes some typos and reduces spelling suggestions to hints.
 2018-07-05 15:54:41 +09:00
Dean Herbert cacabeb67e Remove unused field 2018-06-29 17:00:41 +09:00
tgi74000 61c416dc16 Trigger Shake if HitCircles are hit too early 2018-06-28 13:41:23 +02:00