Commit Graph

73 Commits

Author SHA1 Message Date
Salman Ahmed fc63ee43be Fix legacy catcher sprites getting shrunk 2023-10-10 01:26:59 +03:00
Salman Ahmed 0fb7895a52 Adjust catcher origin position to match 1:1 with stable
Change catcher origin position logic to 1:1 match stable on legacy skin
2023-10-10 01:26:59 +03:00
Bartłomiej Dach 0ae4a0f11f
Adjust gameplay element maximum size limits for backwards compatibility
The new limits were chosen by sampling across over 4000 skins. The
methodology for doing so is described in the following gist:

	https://gist.github.com/bdach/6228ba41d128b23d1f89142f404108a3
2023-10-05 20:37:10 +02:00
Salman Ahmed c4fc4199d1 Use correct maximum size for droplets 2023-09-21 19:02:31 +03:00
Dean Herbert 8e16b1d507 Simplify some maximum size specs 2023-09-20 12:48:15 +09:00
Salman Ahmed 291a91be66 Change extension from retrieval to post-processing instead 2023-09-19 03:40:30 +03:00
Salman Ahmed 57dc76b345 Revert "Update `GetTexture` signature rather than creating new overload"
This reverts commit 96f12cfbaa.
2023-09-19 03:21:19 +03:00
Dean Herbert 96f12cfbaa Update `GetTexture` signature rather than creating new overload 2023-09-05 18:01:19 +09:00
Salman Ahmed f182f571cb Add limit to catch palpable object elements 2023-09-03 02:22:58 +03:00
Dean Herbert e0fc97bb93 Replace various local implementations of rewinding checks with new property 2023-07-07 15:21:24 +09:00
Dean Herbert 4be8eede88 Fix combo counter on legacy skins flipping when "Floating Fruits" mod is active
Closes #23989.
2023-06-22 18:46:43 +09:00
Dean Herbert 76f7accd13 Standardise all local `SkinComponentsContainerLookup` variables to `containerLookup` 2023-02-16 15:33:56 +09:00
Dean Herbert a92e42bb84 Rename `SkinnableTargetContainer` to `SkinComponentsContainer`
Also use full `SkinComponentsContainerLookup` instead of the sub-type.
This will potentially be useful once we bring in per-ruleset targets.
2023-02-15 18:37:41 +09:00
Dean Herbert 8bbd00822c Simplify and rename `SkinnableTargetComponentsContainer` 2023-02-15 17:30:21 +09:00
Berkan Diler 335cb0205f Remove now unnecessary using 2022-12-26 22:50:36 +01:00
Berkan Diler c7ca4bbba5 Use generic Enum methods 2022-12-26 20:36:39 +01:00
Dan Balasescu 7bc8908ca9 Partial everything 2022-11-27 00:00:27 +09:00
Dean Herbert 1aa0e40f2f Add "Component" prefix to lookup naming 2022-11-09 17:46:43 +09:00
Dean Herbert e75c3b3f94 Rename `SkinnableTarget` to `GlobalSkinLookup` 2022-11-09 17:46:43 +09:00
Dean Herbert c908969d9b Rename `ISkinComponent` to `ISkinLookup` 2022-11-09 17:46:43 +09:00
Dean Herbert 2952dbc8fb Apply nullability to osu!catch skinning classes 2022-11-09 13:58:58 +09:00
Dean Herbert 8bf4ca4b53 Add legacy skin fallback when beatmap skin is providing resources 2022-10-12 17:47:20 +09:00
Dean Herbert a10fda2843
Merge branch 'master' into catch-combo-hide 2022-10-12 15:00:35 +09:00
Dean Herbert d0b8409de5 Apply more renames 2022-09-18 18:19:00 +09:00
cdwcgt 857e943b8d
hide catchcombo when Hud hide 2022-09-12 19:14:08 +09:00
Nitrous 9088caa377
move `LegacyComboCounter` to `osu.Game.Skinning` 2022-07-28 08:36:26 +08:00
Dan Balasescu f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
Salman Ahmed 61078910a6 Handle all skin component types explicitly 2022-04-23 03:34:05 +03:00
Bartłomiej Dach e042f29ee3
Remove skin ctor param from `LegacyCatchComboCounter`
No longer used since 004798d61d.
2022-02-01 21:49:52 +01:00
Dean Herbert add39fbd4f Merge branch 'master' into fix-skin-layout-editor-crash 2021-10-28 06:24:24 +09:00
Dean Herbert 6944151486 Apply batch fixing of built-in types using `var` 2021-10-27 13:04:41 +09:00
Dean Herbert 93482414d6 Remove `SkinConfiguration` subclasses and allow configuration parsing for all skin types 2021-10-22 14:42:23 +09:00
Bartłomiej Dach b84f238106
Adjust scaling numbers to be closer to stable 2021-08-12 22:33:12 +02:00
Bartłomiej Dach f3045b3152
Add comment about swapped sprite names 2021-08-12 21:48:07 +02:00
Bartłomiej Dach 68f454b51a
Enable NRT in explosion-related classes and streamline null handling 2021-08-12 21:48:07 +02:00
Bartłomiej Dach 2fb19210af
Fix legacy explosion sprites incorrectly showing after skin change 2021-08-11 22:36:27 +02:00
Bartłomiej Dach 4bcbe6ac90
Restructure explosion to ensure proper lifetime bounds 2021-08-11 21:23:34 +02:00
Bartłomiej Dach 8c8a64fe6e
Add legacy hit lighting implementation 2021-08-11 21:23:33 +02:00
ekrctb d247b8042e Fix default skin catcher not flipping catcher plate
When legacy beatmap skin is present but catcher is not provided, it was using the legacy setting (always false).
2021-07-05 20:05:08 +09:00
ekrctb 83c80291d4 Don't flip catcher plate contents in legacy skin 2021-07-02 23:23:21 +09:00
Dean Herbert 1b0aadcc6f Merge branch 'master' into transformers-per-skin 2021-06-22 16:03:15 +09:00
ekrctb df16d4bacc Remove `CurrentTexture` from catcher 2021-06-14 20:26:33 +09:00
Salman Ahmed fbb856d84b Call `base` when overriding lookup methods
Rather than arbitrarily accessing `Skin` here and there.
2021-06-11 12:44:44 +03:00
Salman Ahmed 26cdcc8d78 Remove stale access to `Source` from master merge 2021-06-10 13:07:32 +03:00
Salman Ahmed dde84e5cbd Merge branch 'master' into transformers-per-skin 2021-06-10 11:58:52 +03:00
Dean Herbert 865c5c0676 Use `[Resolved]` to simplify bindable resolution 2021-06-10 15:47:03 +09:00
Dean Herbert 6995945360 Use `With` to simplify drawable construction 2021-06-10 15:45:49 +09:00
Salman Ahmed cf40282f1f Convert `LegacySkinTransformer`s to accept raw `ISkin`s rather than a full `ISkinSource` 2021-06-09 22:49:31 +03:00
ekrctb e5deecf459 Check skin version for legacy catcher sprite 2021-06-09 15:47:23 +09:00
ekrctb 7df971a970 `ICatcherPiece` -> `ICatcherSprite` 2021-06-08 22:10:13 +09:00