RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix default skin catcher not flipping catcher plate 

When legacy beatmap skin is present but catcher is not provided, it was using the legacy setting (always false).
This commit is contained in:
ekrctb 2021-07-05 20:05:08 +09:00
parent 333caca386
commit d247b8042e
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
osu.Game.Rulesets.Catch/Skinning/Legacy/CatchLegacySkinTransformer.cs
View File

@ -108,8 +108,11 @@ public override IBindable<TValue> GetConfig<TLookup, TValue>(TLookup lookup)
switch (config)
{
case CatchSkinConfiguration.FlipCatcherPlate:
// Always return `false` (don't flip catcher plate contents) for a legacy skin.
return (IBindable<TValue>)new Bindable<bool>();
// Don't flip catcher plate contents if the catcher is provided by this legacy skin.
if (GetDrawableComponent(new CatchSkinComponent(CatchSkinComponents.Catcher)) != null)
return (IBindable<TValue>)new Bindable<bool>();
break;
}
break;