RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
53,411 Commits 3 Branches 659 Tags 364 MiB
Commit Graph

572 Commits

Author SHA1 Message Date
Dean Herbert 31a447fda0 Update parameter discards 2022-06-24 21:26:19 +09:00
Bartłomiej Dach 26c5b59f6d
Replace usages of `string.To{Lower,Upper}()` 2022-06-24 11:57:45 +02:00
Dean Herbert bd5037fcad Fix new hitobject placements not taking on the existing sample settings 
Similar to velocity / difficulty points, a user expectation is that
volume and sample settings will be transferred to newly placed objects
from the most recent one.

Closes https://github.com/ppy/osu/issues/18742.
 2022-06-18 13:49:59 +09:00
Dan Balasescu f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
Bartłomiej Dach e511c1dfff
Merge branch 'master' into use-normalised-precise-scrolling 2022-05-27 16:55:13 +02:00
Dean Herbert 17206bbebf Update screen padding and colouring to better match new designs 2022-05-24 18:43:22 +09:00
Susko3 88217e0c98 Adjust `ScrollDelta` usages to account for normalised `IsPrecise` values 2022-05-23 20:22:27 +02:00
Dan Balasescu 64a371638e
Merge pull request #18236 from peppy/snap-unification 
Add `enum` to snap method as alternative to multiple nested invocations
 2022-05-20 11:35:05 +09:00
Dean Herbert b3d6f76cfa Add "None" snap type to fix flags not working correctly 2022-05-19 15:57:17 +09:00
Dean Herbert c63e65c677 Don't hide `SelectionBlueprint`s themselves, only their children 2022-05-12 19:26:13 +09:00
Dean Herbert c0abce918f Add `enum` to snap method as alternative to mutliple nested invocations 2022-05-12 16:19:07 +09:00
Salman Ahmed 144d33f0d2
Merge branch 'master' into distance-snapping-test 2022-05-06 17:29:27 +03:00
Dean Herbert c6bc6be128 Fix toolbox expand being interrupted by gaps between groups 2022-05-06 19:06:40 +09:00
Dean Herbert 5029710de7 Merge branch 'master' into distance-snapping-test 2022-05-05 22:00:40 +09:00
Dan Balasescu 39d10487b9
Merge branch 'master' into snapping-tidy-distance 2022-05-05 19:55:55 +09:00
Dean Herbert e83604a1fc Merge branch 'master' into cache-at-interface 2022-05-05 18:54:24 +09:00
Dean Herbert 7b71fb860b Expose `DistanceSpacingMultiplier` for test usage 2022-05-05 18:49:12 +09:00
Dean Herbert 947a68006a Add note about `IDistanceSnapProvider` not multiplying `DistanceSpacing` itself 2022-05-05 17:50:17 +09:00
Dean Herbert c3d2648f85
Reword weird xmldoc 
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
 2022-05-05 17:07:05 +09:00
Dean Herbert 4226583afd Merge branch 'cache-at-interface' 2022-05-05 16:52:03 +09:00
Dean Herbert 19cf9dc20b Merge branch 'snapping-tidy-distance' 2022-05-05 16:51:32 +09:00
Dean Herbert 5a1ac71d90 Remove unnecessary type specification in `HitObjectComposer`'s caching 2022-05-05 16:44:37 +09:00
Dean Herbert 1c6a233cc0 Move snap provider caching to interfaces 2022-05-05 16:44:37 +09:00
Dean Herbert b411b59006 Move `IPlacementHandler` caching to interface 2022-05-05 16:43:02 +09:00
Dean Herbert 977e6d8a80 Add xmldoc for `IDistanceSnapProvider` and related properties 2022-05-05 16:25:45 +09:00
Dean Herbert 1fce0da331 Reword slightly, to allow better conformity with `IDistanceSnapProvider` 2022-05-05 16:04:34 +09:00
Dean Herbert f6fc926f1a Add xmldoc and rename methods in `IPositionSnapProvider` for legibility 2022-05-05 15:58:21 +09:00
Bartłomiej Dach bf80dd864c
Merge branch 'master' into fix-editor-toolbox-click-through 2022-05-04 11:57:32 +02:00
Dean Herbert 4e0f899159 Rename value changed variable 2022-05-04 18:13:30 +09:00
Salman Ahmed f5d4f02200 Use `ToUpper` for key binding text 2022-05-04 11:59:29 +03:00
Salman Ahmed 0b8fd2e39f Improve distance spacing toast inline with key binding changes 2022-05-04 11:43:19 +03:00
Dean Herbert b325f0ee0b Combine editor toolbox container implementation and fix input blocking 
Until now, toolbox scroll areas would block input from arriving behind
them, even when no visible element was clicked.

In addition, clicking on a button inside a toolbox would still send a
`MouseDown` event to things behind it. Specifically, the editor's
`HitObjectComposer` would receive these events and also place objects
when the user does not expect them to be placed.

This fixes another regression that occurred due to `ScrollContainer`s no
longer blocking input theirselves.
 2022-05-04 17:41:30 +09:00
Salman Ahmed 3d2072498e Merge branch 'master' into distance-spacing-osd 2022-05-04 11:41:12 +03:00
Dean Herbert a66743266f Remove unused `ScrollingToolboxGroup` class 2022-05-04 17:20:58 +09:00
Salman Ahmed 504ca5be31 Fix scrolling no longer adjusting distance spacing by amount 2022-05-04 09:52:33 +03:00
Salman Ahmed 813d6fed48 Split activation keybind to separate increase/decrease keybinds 2022-05-04 09:00:54 +03:00
Salman Ahmed 0dd2e1652c Mark `OnScreenDisplay` dependency as nullable 2022-05-03 11:15:28 +03:00
Salman Ahmed b8287f3687 Display toast notification on editor distance spacing change 2022-05-03 10:30:32 +03:00
Salman Ahmed 521ec1a225 Add keybind for distance grid spacing activation 2022-05-03 10:15:24 +03:00
Salman Ahmed fef94d49f4 Revert "Convert data type of `DistanceSpacing` to float" 
This reverts commit 7aaa88cac2.
 2022-04-29 08:02:07 +03:00
Salman Ahmed abb88b0907 Move distance spacing application to `DistanceSnapGrid` 2022-04-28 10:54:38 +03:00
Salman Ahmed 7aaa88cac2 Convert data type of `DistanceSpacing` to float 2022-04-28 10:24:36 +03:00
Salman Ahmed 2e8372fe90 Minor cleanup 
Just from reading diff.
 2022-04-28 07:14:43 +03:00
Salman Ahmed bfc6bfc91b Let `CatchHitObjectComposer` inherit from `DistancedHitObjectComposer` and hide control 2022-04-28 06:44:50 +03:00
Salman Ahmed 835898dd30 Introduce `DistancedHitObjectComposer` and supersede `OsuToolboxComposite` 2022-04-28 06:44:50 +03:00
Salman Ahmed 59cf3ff50f Move distancing methods from `IPositionSnapProvider` to `IDistanceSnapProvider` 2022-04-28 05:48:45 +03:00
Salman Ahmed 8ed39009fd Encapsulate distance spacing control handling to a "distance toolbox composite" 
Encapsulated in a way which can allow further extensibility for the
right-side area of toolboxes.
 2022-04-24 08:33:03 +03:00
Salman Ahmed 70a93c0e7e Move `DistanceSpacingMultiplier` bindable to its own `IDistanceSnapProvider` interface 2022-04-24 08:33:00 +03:00
Salman Ahmed 4f8f27a58b Merge branch 'master' into osu-distance-spacing 2022-04-24 05:23:30 +03:00
Dean Herbert ea9495eb74 Update all existing calls to extension method with correct fallback handling 2022-03-29 16:51:30 +09:00