Commit Graph

185 Commits

Author SHA1 Message Date
Dean Herbert 61c702c02e Add new `IDependencyInjectionCandidate` interface to non-drawable cached classes 2022-11-29 14:45:26 +09:00
Dean Herbert b5b79e09e4 Remove unnecessary CQ disable 2022-11-29 14:45:08 +09:00
Bartłomiej Dach c42720acd4
Temporarily disable "partial class with one part" inspection 2022-11-26 18:05:08 +01:00
Dan Balasescu 7bc8908ca9 Partial everything 2022-11-27 00:00:27 +09:00
maromalo b7ef9b176d Make score type consistent 2022-11-06 19:59:27 -03:00
Dan Balasescu 525f98c158 Fix max combo missing from playlists results screen 2022-10-14 18:01:54 +09:00
Dean Herbert ed81297611 Fix playlist items showing download button briefly during initial local presence checks 2022-09-08 17:10:45 +09:00
Dan Balasescu d70208fcf1 Default to off 2022-09-01 14:14:22 +09:00
Dan Balasescu b5ec7d06dd Add auto-skip setting
Default to auto skip
2022-08-31 20:24:06 +09:00
Dean Herbert c3c44c19cd Use `CompositeComponent` in various locations 2022-08-19 20:43:15 +09:00
Salman Ahmed 1b6ebcfd87 Remove `SubmittableScore` and replace with `SoloScoreInfo` extension method 2022-07-25 13:43:43 +03:00
Bartłomiej Dach 6f37487528
Replace calls to defective Humanizer methods with correct version 2022-07-18 22:34:58 +02:00
Dan Balasescu c6520de749 Ensure PlaylistItem beatmap is not null 2022-06-30 14:24:49 +09:00
Dean Herbert 569fde4b47 Add messages to all `InvalidOperationException`s
Without this, they can be very non-descript and hard to track down
2022-06-28 01:34:25 +09:00
Dean Herbert 31a447fda0 Update parameter discards 2022-06-24 21:26:19 +09:00
Dan Balasescu f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
Dan Balasescu 77289c7224 Fix inability to serialise-then-deserialise playlist items 2022-06-03 20:36:12 +09:00
Dan Balasescu 646f5f0f33 Isolate "server-side" multiplayer rooms in testing 2022-06-03 19:17:34 +09:00
Dean Herbert ef47b380c6 Add featured artist playlist category 2022-05-27 20:18:46 +09:00
Joseph Madamba 5e5c8e78a6 Use existing web localisation for most hardcoded strings 2022-04-20 16:31:11 -07:00
Dean Herbert 2bb0d9e6d3 Expose required classes/properties for mocking 2022-04-13 17:02:33 +09:00
Dan Balasescu 6e6271d0c0 Fix "server-side" room playlist not updated
Remove unused using
2022-04-01 18:32:10 +09:00
Dan Balasescu 16d4544ff9 Prevent reloads when playlist item order changes 2022-04-01 17:06:37 +09:00
Dean Herbert de4c04ef80 Fix non-matching json propert for `AutoStartDuration` 2022-03-25 15:34:33 +09:00
Dan Balasescu d0fee53e1f Implement auto countdown timers
Change to using TimeSpan
2022-03-22 14:34:06 +09:00
Dan Balasescu b07a1e8d09 Fix unable to copy playlist rooms without first opening 2022-03-09 15:38:00 +09:00
Dean Herbert c6d78b9325 Fix several oversights in data linking causing drawable rooms not updating as expected 2022-02-24 16:12:15 +09:00
Dean Herbert 53bbd00675 Also make `APIUser` opt-in and remove the remaining serialization exclusion rule 2022-02-23 17:12:38 +09:00
Dean Herbert 43c83d2de1 Add note about why `RoomID` is nulled in `DeepClone` 2022-02-23 17:10:11 +09:00
Dean Herbert f14a9af801 Make `Room` opt-in rather than opt-out for json serialization 2022-02-23 17:10:10 +09:00
Dean Herbert 28c9c5ab6a Remove unnecessary `ShouldSerialize` rules in `Room` 2022-02-23 17:10:10 +09:00
Dean Herbert 61b3280de1 Add missing property copies in `Room.CopyFrom` implementation 2022-02-22 15:47:00 +09:00
Dean Herbert 71ae425fb2 Merge branch 'master' into rooms-request-faster 2022-02-22 15:45:05 +09:00
Dean Herbert f12044b03e Add mention of `PlaylistItem.Beatmap` being a placeholder in many cases 2022-02-22 15:31:08 +09:00
Dean Herbert b43008b9f6 Add cover and count handling from newer response version 2022-02-21 19:05:22 +09:00
Dean Herbert 39d64e779c Handle API returned difficulty range for rooms 2022-02-21 19:05:19 +09:00
Dean Herbert 1737128334 Allow room category to be copied even if `Spotlight`
I remember that this conditional copy was added to support making copies
of spotlight rooms without carrying across the `Spotlight` type, but in
testing this is already handled web side to the point that it's not
required.

The rationale for allowing the copy is that this method is used for
tests, where it was not being copied correctly from the input as
expected (used at
bdc3b76df0/osu.Game/Tests/Visual/OnlinePlay/TestRoomManager.cs (L38)).
2022-02-21 17:47:56 +09:00
Dan Balasescu 55d9f0b44b Store beatmap to a field instead 2022-02-16 16:03:08 +09:00
Dan Balasescu b1dbd4abfe Fix incorrect playlist item <-> availability tracker logic
Results in revert to some prior logic for the tracker implementation.
2022-02-15 23:50:12 +09:00
Dan Balasescu bdc3b76df0 Remove beatmap bindable from PlaylistItem 2022-02-15 23:50:08 +09:00
Dan Balasescu 94a974e1c9 Make OnlinePlayBeatmapAvailabilityTracker look up the online beatmap 2022-02-15 23:41:50 +09:00
Dan Balasescu afcb7a4630 Make DrawableRoomPlaylistItem look up the online beatmap 2022-02-15 23:41:50 +09:00
Dan Balasescu efeba30b9f Remove ruleset and mod bindables from PlaylistItem 2022-02-15 16:28:15 +09:00
Dean Herbert 28bbf34b14 Remove unnecessary `this.` prefix 2022-02-11 16:21:49 +09:00
Dean Herbert beb3731c0b Standardise and combine base implementation of score submission requests
These share too much yet have very different constructor signatures and
property exposure. Just a clean-up pass as I begin to look at replay
submission.
2022-02-11 15:53:47 +09:00
Dean Herbert d7342880f5 Update remaining cases of clashes with `realm.Write` and `realm.RegisterForNotifications` 2022-01-25 13:09:48 +09:00
Dean Herbert 6eb2c28e41 Rename `RealmContextFactory` to `RealmAccess` 2022-01-24 20:38:07 +09:00
Dean Herbert 40aa873190 Rename register methods to better explain their purpose 2022-01-24 14:37:36 +09:00
Dean Herbert e9e3e024a1 Update all usages of `QueryAsyncWithNotifications` to use new `Register` pathway 2022-01-23 20:28:04 +09:00
Dean Herbert 1f157d729d Update existing subscriptions to new style
Fix missing detach calls in `MusicController`
2022-01-21 20:05:03 +09:00