Commit Graph

9991 Commits

Author SHA1 Message Date
smoogipoo dd67070b6f ManiaAction.Special -> ManiaAction.Special1 2018-01-15 17:58:04 +09:00
smoogipoo 351afc350e Implement co-op keybindings 2018-01-15 17:43:45 +09:00
smoogipoo 0d79d16692 Cleanup testcase 2018-01-15 15:52:07 +09:00
smoogipoo dbcabfb6ac Remove ManiaAction.Specia2 2018-01-15 15:50:57 +09:00
smoogipoo 1c74e56bab Increase the point at which normal keys start in ManiaAction 2018-01-15 15:50:43 +09:00
smoogipoo d2b1e27527 Cleanup implementation of coop key mod
This is how I intended the functionality to be implemented.
2018-01-15 15:49:03 +09:00
smoogipoo 9f98983550 Remove gravity mod
Not sure how this made it back in here.
2018-01-15 15:36:36 +09:00
ANDY840119-PC\andy840119 bbb741245e fix CI error 2018-01-14 21:51:07 +09:00
ANDY840119-PC\andy840119 999386497a implement co-op mod 2018-01-14 21:35:35 +09:00
ANDY840119-PC\andy840119 cf0d9e4d9b not sure is it a goodway to delete mania ManiaAction.Special or add more 2018-01-14 21:20:01 +09:00
ANDY840119-PC\andy840119 2d266a8604 fix :
1. Instead of this property, turn SpecialColumnPosition into a
2. special column does not display
2018-01-14 20:44:17 +09:00
ANDY840119-PC\andy840119 5ecfc3a57c fix CI error 2018-01-14 13:06:37 +09:00
ANDY840119-PC\andy840119 58bf611d17 This should be done in the stage instead of the playfield. 2018-01-14 12:51:55 +09:00
ANDY840119-PC\andy840119 d07636a105 Fix :
1. This (along with OnJudgement above) should be done in the following three steps:
2. How about giving the stages an Inverted BindableBool, and having them decide their scale?
2018-01-14 12:49:01 +09:00
ANDY840119-PC\andy840119 f7a908fbfa Fix :
This (along with OnJudgement above) should be done in the following three steps:
.
i'm not sure does it means the code i write
2018-01-14 12:08:09 +09:00
ANDY840119-PC\andy840119 4f0e1f03d2 fix the problem that smoogipoo suggest
1. Rename to stages
2. This should be checking for null or 0, with two exceptions:
3. Space before and after =.
4. foreach (var stage ...
5. Rename to getStageByColumn, and actualColumn -> column.
2018-01-14 11:49:23 +09:00
ANDY840119-PC\andy840119 e947e46566 fix :
1. Add space before {, before Duration, and after 1000
2. How about just ManiaStage?
3. This is really just Columns.Count, you're not saving much with this extra variable here.
2018-01-14 11:41:52 +09:00
ANDY840119-PC\andy840119 561c9f2233 update rom ppy master
.
Find out that has some problem long hit note will not show hit result
2018-01-14 11:32:54 +09:00
Dan Balasescu 25d4445543
Merge pull request #1902 from Aergwyn/expose-ishit
Expose "IsHit" on DrawableHitObject
2018-01-14 00:35:21 +09:00
Aergwyn 8ac6818639 expose IsHit 2018-01-13 16:26:14 +01:00
Dan Balasescu a9d7eac8be
Merge pull request #1899 from Aergwyn/shrink-drawablehitobject_t
Slim down DrawableHitObject<T>
2018-01-14 00:24:52 +09:00
Dan Balasescu ebb8550f53
Merge branch 'master' into shrink-drawablehitobject_t 2018-01-14 00:16:42 +09:00
Aergwyn 7875f0cb01 remove unnecessary internal 2018-01-13 16:15:41 +01:00
Dan Balasescu 093db77c62
Merge pull request #1894 from Aergwyn/remove-empty-lines
Remove unnecessary empty lines
2018-01-14 00:13:50 +09:00
Aergwyn 356bb5da1e move sample logic up too 2018-01-13 12:55:52 +01:00
Aergwyn 70fc09f81e move judgement + state logic up to DrawableHitObject 2018-01-13 12:42:42 +01:00
Aergwyn ae1adfd2f2 remove unnecessary empty lines
codefactor.io \(o.o)/
also one unnecessary semicolon
2018-01-12 19:30:34 +01:00
Dean Herbert b9f4dee801
Merge pull request #1893 from Aergwyn/preview-volume
Remove volume reduction on song preview
2018-01-13 02:52:56 +09:00
Dean Herbert 2507ec2ef8
Merge branch 'master' into preview-volume 2018-01-13 02:32:46 +09:00
Dean Herbert 7ecb49c1f9
Merge pull request #1889 from peppy/catch-overall-fixing
Fixes to catching fruit
2018-01-13 01:18:17 +09:00
Aergwyn 1c5b3d009c remove volume reduction on preview
it doubles with global reduction
2018-01-12 17:09:57 +01:00
Dean Herbert b4b15b7dd0 Apply review fixes 2018-01-13 00:51:20 +09:00
Dean Herbert 9e10854840 Fix banannanananana showers not exploding enough 2018-01-12 22:30:35 +09:00
Dean Herbert 7b19353ed8 Fix weird fruit not fading out 2018-01-12 22:30:35 +09:00
Dean Herbert f03b8206da Make banana showers always last in combo (explodey) 2018-01-12 22:30:35 +09:00
Dean Herbert 20c6f84efa Fix banana test regression 2018-01-12 22:30:35 +09:00
Dean Herbert 93c4d58b69 Make catch plate fruit again 2018-01-12 22:30:35 +09:00
Dan Balasescu 4ef23a8ee8
Merge pull request #1884 from peppy/catch-autoplay
Add very basic osu!catch replay/autoplay handling
2018-01-12 20:58:41 +09:00
smoogipoo 90bcec42d7 Remove unused using 2018-01-12 20:48:58 +09:00
Dan Balasescu 4d26c8c311
Merge branch 'master' into catch-autoplay 2018-01-12 20:26:11 +09:00
Dan Balasescu 56e4212883
Merge branch 'master' into catch-autoplay 2018-01-12 20:25:24 +09:00
Dean Herbert f918bfa11b
Merge pull request #1885 from peppy/catch-banana-shower
Add osu!catch banana showers
2018-01-12 20:22:53 +09:00
Dan Balasescu d9c47f98a8
Merge branch 'master' into catch-banana-shower 2018-01-12 20:00:00 +09:00
Dan Balasescu 65c7882ea2
Merge pull request #1886 from peppy/fix-catch-stream-colours
Fix juice streams not propagating accent colours to nested objects
2018-01-12 19:56:15 +09:00
Dean Herbert 7bdedf802c Fix juice streams not propagating accent colours to nested objects 2018-01-12 19:39:56 +09:00
Dean Herbert 2a0a0e3b48
Merge pull request #1856 from smoogipoo/sliderbar-tooltip-precision
Fix up replay playback speed slider having a different tooltip than the displayed number
2018-01-12 19:08:50 +09:00
Dean Herbert 73aa56a8a7
Merge branch 'master' into sliderbar-tooltip-precision 2018-01-12 18:58:30 +09:00
Dean Herbert 98894f010f Update framework 2018-01-12 18:57:53 +09:00
Dean Herbert 188b26472c Merge remote-tracking branch 'upstream/master' into sliderbar-tooltip-precision 2018-01-12 18:54:36 +09:00
Dan Balasescu a526d05ef4
Merge pull request #1883 from peppy/fix-incorrect-conditional
Fix incorrect online conditional check in social browser logic
2018-01-12 18:53:41 +09:00