Commit Graph

1049 Commits

Author SHA1 Message Date
Bartłomiej Dach c911332540
Merge branch 'master' into correct-reverse-arrow-depth 2021-09-20 22:32:28 +02:00
Bartłomiej Dach 79438c19a4
Fix slider parts not reproxying after first hitobject freed 2021-09-18 16:27:30 +02:00
Dean Herbert fde7c88999
Merge branch 'master' into update-framework 2021-09-16 22:49:02 +09:00
smoogipoo d8f27633a4 Fix legacy approach circles accepting alpha 2021-09-16 19:35:15 +09:00
smoogipoo f9d5abff8a Update with keybinding changes 2021-09-16 18:26:12 +09:00
Dean Herbert b907c2f4f6 Fix osu! judgements getting scaled twice over different durations 2021-09-02 16:31:43 +09:00
Dean Herbert 738ce0f689 Fix repeat arrows being hidden beneath head circles in legacy skins
Aims to make minimal changes to `DrawableSlider` itself. I'm not super
happy about the slider ball being moved above the head circle, but it
*is* what people are used to so no one except for me is going to
complain.

Supersedes and closes https://github.com/ppy/osu/pull/14561.
2021-09-01 19:41:49 +09:00
Dan Balasescu f0296e5d12
Merge branch 'master' into avoid-default-skin-judgement-transform-overhead 2021-08-27 10:02:40 +09:00
Dan Balasescu a28bc9f6b2
Merge branch 'master' into path-control-point-bindable-removal 2021-08-27 09:37:37 +09:00
Salman Ahmed b9ea984c36 Remove redundant default value 2021-08-26 08:18:58 +03:00
Dean Herbert 8cfb3d456b Avoid expensive text spacing transforms for now 2021-08-26 13:15:27 +09:00
Dean Herbert 69064c1938 Avoid unnecessary unbind operations when constructing `FollowPointLifetimeEntry` 2021-08-26 12:35:31 +09:00
Dean Herbert 6dcd9427ac Remove bindable usage in `PathControlPoint`
This is quite a breaking change, but I think it is beneficial due to the large amount of usage of this class.

I originally intended just to remove the allocations of the two delegates handling the `Changed` flow internally, but as nothing was really using the bindables for anything more than a general "point has changed" case, this felt like a better direction.
2021-08-26 12:33:53 +09:00
Salman Ahmed 523c154f15 Add `ComboIndexWithOffsetsBindable` and bind similar to `ComboIndexBindable` 2021-07-22 16:40:33 +03:00
Dean Herbert 399c3b0be8 Rename property, reword xmldoc and improve readability of update code 2021-07-21 17:32:56 +09:00
Salman Ahmed 9d92b795fa Revert making `ComboOffset`s legacy and define `BeatmapSkinComboIndex` instead 2021-07-20 14:15:43 +03:00
Salman Ahmed 554652b033 Merge branch 'refactor-combo-colour-retrieval' into legacy-beatmap-combo-offset 2021-07-20 10:11:52 +03:00
Salman Ahmed 68e28f4903 Implement `IHasApproachCircle` in `DrawableHitCircle` as well 2021-06-21 07:35:07 +03:00
Salman Ahmed c04b09520d Replace spinner approach circle proxying logic with hooking up to `OnSkinChange` in mod 2021-06-19 20:06:28 +03:00
Salman Ahmed 843c8bd7a4 Move spinner approach circle to its own `SkinnableDrawable` 2021-06-18 20:33:50 +03:00
Salman Ahmed f7b5341663 Merge branch 'master' into legacy-spinner-approach-circle 2021-06-18 19:50:52 +03:00
Salman Ahmed c9458fd9ce Hide spinner approach circle in "Hidden" mod 2021-06-18 06:23:54 +03:00
Dean Herbert a46f730a69 Fix approach circle fade not running early on an early user hit
Regressed in https://github.com/ppy/osu/pull/12153.
Closes https://github.com/ppy/osu/issues/13531.
2021-06-17 15:09:05 +09:00
Dean Herbert 6017ef3825
Merge branch 'master' into fix-skin-sample-lookup 2021-06-08 17:37:36 +09:00
Dean Herbert 277eb9fa6e Fix slider repeat arrow not updating rotation immediately while paused in editor
A bit of a local solution, but not sure there's a better way to handle
this.

Closes #13342.
2021-06-07 15:58:43 +09:00
Dean Herbert d26c9a66c2 Merge branch 'legacy-skin-default-fallback' into fix-skin-sample-lookup 2021-06-07 12:01:19 +09:00
ekrctb d7da66d876 Bring back scheduling of follow point update 2021-06-04 18:41:02 +09:00
ekrctb 0098ac2760 Remove one TODO
It can be removed because pooled drawables are always ready, and `FollowPointConnection` is also ready when applied.
2021-06-04 17:09:59 +09:00
ekrctb bc892086fe Resolve nullable inspection, enable nullable for `FollowPointLifetimeEntry` 2021-06-04 17:09:59 +09:00
ekrctb b373b120ff Use general lifetime container for follow point container 2021-06-04 16:31:50 +09:00
ekrctb c06ff3c623 Remove defunct `Animate` calls 2021-06-02 11:46:28 +09:00
ekrctb b82190e157 Fix hit circle animation reset when skin is changed
The transforms applied in `Animate` call was not applied because the piece is recreated.
2021-06-02 11:32:24 +09:00
Dean Herbert 6268bbea85 Merge branch 'master' into fix-skin-sample-lookup 2021-05-28 14:47:35 +09:00
Dean Herbert 70a844ac10 Remove `allowFallback` parameters completely 2021-05-27 14:50:42 +09:00
Endrik Tombak 9ac4ef273e Make DrawableSliderTail not require ITrackSnaking 2021-05-26 23:21:05 +03:00
smoogipoo 3db995c778 Fix sliders jumping around the screen on movement 2021-05-24 17:15:57 +09:00
Dean Herbert 8336428574 Add regression test for spinner sample actually transforming its frequency 2021-05-24 15:10:33 +09:00
Dean Herbert 1410b8f36d Fix follow points displaying at incorrect locations when dragging a slider out-of-bounds 2021-05-05 18:30:57 +09:00
Salman Ahmed cd6d070b4a Consider "combo offsets" as legacy logic and separate from combo information 2021-05-05 07:43:08 +03:00
Dean Herbert d10aac851d Extract scale constant 2021-04-26 15:30:22 +09:00
Dean Herbert 4da964c3f3 Expose `DrawableSliderRepeat`'s arrow and move transforms to children 2021-04-26 15:22:42 +09:00
Dean Herbert aa7ade8186 Expose presence of `MainCirclePiece` via an interface 2021-04-26 15:22:17 +09:00
Salman Ahmed 0b9172a1dc Animate back slider repeat and tail circle pieces 2021-04-26 02:39:49 +03:00
Dean Herbert 47a4a07024 Split out animation triggering of `MainCirclePiece` to be interface driven 2021-04-21 19:15:10 +09:00
Dean Herbert ac0ed72d04 Keep hitcircles aligned with view in "Barrel Roll" mod 2021-04-20 18:36:11 +09:00
Dean Herbert e2470d757e
Merge branch 'master' into legacy-spm-counter 2021-04-12 12:52:52 +09:00
smoogipoo f2e811928b Rework slider hackery to not overwrite Samples 2021-04-09 15:28:08 +09:00
smoogipoo 8efa381d3a Actually use whistle sample for sliderwhistle 2021-04-08 23:13:16 +09:00
smoogipoo 7d291ed7d7 Don't serialise OriginalSamples 2021-04-08 20:57:50 +09:00
smoogipoo 7713c8a45f Add support for sliderwhistle 2021-04-08 20:20:09 +09:00