Commit Graph

143 Commits

Author SHA1 Message Date
Dan Balasescu 30116512ca
Populate MaxCombo scoring attrib for non-osu rulesets 2023-12-18 12:01:51 +09:00
Dan Balasescu da2a4681d9 Add method to retrieve legacy score multiplier 2023-10-02 16:52:01 +09:00
Dan Balasescu 2334be1987 Split legacy scoring attributes into a separate object 2023-09-07 21:10:38 +09:00
Dan Balasescu 7d8cef83e6
Merge branch 'master' into LNFixHotfix 2023-08-15 13:45:06 +02:00
Hydria 1e19def153 2nd fix to cover all scenarios 2023-07-22 16:44:01 +01:00
Hydria ef2134a92a Fix issue with processing LN orders
Related Issue: https://github.com/ppy/osu/issues/22756

The trigger in question happens when
(1) in a chord: a longer LN, then a shorter LN is processed respectively.
(2) in a chord: a long LN, then a note is processed respectively.

however, given the opposite processing step, it will fail to trigger.

We observe that both situations have the same pattern, however has undeterministic results, which only depends on the order the mapper placed each note.
2023-07-22 10:45:48 +01:00
Dean Herbert 1629024111 `ILegacyScoreProcessor` -> `ILegacyScoreSimulator` 2023-07-04 17:32:54 +09:00
Hydria 5d5e6a5ab7 Finalised LN Adjustment Values
Spent a couple days discussing this on the pp rework server about values that were the most acceptable, these seemed to be the best from the community standpoint of top players.
Note: This is more to fix issues with the current system, not to be a final solution.
Related Google Sheets Page: https://docs.google.com/spreadsheets/d/1P0AxfdKvMHwWBQder4ZkFGO1fC9eADSGCryA5-UGriU/edit?usp=sharing
2023-07-03 17:45:30 +01:00
Dan Balasescu 426f11b824 Apply a few other code reviews 2023-06-29 17:28:06 +09:00
Dan Balasescu 09bc8e45de Refactoring 2023-06-28 16:14:32 +09:00
Dan Balasescu a9c65d200a Initial conversion of scores 2023-06-26 22:19:01 +09:00
Dan Balasescu e1d723a2cc Merge branch 'master' into diffcalc-total-scorev1 2023-06-26 14:32:14 +09:00
Dan Balasescu 06565871d6 Add flag to disable computing legacy scoring values 2023-06-24 01:03:18 +09:00
Dean Herbert 0ab0c52ad5 Automated pass 2023-06-24 01:00:03 +09:00
Dan Balasescu bfa449e47a Adjust attribute data 2023-06-19 21:38:13 +09:00
Dan Balasescu 975e9baf43 Fix exception with no matching mods 2023-06-15 19:55:51 +09:00
Dan Balasescu 13d1f9c902 Add ScoreV1 calculation for ManiaRuleset 2023-06-13 23:28:45 +09:00
Dan Balasescu e402c6d2b4 Write max combo attribute from base class 2023-06-02 21:53:25 +09:00
Dan Balasescu ed2b39a220 Remove whitespace 2022-10-11 13:53:18 +09:00
Natelytle cc54fc5c1b rename method to reflect being a method 2022-10-10 13:52:01 -04:00
Natelytle 430eb44446 slight formatting 2022-10-10 13:45:16 -04:00
Natelytle 32adc1ec14 Fix division by 0 2022-10-10 13:36:52 -04:00
Dan Balasescu 9645bfe708 Bump difficulty calculator versions 2022-09-02 16:27:25 +09:00
Dan Balasescu f381bc9115 Add explanatory comment 2022-08-17 19:03:48 +09:00
63411 b33e0f5e1c update comment and deltaTime check 2022-08-16 11:03:18 +08:00
Dan Balasescu 5f70ee3ed7
Merge branch 'master' into mania-note-order-fix 2022-08-15 23:44:02 +09:00
Dean Herbert aca19a005e Add versioning to difficulty calculators 2022-07-21 18:15:25 +09:00
63411 4fdbf3ff24 individualStrain should be the hardest individualStrain column for notes in a chord 2022-07-14 15:07:58 +08:00
molneya 11c7756670
Merge branch 'ppy:master' into mania-difficulty-refactor 2022-07-01 11:04:55 +00:00
Dan Balasescu 5cdf98b4dc Merge branch 'master' into accuracy-pp-curve 2022-06-29 16:48:11 +09:00
63411 2b42dfb9cb apply individualStrain decay only when a note appears in that column 2022-06-28 20:32:35 +08:00
Dan Balasescu 0fd2c010e5 Remove NRT disables from attributes classes 2022-06-27 16:07:15 +09:00
Dan Balasescu 0579780bb8 Add IBeatmapOnlineInfo parameter and use to extract more data 2022-06-27 16:07:15 +09:00
Dean Herbert 31a447fda0 Update parameter discards 2022-06-24 21:26:19 +09:00
63411 9be13f88fd revert customAccuracy changes 2022-06-23 15:51:28 +08:00
63411 58d6fa4645 Reduce NoFail pp multiplier 2022-06-20 19:55:26 +08:00
63411 984634c580 Adjust customAccuracy formula slightly 2022-06-18 22:27:28 +08:00
63411 361a87412b Update comments 2022-06-18 12:20:47 +08:00
63411 451d4154f0 Fix code style 2022-06-18 00:45:34 +08:00
63411 e238bcc6c6 Remove unneeded attributes 2022-06-17 23:44:10 +08:00
63411 9fe7636138 Use accuracy for pp calculation 2022-06-17 23:38:22 +08:00
Dan Balasescu f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
Dan Balasescu 6d2a2ba7d6 Rename Position -> Index 2022-06-09 18:49:11 +09:00
Dan Balasescu f0ef2e610e Merge branch 'master' into dho 2022-06-09 18:29:14 +09:00
Dan Balasescu a287fd73bb Write MaxCombo attribute for mania 2022-06-02 19:16:38 +09:00
Dan Balasescu b1ffffc1ac Calculate true combo value in ManiaDifficultyCalculator 2022-06-02 19:16:31 +09:00
apollo-dw 66a6467403 Pass object position to the object 2022-05-26 19:26:14 +01:00
apollo-dw 30b9e0e7ab Use object list size for object position 2022-05-24 16:30:25 +01:00
apollo-dw 26985ca8af Store hitobject history in the hitobject 2022-05-22 16:26:22 +01:00
63411 6cca56ab77 Move release_threshold to const 2022-04-23 10:46:12 +08:00