Dean Herbert
4a4d9b0dc6
Update description to match mania mirror implementation
2021-07-28 19:20:40 +09:00
ekrctb
90f3611ed0
Replace "sprite" variable names in CatcherTrailDisplay
...
The `CatcherTrail` was originally named `CatcherTrailSprite`, but it is not a sprite anymore.
2021-07-28 19:11:22 +09:00
ekrctb
a960a28d06
Replace "end glow" terminology with "hyper-dash after-image"
...
Because the is "end glow" is when a hyper-dash is *started*, the name was confusing.
The "after-image" was already used in the code as a synonym of "end glow" inconsistently.
2021-07-28 19:11:22 +09:00
Dean Herbert
2b107d624a
Merge pull request #14024 from ekrctb/trail-generation
...
Move catcher trail generation logic to `CatcherArea` to remove mutual dependency of `Catcher` and `CatcherTrailDisplay`
2021-07-28 19:06:44 +09:00
ekrctb
0bf04ece34
Avoid internal property by using ChildrenOfType
2021-07-28 18:13:43 +09:00
Gabe Livengood
712bc578dc
update setting name and description
2021-07-27 17:45:52 -04:00
Bartłomiej Dach
239b38a0ab
Reduce implicit conversions by using default
2021-07-27 21:46:29 +02:00
Lucas A
94877117b9
Apply changes in-line with framework changes.
2021-07-27 18:22:47 +02:00
Salman Ahmed
5cb02002d7
Fix flipped xmldoc
2021-07-27 18:24:17 +03:00
Salman Ahmed
ed903c60ea
Fix code style issues and remove unused using directives
2021-07-27 18:24:17 +03:00
Gabe Livengood
c741366c72
review modifications: change xmldocs, change reflection method name, remove reflection method returns, simplify incompat. mod list
2021-07-27 09:01:01 -04:00
ekrctb
846f539428
Avoid usage of LINQ in last dash trail computation
2021-07-27 19:11:08 +09:00
ekrctb
da69867fd4
Move catcher trail generation logic to CatcherArea
2021-07-27 19:07:37 +09:00
ekrctb
de68fd12b3
Move catcher trail colouring logic to CatcherTrailDisplay
2021-07-27 19:07:37 +09:00
ekrctb
d9d9db6f62
Revert "Modify catcher autoplay test pattern to see more variety movement"
...
I found `TestSceneHyperDash` is useful for visual inspection of hyper dash trails.
This reverts commit 0fbe950a
2021-07-27 19:07:37 +09:00
Dan Balasescu
6f35036f53
Merge pull request #14027 from gagahpangeran/comment-markdown
...
Add support for markdown in comments
2021-07-27 14:38:59 +09:00
Gabe Livengood
c7c261ba03
review modifications: change xmldoc wording, configure with enum instead of bool, declare incompatibility with hr
2021-07-26 17:48:03 -04:00
Dan Balasescu
7ae1b5bae7
Merge pull request #14022 from peppy/fix-invalid-ruleset-causing-crash
...
Fix invalid/unavailable ruleset causing game-wide crash
2021-07-27 02:39:26 +09:00
Gabe Livengood
49160e4482
review modifications: maniamodmirror inheritance, reflection utilities, vertical flip option
2021-07-26 10:46:41 -04:00
Gagah Pangeran Rosfatiputra
dc864abbd8
add link test
2021-07-26 21:08:57 +07:00
Gagah Pangeran Rosfatiputra
6631f0de19
add CommentMarkdownHeading
2021-07-26 21:07:35 +07:00
Gagah Pangeran Rosfatiputra
f80c46e2a0
add heading test
2021-07-26 21:04:08 +07:00
Gagah Pangeran Rosfatiputra
2a6aeb5310
use CommentMarkdownContainer in DrawableContainer
2021-07-26 18:18:55 +07:00
Gagah Pangeran Rosfatiputra
43100c5288
initial CommentMarkdownContainer
2021-07-26 18:18:33 +07:00
Gagah Pangeran Rosfatiputra
55e8a44db6
add test for DrawableComment
...
Can reproduce the issue at https://github.com/ppy/osu/issues/13993
2021-07-26 18:15:59 +07:00
Dean Herbert
8837340ac3
Merge pull request #14025 from ekrctb/simplify-can-catch
...
Remove outdated comment and simplify code in `Catcher.CanCatch`
2021-07-26 19:27:33 +09:00
ekrctb
8045534fa5
Remove outdated comment and simplify code
2021-07-26 18:18:24 +09:00
Dan Balasescu
3a81d5e8ce
Merge pull request #14023 from peppy/add-high-precision-macos-note
...
Add warning about using high precision mouse on non-windows platforms
2021-07-26 18:07:38 +09:00
ekrctb
0fbe950a3c
Modify catcher autoplay test pattern to see more variety movement
2021-07-26 18:06:30 +09:00
ekrctb
4282442278
Make Catcher.body private as it is no longer needed by CatcherTrailDisplay
2021-07-26 17:58:34 +09:00
ekrctb
c08130398c
Add some comments
2021-07-26 17:58:34 +09:00
ekrctb
bb046fa3b8
Move catcher trail generation logic to Catcher
...
It resolves mutual dependency of `Catcher` and `CatcherTrailDisplay`.
Trail generation logic is moved to `Catcher`.
The generation logic no longer uses delayed scheduling because the hidden state is hard to manage.
Instead, the last time a trail is generated is calculated and used.
The new logic has a different behavior when the dash key is pressed in succession under 50ms, but it is not noticeable for normal plays.
2021-07-26 17:51:59 +09:00
Dean Herbert
5984699842
Update comment to match updated string
...
Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
2021-07-26 17:40:07 +09:00
Dean Herbert
c8944b62ec
Update incorrect linked comment
2021-07-26 17:28:58 +09:00
Dean Herbert
075507648a
Show warning for linux as well
2021-07-26 17:28:58 +09:00
Dean Herbert
b70bd7689e
Add warning about using high precision mouse on macOS
2021-07-26 17:00:06 +09:00
Dean Herbert
af9f910a12
Change WarningText to accept LocalisableString
...
Can't work just yet, but best to have the flow in place to maintain 100%
localisation on classes which were already localised.
2021-07-26 16:59:29 +09:00
Dean Herbert
046f30a268
Reject invalid global ruleset values
2021-07-26 16:34:38 +09:00
Dean Herbert
04c8ea2813
Add failing test for the global ruleset being set to an invalid value
2021-07-26 16:33:56 +09:00
Dan Balasescu
9ae3c685db
Merge pull request #14020 from peppy/multiplayer-test-request-clarification
...
Rename class, add commenting and avoid firing requests to create rooms for testing purposes
2021-07-26 16:29:02 +09:00
Dean Herbert
888954747c
Rename class, add commenting and avoid firing requests to create rooms for testing purposes
2021-07-26 15:47:13 +09:00
Dan Balasescu
488dd3ea52
Merge pull request #13980 from peppy/fix-online-song-select-background
...
Fix song select background not showing in multiplayer/playlists
2021-07-26 15:16:39 +09:00
Dan Balasescu
5e2222cc05
Merge pull request #14018 from peppy/fix-keyboard-navigation-room-container
...
Fix keyboard navigation at multiplayer lounge not iterating in correct order
2021-07-26 14:55:40 +09:00
Dean Herbert
32e29d0428
Ensure lounge is loaded before continuing with tests
2021-07-26 14:29:16 +09:00
Dean Herbert
3770193ede
Fix keyboard navigation at multiplayer lounge not iterating in correct order
2021-07-26 13:49:09 +09:00
Dean Herbert
971a67c669
Add failing test coverage for misordered rooms
2021-07-26 13:46:55 +09:00
Dean Herbert
9713875ce4
Merge pull request #14017 from frenzibyte/room-eating-drag
...
Fix rooms in online-play longue screen no longer scrollable by dragging
2021-07-26 11:58:31 +09:00
Salman Ahmed
749d7a7b24
Fix DrawableRoom swallowing mouse down events before reaching its container
2021-07-26 04:41:47 +03:00
Salman Ahmed
5141bf66eb
Add failing test case
2021-07-26 04:41:47 +03:00
Gabe Livengood
2e1cd4a389
remove accidental tab characters
2021-07-25 21:26:21 -04:00
