Commit Graph

1221 Commits

Author SHA1 Message Date
Bartłomiej Dach 5454d1caa1
Remove global action container input queue workaround
As described in #24248, the workaround employed by
`GlobalActionContainer`, wherein it tried to handle actions with
priority before its children by being placed in front of the children
and not _actually containing_ said children, is blocking the resolution
of some rather major input handling issues that allow key releases to be
received by deparented drawables.

To resolve, migrate `GlobalActionContainer` to use `Prioritised`, which
can be done without regressing certain mouse button flows after
ppy/osu-framework#5966.
2023-08-21 17:54:08 +02:00
Dean Herbert 56eb44d15b Change `TestSpectatorClient` to provide some better fake data for score / acc 2023-08-16 17:14:42 +09:00
Bartłomiej Dach 0ecfb7b36f
Remove unused field 2023-07-08 15:03:33 +02:00
Dean Herbert 04a1550215 Redesign "local input" toggle in manual input tests to be more user-friendly
- Only displays when required (there's literally zero case we want to
  return input to the test, as this is automatic on next action)
- No longer hugs the right side of the screen (blocking visibility of
  some tests).
2023-07-07 13:32:16 +09:00
Dean Herbert 0ab0c52ad5 Automated pass 2023-06-24 01:00:03 +09:00
Bartłomiej Dach 58507291b9
Apply NRT in `MemoryCachingComponent` test-only subclasses 2023-06-09 13:48:42 +02:00
Dean Herbert a842f79ad4 Refactor `IWorkingBeatmap.Background` to `GetBackground()` 2023-06-08 16:19:32 +09:00
Bartłomiej Dach 474f7c2bc0
Fix code quality inspection 2023-06-03 16:50:58 +02:00
Bartłomiej Dach a9d4556647
Merge branch 'master' into update-multiplayer-room-diff-range 2023-06-03 16:50:09 +02:00
Dean Herbert 7a5349d747 Remove constructor from `MultiplayerPlaylistItem` which is only used in tests 2023-05-25 20:09:40 +09:00
Dan Balasescu 6c6f8621c1 Add score processor statistics to replay header 2023-05-19 16:29:24 +09:00
Dan Balasescu d2380bd840 Remove usages of [ExcludeFromDynamicCompile] 2023-05-08 18:12:56 +09:00
Bartłomiej Dach 8ab3a87b13
Add failing test case covering online ID reset on save
This test scene passes at e58e1151f3 and
fails at current master, due to an inadvertent regression caused by
e72f103c17.

As it turns out, the online lookup flow that was causing UI thread
freezes when saving beatmaps in the editor, was also responsible for
resetting the online ID of locally-modified beatmaps if online lookup
failed.
2023-05-01 18:17:35 +02:00
Bartłomiej Dach 6afa65bd3d
Merge branch 'master' into skinnable-clean-up-documentation 2023-02-17 20:59:18 +01:00
Dean Herbert 7afdcb9383 Merge branch 'master' into hide-resume-overlay 2023-02-16 15:42:14 +09:00
Dean Herbert a92e42bb84 Rename `SkinnableTargetContainer` to `SkinComponentsContainer`
Also use full `SkinComponentsContainerLookup` instead of the sub-type.
This will potentially be useful once we bring in per-ruleset targets.
2023-02-15 18:37:41 +09:00
Dean Herbert 9e04a36d86 Move test to a mod test and add more resilient test logic 2023-02-14 15:07:45 +09:00
Dean Herbert 96fbd04698 Add failing test coverage of skip no longer working in replay playback 2023-02-10 18:57:04 +09:00
Joseph Madamba f1decb667e Address todos relating to init-only usages 2023-02-08 17:51:28 -08:00
Dean Herbert a77baf8717 Output gameplay clock progress in `PlayerTestScene`s 2023-02-01 23:42:44 +09:00
Salman Ahmed c48af79588 Fix test browsers on longer working after framework update 2023-01-21 14:49:47 +03:00
Dean Herbert 1e5dd9165a Adjust `SkinnableTestScene` to give more breathing room to `RelativeSize` components 2023-01-18 15:37:46 +09:00
Dean Herbert 53e7873f6c
Merge branch 'master' into fix-pause-gameplay-action-not-closing 2023-01-17 17:41:16 +09:00
Joseph Madamba 08c570849f Simplify container logic 2023-01-16 23:24:47 -08:00
Salman Ahmed 13c1b8f5a4 Fix intermittent failure in tests with restarting player instances 2023-01-15 16:06:06 +03:00
Joseph Madamba 776b60f3b3 Fix manual input manager test scenes not matching game input hierarchy
Fix popover using on key down

Fix popover not expiring when using global action
2023-01-10 15:35:26 -08:00
Bartłomiej Dach a82f1a6abd
Adjust method naming and copy 2023-01-01 18:50:47 +01:00
Bartłomiej Dach 0e59b55a12
Merge branch 'master' into previewTime 2023-01-01 18:38:19 +01:00
Dean Herbert 4a7d7c6ed9 Use `MaxBy` in all locations that can and update inspection level to match `dotnet-build` 2022-12-19 16:47:10 +09:00
Dean Herbert dd9a418549 Fix assembly location lookups 2022-12-16 19:19:59 +09:00
Dean Herbert 27c497145f Fix the MOTHERLOAD of undetected issues that are now visible thanks to net6.0 2022-12-16 18:16:26 +09:00
cdwcgt a4d28aff6d
fix typo 2022-12-16 10:48:56 +09:00
cdwcgt 984f0b5fa9
Add test for set preview point 2022-12-16 01:35:54 +09:00
Dan Balasescu caa0b7c290 Move score token to BeginPlaying 2022-12-12 13:59:27 +09:00
Dean Herbert b7f0310070
Merge pull request #21353 from peppy/no-initial-presence
Stop requesting messages as part of initial chat presence
2022-11-30 16:15:23 +09:00
Dean Herbert 61c702c02e Add new `IDependencyInjectionCandidate` interface to non-drawable cached classes 2022-11-29 14:45:26 +09:00
Bartłomiej Dach 894ef15e79
Merge branch 'master' into update-framework 2022-11-26 16:19:36 +01:00
Dan Balasescu 7bc8908ca9 Partial everything 2022-11-27 00:00:27 +09:00
Dean Herbert 53b03df93d Combine `TriangleButton` and `RoundedButton` classes 2022-11-24 16:26:57 +09:00
Dean Herbert efd73ea9da Rename method to suit better 2022-11-21 15:22:57 +09:00
Dean Herbert 19876ca0fb
Merge branch 'master' into websocket-chat-2 2022-11-11 23:53:42 +09:00
Dan Balasescu 66bbe34116 Move polling clients to osu.Game.Tests namespace 2022-11-04 18:52:57 +09:00
andy840119 4c9c65856c Remove the nullable disable annotation in the testing beatmap and mark some of the properties as nullable.
This class will be used in some check test cases.
2022-10-30 17:03:54 +08:00
Dean Herbert 4d4f6e25ba Rename to "clone" instead of "duplicate" 2022-10-25 11:43:23 +09:00
Dean Herbert da74690ec9 Add test coverage of clone operations 2022-10-25 11:38:58 +09:00
Dean Herbert a7d4a74ed6
Update osu.Game/Tests/Visual/ScrollingTestContainer.cs
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-10-20 08:07:56 +09:00
Dean Herbert d237c818f6 Fix nested objects in overlapping scrolling hit object container ruleset not using correct reference time 2022-10-18 16:15:21 +09:00
Salman Ahmed 241ecb63a1 Hide manual input manager cursor in `OsuGameTestScene`s
Allows checking that the cursor is actually hidden in
`TestSceneOsuGame.TestCursorHidesWhenIdle`.
2022-10-15 00:20:22 +03:00
Dan Balasescu 1811647e34 Make room requests handler handle GetBeatmapRequest 2022-09-27 20:30:41 +09:00
Salman Ahmed 8aff856c79 Fix `SkinnableTestScene` sizing logic potentially failing to work 2022-09-27 05:18:17 +03:00