Commit Graph

181 Commits

Author SHA1 Message Date
Andrei Zavatski 060b01eee8 Make CreateJudgement public again and add remarks 2024-02-16 20:24:02 +03:00
Andrei Zavatski 5fa54c8c63 Fix remaining use cases 2024-02-10 14:16:45 +03:00
Bartłomiej Dach 39fe078984
Merge branch 'master' into hit-object-result-allocations 2024-02-05 13:24:10 +01:00
Bartłomiej Dach efe6bb25b1
Refactor result application around again to remove requirement for fields
Co-authored-by: Dean Herbert <pe@ppy.sh>
2024-02-05 13:21:01 +01:00
Dan Balasescu b44f77cee1
Update R# + fix inspections 2024-02-02 21:00:28 +09:00
Chandler Stowell 93bd3ce5ae update `DrawableHitCircle.ApplyResult` to pass `this` to its callback 2024-01-25 11:25:41 -05:00
Dan Balasescu 6b4b2a57fc
Expose only as one method 2023-12-21 14:58:23 +09:00
Dan Balasescu 4e3b994142
Relocate HitResult numeric score to ScoreProcessor 2023-12-21 14:52:31 +09:00
Dean Herbert e3217bc82e
Merge branch 'master' into hp-drain-fix-breaks 2023-11-24 15:15:48 +09:00
Dan Balasescu cb4568c4a1
Fix first object after break not starting a new combo 2023-11-22 17:22:48 +09:00
Dan Balasescu e3137d575b
Fix osu! and base HP processor break time implementation 2023-11-14 01:11:17 +09:00
Bartłomiej Dach 0482c05d7c
Add failing test case 2023-10-26 19:38:52 +02:00
Dean Herbert f9021bf551
Remove pointless test class in `TestSceneStoryboardSamples` 2023-10-06 16:43:28 +09:00
Dean Herbert e21dc56fcb Add test coverage of `Judged` state 2023-07-05 18:20:25 +09:00
Dean Herbert 0ab0c52ad5 Automated pass 2023-06-24 01:00:03 +09:00
Dean Herbert a789d1e49c Add xmldoc and change naming around `ScoreProcessorStatistics` a bit 2023-05-29 18:38:16 +09:00
Dan Balasescu 844c023fb7 Fix tests 2023-05-23 18:18:27 +09:00
Salman Ahmed befb275512 Fix intermittent failure in GCC seeking test 2023-01-14 14:34:22 +03:00
Bartłomiej Dach ae026e2d2d
Add test coverage 2022-12-30 20:55:54 +01:00
Bartłomiej Dach 830e243d12
Add test coverage for failure case 2022-11-30 22:53:56 +01:00
Dan Balasescu 7bc8908ca9 Partial everything 2022-11-27 00:00:27 +09:00
maromalo 1911120afe
Merge branch 'master' into long-standard 2022-11-12 09:52:11 -03:00
Dan Balasescu db25e9e9c8 Merge branch 'master' into combo-colour-brightness-limit 2022-11-11 15:31:28 +09:00
Dean Herbert 1aa0e40f2f Add "Component" prefix to lookup naming 2022-11-09 17:46:43 +09:00
Dean Herbert c908969d9b Rename `ISkinComponent` to `ISkinLookup` 2022-11-09 17:46:43 +09:00
maromalo b7ef9b176d Make score type consistent 2022-11-06 19:59:27 -03:00
Dean Herbert 3ec9686e58 Fix test failures and rename configuration value to match better 2022-11-02 18:15:18 +09:00
Dan Balasescu d4a37725c4 Adjust test 2022-08-29 15:59:57 +09:00
Dean Herbert 46d000b8ce Fix test regressions on windows due to `Reset` never being called
I'm not sure this is great. Without calling `Reset`, the correct initial
time may not be set (ever). In practice this doesn't happen anywhere in
the gameplay flow, but something worth noting.

This change is required now that `Reset` isn't called in the
constructor. It couldn't be called in the constructor because it would
cause the audio track to reset its position too early.

What an ordeal.
2022-08-24 11:50:20 +09:00
Dean Herbert af2e82d7d5 Move operation of setting `GameplayClockContainer.StartTime` to `Reset` call 2022-08-22 14:11:06 +09:00
Dean Herbert 43879633db Ensure setting a `StartTime` on a `GameplayClockContainer` always resets to the new time 2022-08-18 18:54:10 +09:00
Dean Herbert f81c7644b4 Make `GameplayClockContainer` also an `IGameplayClock` and expose to remaining tests 2022-08-15 18:30:53 +09:00
Dean Herbert 6d78218142 Update usages of `GameplayClockContainer.GameplayClock` to access properties directly 2022-08-15 18:08:49 +09:00
Dan Balasescu b4e55f7309 Apply IRenderer changes 2022-08-02 19:50:57 +09:00
Dean Herbert a21aee4e9c Reduce calls to `LoadTrack` by implicitly running on test/dummy classes 2022-07-28 18:11:40 +09:00
Salman Ahmed 9df49db45f Include bonus/ignore judgements in statistics fill logic 2022-07-21 08:13:09 +03:00
Salman Ahmed 3c2a885872 Add test coverage 2022-07-21 06:01:48 +03:00
Salman Ahmed a5b01b8920 Improve asserts in `TestSeekPerformsInGameplayTime` to be more descriptive 2022-07-07 01:00:55 +03:00
Dean Herbert b597843579 Mark and document remaining flaky tests 2022-07-01 16:17:40 +09:00
Bartłomiej Dach 26c5b59f6d
Replace usages of `string.To{Lower,Upper}()` 2022-06-24 11:57:45 +02:00
Dan Balasescu f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
Dan Balasescu 4e35ac8d4c Add test 2022-06-06 18:01:52 +09:00
Dan Balasescu 132c94c1b5 Remove Ruleset parameter from ResetFromReplayFrame() 2022-05-31 17:16:23 +09:00
Salman Ahmed 8842847b18 Fix wrong result applied 2022-04-27 00:05:49 +03:00
Salman Ahmed 1676c2c3f6 Change boolean argument to `HitResult` instead 2022-04-27 00:05:15 +03:00
Salman Ahmed a884f20c65 Add failing test case 2022-04-26 23:27:03 +03:00
Dean Herbert c8db7cf2a8 Reset audio offset before each test run in `TestSceneMasterGameplayClockContainer` 2022-04-14 18:09:23 +09:00
Dean Herbert fbf0e5a45c Remove `startFromSkipTarget` parameter and update usages that required said behaviour 2022-04-13 14:25:43 +09:00
Dean Herbert a3695c7e97
Merge branch 'master' into fix-spectator-seeks 2022-04-06 12:58:43 +09:00
Dean Herbert 1049e349e3 Add test coverage of user offset being set before construction of `MasterGameplayClockContainer` 2022-03-24 14:55:01 +09:00