Commit Graph

51304 Commits

Author SHA1 Message Date
Bartłomiej Dach
18e4c3ed0f
Update mod columns even if they're not present/offscreen
Important to make "select/deselect all" operations work on all columns
simultaneously, even if they're offscreen. Unfortunately by the nature
of how the existing selection animation works, it is hard-tied to the
update loop, so we need to compensate.
2022-05-07 09:50:09 +02:00
Bartłomiej Dach
9514a5cef7
Only load panels asynchronously outside of BDL 2022-05-07 09:50:09 +02:00
Bartłomiej Dach
9f96dd47d1
Remove schedule in panel load
It was causing selection/deselection of all mods to work improperly if a
select/deselect all operation was requested before the panel was
scrolled into view.

In general the schedule was an over-optimisation - the game-global set
of available mods shouldn't be changing so often as to warrant such an
aggressive debounce.
2022-05-07 09:50:09 +02:00
Bartłomiej Dach
e1953c484c
Add test coverage for selecting/deselecting all mods on free mod select 2022-05-07 09:50:08 +02:00
Bartłomiej Dach
35c106efaa
Add test coverage for deselecting all mods on user mod select 2022-05-07 09:29:33 +02:00
Bartłomiej Dach
852e4a9766
Add select/deselect all buttons to free mod select screen 2022-05-07 09:29:33 +02:00
Bartłomiej Dach
0b95594f60
Add some more padding between footer and column scroll 2022-05-07 09:29:33 +02:00
Bartłomiej Dach
0c6de331f3
Move footer button padding to a higher level 2022-05-07 09:29:32 +02:00
Bartłomiej Dach
202a603d72
Merge branch 'master' into distance-snap-grid-current-tiume 2022-05-07 08:49:30 +02:00
Dean Herbert
dd63657dfb
Merge pull request #18065 from huoyaoyuan/code-style
Enforce code style analysis shipped with .NET SDK
2022-05-07 14:58:19 +09:00
Dean Herbert
2dd9899cd7
Merge pull request #18126 from bdach/mod-overlay/fix-broken-mod-reference-logic
Fix several issues with new mod select reference replacement logic
2022-05-07 14:36:05 +09:00
Dean Herbert
34237fd05e
Merge pull request #18125 from frenzibyte/fix-overlay-horizontal-offset-overlays
Fix side overlay offset not affecting fullscreen overlays
2022-05-07 14:02:22 +09:00
Dean Herbert
ce14fddcb2 Use above-1 offset instead for more correct feeling parallax 2022-05-07 14:02:07 +09:00
Dean Herbert
71758390b5 Fix time based distance grid alpha not correctly accounting for distance spacing multiplier 2022-05-07 13:37:36 +09:00
Bartłomiej Dach
8c73ed7207
Fix sequence equality check not using reference comparison 2022-05-06 21:47:04 +02:00
Bartłomiej Dach
621f746789
Do not modify selected mods through panel state change during external update 2022-05-06 21:47:04 +02:00
Bartłomiej Dach
c199b8fcb6
Simplify state management in ModColumn
Bad sign when you can't follow your own code.

All of the various state changing methods were flattened into one
because it was too hard to follow what was calling what and why.
2022-05-06 21:46:16 +02:00
Bartłomiej Dach
380cd1e036
Add test coverage for lack of customisation on free mod select 2022-05-06 21:35:22 +02:00
Salman Ahmed
8080f784fd Apply offset by a factor of 0.8x from screen offset 2022-05-06 22:20:09 +03:00
Salman Ahmed
049fed42e2 Fix side overlay offsetting not affecting fullscreen overlays 2022-05-06 21:42:20 +03:00
Salman Ahmed
723fce8174 Move inverting value to happen outside clamp
Looks to have no effect, but makes sense to happen outside instead.
2022-05-06 18:54:13 +03:00
Salman Ahmed
d78f1d158d Use GetEndTime() instead of StartTime
Companion to
246479bf34
2022-05-06 18:51:35 +03:00
Salman Ahmed
112496204d Make nested class private 2022-05-06 18:50:28 +03:00
Salman Ahmed
404798395c
Merge pull request #18120 from peppy/fix-toolbox-expansion
Fix user-contracted toolbox groups in editor incorrectly expanding on hover
2022-05-06 18:44:09 +03:00
Salman Ahmed
3077d398ef
Merge branch 'master' into distance-snap-grid-current-tiume 2022-05-06 18:20:22 +03:00
Salman Ahmed
1409f8ca96
Merge branch 'master' into fix-toolbox-expansion 2022-05-06 18:00:01 +03:00
Dean Herbert
bda57dd970
Merge pull request #18122 from bdach/mod-overlay/leftover-mod-area-border
Remove leftover border thickness spec in mod settings area
2022-05-06 23:58:35 +09:00
Salman Ahmed
f222affe88
Merge branch 'master' into fix-toolbox-expansion 2022-05-06 17:54:14 +03:00
Salman Ahmed
a7c7fc745b
Merge pull request #18103 from peppy/distance-snapping-test
Fix distance snapping grid providing incorrect time values for non-1.0x spacing
2022-05-06 17:53:44 +03:00
Salman Ahmed
144d33f0d2
Merge branch 'master' into distance-snapping-test 2022-05-06 17:29:27 +03:00
Bartłomiej Dach
9961545147
Merge pull request #18121 from peppy/editor-drag-box
Fix editor drag box visuals
2022-05-06 15:52:26 +02:00
Bartłomiej Dach
c533c93ffd
Remove leftover border thickness spec in mod settings area
Was never supposed to be there, it was a vestige of a previous design
iteration that went by unnoticed.
2022-05-06 15:34:49 +02:00
Bartłomiej Dach
56fa5c9db1
Merge branch 'master' into editor-drag-box 2022-05-06 15:22:39 +02:00
Bartłomiej Dach
29a3ab7e7a
Halve drag box padding
Allows the drag box borders to collapse in on themselves to a single
line if the drag selection has zero width or height.
2022-05-06 15:21:35 +02:00
Salman Ahmed
b119726b28 Reword test step 2022-05-06 15:38:38 +03:00
Bartłomiej Dach
e527574ede
Merge branch 'master' into fix-toolbox-expansion 2022-05-06 13:47:36 +02:00
Bartłomiej Dach
19297375e2
Update tests to reflect new expected behaviour 2022-05-06 13:47:13 +02:00
Dean Herbert
98eab9668d
Merge pull request #18119 from bdach/mod-overlay/broken-hover
Fix mod panels not hovering correctly after closing customisation area via mouse on new mod select
2022-05-06 20:42:33 +09:00
Dean Herbert
fad1f727bb Fix editor drag box visuals 2022-05-06 20:34:44 +09:00
Bartłomiej Dach
e9d52aa954
Remove not-accessed field 2022-05-06 13:09:37 +02:00
Bartłomiej Dach
a915b7333c
Remove unused using directive 2022-05-06 13:08:54 +02:00
Dean Herbert
cfcd64873c
Merge pull request #18069 from peppy/exit-multiplayer-is-dangerous
Make exiting multiplayer a dangerous operation, requiring hold
2022-05-06 20:00:41 +09:00
Bartłomiej Dach
839f9373b2
Merge branch 'master' into exit-multiplayer-is-dangerous 2022-05-06 12:57:13 +02:00
Bartłomiej Dach
3e75e7184a
Merge pull request #18118 from peppy/fix-toolbox-expand-coi
Fix toolbox expand being interrupted by gaps between groups
2022-05-06 12:47:02 +02:00
Dean Herbert
88c190f3e3 Change colour denoting expanded state to be gray rather than yellow
I always found the yellow colour very non-descript in this case. Gray
seems to work better?
2022-05-06 19:45:17 +09:00
Dean Herbert
b432885e5f Tidy up ordering of SettingsToolboxGroup 2022-05-06 19:39:09 +09:00
Dean Herbert
59add66632 Remove unnecessary autosize workaround (was fixed long ago) 2022-05-06 19:39:00 +09:00
Dean Herbert
949e30c4b4 Remove auto-expansion of individual toolbox groups when parent expanding container expands 2022-05-06 19:36:41 +09:00
Bartłomiej Dach
08fd0ea086
Fix click-to-return container still handling hover when inactive 2022-05-06 12:28:53 +02:00
Dean Herbert
c6bc6be128 Fix toolbox expand being interrupted by gaps between groups 2022-05-06 19:06:40 +09:00