Commit Graph

62141 Commits

Author SHA1 Message Date
Bartłomiej Dach ba1f6439bf
Disable redundant verbatim string prefix inspections
For some reason this started flaring up recently all over for me and
showing inspections all over, which are _technically_ valid, but
interfere with our convention of using verbatim string prefixes to
denote non-localisable strings. This, as a result, led to circular
inspections (addressing the r# inspection results in getting the
osu-localisation-analyser one, addresssing that one results in
getting the r# inspection back, etc. ad nauseam).
2023-08-28 12:44:57 +02:00
Dean Herbert d70df88fa0
Merge pull request #24645 from Dreamurrrr/Dreamurrrr-patch-1
Update README.md to include VS Code plugin prerequisites
2023-08-25 13:48:26 +09:00
Dreamurrrr 4fd165c0a7
Update README.md to include VS Code plugin prerequisites 2023-08-24 13:28:17 -05:00
Dean Herbert 1efd557b96
Merge pull request #24576 from nekodex/new-overlay-sfx
Update overlay pop-in/pop-out sample usage
2023-08-25 01:47:55 +09:00
Dean Herbert bf0f4fddad Localise non-overridden samples 2023-08-25 01:08:22 +09:00
Dean Herbert 35cdd6d866 Use `string.Empty` 2023-08-25 01:07:07 +09:00
Dean Herbert 081fb308e1 Merge branch 'master' into new-overlay-sfx 2023-08-24 18:29:00 +09:00
Jamie Taylor f4415a5bab
Add more detail to comment 2023-08-24 18:20:36 +09:00
Jamie Taylor 7ef5a71e91
Move PopIn/PopOut sample playback from `WaveOverlayContainer` to `WaveContainer` (so Multiplayer/Lounge plays the samples) 2023-08-24 18:13:23 +09:00
Jamie Taylor 2e27a476bb
Re-enable sample playback for `PasswordEntryPopover` and remove `sampleJoin` playback instead 2023-08-24 18:04:47 +09:00
Bartłomiej Dach 90dfef2bb9
Merge pull request #24628 from bdach/export-note-lock-test-cases
Add capability to export ordered object policy test cases for stable crosscheck
2023-08-24 08:42:27 +02:00
Dean Herbert 981e0c1ad7 Rename export test step to better fit purpose 2023-08-24 14:26:26 +09:00
Bartłomiej Dach 7312d1147d
Merge branch 'master' into export-note-lock-test-cases 2023-08-24 07:17:38 +02:00
Dean Herbert d01b065b4a
Merge pull request #24627 from bdach/no-custom-hitwindows
Rewrite `TestSceneObjectOrderedHitPolicy` to not rely on custom hitwindows
2023-08-24 13:50:06 +09:00
Bartłomiej Dach 9ef0ae53d1
Merge pull request #24634 from peppy/enable-sentry-global-mode
Enable sentry "global mode" as per recommendation
2023-08-23 20:58:48 +02:00
Dean Herbert a8e4237e34 Enable sentry "global mode" as per recommendation
Sentry documentation suggests this should be on for a client-facing app.

We haven't run into issues without it until now, but might as well set it correctly?
2023-08-24 03:23:18 +09:00
Bartłomiej Dach 8d24bf5049
Merge pull request #24632 from peppy/mod-bool-display-improvement
Show mod settings as "on" or "off" rather than "True" or "False"
2023-08-23 19:47:55 +02:00
Bartłomiej Dach 052bf2a6e0
Use alternative solution for timing offset woes on export 2023-08-23 13:54:34 +02:00
Dean Herbert 72d2715222 Show mod settings as "on" or "off" rather than "True" or "False" 2023-08-23 20:21:43 +09:00
Dean Herbert d6aded3ac3 Update framework 2023-08-23 20:11:55 +09:00
Bartłomiej Dach b1979954f5
Merge pull request #24631 from peppy/add-colon-mod-settings
Add missing colon in mod settings tooltip
2023-08-23 12:46:33 +02:00
Dean Herbert 91c2cadb47 Add missing colon in mod settings tooltip 2023-08-23 19:13:32 +09:00
Bartłomiej Dach 64786aaee8
Adjust test cases slightly to avoid running into hitwindow edge issue
Some note lock test cases do not play out correctly when exported out
to stable due to a completely separate issue, namely #11311.
Adjust the test cases for now to isolate failure vectors.
2023-08-23 10:43:48 +02:00
Bartłomiej Dach a1b4a56215
Add capability to export ordered object policy test cases for stable crosscheck 2023-08-23 10:43:41 +02:00
Bartłomiej Dach 9fd59b807f
Rewrite `TestSceneObjectOrderedHitPolicy` to not rely on custom hitwindows 2023-08-22 15:36:36 +02:00
Bartłomiej Dach ab4d47b594
Rewrite assertions to use nunit constraints 2023-08-22 14:37:58 +02:00
Bartłomiej Dach c9f611a713
Enable NRT in `TestSceneObjectOrderedHitPolicy` 2023-08-22 14:30:55 +02:00
Bartłomiej Dach 71ec29041b
Merge pull request #24508 from OliBomby/judge-fix
Fix hit animation not synchronizing when editing hit objects
2023-08-22 10:21:42 +02:00
Bartłomiej Dach 8cd9f0822a
Merge branch 'master' into judge-fix 2023-08-22 09:44:58 +02:00
Dean Herbert 36ebdd8d30
Merge pull request #24588 from ItsShamed/ux/notifications/flash-on-message
Flash taskbar when receiving notifications while the game is not focused
2023-08-22 16:44:16 +09:00
Bartłomiej Dach 5be5335784
Reword comment to be better 2023-08-22 09:37:54 +02:00
Bartłomiej Dach 142abe1fd0
Make highlight messages important in order to trigger window flash 2023-08-22 09:01:32 +02:00
Bartłomiej Dach aa29e00578
Remove `FlashTaskbar` and use `IsImportant` directly instead 2023-08-22 08:58:48 +02:00
Bartłomiej Dach be1a712f33
Make `OsuGame` dependency nullable 2023-08-22 08:54:41 +02:00
Bartłomiej Dach 71b5be2568
Merge branch 'master' into ux/notifications/flash-on-message 2023-08-22 08:20:08 +02:00
Dean Herbert b581d67416
Merge pull request #24613 from smoogipoo/masking-ssbo
Update framework and apply changes to support masking SSBO
2023-08-22 14:00:34 +09:00
Dean Herbert f09b818418 Update resources 2023-08-22 13:17:12 +09:00
Dan Balasescu e8337c592a Update framework and apply changes to support masking SSBO 2023-08-22 12:50:13 +09:00
Dean Herbert 2937dcef1a
Merge pull request #24610 from bdach/remove-global-action-container-hack
Remove global action container input queue workaround
2023-08-22 12:44:26 +09:00
tsrk 96c58c86ea
refactor: make flashing available in `Notifications`
This will be used in `NotificationOverlay` when a `Notification` is posted.
2023-08-21 23:36:54 +02:00
Bartłomiej Dach 00c87c782b
Merge pull request #24368 from peppy/fix-score-import-fail-fail-fail
Avoid reprocessing scores which already failed an upgrade previously
2023-08-21 18:23:06 +02:00
Bartłomiej Dach 5454d1caa1
Remove global action container input queue workaround
As described in #24248, the workaround employed by
`GlobalActionContainer`, wherein it tried to handle actions with
priority before its children by being placed in front of the children
and not _actually containing_ said children, is blocking the resolution
of some rather major input handling issues that allow key releases to be
received by deparented drawables.

To resolve, migrate `GlobalActionContainer` to use `Prioritised`, which
can be done without regressing certain mouse button flows after
ppy/osu-framework#5966.
2023-08-21 17:54:08 +02:00
Bartłomiej Dach 273dcf9150
Also update the reference to added flag in schema change breakdown 2023-08-21 17:44:35 +02:00
Bartłomiej Dach 99c862f894
Merge branch 'master' into fix-score-import-fail-fail-fail 2023-08-21 17:28:10 +02:00
Bartłomiej Dach 8533cba0bf
Fix mismatching schema version in comment 2023-08-21 17:27:05 +02:00
Bartłomiej Dach aa5680a8aa
Merge pull request #24527 from Pasi4K5/fix-slider-reversing
Fix sliders being reversed incorrectly in the editor
2023-08-21 17:12:00 +02:00
Bartłomiej Dach 6cd48e9db5
Merge pull request #24604 from peppy/fix-star-fountain-directions
Fix star fountain directions not matching stable
2023-08-21 17:00:51 +02:00
Bartłomiej Dach a79031dddd
Merge pull request #24605 from peppy/fix-drawable-menu-item-crash
Fix potential crash when loading menu items due to cross-thread ops
2023-08-21 16:52:24 +02:00
tsrk bdac052631
refactor(MessageNotifier): apply changes required by framework 2023-08-21 15:29:41 +02:00
OliBomby e283aa2843 Update inline comments 2023-08-21 13:09:31 +02:00