Salman Ahmed
b56fbacaa6
Merge pull request #19409 from peppy/carousel-maintain-selection-over-update
...
Fix beatmap carousel not maintaining selection if currently selected beatmap is updated
2022-08-29 11:55:04 +03:00
Salman Ahmed
f2378d3fde
Merge branch 'master' into carousel-maintain-selection-over-update
2022-08-29 11:23:22 +03:00
Dean Herbert
9b830d063f
Merge pull request #20010 from smoogipoo/scoreprocessor-no-rewrite-statistics
...
Don't include misses in failed score statistics
2022-08-29 17:07:13 +09:00
Dan Balasescu
d4a37725c4
Adjust test
2022-08-29 15:59:57 +09:00
Dean Herbert
2b7b77157a
Merge pull request #20008 from smoogipoo/scoreprocessor-computescore
...
Refactor/merge `ScoreProcessor.ComputeScore()` methods
2022-08-29 15:54:43 +09:00
Dan Balasescu
81ac0daba8
Update xmldoc
2022-08-29 15:51:12 +09:00
Dan Balasescu
b2e80ca7f0
Don't include misses in failed score statistics
2022-08-29 15:27:19 +09:00
Dean Herbert
e8ae6840ea
Add test coverage of selection being retained
2022-08-29 15:23:34 +09:00
Dan Balasescu
c0b13c7e1f
Refactor ScoreProcessor ComputeScore() methods
2022-08-29 13:51:10 +09:00
Dean Herbert
3e246caf05
Merge pull request #19995 from its5Q/import-crash-fix
...
Fix crash with legacy import from incomplete installs
2022-08-28 13:52:12 +09:00
its5Q
0cc6a76c17
Fix crash with legacy import from incomplete installs
2022-08-28 14:13:38 +10:00
Dan Balasescu
cf6bb3b030
Merge pull request #19958 from peppy/fix-fail-freq-stuck
...
Ensure fail animation sequence isn't run after the player exit sequence has started
2022-08-27 00:58:41 +09:00
Dean Herbert
35f0273c8a
Merge pull request #19850 from nekodex/text-selection-sfx
...
Add audio feedback for text selection
2022-08-27 00:54:28 +09:00
Salman Ahmed
764ab9f095
Merge branch 'master' into text-selection-sfx
2022-08-26 17:50:03 +03:00
Dan Balasescu
289b6f1a58
Merge pull request #19924 from peppy/fix-playlist-overlay-test-failures
...
Fix intermittent test failures in `TestScenePlaylistOverlay`
2022-08-26 23:36:16 +09:00
Dean Herbert
470bec7949
Move private method down
2022-08-26 23:29:03 +09:00
Dean Herbert
9c64520f8f
Merge pull request #19909 from peppy/framework-ini-in-sentry
...
Include framework configuration in sentry output
2022-08-26 23:13:26 +09:00
Dan Balasescu
8b871dab28
Merge pull request #19203 from tsunyoku/mod-validation-tests
...
Ensure all mods are incompatible in both ways
2022-08-26 23:01:51 +09:00
Dean Herbert
e4100ee3f1
Merge branch 'master' into text-selection-sfx
2022-08-26 22:05:32 +09:00
Dean Herbert
b9d9bf3004
Merge pull request #19938 from frenzibyte/fix-multi-spectator-results-screen
...
Fix multi-spectator potentially getting stuck for passed players
2022-08-26 21:53:17 +09:00
Dan Balasescu
17a12807de
Merge branch 'master' into framework-ini-in-sentry
2022-08-26 21:30:07 +09:00
Salman Ahmed
1fd1672d89
Merge branch 'master' into mod-validation-tests
2022-08-26 15:00:07 +03:00
Salman Ahmed
a3e595a9aa
Update comment to include inserted indices
2022-08-26 14:51:19 +03:00
Salman Ahmed
81c0a641b4
Fix selection fallback path not updated to check inserted indices
2022-08-26 14:51:08 +03:00
Salman Ahmed
f38194fb40
Merge branch 'master' into carousel-maintain-selection-over-update
2022-08-26 14:35:19 +03:00
Dean Herbert
6dc859973b
Merge branch 'master' into fix-playlist-overlay-test-failures
2022-08-26 20:25:53 +09:00
Dan Balasescu
91e044542d
Merge pull request #19828 from peppy/no-gameplay-clock-gameplay-offset
...
Introduce `FramedBeatmapClock` (and use in gameplay flow)
2022-08-26 20:21:34 +09:00
Dean Herbert
69cbc0125b
Merge pull request #19964 from nanashi-1/merge-hitobject-hitsound-fix
...
Fix hitobjects merge feature in editor not adding any hitsounds
2022-08-26 20:05:02 +09:00
Dean Herbert
5ef8e26ebe
Fix check not accounting for mods not existing in certain rulesets
...
Also check all instances, rather than first.
2022-08-26 19:59:26 +09:00
Dean Herbert
580754833f
Merge branch 'master' into mod-validation-tests
2022-08-26 19:48:42 +09:00
Dean Herbert
9e3659b2d2
Merge pull request #19858 from OliBomby/slider-splitter
...
Add ability to split sliders in osu! editor
2022-08-26 19:43:03 +09:00
Dean Herbert
cb1c4a1bb1
Move sample checks to be inline in other existing tests
2022-08-26 19:18:15 +09:00
Dean Herbert
03dcfed384
Merge branch 'master' into slider-splitter
2022-08-26 19:10:33 +09:00
Dean Herbert
47cb163015
Refactor splitting logic and comments slightly
2022-08-26 19:09:03 +09:00
Dean Herbert
f54047d17b
Move selection clearing to top
2022-08-26 18:55:20 +09:00
nanashi-1
78717956d5
add visual test
2022-08-26 16:55:18 +08:00
Dean Herbert
9050f54681
Split out test assertion methods to read better
2022-08-26 16:56:03 +09:00
Dean Herbert
ed0843aa84
Reword xmldoc regarding final clock source to read better
2022-08-26 16:46:22 +09:00
nanashi
0b4d1fd3c0
Merge branch 'ppy:master' into merge-hitobject-hitsound-fix
2022-08-26 15:20:30 +08:00
Dean Herbert
9862b79b47
Fix typo in long comment
2022-08-26 15:20:09 +09:00
Salman Ahmed
0d6b7fde92
Merge pull request #19940 from smoogipoo/legacy-combo-increase
...
Add `legacy_combo_increase` hit result type for legacy scores
2022-08-25 16:17:35 +03:00
Dean Herbert
a260d7872d
Update framework
2022-08-25 21:50:10 +09:00
Salman Ahmed
dad4946481
Merge branch 'master' into legacy-combo-increase
2022-08-25 15:44:08 +03:00
Dean Herbert
a546aa2673
Clamp SpectatorPlayerClock's elapsed calculation to avoid player clocks getting too far ahead
2022-08-25 21:33:33 +09:00
nanashi
4fc96f0389
Merge branch 'ppy:master' into merge-hitobject-hitsound-fix
2022-08-25 19:34:05 +08:00
nanashi-1
16fee7ac1c
add visual test
2022-08-25 19:31:47 +08:00
Dean Herbert
ae38c9e58d
Update framework
2022-08-25 19:18:17 +09:00
Dean Herbert
510d9ac79f
Merge branch 'master' into text-selection-sfx
2022-08-25 19:18:14 +09:00
nanashi-1
2d2bfac5e9
used firstHitObject.Samples as samples for mergedHitObject
2022-08-25 17:49:38 +08:00
Dean Herbert
a8c699610a
Fix lead in tests not waiting for player to start running
...
The tests are only meant to ensure that gameplay eventually starts.
The case where failures can occur is where the master clock is behind
the player clock (due to being in lead-in time). Because the test is
running in real-time, it can take arbitrary amounts of time to catch up.
If it took too long, the test would fail.
2022-08-25 18:00:14 +09:00
