Commit Graph

1130 Commits

Author SHA1 Message Date
Dan Balasescu 7bc8908ca9 Partial everything 2022-11-27 00:00:27 +09:00
Dean Herbert 1aa0e40f2f Add "Component" prefix to lookup naming 2022-11-09 17:46:43 +09:00
Dean Herbert c908969d9b Rename `ISkinComponent` to `ISkinLookup` 2022-11-09 17:46:43 +09:00
Dean Herbert ab458320c4 Fix some lingering inspections 2022-11-09 17:46:24 +09:00
Dean Herbert 710c224de4 Remove unused `IHasMainCirclePiece` interface 2022-11-09 13:31:50 +09:00
Dean Herbert 8c9250285f Revert incorrect removal default value (causing a new warning) 2022-10-29 18:09:27 +09:00
Dean Herbert 19e0b9085c Remove redundant parameters 2022-10-29 00:24:33 +09:00
Dean Herbert 674ae9e742 Refactor `DrawableSliderHead` to never update the drawable position
Slider heads are guaranteed to always be drawn at (0,0). This fixes
weird behaviour in the editor, but also simplifies things in the
process. Win-win.

Closes #20644.
2022-10-26 15:26:22 +09:00
Salman Ahmed 7d31eaea54 Move ball tinting logic to overwrite `SliderBall` colour 2022-10-20 03:55:53 +03:00
Dean Herbert 299131c985
Merge pull request #20816 from frenzibyte/adjust-slider-fade-parameters
Adjust slider fade out transition to match stable
2022-10-19 12:04:24 +09:00
Salman Ahmed 13e2323791 Adjust fade out duration to match stable 2022-10-18 23:48:51 +03:00
Salman Ahmed 03edfce822 Remove fade easing from sliders 2022-10-18 23:43:42 +03:00
Salman Ahmed d46bc7f72a Adjust fade out time to match stable 2022-10-18 23:43:31 +03:00
Dan Balasescu 083a13f041
Merge pull request #20680 from peppy/fix-slider-ball-editor-rewind
Fix slider ball facing incorrect direction during rewinding in editor
2022-10-11 17:47:17 +09:00
Dean Herbert f060e6a780 Implement hold "sliding" samples in osu!mania 2022-10-11 16:31:37 +09:00
Dean Herbert 33620b7bd6 Fix slider ball facing incorrect direction during rewinding in editor
Closes https://github.com/ppy/osu/issues/20648.
2022-10-10 15:24:18 +09:00
Dan Balasescu b6db36dcca
Merge pull request #20580 from peppy/approach-circle-fade-out
Hide approach circles immediate on successful hit
2022-10-05 19:17:57 +09:00
Dean Herbert 52002d91dd Only apply dim at top level objects 2022-10-05 17:48:56 +09:00
Dean Herbert 56d424003d Fix sliders not dimming correctly due to modified miss window 2022-10-05 14:25:04 +09:00
Dean Herbert 44b99444a7 Hide approach circles immediate on successful hit 2022-10-05 13:42:04 +09:00
Dean Herbert c2956c6e1e Add osu! hit object dim
Stable would dim objects when they can't be hit (ie. the "miss" window
is not active yet). This was never implemented in lazer, and causes
quite large visual differences.

No one has mentioned this yet, but it will definitely be one of those
missing pieces which makes lazer feel different to stable.
2022-10-04 17:28:17 +09:00
Dan Balasescu cbed268ac9
Merge pull request #20510 from sw1tchbl4d3r/high_bpm_judgements
Clamp `LifetimeStart` of `HitObject`s to their judgement windows
2022-09-28 17:49:35 +09:00
sw1tchbl4d3 0cffbb7562 Clamp `LifetimeStart` of `HitObject`'s to their judgement windows 2022-09-27 16:54:24 +02:00
Dean Herbert a7449380cd Fix osu! slider ticks appearing too late 2022-09-26 14:11:59 +09:00
Dean Herbert 749053481a Update osu! hitobject implementation to avoid triggering `ClearInternal` 2022-09-22 15:04:20 +09:00
Dean Herbert b844d76311 Move `Shake` logic local to hitcircle/slider 2022-09-22 15:04:20 +09:00
Dean Herbert 2bdc6417e9 Mark `DrawableOsuHitObject` `abstract` for clarity 2022-09-22 14:44:03 +09:00
Dean Herbert 289e6ad977 Fix follow point animations in legacy skins not always starting at correct point in time 2022-09-16 15:12:05 +09:00
Dean Herbert 6a35b233e5 Merge branch 'master' into remove-dispose-updates 2022-09-01 23:03:19 +09:00
Dean Herbert 105aa01e7d Update usages of `RemoveInternal` 2022-08-29 15:57:40 +09:00
Dean Herbert a215d009fe Update `Remove`/`RemoveRange`/`RemoveAll` calls in line with framework changes 2022-08-29 15:57:40 +09:00
Khang 9c6968e96d Remove unused import in Slider 2022-08-24 02:54:40 -04:00
Khang ec9daec93b Remove unnecessary workaround 2022-08-23 14:18:40 -04:00
Khang c1ced85b5e Move GenerateTicks to LegacyDifficultyControlPoint and remove support for NaN slider velocity support for other rulesets (at least for now) 2022-08-23 14:07:18 -04:00
Khang a81672f3dc Use an infinite tick distance instead of directly disabling tick generation for SliderEventGenerator 2022-08-22 23:31:24 -04:00
Khang 9f08c474ca Treat NaN slider velocity timing points as 1.0x but without slider ticks 2022-08-22 21:58:38 -04:00
Dean Herbert 9a4d0494de Adjust various pooling defaults to better handle more intense beatmaps 2022-08-05 18:09:07 +09:00
Salman Ahmed d8cce5fe36 Fix `OsuHitObject` not using property wrapper properly 2022-07-19 07:52:12 +03:00
Salman Ahmed 8f80a22ef9 Fix osu! and catch hitobjects no longer scaled to 1 by default 2022-07-19 07:00:13 +03:00
Salman Ahmed 1051009827 Change bindable properties in all `HitObject`s to be lazily initialised 2022-07-19 05:39:10 +03:00
goodtrailer e6a05ce3e2 Slow down legacy followcircle animations 2022-07-03 13:51:30 -07:00
goodtrailer 0e0e9968ac Split ball and followcircle into default/legacy files 2022-06-29 01:23:35 -07:00
Dean Herbert 31a447fda0 Update parameter discards 2022-06-24 21:26:19 +09:00
Dan Balasescu f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
Salman Ahmed b6e97e699a Remove unnecessary position specification 2022-06-07 00:34:18 +03:00
Salman Ahmed 4158146c71 Fix spinenr tick samples not positioned at centre
Causing samples to be played at left ear rather than centre.
2022-06-07 00:30:11 +03:00
Salman Ahmed 0eaf420fa1 Specify full size for spinner ticks container 2022-06-07 00:29:14 +03:00
Salman Ahmed 3a00931e38 Update slider sliding samples balance calculation to use screen-space as well 2022-04-18 09:18:56 +03:00
Salman Ahmed fcb48c69cf Calculate sample playback position using screen-space drawable rectangles 2022-04-18 07:57:31 +03:00
Dean Herbert 879267862c Fix typo in `DrawableOsuHitObject` 2022-04-08 15:20:22 +09:00