RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
49,008 Commits 3 Branches 659 Tags 360 MiB
Commit Graph

2540 Commits

Author SHA1 Message Date
Bartłomiej Dach e45a2ae0fc
Restructure difficulty copy flow to adapt to latest changes 2022-02-14 22:02:37 +01:00
Bartłomiej Dach 6221447164
Append copy suffix on creating copy of difficulty 2022-02-14 20:19:12 +01:00
Bartłomiej Dach 40cfee3421
Explicitly reset online ID and beatmap status on copy 2022-02-14 19:54:40 +01:00
Bartłomiej Dach 7e75fa7117
Revert "Change `BeatmapInfo` copy logic to be opt-in rather than opt-out" 
This reverts commit 5dabc9282c.
 2022-02-14 19:52:08 +01:00
Bartłomiej Dach 5dabc9282c
Change `BeatmapInfo` copy logic to be opt-in rather than opt-out 2022-02-13 19:04:11 +01:00
Bartłomiej Dach ecd6a68c6f
Clear hash when creating copy of existing difficulty 2022-02-13 14:01:23 +01:00
Bartłomiej Dach 6fd663a718
Apply some renames to convey difference between creation options better 2022-02-13 14:01:23 +01:00
Bartłomiej Dach a144d6f8d6
Fix beatmap skin properties not copying 2022-02-13 14:01:22 +01:00
Bartłomiej Dach 1bf5375e74
Fix `BeatmapInfo`-associated member not copying 2022-02-13 14:01:21 +01:00
Bartłomiej Dach a2c2b2bbb3
Add flow for copying existing difficulty content 2022-02-13 14:01:20 +01:00
Salman Ahmed 6f0e32826c Standardise ordering/grouping of `IRulesetInfo`/`RulesetInfo`s 2022-02-11 04:27:11 +03:00
Bartłomiej Dach 6dc0f3fd96
Merge difficulty creation methods into one 
One of them wasn't really doing much anymore and was more obfuscating
what was actually happening at this point.
 2022-02-03 18:14:30 +01:00
Dean Herbert bef0a2da21 Remove return type from `AddDifficultyToBeatmapSet` 
Also removes a pointless realm encapsulation.
 2022-02-03 19:43:43 +09:00
Dean Herbert ad47649d1c Make `BeatmapModelManager.Save` non-virtual 2022-02-03 19:38:53 +09:00
Bartłomiej Dach a8ffc4fc2a
Add editor override to respect `IsolateSavingFromDatabase` 2022-02-02 21:57:21 +01:00
Bartłomiej Dach 47429fb0c6
Fix same-name safety firing wrongly 2022-02-02 21:57:21 +01:00
Bartłomiej Dach 4f1aac9345
Add safeties preventing creating multiple difficulties with same name 2022-02-02 21:57:09 +01:00
Bartłomiej Dach 54bb6ad40c
Fix working beatmaps not seeing new difficulties after add 2022-02-02 21:55:34 +01:00
Bartłomiej Dach dc96c4888b
Add support for creating new blank difficulties 2022-02-02 21:55:33 +01:00
Dean Herbert 6d962e7925
Merge pull request #16726 from dekrain/leaderboard-score-tooltip 
Add basic tooltip for leaderboard scores
 2022-02-02 13:56:45 +09:00
Bartłomiej Dach 3d7af805a3
Fix `BeatmapMetadata` not using its user param correctly 2022-02-01 21:16:28 +01:00
Dean Herbert 8eace12fe3 Synchronise (roughly) backgrounds of all custom tooltips 2022-02-01 16:35:25 +09:00
Dean Herbert 142a67e163 Fix approach rate not being transferred from OD on older beatmaps 2022-01-28 18:53:28 +09:00
Bartłomiej Dach 6674567af1
Use -1 as the default preview time globally in metadata 2022-01-27 21:51:51 +01:00
Bartłomiej Dach 1b8136e3e0
Change some `BeatmapInfo` defaults in a backwards compatible manner 2022-01-27 21:49:37 +01:00
Dean Herbert 5288eedd31 Update all usages of `RulesetID` and `Ruleset.ID` to use `Ruleset.OnlineID` 2022-01-27 15:38:03 +09:00
Dean Herbert 68ee80c5de
Merge pull request #16623 from frenzibyte/refactor-editor-save-test 
Refactor editor saving test scene for scalability
 2022-01-26 15:40:39 +09:00
Salman Ahmed 064468faad Refactor editor saving test scene for scalability 2022-01-26 07:57:46 +03:00
Dean Herbert cd71ec0edd Remove `ILive<>` interface (and use `abstract Live<>` instead) 2022-01-26 13:38:56 +09:00
Dean Herbert 778d2a71b4 Remove `Task` from the inner-most `Import` method in `RealmArchiveModelImporter` 
One of my pending work items for post-realm merge.

The lowest-level import task is no longer asynchronous, as we don't want
it to span multiple threads to allow easier interaction with realm.
Removing the `Task` spec simplifies a heap of usages.

Individual usages should decide whether they want to run the import
asynchronously, by either using an alternative override or spooling up a
thread themselves.
 2022-01-25 15:30:29 +09:00
Dan Balasescu 05a2d7fbfe
Merge pull request #16591 from peppy/fix-editor-slider-velocity-saving 
Don't include nested hit objects' `DifficultyControlPoints` in legacy encoder logic
 2022-01-25 14:50:09 +09:00
Dean Herbert e23b10e6a5 Update remaining cases of clashing variable name in `realm.Run(realm..` 2022-01-25 13:04:05 +09:00
Dean Herbert 3e5c9e8436 Fix cases of `Access` instead of `Realm` 2022-01-25 12:58:15 +09:00
Dean Herbert 6eb2c28e41 Rename `RealmContextFactory` to `RealmAccess` 2022-01-24 20:38:07 +09:00
Dean Herbert c3758047fd Don't include nested hit objects' `DifficultyControLPoints` in legacy encoder logic 
The editor doesn't currently propagate velocity to nested objects. We're
not yet sure whether it should or not. For now, let's just ignore nested
objects' `DifficultyControlPoints` for simplicity.

Note that this only affects osu! ruleset due to the pre-check on
`isOsuRuleset`.
 2022-01-24 19:54:08 +09:00
Dean Herbert d7db6fa918
Merge branch 'master' into custom-meter 2022-01-24 15:46:44 +09:00
Bartłomiej Dach 838a9f69ed
Fix saved beatmap filename depending on `ToString()` implementation 2022-01-23 20:28:30 +01:00
Bartłomiej Dach 4e5a1f27a8
Initialise `Simple{Triple,Quadruple}` only once ever rather than create every time 2022-01-23 15:21:25 +01:00
Bartłomiej Dach 735414bc49
Replace `TimeSignatures` enum with struct for storage of arbitrary meter 2022-01-22 20:50:31 +01:00
Dean Herbert 495636538f Add forced refresh on `GetAllUsableBeatmapSets()` 
This is commonly used in tests in a way where it's not feasible to
guarantee correct results unless a refresh is called. This method
shouldn't really be used outside of tests anyway, but that's for a
folow-up effort.
 2022-01-21 17:33:29 +09:00
Dean Herbert 114c9e8c1f Update all usages of `CreateContext` to use either `Run` or `Write` 2022-01-21 17:27:08 +09:00
Dean Herbert a5d2047f05 Fix various cases of creating realm contexts from update thread when not necessary 2022-01-21 01:44:56 +09:00
Dean Herbert 6c10531df2 Avoid constructor overhead for realm `BeatmapMetadata` parameterless constructor 2022-01-20 17:14:51 +09:00
Dean Herbert deb108816c Fix some regressions in json output (we need to make all these explicit instead) 2022-01-20 17:09:31 +09:00
Dean Herbert ccddf9b47d Avoid constructor overhead for realm `BeatmapSetInfo` parameterless constructor 2022-01-20 17:03:44 +09:00
Dean Herbert 3faf980fed Avoid constructor overhead for realm `BeatmapInfo` parameterless constructor 2022-01-20 16:47:27 +09:00
Bartłomiej Dach 247c557eaf
Fix expanded content scrollbar inadvertently hiding expanded content 2022-01-19 22:30:49 +01:00
Bartłomiej Dach 77748a5f93
Show scrollbar on expanded card content where applicable 2022-01-19 22:21:08 +01:00
Dan Balasescu 3e5d29ed00
Merge pull request #16505 from peppy/remove-base-difficulty-usage 
Remove all usage of `BaseDifficulty` (and access `Difficulty` instead)
 2022-01-19 13:53:55 +09:00
Dan Balasescu 2556f1cb87
Merge branch 'master' into optimise-set-detach-part-2 2022-01-19 13:20:38 +09:00