RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
23,819 Commits 3 Branches 650 Tags 350 MiB
Commit Graph

875 Commits

Author SHA1 Message Date
Dean Herbert 65d71b9442 Fix beatmap lookups failing for beatmaps with no local path 
Turns out the underlying EscapeUriString doesn't like nulls
 2019-11-23 20:55:42 +09:00
Dean Herbert f079ebe857 Simplify beatmap lookup to use a single endpoint 2019-11-22 16:13:48 +09:00
Dean Herbert 19dfbb0a45 Update obsolete usages 2019-11-21 10:55:31 +09:00
Huo Yaoyuan f05b83d7d4 Use typeparamref. 2019-11-17 20:48:23 +08:00
Huo Yaoyuan 87d40cf8d0 Resolve equals usages. 2019-11-13 22:35:50 +08:00
Dean Herbert 61464c5c89 Fix potential nullref in unrelated test 2019-11-12 21:27:15 +09:00
Dean Herbert 58df6930b2 Get error message from server 2019-11-12 19:34:20 +09:00
Dean Herbert f04d7f733f Merge remote-tracking branch 'upstream/master' into favourite-beatmap 2019-11-12 19:19:29 +09:00
Huo Yaoyuan e9b8cbb516 Apply other styles. 2019-11-11 20:27:04 +08:00
Huo Yaoyuan ccc8aa6fa4 Apply brace style. 2019-11-11 20:13:13 +08:00
iiSaLMaN 6ecea0e4c1 Fix DummyAPIAccess being potentially incorrect 2019-11-06 18:15:49 +03:00
Dan Balasescu 23ad516348
Merge branch 'master' into game-handles-links 2019-11-05 12:33:32 +09:00
Dean Herbert 1a7b803d4d Change colour to green to match web implementation 2019-11-04 08:39:51 +09:00
Ganendra Afrasya ce3b34a768 Fix UserTopScoreContainer is also tinted 2019-11-01 23:00:55 +07:00
Ganendra Afrasya d9a91100fb Add tint to user's score container background 2019-11-01 22:47:23 +07:00
Dean Herbert 898520935e Move link handling code to OsuGame 
This allows for future calls from arguments / associations
 2019-11-01 11:40:51 +09:00
Dean Herbert d1c6e3f620 Add test for scroll to end when max history is exceeded 2019-10-29 14:32:52 +09:00
Dan Balasescu c2f6cd9c24
Merge branch 'master' into comments-vote-pill 2019-10-25 19:19:44 +09:00
Bartłomiej Dach 661dfbefaf Change containment check to overlap 
Due to scenarios wherein a formatted link ended up as part of a larger
raw link after parsing, change the containment check to an overlap check
and add appropriate tests for these edge cases.
 2019-10-25 00:42:58 +02:00
Bartłomiej Dach cbd99cc767 Resolve link-in-link edge case 
Testing with #6542 surfaced a crash scenario, caused by formatted links
that had URLs in the display text, for example

    [mean example - https://osu.ppy.sh](https://osu.ppy.sh)

In that case the outer Markdown link would get picked up once, and then
reduced to the link text when looking for other links, leading to it
being picked up again the second time when the raw link is found.

Add a check in the raw link parsing path that ensures that the found
URL is not a part of a bigger, pre-existing link.
 2019-10-24 15:52:55 +02:00
Bartłomiej Dach 24b7160522 Add support for parsing Markdown inline links 
Extend the Markdown parsing regex to allow parsing so-called inline
links. Within the parenthesis () part of the Markdown URL syntax,
introduce a new capturing group:

    (
      \s+              // whitespace between actual URL and inline title
      (?<title>        // start of "title" named group
        ""             // opening double quote (doubled inside @ string)
        (
          [^""]        // any character but a double quote
          |            // or
          (?<=\\)      // the next character should be preceded by a \
          ""           // a double quote
        )*             // zero or more times
        ""             // closing double quote
      )
    )?                 // the whole group is optional

This allows for parsing the inline links as-provided by web. Correctness
is displayed by the passing tests.
 2019-10-24 15:52:55 +02:00
Dean Herbert 40c202c394
Merge branch 'master' into comments-vote-pill 2019-10-23 15:41:54 +09:00
Dean Herbert c3375071ad Fix formatting issue 2019-10-23 00:26:47 +09:00
Dean Herbert e9aa7f3218 Subclass and use yellow for stand-alone chat display 2019-10-23 00:24:19 +09:00
Andrei Zavatski bb7af1e39c Fix some margin/padding issues 2019-10-22 01:45:04 +03:00
Andrei Zavatski d19041fa53 Implement DaySeparator class 2019-10-22 01:30:37 +03:00
Andrei Zavatski 9ee63a8c1a Apply suggested changes 2019-10-17 16:28:32 +03:00
Andrei Zavatski 42cd4107a0 Implement CommentVoteRequest and adjust UI 2019-10-17 15:04:30 +03:00
Andrei Zavatski 38dcd42d08 Parse voted comments 2019-10-17 12:35:12 +03:00
Dean Herbert 4f356f3aeb
Merge branch 'master' into favourite-beatmap 2019-10-16 18:22:09 +09:00
Andrei Zavatski 96e31b9cca Add support for deleted comments with message 2019-10-15 12:07:01 +03:00
Andrei Zavatski eb5dad08aa Remove initial filed 2019-10-15 11:25:58 +03:00
Andrei Zavatski 3c714dc013 APICommentsController -> CommentBundle 2019-10-15 11:20:06 +03:00
Andrei Zavatski ad32d66365 CI fix 2019-10-15 01:10:23 +03:00
Andrei Zavatski 0fd6b0c852 Use linq expression to count deleted comments 2019-10-15 00:55:33 +03:00
Andrei Zavatski 09621f066e Childs -> Children 2019-10-15 00:32:21 +03:00
Andrei Zavatski 0676c880b5 Simplify IsTopLevel and IsDeleted properties 2019-10-15 00:26:31 +03:00
Andrei Zavatski d4843285db CI fixes 2019-10-14 17:33:14 +03:00
Andrei Zavatski a4ffd4798d Fix escaped html strings not being unescaped 2019-10-14 17:02:48 +03:00
Andrei Zavatski 7cd3f5656d Cleanups 2019-10-14 16:43:43 +03:00
Andrei Zavatski 27e3ffd293 Update dependencies 2019-10-13 11:23:49 +03:00
Andrei Zavatski 7f867562ca Merge remote-tracking branch 'refs/remotes/ppy/master' into comments_api 2019-10-13 11:15:43 +03:00
Dean Herbert 475815df04 Update ranking display to handle new osu-web request format 2019-10-11 13:09:21 +09:00
Andrei Zavatski f6b78ad661 Overall cleanups 2019-10-10 11:43:45 +03:00
Andrei Zavatski 107d39c3e9 Add DeletedChildsPlaceholder to the bottom of the comments container 2019-10-09 14:10:05 +03:00
Andrei Zavatski 7e3c97f496 Implement DeletedChildsPlaceholder component 2019-10-09 13:37:07 +03:00
Andrei Zavatski b2bd78308d Handle deleted comments 2019-10-09 12:18:49 +03:00
Andrei Zavatski ad99a3236f Handle edited comments 2019-10-09 11:32:17 +03:00
Andrei Zavatski 0a56b041fd Implement ShowChildsButton 2019-10-09 11:07:56 +03:00
Andrei Zavatski faef4d932d Improve message parsing 2019-10-09 10:17:14 +03:00