Commit Graph

310 Commits

Author SHA1 Message Date
Dean Herbert 4cdde42228 Remove unnecessary backing field 2021-02-25 14:08:01 +09:00
Dean Herbert 1fd76ea3fb Apply changes to UI components overriding functions with changing signatures 2021-02-22 19:01:42 +09:00
Dean Herbert a76314a876 Use Update instead of UpdateAfterChildren (no need for the latter) 2021-02-02 15:57:17 +09:00
Dean Herbert bb0753f68d Use a better method of cancelling user scroll 2021-02-02 15:44:03 +09:00
Dean Herbert 398ab9c2c2 Use UserTrackingScrollContainer instead 2021-02-02 15:29:38 +09:00
Salman Ahmed 5c28c030c8 Unconditionally set "autoscroll" state 2021-02-01 22:08:57 +03:00
Salman Ahmed 15fcabb128
Add documentation to auto-scroll leniency
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-02-01 22:04:44 +03:00
Salman Ahmed 49e62c3a4b
Apply documentation changes
Co-authored-by: Dean Herbert <pe@ppy.sh>
2021-02-01 11:02:08 +03:00
Salman Ahmed e806e5bcd1 Improve robustness of chat auto-scrolling logic
Fix auto-scrolling state changing by old messages removal logic
2021-01-31 23:45:49 +03:00
Dean Herbert fca6b15d2f Fix local echo messages remaining permanently dimmed when chatting via multiplayer 2021-01-22 16:05:45 +09:00
Bartłomiej Dach 0b42b4b955 Rename {Drawable -> Clickable}Avatar 2020-12-26 14:35:11 +01:00
Dean Herbert d096f2f8f6 Fix potential cross-thread operation during chat channel load
The callbacks are scheduled to the API thread, but hooked up in BDL
load. This causes a potential case of cross-thread collection
enumeration.

I've tested and it seems like the schedule logic should be fine for
short term. Longer term, we probably want to re-think how this works so
background operations aren't performed on the `DrawableChannel` in the
first place (chat shouldn't have an overhead like this when not
visible).

Closes #11231.
2020-12-21 16:39:50 +09:00
Joehu 2ad7e6ca88 Fix hovered channel tabs color when unselected 2020-09-17 19:10:58 -07:00
Dean Herbert 942276d88f Remove outdated SearchableList classes 2020-09-03 16:34:58 +09:00
smoogipoo 96724bde32 Fix chat name backgrounds not dimming 2020-07-16 15:05:01 +09:00
Dean Herbert c79d8a4251 Update ChannelTabControl in line with TabControl changes 2020-06-16 00:18:09 +09:00
smoogipoo f3b5149648 Move some suggestions to warnings, resolve issues 2020-06-03 16:48:44 +09:00
Dean Herbert c73d45bc01 Reduce initial channel load overhead by only loading history on active channel 2020-04-29 15:23:28 +09:00
Dean Herbert 1b6342438f Hide scrollbars in tournament chat display 2020-03-23 12:05:16 +09:00
TheWildTree acd280c855 Add System channel type and use it for the ChannelSelectorTab 2020-03-15 22:13:26 +01:00
TheWildTree 8991e88039 Fix active tab closing behaviour 2020-03-13 18:34:51 +01:00
TheWildTree 097bd37e37 Fix SelectorTab crashing tests after a reload
For some reason, the default channel type (Public) caused the channel manager to attempt to connect to an API, which was null at that time, after hot reloading the test environment (via dynamic compilation). Changing the channel type seems to fix that.
2020-03-13 18:34:51 +01:00
Dean Herbert ed837d3115 Use framework extension method for FromHex 2020-03-11 10:18:41 +09:00
smoogipoo 2fb640f57f Change to until step + fix CI error 2020-01-30 15:00:39 +09:00
smoogipoo ce36e5458f Fix possible crash with no channel topic 2020-01-30 14:35:03 +09:00
TheWildTree d2a032ca8d Move reverse-order comparer to ChannelTabControl 2020-01-25 22:16:21 +01:00
smoogipoo bfb056c612 Apply input method signature refactorings 2020-01-20 18:17:21 +09:00
smoogipoo d01cc37968 Fix channel tab control test scene 2020-01-16 18:36:27 +09:00
Joehu 5af363c920 Use default placeholder text on chat channel search box 2019-12-14 12:58:13 -08:00
Huo Yaoyuan c0fe91a84c Merge branch 'master' into sharpen 2019-11-26 18:21:50 +08:00
Dean Herbert 45514ff660 Apply fixes 2019-11-25 11:30:55 +09:00
Huo Yaoyuan 818553027b Merge branch 'master' into sharpen 2019-11-21 23:42:46 +08:00
Berkan Diler 6cab517b2d .NET Standard 2.1 implements Math.Clamp , use it instead of MathHelper.Clamp from osuTK. 2019-11-20 13:37:47 +01:00
Huo Yaoyuan 42a98c5d87 Use constants. 2019-11-12 20:07:01 +08:00
Huo Yaoyuan bbeab6fa76 Use auto property. 2019-11-12 19:53:25 +08:00
Dean Herbert 54befb6f8f Remove adjacent day separators 2019-10-29 15:45:41 +09:00
Dean Herbert b06e70e546 Add failing test showing issue with day separator logic 2019-10-29 15:27:08 +09:00
Dean Herbert 09a6d1184a Tidy up order of scroll changes 2019-10-29 14:33:05 +09:00
Dean Herbert d1c6e3f620 Add test for scroll to end when max history is exceeded 2019-10-29 14:32:52 +09:00
Dean Herbert e9aa7f3218 Subclass and use yellow for stand-alone chat display 2019-10-23 00:24:19 +09:00
Dean Herbert 3b4823abe7 Use foreach 2019-10-23 00:17:37 +09:00
Dean Herbert 0ba287a7fd Rename variable 2019-10-23 00:14:22 +09:00
Andrei Zavatski 09b2f11bd5 Remove unused variable 2019-10-22 03:14:20 +03:00
Andrei Zavatski b1eac6b400 Apply suggested changes 2019-10-22 03:11:19 +03:00
Andrei Zavatski e9ae838f46 CI fixes 2019-10-22 02:16:52 +03:00
Andrei Zavatski 2896ed90e2 Fix incorrect date comparison 2019-10-22 01:55:26 +03:00
Andrei Zavatski bb7af1e39c Fix some margin/padding issues 2019-10-22 01:45:04 +03:00
Andrei Zavatski d19041fa53 Implement DaySeparator class 2019-10-22 01:30:37 +03:00
Andrei Zavatski 75f444e431 Basic implementation 2019-10-22 00:44:58 +03:00
Joehu 38c1cee5fd Fix tab controls overflowing 2019-10-06 10:22:55 -07:00