1
0
mirror of https://github.com/ppy/osu synced 2025-01-29 17:23:03 +00:00
Commit Graph

52453 Commits

Author SHA1 Message Date
Dean Herbert
87bf53485a
Merge pull request from frenzibyte/selection-context-outside-bounds
Fix context menus not appearing when clicking outside of editor playfield's bounds
2022-06-15 17:08:09 +09:00
Dean Herbert
080f2859ef
Merge pull request from peppy/quick-import-only-on-batch
Always perform full consistency checks for single imports
2022-06-15 17:06:06 +09:00
Dean Herbert
b8d593b1fa
Merge pull request from frenzibyte/stable-beatmap-recursive-import
Handle subdirectories during beatmap stable import
2022-06-15 17:04:24 +09:00
Salman Ahmed
dfab8b71f6
Merge branch 'master' into stable-beatmap-recursive-import 2022-06-15 10:06:46 +03:00
Dean Herbert
5201057a62 Change batch import to require at least 10 items 2022-06-15 15:31:58 +09:00
Dean Herbert
abe947bcb0 Update outdated xmldoc comments 2022-06-15 15:31:45 +09:00
Dean Herbert
19543685ff Merge branch 'master' into quick-import-only-on-batch 2022-06-15 15:27:06 +09:00
Dean Herbert
cca7633e59 Rename variables and remove unnecessary nested call to GetFullPath 2022-06-15 15:05:51 +09:00
Dean Herbert
d1c236e187
Merge pull request from frenzibyte/timeline-track-change-crash
Fix `ZoomableScrollContainer` attempting to update zoom with invalid range
2022-06-15 14:41:37 +09:00
Salman Ahmed
3d638abc52 Fix test files stream not disposed after creation 2022-06-15 08:24:20 +03:00
Salman Ahmed
d3feb07bc1 Split zoom updating to named method with value as optional 2022-06-15 07:57:16 +03:00
Salman Ahmed
22c09ec893 Handle subdirectories during beatmap stable import 2022-06-15 07:33:21 +03:00
Salman Ahmed
ee8045d507 Add failing test case 2022-06-15 07:33:21 +03:00
Salman Ahmed
268a7e1334 Fix ZoomableScrollContainer attempting to update zoom with overlapping range 2022-06-15 05:43:41 +03:00
Salman Ahmed
850afcb1c3 Add failing test case 2022-06-15 05:43:39 +03:00
Salman Ahmed
674a9bb399
Merge pull request from peppy/fix-hit-error-when-not-visible
Fix hit error meters not updating visual state when hidden
2022-06-15 00:39:19 +03:00
Salman Ahmed
9517e0f789
Merge branch 'master' into fix-hit-error-when-not-visible 2022-06-14 23:58:15 +03:00
Bartłomiej Dach
a8f5daa2f1
Merge pull request from jaxxibae/master
Add "View beatmap" button to Discord Rich Presence
2022-06-14 22:34:40 +02:00
Salman Ahmed
36599d1174
Merge branch 'master' into fix-hit-error-when-not-visible 2022-06-14 22:47:11 +03:00
Bartłomiej Dach
439ce63eb1
Merge branch 'master' into master 2022-06-14 21:47:07 +02:00
Bartłomiej Dach
54eb2083c0
Merge pull request from peppy/toolbar-scrolling-ruleset-selection
Allow scrolling overflow of ruleset buttons in the toolbar
2022-06-14 21:43:00 +02:00
Bartłomiej Dach
300663684c
Merge branch 'master' into toolbar-scrolling-ruleset-selection 2022-06-14 20:25:06 +02:00
Dean Herbert
c55c7becba Always use current ruleset to ensure URL is valid 2022-06-15 02:38:44 +09:00
Dean Herbert
1951eb30bc Remove call to RegisterUriScheme
Seems both unnecessary, and crashes the whole came on macOS.
2022-06-15 02:27:51 +09:00
Dean Herbert
0d36495cfc Fix up code quality, use more correct URL and update button text 2022-06-15 02:25:06 +09:00
Dean Herbert
7861043202
Merge pull request from frenzibyte/toolbar-block-scroll
Block scroll input from passing through game toolbar
2022-06-15 02:23:28 +09:00
Dean Herbert
cf82843e3d Merge branch 'master' into jaxxibae/master 2022-06-15 02:15:24 +09:00
Dean Herbert
49ec2572b8 Allow scrolling overflow of ruleset buttons in the toolbar 2022-06-15 01:43:10 +09:00
Salman Ahmed
d89c11e49e Allow Toolbar to block scroll input from passing through 2022-06-14 19:10:13 +03:00
Salman Ahmed
cd74f22e12 Add failing test case 2022-06-14 19:10:13 +03:00
Dean Herbert
6be4209458 Fix AlwaysPresent specification in wrong container 2022-06-15 01:04:43 +09:00
Dean Herbert
cac724f436 Re-enable ignored tests that will work again now 2022-06-15 00:51:08 +09:00
Dean Herbert
88d5e074a8 Rename lowPriority to batchImport 2022-06-15 00:46:00 +09:00
Dean Herbert
f11fe54385 Remove custom hash function flow 2022-06-15 00:42:30 +09:00
Dean Herbert
2f8290831a Skip quick import clause when importing a single item
Closes https://github.com/ppy/osu/issues/18600.
2022-06-15 00:26:34 +09:00
Dean Herbert
7affef75b0 Remove unused Import method in SkinManager 2022-06-15 00:26:34 +09:00
Dean Herbert
cf2238f683
Merge pull request from peppy/too-many-import-methods
Various clean-up on model managers / importer classes
2022-06-15 00:12:33 +09:00
Dan Balasescu
cc7943dfb1
Merge pull request from peppy/editor-repeat-behaviour-change-collapsing
Fix timing adjustment repeat buttons firing one change per repeat invocation
2022-06-14 20:24:13 +09:00
Dean Herbert
94ba71aa13 Remove one more usage of lowPriority 2022-06-14 20:21:28 +09:00
Dean Herbert
c179a13d25
Merge pull request from peppy/fix-editor-z-key
Fix ctrl-z in editor also seeking to start in addition to undo
2022-06-14 20:12:42 +09:00
Dean Herbert
6250caca29 Remove duplicate implementation of same thing 2022-06-14 20:01:11 +09:00
Dean Herbert
e96c5ce703 Move and correct xmldoc to interfaces 2022-06-14 20:00:16 +09:00
Dean Herbert
84e526a2d9 Move methods around to make more sense 2022-06-14 20:00:08 +09:00
Dean Herbert
9f599a5ab4 Remove unused lowPriority flag from one Import method 2022-06-14 19:52:30 +09:00
Dean Herbert
ca0765a932 Tidy up various delegation implementations 2022-06-14 19:46:59 +09:00
Dean Herbert
d73c0ca659 Remove unused methods from IModelImporter
All the xmldoc is already present in `RealmArchiveModelImporter` so
nothing is lost here.
2022-06-14 19:42:11 +09:00
Dean Herbert
c30644328c Fix timing adjustment repeat buttons firing one change per repeat invocation 2022-06-14 19:21:02 +09:00
Dean Herbert
aeca138930 Fix ctrl-z in editor also seeking to start in addition to undo 2022-06-14 18:48:57 +09:00
Dean Herbert
0147a8ecee Add test coverage of HUD components still getting updated when hidden 2022-06-14 18:35:49 +09:00
Dean Herbert
a20e43c2ae Ensure containers which are being used to hide HUD elements still update for now
I don't think this is necessarily a final solution (as this means all
HUD elements are adding overhead even when not visible), but this will
make the implementations much easier for the time being.

I've checked and can't notice any perceivable overhead in profiling so
we should be fine for now.
2022-06-14 18:22:25 +09:00