Commit Graph

70201 Commits

Author SHA1 Message Date
Dean Herbert 78084e33af
Merge pull request #30411 from frenzibyte/editor-slider-touch-support-2
Fix placing objects via touch in editor not working sometimes
2024-11-13 15:09:57 +09:00
Bartłomiej Dach c25215d2cf
Merge pull request #30579 from peppy/fix-rank-display-song-select
Fix top rank display not showing up on beatmaps with many difficulties
2024-11-12 12:26:26 +01:00
Dan Balasescu 678d14aa60
Merge pull request #30534 from Lawtrohux/difficult-strain
Globalise `CountDifficultStrains` within StrainSkill
2024-11-12 14:50:18 +09:00
Dean Herbert 8c5785fdf6
Make math more logical 2024-11-11 22:57:26 +09:00
Dean Herbert ee4d58544d
Update framework (and other common packages) 2024-11-11 21:58:13 +09:00
Bartłomiej Dach bca42e9d24
Merge pull request #30580 from peppy/song-select-less-semi-opaque
Reduce semi-opaque layers at song select
2024-11-11 12:23:17 +01:00
Dan Balasescu f746999d58
Merge pull request #30544 from Finadoggie/clamp-slider 2024-11-11 19:22:34 +09:00
Bartłomiej Dach b430ac2214
Merge branch 'master' into song-select-less-semi-opaque 2024-11-11 11:04:48 +01:00
Bartłomiej Dach d29dd2c223
Remove unused using directives 2024-11-11 11:04:43 +01:00
Dean Herbert 8605639e67
Merge pull request #28382 from Hecatia-Lapislazuli/move-already-placed-objects-when-adjusting-offset-bpm
Implemented ability to adjust already-placed objects when changing timing offsets
2024-11-11 18:56:11 +09:00
Bartłomiej Dach c37e4877e2
Move setting back to timing panel 2024-11-11 10:08:26 +01:00
Dean Herbert f84ee3996f
Reduce semi-opaque layers at song select
I made these changes while working on
https://github.com/ppy/osu/pull/30579. Basically, it's hard to fix the
ranks not loading while underneath the footer, and the transparency both
looks bad, and is going away in the redesign.

I've chosen values here that are moving *in the direction* of the new
design without overhauling everything.

- I know that there's still some transparency. I did this because it
helps keep all current elements / colours contrasting without too much
effort.
- I completely removed the transparency adjustments on the beatmap
panels. This always looked bad due to being applied per-layer, and I
don't think it added much.
2024-11-11 17:57:23 +09:00
Bartłomiej Dach 0cddb93dda
Move setting to user config 2024-11-11 09:57:17 +01:00
Bartłomiej Dach a6cdf6df07
Merge branch 'master' into move-already-placed-objects-when-adjusting-offset-bpm 2024-11-11 09:50:00 +01:00
Dean Herbert e8b69581b7
Fix top rank display not showing up on beatmaps with many difficulties 2024-11-11 17:49:34 +09:00
Dean Herbert f8ac54d61c
Fix weird local variable typo 2024-11-11 16:59:02 +09:00
Dean Herbert 322df72cce
Merge pull request #30425 from bdach/multiplayer-song-select-wyd
Fix multiplayer song select not correctly applying filter sometimes
2024-11-11 14:54:48 +09:00
Dean Herbert caedbdeccf
Merge pull request #30545 from bdach/fix-restore-storage-not-restoring-storage
Fix retry button on storage unavailable dialog not reopening realm if retry succeeds
2024-11-11 14:30:50 +09:00
Dan Balasescu 91d9c0a7e8
Adjust job name 2024-11-11 13:44:11 +09:00
Dan Balasescu 0b570c4e15
Enforce concurrency by using single job
I've yet again re-confirmed by doubts about using concurrency groups.
It's just not flexible enough. In this case, it cancels any _future_
jobs.
2024-11-11 13:40:17 +09:00
Dan Balasescu 394ff88a62
Fix empty JSON sent on non-`workflow_dispatch` events 2024-11-11 13:11:21 +09:00
Dan Balasescu c1686fb687
Don't fail grep if no matches 2024-11-11 13:02:26 +09:00
Dan Balasescu a3b8c4d127
Fix wrong cleaned up directory 2024-11-11 12:49:23 +09:00
Dan Balasescu 2767054286
Set `-euo pipefail` in diffcalc workflows 2024-11-11 12:49:23 +09:00
Dean Herbert d39a46f861
Merge pull request #30508 from bdach/taiko-strong-bug
Fix drum rolls losing width on strong state toggle in editor
2024-11-11 12:16:51 +09:00
Dean Herbert f897ab5a6e
Merge pull request #30566 from ppy/improve-diffcalc-workflow
Split diffcalc workflow to add concurrency group
2024-11-11 12:11:38 +09:00
Dean Herbert 4aa3516058
Merge pull request #30572 from Joehuu/fix-break-overlay-grades
Fix break overlay grades not using localised string
2024-11-10 21:13:01 +09:00
Joseph Madamba 9acfb3c900
Fix break overlay grades not using localised string 2024-11-09 16:45:18 -08:00
Dan Balasescu 5e8df623d4
Rename workflow 2024-11-09 23:49:30 +09:00
Dan Balasescu 6183daa95f
Split diffcalc workflow to add concurrency group 2024-11-09 19:59:20 +09:00
Dean Herbert e20163652e
Merge pull request #30560 from smoogipoo/fix-nvapi
Fix incorrectly translated NVAPI ABI
2024-11-09 17:23:21 +09:00
Dan Balasescu 8d7b19d6cf
Fix incorrectly translated NVAPI ABI 2024-11-09 15:11:47 +09:00
Dan Balasescu df0d51cbbc
Merge pull request #30547 from bdach/extended-nvapi-logging
Add extended logging to NVAPI operations
2024-11-08 19:32:51 +09:00
Bartłomiej Dach d8fc7b1803
Add extended logging to NVAPI operations
To help diagnose https://github.com/ppy/osu/issues/30546.
2024-11-08 10:29:13 +01:00
Bartłomiej Dach 091d02b3a8
Fix retry button on storage unavailable dialog not reopening realm if retry succeeds
Related: https://github.com/ppy/osu/issues/30539

When starting up the game with a data location that points to an
unavailable external device, a new realm file is created in the default
location. Eventually a popup is shown that informs the user that the
external storage is unavailable, and the user has an option to try the
storage again. The button that invokes said option would check said
storage correctly, but would not do anything about realm, which means
the previously opened empty realm that is placed in the default location
would remain open, which means the retry essentially doesn't work
because the user's stuff isn't there after the retry.

To fix this, take out a `BlockAllOperations()`, which will flush all
open realms, and re-open the realm on the external location if the
custom storage restore succeeds.
2024-11-08 09:28:14 +01:00
Bartłomiej Dach ce9c74af85
Merge pull request #30543 from smoogipoo/fix-ci-report
Fix up + improve CI test reporting workflow
2024-11-08 08:37:22 +01:00
finadoggie 70be82b048
Clamp estimateImproperlyFollowedDifficultSliders for lazer scores 2024-11-07 22:42:41 -08:00
Dan Balasescu 233560b867
Fix CI test report workflow 2024-11-08 11:55:24 +09:00
Dan Balasescu 8bd65d9938
Merge pull request #30535 from bdach/fix-hud-shifting-when-flipped-drawables-present
Fix HUD elements shifting in unintended manner when partially off-screen flipped skin elements are present
2024-11-08 01:55:03 +09:00
Bartłomiej Dach b0c6042b2a
Fix HUD elements shifting in unintended manner when partially off-screen flipped skin elements are present
Closes https://github.com/ppy/osu/issues/30286.
2024-11-07 14:01:34 +01:00
Jay Lawton 7c3a3c4d10 rename DifficultStrains for clarity 2024-11-07 21:56:42 +10:00
Jay Lawton 2b6a473164 update methods 2024-11-07 21:12:04 +10:00
Dean Herbert 54288c350a
Merge pull request #30525 from smoogipoo/multiplayer-refactor
Replace `MultiplayerRoomComposite` with local bindings
2024-11-07 19:53:44 +09:00
Jay Lawton 748055ab29 remove double instance of array 2024-11-07 20:15:59 +10:00
Dan Balasescu cb2e5ac2c4
Skip diffcalc job if target is not valid
Same as all other jobs... Just so that it doesn't appear as "completed"
in the workflow list.
2024-11-07 19:15:58 +09:00
Jay Lawton 177781aca5 remove localised instance of difficultstrains 2024-11-07 19:57:37 +10:00
Jay Lawton a5e6da76cb introduce difficult strains globally 2024-11-07 19:53:53 +10:00
Dean Herbert aad9f4078e
Merge pull request #30526 from smoogipoo/fix-beatmap-recommender-test
Fix intermittent beatmap recommendations test
2024-11-07 18:40:31 +09:00
Dean Herbert c7d0a7dde2
Update xmldoc and make realm transactions more obvious 2024-11-07 18:31:06 +09:00
Dan Balasescu 4d7fd236c5
Make class partial 2024-11-07 17:28:31 +09:00