Commit Graph

1466 Commits

Author SHA1 Message Date
Andrei Zavatski a59a14c9e6 Add setting to enable/disable hit error visibility 2019-08-18 15:01:04 +03:00
Andrei Zavatski ee5568e596 Use Queue instead of List for stored Judgements 2019-08-18 14:43:34 +03:00
Andrei Zavatski 50133ba863 naming adjustments 2019-08-18 02:57:12 +03:00
Andrei Zavatski 906984ad95 Fix the math 2019-08-18 02:49:07 +03:00
Andrei Zavatski f7024b513e Visual improvements 2019-08-18 01:43:43 +03:00
Andrei Zavatski 94dbd6386f Merge remote-tracking branch 'refs/remotes/ppy/master' into accuracy-bar 2019-08-18 01:14:27 +03:00
Dean Herbert d0f2d22995
Merge branch 'master' into fix-storyboard-not-shown-on-disabled-user-dim 2019-08-12 05:46:15 +09:00
Andrei Zavatski e7964c165f Make judgement lines alive for a bit longer 2019-08-11 19:09:50 +03:00
Andrei Zavatski 3136d46c7f Do not generate new judgement line on miss 2019-08-11 19:04:56 +03:00
Andrei Zavatski 5e0ac28ca8 Add basic colours 2019-08-11 18:30:03 +03:00
Andrei Zavatski 177a317a48 rename AccuracyBar to HitErrorDisplay 2019-08-11 18:11:49 +03:00
Andrei Zavatski 2a35c3c3e2 Calculate real position for judgement lines 2019-08-11 18:04:54 +03:00
Andrei Zavatski 0a255fe4d1 Add moving arrow 2019-08-11 16:38:03 +03:00
Andrei Zavatski ed409d113b Add judgement lines generator 2019-08-11 15:53:15 +03:00
Andrei Zavatski fd334e0319 Implement basic layout for AccuracyBar 2019-08-11 14:57:21 +03:00
Dean Herbert 90b1fe81f3 Update cached usage in line with framework changes 2019-08-09 19:12:29 +09:00
iiSaLMaN 0fcc6c1676 Add DimLevel property 2019-08-08 22:13:48 +03:00
iiSaLMaN bedb744a2e Add parentheses 2019-08-08 17:11:26 +03:00
iiSaLMaN 88b9942b2a Move EnableUserDim check to defualt value of ShowDimContent 2019-08-08 17:07:06 +03:00
Dean Herbert 2172c5a52b
Merge branch 'master' into use-bindable-break-time-in-player 2019-08-08 14:24:52 +09:00
Dean Herbert 7d42561da9 Remove linq usage in BreakOverlay update 2019-08-08 12:58:20 +09:00
Salman Ahmed 3f9f9e7bc9
Merge branch 'master' into use-bindable-break-time-in-player 2019-08-08 05:36:45 +03:00
Dean Herbert 99f5ca07ce Remove redundant comment 2019-08-08 10:42:54 +09:00
Dean Herbert 40a33b3382 Move IsLoaded check to more correct place 2019-08-08 10:41:23 +09:00
Dean Herbert a2e3ab6463
Merge branch 'master' into add-bindable-for-break-times 2019-08-08 10:13:14 +09:00
iiSaLMaN ba269a49ee Expose break fade duration and add it in the calculation 2019-08-07 16:59:35 +03:00
iiSaLMaN d3657d82cd Simplify final check for break time 2019-08-07 16:28:16 +03:00
iiSaLMaN c2b3c28c79 Use IsBreakTime for checking if currently in a break
Rather than iterating over all breaks to find which is in current time
2019-08-07 16:15:53 +03:00
Dean Herbert dda078277a Minor variable name changes 2019-08-06 23:05:12 +09:00
iiSaLMaN 2a68bb2749 onCompletionEvent -> pushResults 2019-08-06 14:11:43 +03:00
iiSaLMaN dd701eaa62 Safely cancel the completion task on restart or immediate exit 2019-08-06 14:10:03 +03:00
iiSaLMaN e6e315e07b Expose current break index 2019-07-30 13:29:41 +03:00
iiSaLMaN 5bf0277fd4 Remove unnecessary quick check
Not saving for anything
2019-07-28 09:17:13 +03:00
iiSaLMaN 1dd3a66300 Remove unnecessary index resets 2019-07-28 09:16:19 +03:00
iiSaLMaN 95b568eb46 Remove unnecessary condition 2019-07-27 15:52:30 +03:00
iiSaLMaN 6c580ac9d5 Use while loops instead 2019-07-27 15:52:01 +03:00
Salman Ahmed 934439e138
Merge branch 'master' into add-bindable-for-break-times 2019-07-26 12:57:52 +03:00
iiSaLMaN 4c9e8527d8 Modify global index directly in the for loop
Moves the global index to a near break if not in a break yet
2019-07-26 09:24:53 +03:00
iiSaLMaN 5a94a22314 Add a quick check if we're not in a break with current index 2019-07-26 09:17:39 +03:00
iiSaLMaN 3fa6804501 Use better loops for moving index
Easy to read, suggested by peppy
2019-07-26 08:12:32 +03:00
iiSaLMaN 806d41daf4 Add function to reset break index 2019-07-26 08:11:13 +03:00
iiSaLMaN 91fa8a6552 Simplify null and any check 2019-07-26 08:09:18 +03:00
iiSaLMaN 44895c4b69 Use IReadOnlyList for break periods list 2019-07-26 05:41:10 +03:00
iiSaLMaN b4c93b1777 Use lookup direction than 2 while loops 2019-07-26 05:11:01 +03:00
iiSaLMaN a08d54eb06 Remove unnecessary checks 2019-07-26 03:11:59 +03:00
Shane Woolcock 1d6c321e14 Ensure we don't ping-pong nearestBreakIndex between breaks 2019-07-26 08:34:18 +09:30
Shane Woolcock 5e51012800 Rewrite updateBreakTimeBindable 2019-07-25 22:54:05 +09:30
iiSaLMaN cdda264c49 Use global index and move it to find if break time
Avoid using iterations
2019-07-25 12:28:21 +03:00
iiSaLMaN 5a55433d6c Return if breaks are null
Fixes a test
2019-07-25 11:53:32 +03:00
iiSaLMaN 172a9ce33a Use a for loop instead of foreach
avoid allocating an iterator
2019-07-25 11:40:45 +03:00
iiSaLMaN 9bd66b6e7a Better xmldoc 2019-07-25 11:27:32 +03:00
iiSaLMaN 69d2f57f4f Avoid using LINQ 2019-07-25 11:27:01 +03:00
iiSaLMaN 0ea0a10ca4 Expose as IBindable<bool> 2019-07-25 11:26:38 +03:00
iiSaLMaN 7b82d184bd Add bindable boolean for break times 2019-07-25 11:07:53 +03:00
Dan Balasescu 986031e127
Merge branch 'master' into storyboard-clock-di 2019-07-12 23:14:12 +09:30
Dean Herbert 8b67f88d16 Don't expose dimmable container creation in player 2019-07-12 12:04:45 +09:00
Dean Herbert 46f7bb885b Move classes to local namespaces
Also renames test scene to more appropriate name.
2019-07-12 11:50:06 +09:00
Dean Herbert ecbd0f7eff
Merge branch 'master' into fix-skip-button-clickability 2019-07-11 23:10:28 +09:00
David Zhao 6c0de0b436 Merge remote-tracking branch 'upstream/master' into storyboard-clock-di 2019-07-11 13:33:35 +09:00
David Zhao 321266e96f Make UserDimContainer abstract 2019-07-11 13:17:28 +09:00
David Zhao 7929104b8a move default into StoryboardContainer, fix load bug, remove comment 2019-07-10 12:24:05 +09:00
David Zhao 41afe89c0b
delete no longer needed bindable 2019-07-10 00:46:34 +09:00
David Zhao 5bb21ecae0 remove storyboard region 2019-07-09 16:50:37 +09:00
David Zhao 89cb8a0cac Move storyboard initialization to new StoryboardContainer 2019-07-09 16:23:59 +09:00
Dean Herbert 8a98aff318
Merge branch 'master' into replay-local-mods 2019-07-08 22:38:02 +09:00
Dean Herbert 54f5e6aedf Add assertion and comment about lease logic 2019-07-08 22:37:39 +09:00
David Zhao 0cf4bf2352 Manually set clock for storyboard if loading before being given a parent 2019-07-08 18:46:12 +09:00
David Zhao d489a77fe1 remove new container and comment 2019-07-08 17:57:29 +09:00
David Zhao fbd300e664 Move ruleset into ReplayPlayerLoader as well 2019-07-08 17:37:20 +09:00
David Zhao e78e326f34 remove unused using 2019-07-08 17:02:42 +09:00
David Zhao ef22ab9340 remove bindable 2019-07-08 16:32:11 +09:00
David Zhao 6a86f62d17 Get mods from score info 2019-07-08 16:13:03 +09:00
David Zhao 5853a877c2 create base dependencies before caching, create player in playerloader 2019-07-08 15:40:10 +09:00
David Zhao 2747d7692b Create ReplayPlayerLoader for local mod caching 2019-07-08 14:55:05 +09:00
Dean Herbert 8f2ec73626 Move logic inside of HUDOverlay
Add vertical offset adjust.
2019-07-07 05:30:53 +09:00
Salman Ahmed dfabed3d85
Merge branch 'master' into applicable-to-hud 2019-07-06 16:30:02 +03:00
Dan Balasescu 3a9f16ccf2
Merge branch 'master' into idle-still-starts 2019-07-06 00:08:59 +09:30
Dean Herbert b902457f8d Allow PlayerLoader to proceed even if the mouse is hovering an overlay panel 2019-07-05 15:32:07 +09:00
iiSaLMaN d624157c45 Remove unnecessary fading 2019-07-05 05:17:36 +03:00
Dean Herbert db24ac28ec Add tests 2019-07-04 16:53:08 +09:00
Dean Herbert a20d5baa57 Fix skip button not being clickable after fade out 2019-07-04 16:21:01 +09:00
Dean Herbert 23acddcb56 Rename download buttons to avoid ambiguity 2019-07-03 12:02:35 +09:00
Salman Ahmed 8b4ef52c13
Revert unnecessary changes 2019-07-03 07:27:24 +03:00
naoey eaa19d5a49
Remove unused/unnecessary fields 2019-07-02 16:13:47 +05:30
naoey ee516d2515
Make direct panel download and replay buttons share UI 2019-07-02 15:55:30 +05:30
Dean Herbert 6539c6da17
Merge branch 'master' into watch-replays-4 2019-07-02 13:24:16 +09:00
Salman Ahmed 744e651a37
Merge branch 'master' into applicable-to-hud 2019-07-02 05:24:56 +03:00
Salman Ahmed 6a79349f4a Move health display out of the visibility container 2019-07-02 02:19:59 +03:00
Dean Herbert 60ea3d4e1a Fix skinning support for combobreak 2019-06-30 21:58:30 +09:00
naoey bfcbb47b77
Clean up some more leftover code 2019-06-30 10:56:20 +05:30
welsar55 d6561531a3
Merge branch 'master' into combobreak 2019-06-29 11:55:10 -05:00
Welsar55 a22c166575 Make ComboEffects its own class 2019-06-29 11:28:40 -05:00
naoey d8f6bbc90e
Disable replay button when replay is unavailable 2019-06-29 12:49:03 +05:30
naoey 7d9e215744
Code quality fixes 2019-06-29 12:29:12 +05:30
naoey 424711d24b
Fix replay button shake container
- Add license headers
- Slightly reduce bottom margin of button in score screen
2019-06-29 12:26:37 +05:30
naoey bc52f76556
Move replay button to score card 2019-06-29 10:55:30 +05:30
Welsar55 a57218e50e Move to LocalSkinOverride 2019-06-28 20:45:11 -05:00
iiSaLMaN d37cefbad8 Implement IApplicableToHUD 2019-06-29 04:23:59 +03:00
naoey 53d6d74537
Update to match upstream changes 2019-06-28 09:33:13 +05:30
naoey ab0bb8b678
Implement replay downloading with ArchiveDownloadModelManager 2019-06-28 09:33:13 +05:30